Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove href/auto-route attrs from buttons (#26247) 

Those apply only to `a` elements
This commit is contained in:
Jarek Radosz 2024-03-19 23:59:37 +01:00 committed by GitHub
parent 2db3ddb22e
commit 1f17602b86
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/glimmer-header/dropdown.gjs
View File

@ -42,8 +42,6 @@ export default class Dropdown extends Component {
class="button icon btn-flat" class="button icon btn-flat"
aria-expanded={{@active}} aria-expanded={{@active}}
aria-haspopup="true" aria-haspopup="true"
href={{@href}}
data-auto-route="true"
title={{i18n @title}} title={{i18n @title}}
aria-label={{i18n @title}} aria-label={{i18n @title}}
id={{@iconId}} id={{@iconId}}

2
app/assets/javascripts/discourse/app/components/glimmer-header/user-dropdown.gjs
View File

@ -37,12 +37,10 @@ export default class UserDropdown extends Component {
class="icon btn-flat" class="icon btn-flat"
aria-haspopup="true" aria-haspopup="true"
aria-expanded={{@active}} aria-expanded={{@active}}
href={{this.currentUser.path}}
aria-label={{i18n aria-label={{i18n
"user.account_possessive" "user.account_possessive"
name=(or this.currentUser.name this.currentUser.username) name=(or this.currentUser.name this.currentUser.username)
}} }}
data-auto-route="true"
{{on "click" this.click}} {{on "click" this.click}}
> >
<Notifications @active={{@active}} /> <Notifications @active={{@active}} />

4
app/assets/javascripts/discourse/app/widgets/header.js
View File

@ -187,11 +187,9 @@ createWidget(
attributes: { attributes: {
"aria-haspopup": true, "aria-haspopup": true,
"aria-expanded": attrs.active, "aria-expanded": attrs.active,
href: attrs.user.path,
"aria-label": I18n.t("user.account_possessive", { "aria-label": I18n.t("user.account_possessive", {
name: attrs.user.name || attrs.user.username, name: attrs.user.name || attrs.user.username,
}), }),
"data-auto-route": true,
}, },
}, },
this.attach("header-notifications", attrs) this.attach("header-notifications", attrs)
@ -222,8 +220,6 @@ createWidget(
attributes: { attributes: {
"aria-expanded": attrs.active, "aria-expanded": attrs.active,
"aria-haspopup": true, "aria-haspopup": true,
href: attrs.href,
"data-auto-route": true,
title, title,
"aria-label": title, "aria-label": title,
id: attrs.iconId, id: attrs.iconId,