UX: Remove loading spinner from emoji picker (#16064)

Emoji picker doesn't load external data, so this didn't provide much value to users (and just delayed displaying the list by 50ms+)

app/assets/javascripts/discourse/app/components/emoji-picker.js

@@ -36,7 +36,6 @@ export default Component.extend({
   recentEmojis: null,
   hoveredEmoji: null,
   isActive: false,
-  isLoading: true,
   usePopper: true,
   initialFilter: "",
 
@@ -79,7 +78,6 @@ export default Component.extend({
 
   @action
   onShow() {
-    this.set("isLoading", true);
     this.set("recentEmojis", this.emojiStore.favorites);
 
     schedule("afterRender", () => {
@@ -135,8 +133,6 @@ export default Component.extend({
       // this is a low-tech trick to prevent appending hundreds of emojis
       // of blocking the rendering of the picker
       later(() => {
-        this.set("isLoading", false);
-
         schedule("afterRender", () => {
           if (!this.site.isMobileDevice || this.isEditorFocused) {
             const filter = emojiPicker.querySelector("input.filter");

app/assets/javascripts/discourse/app/templates/components/emoji-picker.hbs

@@ -38,7 +38,6 @@
       <div class="emoji-picker-emoji-area" role="button" {{on "click" this.onEmojiSelection}} {{on "mouseover" this.onEmojiHover}}>
         <div class="results"></div>
 
-        {{#conditional-loading-spinner condition=isLoading}}
         <div class="emojis-container">
           {{#if recentEmojis.length}}
             <div class="section recent" data-section="recent">
@@ -73,7 +72,6 @@
             </div>
           {{/each-in}}
         </div>
-        {{/conditional-loading-spinner}}
       </div>
 
       <div class="emoji-picker-footer">