Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: update pull request template with more details of what is expected in a PR (#28857) 

* DEV: update pull request template with more details of what is expected in a PR

Added information:
- We expected the pr to have a title that is descriptive of the changes
- Good commit messages and prefixes
- If the pull request had UX/UI changes to include screenshots
- If changing flaky tests to include the reason for the change

* Update .github/pull_request_template.md

Co-authored-by: David Taylor <david@taylorhq.com>

---------

Co-authored-by: David Taylor <david@taylorhq.com>
This commit is contained in:
Gabriel Grubba 2024-09-11 13:57:45 -03:00 committed by GitHub
parent 2bc31bc45a
commit a4359d274e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.github/pull_request_template.md vendored
View File

@ -1 +1,8 @@
<!-- NOTE: All pull requests should have tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted. -->
<!--
NOTE: All pull requests should have:
- Tests (rspec in Ruby, qunit in JavaScript). If your code does not include test coverage, please include an explanation of why it was omitted.
- A descriptive title and description with context about those changes.
- Good commit messages with the correct prefixes see: https://meta.discourse.org/t/discourse-github-commit-prefix-convention/19392
- If the pull request had UX/UI changes, please add a screenshot of how it was before and how it is with your changes in mobile and desktop
- If changing flakey tests, please add a description in your commit/PR description about the error you were having
-->