Merge pull request #4556 from cpradio/cannot-see-mention-comments

Add comments to relevant sections denoting "create new topic" …
This commit is contained in:
Jeff Atwood 2016-11-16 22:02:31 +01:00 committed by GitHub
commit a5de6f79a3
3 changed files with 6 additions and 0 deletions

View File

@ -137,6 +137,8 @@ export default Ember.Component.extend({
},
_renderUnseenMentions($preview, unseen) {
// 'Create a New Topic' scenario is not supported (per conversation with codinghorror)
// https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
fetchUnseenMentions(unseen, this.get('topic.id')).then(() => {
linkSeenMentions($preview, this.siteSettings);
this._warnMentionedGroups($preview);

View File

@ -51,6 +51,8 @@ export function linkSeenMentions($elem, siteSettings) {
return [];
}
// 'Create a New Topic' scenario is not supported (per conversation with codinghorror)
// https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
export function fetchUnseenMentions(usernames, topic_id) {
return ajax("/users/is_local_username", { data: { usernames, topic_id } }).then(r => {
r.valid.forEach(v => found[v] = true);

View File

@ -242,6 +242,8 @@ class UsersController < ApplicationController
usernames -= groups
usernames.each(&:downcase!)
# Create a New Topic Scenario is not supported (per conversation with codinghorror)
# https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
cannot_see = []
topic_id = params[:topic_id]
unless topic_id.blank?