Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Update dynamic component hbs syntax (#29445) 

The block form of `{{#component` is not supported by Glint tooling. They recommend using this `{{#let`-based syntax to achieve the same result
This commit is contained in:
David Taylor 2024-10-29 11:11:10 +00:00 committed by GitHub
parent 336d98732d
commit b364a13ad3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse/app/components/reviewable-item.hbs
View File

@ -55,11 +55,17 @@
{{/each}} {{/each}}
</div> </div>
{{else}} {{else}}
{{#component {{#let
this.reviewableComponent reviewable=this.reviewable tagName="" (component
this.reviewableComponent reviewable=this.reviewable tagName=""
)
as |ReviewableComponent|
}} }}
<ReviewableScores @reviewable={{this.reviewable}} @tagName="" /> {{! template-lint-disable no-shadowed-elements }}{{! (seems to be a false positive) }}
{{/component}} <ReviewableComponent>
<ReviewableScores @reviewable={{this.reviewable}} @tagName="" />
</ReviewableComponent>
{{/let}}
{{/if}} {{/if}}
</div> </div>