Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "DEV: Enable and fix link-href-attributes lint" 

Introducing an href attribute on the upload button caused the page to reload when clicked

This reverts commit a17fa222af.
This commit is contained in:
David Taylor 2020-03-27 11:43:00 +00:00
parent 57321b90f0
commit e6e6d20912
No known key found for this signature in database
GPG Key ID: 46904C18B1D3F434
4 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.template-lintrc.js
View File

@ -11,7 +11,6 @@ module.exports = {
"img-alt-attributes": false, "img-alt-attributes": false,
"linebreak-style": true, "linebreak-style": true,
"link-rel-noopener": true, "link-rel-noopener": true,
"link-href-attributes": true,
"no-abstract-roles": true, "no-abstract-roles": true,
"no-args-paths": true, "no-args-paths": true,
"no-attrs-in-components": true, "no-attrs-in-components": true,

2
app/assets/javascripts/discourse/templates/components/share-panel.hbs
View File

@ -4,7 +4,7 @@
<div class="body"> <div class="body">
{{textarea value=shareUrl class="topic-share-url"}} {{textarea value=shareUrl class="topic-share-url"}}
<div class="topic-share-url-for-touch"><a href>{{! set by component }}</a></div> <div class="topic-share-url-for-touch"><a></a></div>
<div class="sources"> <div class="sources">
{{#each sources as |source|}} {{#each sources as |source|}}

2
app/assets/javascripts/discourse/templates/components/share-popup.hbs
View File

@ -8,7 +8,7 @@
<div> <div>
<input type="text"> <input type="text">
<div class="share-for-touch"><div class="overflow-ellipsis"><a href>{{! set by component }}</a></div></div> <div class="share-for-touch"><div class="overflow-ellipsis"><a></a></div></div>
</div> </div>
<div class="actions"> <div class="actions">

2
app/assets/javascripts/discourse/templates/composer.hbs
View File

@ -191,7 +191,7 @@
{{#if site.mobileView}} {{#if site.mobileView}}
{{#if allowUpload}} {{#if allowUpload}}
<a href class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}"> <a class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}">
{{d-icon uploadIcon}} {{d-icon uploadIcon}}
</a> </a>
{{/if}} {{/if}}