d2ecba195c
Merge branch 'main' into 0-a-no-query
...
# Conflicts:
# app/assets/javascripts/discourse/tests/acceptance/composer-actions-test.js
# app/assets/javascripts/discourse/tests/acceptance/composer-editor-mentions-test.js
# app/assets/javascripts/discourse/tests/acceptance/composer-image-preview-test.js
# app/assets/javascripts/discourse/tests/acceptance/composer-test.js
# app/assets/javascripts/discourse/tests/acceptance/composer-uploads-uppy-test.js
# app/assets/javascripts/discourse/tests/acceptance/search-test.js
# app/assets/javascripts/discourse/tests/acceptance/share-topic-test.js
# app/assets/javascripts/discourse/tests/acceptance/topic-test.js
# app/assets/javascripts/discourse/tests/acceptance/user-menu-test.js
# app/assets/javascripts/discourse/tests/integration/components/date-time-input-range-test.js
# app/assets/javascripts/discourse/tests/integration/components/date-time-input-test.js
# plugins/poll/test/javascripts/component/poll-buttons-dropdown-test.js
2024-12-02 16:38:41 +01:00
72f3cd252f
DEV: Use new qunit-dom's includesValue/doesNotIncludeValue ( #30034 )
2024-12-02 16:30:56 +01:00
9bdd97db42
FIX: editing post while replying ( #29985 )
...
BEFORE: if you click the "reply" button on a post and then decided that you want to "edit" the same post, clicking the "edit" button would do nothing. Clicking "edit" on another post works, but editing the same post would appear broken.
AFTER: if you click the "edit" button, it will properly load the content of the post you're trying to edit. No matter which one it is.
This was somewhat tricky to track down as the system specs seemed to contradict the qunit tests until I realized that the qunit tests were only testing the edit on the 1st post and the system specs were testing on replies.
I improved the qunit tests to test both editing OP and a reply and (hopefully) made the system specs a little bit clearer.
This is a follow up to bbe62d88d2
2024-12-02 16:06:36 +01:00
ab32623c07
UX: disable scrolling when modal is open on desktop ( #30035 )
...
Uses the `htmlClass` to automagically set the `modal-open` class to
`<html>` so that we can do `overflow: hidden` and prevent the
"background" behind the modal from scrolling while the modal is open.
Internal ref - t/142760
2024-12-02 15:08:43 +01:00
5d5f9ecfb9
Build(deps-dev): Bump lefthook from 1.8.4 to 1.8.5 ( #30031 )
...
Bumps [lefthook](https://github.com/evilmartians/lefthook ) from 1.8.4 to 1.8.5.
- [Release notes](https://github.com/evilmartians/lefthook/releases )
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md )
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.8.4...v1.8.5 )
---
updated-dependencies:
- dependency-name: lefthook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 14:07:27 +01:00
62fc2a383a
Build(deps): Bump @glimmer/syntax from 0.92.3 to 0.93.1 ( #30032 )
...
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm ) from 0.92.3 to 0.93.1.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases )
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md )
- [Commits](https://github.com/glimmerjs/glimmer-vm/commits )
---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:19:33 +00:00
08542400ad
Build(deps-dev): Bump jsuites from 5.7.2 to 5.8.0 ( #30033 )
...
Bumps [jsuites](https://github.com/jsuites/jsuites ) from 5.7.2 to 5.8.0.
- [Release notes](https://github.com/jsuites/jsuites/releases )
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md )
- [Commits](https://github.com/jsuites/jsuites/commits )
---
updated-dependencies:
- dependency-name: jsuites
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:18:52 +00:00
7d5d1dcc51
Build(deps-dev): Bump qunit-dom from 3.3.0 to 3.4.0 ( #30030 )
2024-12-02 13:18:28 +01:00
33ef912dc5
Build(deps-dev): Bump lint-to-the-future from 2.4.1 to 2.5.1 ( #30029 )
...
Bumps [lint-to-the-future](https://github.com/mansona/lint-to-the-future ) from 2.4.1 to 2.5.1.
- [Release notes](https://github.com/mansona/lint-to-the-future/releases )
- [Changelog](https://github.com/mansona/lint-to-the-future/blob/main/CHANGELOG.md )
- [Commits](https://github.com/mansona/lint-to-the-future/commits )
---
updated-dependencies:
- dependency-name: lint-to-the-future
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:18:18 +00:00
5af056c48c
DEV: Set version on tracked-built-ins patch ( #30024 )
2024-12-02 10:10:59 +01:00
44a81069ac
DEV: Avoid creating system message when system user initiates restore ( #30027 )
...
There is no point creating a message for the system user since it is a
non-human user.
2024-12-02 16:13:38 +08:00
746d145258
FEATURE: pass faqOverridden to about-wrapper plugin outlet ( #29994 )
...
Ref: https://github.com/discourse/discourse-woot-theme/pull/29
2024-12-02 12:55:06 +05:30
87f1d507f5
DEV: add db migration to remap icon names to fontawesome 6 ( #29958 )
...
* DEV: add irreversible db migration to remap icon names to fontawesome 6
2024-12-02 12:41:43 +08:00
1bb33d15f2
DEV: Hide admin_sidebar_enabled_groups ( #30025 )
...
We are hiding this site setting because we no longer
support the old horizontal admin nav, and this setting
will be going away soon.
2024-12-02 11:06:00 +10:00
c4d86635d1
DEV: Update decorator-transforms to 2.3.0 ( #30020 )
...
1. the patch is no longer needed
2. this unblocks dependabot (it's been erroring out for a bit)
2024-12-02 01:04:20 +01:00
045f119f67
DEV: Update licensee to 11.1.1 ( #30022 )
2024-12-02 07:34:19 +08:00
b3423c40b0
DEV: Fix random typos ( #30023 )
...
(late) Nov 2024 edition
2024-12-02 07:34:05 +08:00
6d4c6ee154
UX: admins users page follows admin ux guideline ( #29873 )
...
Conversion of `/admin/users` page to follow admin UX guidelines.
In addition, add the username to the title on the user admin page.
2024-12-02 10:11:23 +11:00
976be2abcd
Build(deps): Bump regexp_parser from 2.9.2 to 2.9.3 ( #30021 )
...
Bumps [regexp_parser](https://github.com/ammar/regexp_parser ) from 2.9.2 to 2.9.3.
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.9.2...v2.9.3 )
---
updated-dependencies:
- dependency-name: regexp_parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-01 23:23:18 +01:00
6e4baaf092
DEV: Use qunit-dom's `hasValue` wherever possible ( #30018 )
2024-12-01 20:37:24 +01:00
efa2589204
DEV: Finish qunit-dom hasText migration ( #30017 )
2024-12-01 14:00:48 +01:00
7186716a4c
fixups
2024-12-01 02:13:15 +01:00
75d85115e8
DEV: Replace remaining uses of `query` helper
2024-12-01 01:02:37 +01:00
489b27ca03
fixups
2024-11-30 23:28:39 +01:00
acc8c2a161
DEV: Use qunit-dom's `hasValue` wherever possible
2024-11-30 23:09:00 +01:00
41e025f050
update
2024-11-30 19:15:31 +01:00
0cf9412291
DEV: Finish qunit-dom hasText migration
2024-11-30 18:36:41 +01:00
1396aef99f
DEV: Make the `logIn` helper replace current-user service ( #30010 )
2024-11-30 17:23:51 +01:00
dfb74d90c3
DEV: Extensively use qunit-dom's hasText ( #30012 )
2024-11-30 16:44:51 +01:00
d93967e2fb
DEV: bump email_reply_trimmer version to 0.2.0 ( #30016 )
2024-11-30 16:38:58 +01:00
7d58793759
DEV: deduplicate inline styles in emails ( #30015 )
...
In order to limit issues with duplicate inline CSS definitions, this will now deduplicate inline CSS styles with the "last-to-be-defined-wins" strategy.
Also removes unecessary whitespaces in inline styles.
Context - https://meta.discourse.org/t/resolve-final-styles-in-email-notifications/310219
Co-authored-by: Thomas Kalka <thomas.kalka@gmail.com>
2024-11-30 16:38:45 +01:00
20d46c9583
PERF: only diff HTML / Markdown when needed ( #30014 )
...
When serializing the `body_changes` in the `PostRevisionSerializer`, we create two diffs: one for the `cooked` and another one for the `raw` version of the post.
Inside `DiscourseDiff`, we generate both `html` and `markdown` diffs when we only need the `html` diffs for the `cooked` version of the post and the `markdown` diff for the `raw` version of the post.
This solves the issue repored in https://meta.discourse.org/t/server-error-accessing-topic-revisions-on-a-specific-topic/339185 where some revisions would return 500 because of a `ArgumentError : Attributes per element limit exceeded` exception when trying to generate the `html` diff on a very large `raw`.
2024-11-30 16:30:30 +01:00
bf3e75ca70
DEV: Reduce async/indirection in site-header ( #30011 )
2024-11-30 15:33:38 +01:00
fa4a37fd7d
DEV: Deprecate `componentTest` ( #30001 )
2024-11-30 15:33:27 +01:00
85ead5ac7a
Revert "FIX: deduplicate css in mails ( #30003 )" ( #30013 )
...
This reverts commit 6e726d436f
2024-11-30 15:32:32 +01:00
6e726d436f
FIX: deduplicate css in mails ( #30003 )
...
Feature: Resolve final styles in email notifications
Context - https://meta.discourse.org/t/resolve-final-styles-in-email-notifications/310219
2024-11-30 14:51:02 +01:00
35be2a9879
FIX: word break long continuous thread titles ( #30007 )
2024-11-30 01:07:39 +01:00
c42248670d
FIX: increase chat thread title limit ( #30006 )
...
This will ensure AI generated titles don't appear as out of range in the UI and also allow users to set longer titles. The limit in DB was already 100 so it's just a simple frontend change.
2024-11-30 00:42:20 +01:00
877b03c7ae
FIX: do not show as clickable the thread header ( #30005 )
...
When the current user can't modify the thread title we shouldn't show it as a clickable area.
2024-11-30 00:32:58 +01:00
b546c31b7f
UI: simplify chat thread title ( #29998 )
...
We were using a complex logic to make it change size based on scroll position but this was imperfect and not visually pleasing. Also the title had been made a button which was causing the ellipsis to not work correctly, and I would prefer to not mix page knowledge (thread) with title component so I made this click logic directly in the chat-thread component.
---------
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
2024-11-29 22:39:18 +01:00
2f932812e0
DEV: Add `topic-list-header-sortable-column` transformer ( #29917 )
...
For conditionally disabling ability to sort on specific columns in the topic list.
2024-11-29 21:32:48 +01:00
a2c8177a4c
DEV: Deprecate `discourseModule` ( #30000 )
...
We're now using QUnit's `module` directly in core and all plugins/themes.
2024-11-29 20:08:52 +01:00
52b7280ad4
DEV: Remove a use of discourseModule ( #29996 )
2024-11-29 18:16:21 +01:00
f20db92512
UX: Improve loading-slider behavior ( #29995 )
...
- Use `requestAnimationFrame` when transitioning from `ready` -> `loading`. The previous `next()` implementation was unreliable, particularly in Safari, and would cause the loading slider to jump backwards instead of forwards
- Double the minimum transition time to 200ms. This avoids the rolling average being skewed too much by routes which load quickly without network access.
2024-11-29 16:32:59 +00:00
3cde55b76f
FIX: show urgent badge for mentions in DM threads ( #29821 )
...
When thread tracking level is Normal in a DM channel, we should still show notification badges to the mentioned user.
2024-11-29 12:52:55 +04:00
1497b298d2
DEV: Include controller namespace in X-Discourse-Route ( #29783 )
...
* DEV: Include controller namespace in X-Discourse-Route
* use same separator
2024-11-29 17:11:17 +11:00
fd2a82f41a
Build(deps-dev): Bump mocha from 2.6.0 to 2.6.1 ( #29991 )
...
Bumps [mocha](https://github.com/freerange/mocha ) from 2.6.0 to 2.6.1.
- [Changelog](https://github.com/freerange/mocha/blob/main/RELEASE.md )
- [Commits](https://github.com/freerange/mocha/compare/v2.6.0...v2.6.1 )
---
updated-dependencies:
- dependency-name: mocha
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-28 23:25:05 +01:00
615ec86b63
Build(deps): Bump reline from 0.5.11 to 0.5.12 ( #29990 )
...
Bumps [reline](https://github.com/ruby/reline ) from 0.5.11 to 0.5.12.
- [Release notes](https://github.com/ruby/reline/releases )
- [Commits](https://github.com/ruby/reline/compare/v0.5.11...v0.5.12 )
---
updated-dependencies:
- dependency-name: reline
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-28 23:24:48 +01:00
4cfc350b09
DEV: Fix linting issue and failing post test ( #29989 )
2024-11-28 18:13:32 -03:00
d3595b6118
FIX: Reset likeAction when updating a cached post from JSON data ( #29971 )
...
This commit addresses an issue where the like button would not be updated properly when reloading a post that lost the only like it had received.
2024-11-28 17:20:20 -03:00
Jarek Radosz
Régis Hanol
dependabot[bot]
Alan Guo Xiang Tan
Arpit Jalan
Kelv
Martin Brennan
Krzysztof Kotlarek
Thomas Kalka
Joffrey JAFFEUX
David Taylor
David Battersby
Osama Sayegh
Sérgio Saquetim