Commit Graph

24738 Commits

Author SHA1 Message Date
David Taylor 8825581d98 Discourse-presence improvements
- Added guardian checks to endpoint
- Added security to messagebus publishing
- Added specs for security measures
- Moved all logic into component
- Stop sending ‘keepAlive’ messages if the user stops editing for more then 2 minutes

- Enable plugin by default
2017-09-08 14:32:13 -07:00
David Taylor 1def49cf6c SECURITY: Only publish PM reply messagebus notifications to allowed users 2017-09-08 14:12:15 -07:00
Joffrey JAFFEUX 1d52231f42 FIX: css regression on category-dropdown-button 2017-09-08 21:28:28 +02:00
Joffrey JAFFEUX cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Robin Ward f13776e550 UX: Move `.visited` to entire row, not just the link to a topic 2017-09-08 13:54:41 -04:00
Robin Ward 717ed75fc4 Add warning when plugins changed by `tmp` was not removed 2017-09-08 13:38:46 -04:00
Robin Ward 7eb79ea31d FIX: Only enable the controller when the plugin is enabled 2017-09-08 10:45:14 -04:00
Robin Ward ac00f8b984 Disable presence for now 2017-09-08 10:36:10 -04:00
Robin Ward a9ed0023dc FIX: Presence was broken with a null array 2017-09-08 10:20:35 -04:00
Robin Ward 846e573766 Use a connector class to determine wheteher to render presence 2017-09-08 10:20:35 -04:00
Guo Xiang Tan b7ac33464f Reduce number of Redis calls. 2017-09-08 20:12:53 +08:00
Joffrey JAFFEUX 661ae38a03 FIX: makes sure we only autocomplete valid emoji tones 2017-09-08 09:42:13 +02:00
Arpit Jalan 6d35b62238 add image type attribute to icon link tag 2017-09-08 12:48:30 +05:30
Guo Xiang Tan 84031c5cb9 Make eslint happy. 2017-09-08 14:08:19 +08:00
Guo Xiang Tan 2db47f98cd Avoid allocating an extra array. 2017-09-08 14:07:24 +08:00
Guo Xiang Tan 0f2a303f00 Remove irrelevant comment. 2017-09-08 14:07:24 +08:00
Guo Xiang Tan 5d4221fbe1 PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
Before

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 19
  75: 19
  90: 21
  99: 27
topic:
  50: 56
  75: 62
  90: 64
  99: 99
timings:
  load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```

After

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 18
  75: 18
  90: 20
  99: 28
topic:
  50: 41
  75: 42
  90: 46
  99: 49
timings:
  load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Arpit Jalan 164a388dcc Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
Jeff Atwood f14f8d756f Merge pull request #5149 from davidtaylorhq/presence-translations
Simplify presence copy & add transifex config
2017-09-07 16:50:02 -07:00
David Taylor feef5491a2 Simplify copy & add transifex config 2017-09-08 00:47:35 +01:00
Robin Ward f6fb94d31f UX: Flags lost their red color on dropdown 2017-09-07 16:22:31 -04:00
Leo McArdle e183600563 FIX: redirect loop for new users visiting /new-topic using full screen login 2017-09-07 21:02:41 +01:00
Arpit Jalan a9737e2813 Merge pull request #5133 from guoyunhe/patch-1
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
Joffrey JAFFEUX d2d1c29f48 FIX: topic-notifications was taking too much space on mobile 2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX 3c0a9d4d19 FIX: topic-notifications taking too much space in timeline 2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX 5054065e81 FIX: broken spec 2017-09-07 19:18:27 +02:00
Régis Hanol 657440b8be FIX: consecutive_visits query wasn't properly setting 'granted_at' (3rd time's a charm) 2017-09-07 18:41:56 +02:00
Robin Ward afc075d93b UX: Convert bookmark icon from CSS to a proper icon using our helper 2017-09-07 11:41:19 -04:00
Robin Ward 0ba789de17 Allow for customization of header dropdown icons 2017-09-07 11:18:59 -04:00
Robin Ward 8e88bf019f Add `span` to various labels so they can be targetted 2017-09-07 11:10:11 -04:00
Joffrey JAFFEUX 70d0e175a2 FIX: default select-box-row should be aligned vertically 2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX 0374dc1a0e FIX: keys were incorrectly set to category 2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX 633d2fde45 removes select-box minWidth property
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX ca58a8228c minor css fixes on select-box 2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX d04aa5c7af FIX: component height computation was wrong 2017-09-07 16:55:36 +02:00
Leo McArdle 0ce9098339 add admin-user-details plugin outlet (#5141) 2017-09-07 16:17:27 +02:00
Guo Xiang Tan 58321d0783 PERF: Remove `Object#present?` check introduced in e0d5d9670a. 2017-09-07 21:36:27 +08:00
David Taylor 7d350d0d75 Revert plugin js changes (#5139)
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134)"

This reverts commit b840170f8d.

* Revert "Do not load javascripts for disabled plugins (#5103)"

This reverts commit a14ab48829.
2017-09-07 15:15:29 +02:00
Guo Xiang Tan a0daa7cad0 Oops fix build again. 2017-09-07 18:59:02 +08:00
Guo Xiang Tan e0d5d9670a Fix the build. 2017-09-07 18:41:44 +08:00
Guo Xiang Tan 3e123b1a39 PERF: Use `pluck` instead of enmurating through all the records. 2017-09-07 17:24:23 +08:00
Joffrey JAFFEUX dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
David Taylor c9912fcc37 Add discourse-presence as a core plugin (#5137)
* Add discourse-presence as a core plugin

* Default enabled
2017-09-07 09:40:18 +02:00
Guo Xiang Tan 4d840d10db PERF: Reduce number of Redis hits per requests. 2017-09-07 13:34:27 +08:00
Jeff Atwood 5aba30ede6 description wasn't checked in. ???? 2017-09-06 18:46:40 -07:00
Régis Hanol db920673dc FIX: consecutive_visits query wasn't return only the first result per user 2017-09-07 01:08:28 +02:00
Guo Xiang Tan 4142bed1af Fix incorrect topic id in profiiing script. 2017-09-07 06:01:35 +08:00
Jeff Atwood 27e4baf357 minor copyedits on visit days badges 2017-09-06 15:01:04 -07:00
Robin Ward a1957b7723 FIX: Stop moving notifications on large screens 2017-09-06 17:35:35 -04:00
Régis Hanol 8a935a4b5f FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days 2017-09-06 22:35:08 +02:00