00f632fb0d
REFACTOR: s/translatedfilterPlaceholder/translatedFilterPlaceholder ( #9521 )
2020-04-22 20:39:55 +02:00
4c248fc5c4
UX: do not attempt to full width sk on mobile ( #9520 )
2020-04-22 20:39:45 +02:00
e4a0e0bead
FIX: Ignore removed column
2020-04-22 14:27:01 -04:00
80a572d3b7
FIX: Multisite spec was failing in parallel environment
...
We were not adding the test number to the path in all places.
2020-04-22 14:05:39 -04:00
b810fc282d
FEATURE: Digital Ocean Spaces compatibility for Object Storage
...
DO does not implement tagging support for S3 objects. Removing our default
empty tag fixes compatibility.
The expire_missing_assets rake task can't be used with that service still,
but this patch allows normal operation.
2020-04-22 13:57:14 -03:00
df0c386f8a
UX: drop the `automatic_membership_retroactive` column from groups model. ( #9430 )
2020-04-22 22:07:39 +05:30
bf0c055a9a
UX: add comment-plus icon for reopening topics
2020-04-22 12:29:27 -04:00
81c216e04c
FIX: composer problem on the categories page ( #9508 )
2020-04-22 09:24:54 -07:00
04fb37c7a4
DEV: Export openNewCategoryModal from discovery-categories ( #9501 )
2020-04-22 11:03:28 -05:00
45f3517ef6
FEATURE: add class to <aside> quote block when quoting an ignored user ( #9511 )
...
* add class to <aside> quote block when quoted an ignored user
* Changed from single to double quotes
2020-04-22 12:00:44 -04:00
13f2723dcb
FIX: Don't log an error to logster if a topic could not be updated.
...
If for some reason an update did not go through (for example,
concurrently updating the same topic twice), we were logging something
like:
```
create_errors_json called with unrecognized type: #<Topic
```
This happened because we knew an error occurred but the active record
object had no errors attached.
This patch fixes the issue by attaching a proper error message in the
event that this happens.
2020-04-22 11:56:04 -04:00
58bdc04aac
Version bump to v2.5.0.beta3
2020-04-22 10:51:19 -04:00
4d45602517
Build(deps): Bump mini_racer from 0.2.9 to 0.2.10 ( #9507 )
...
Bumps [mini_racer](https://github.com/discourse/mini_racer ) from 0.2.9 to 0.2.10.
- [Release notes](https://github.com/discourse/mini_racer/releases )
- [Changelog](https://github.com/rubyjs/mini_racer/blob/master/CHANGELOG )
- [Commits](https://github.com/discourse/mini_racer/compare/v0.2.9...v0.2.10 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-22 10:26:31 -04:00
32f3f1c14b
Build(deps-dev): Bump mock_redis from 0.22.0 to 0.23.0 ( #9506 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.22.0...v0.23.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-04-22 10:26:09 -04:00
b7dea0d5c1
FIX: Copy button was displayed on quoted codeblock ( #9514 )
2020-04-22 15:57:25 +02:00
e5c44f6dcf
UX: display 'merge' button in all non-staff user profiles.
2020-04-22 17:42:09 +05:30
c8fed90e4e
FIX: Handle sub-sub-category paths without an id
2020-04-22 12:19:54 +01:00
ceee855d00
minor code improvement
...
a511bea4cc
2020-04-22 16:40:59 +05:30
5fb5807098
FIX: caret icon should inherit its color ( #9513 )
2020-04-22 13:10:02 +02:00
4889dbde49
FIX: differentiate sk outline handling on single/multi ( #9512 )
2020-04-22 13:02:20 +02:00
4e5f9d4cd1
DEV: Drop 'key' column from user_api_keys ( #9388 )
2020-04-22 12:13:19 +03:00
5c45363e67
UX: better outline support in sk components ( #9510 )
2020-04-22 10:54:02 +02:00
e733701887
FEATURE: Make report filters reusable ( #9444 )
...
This commit also adds 'include subcategories' report filter
2020-04-22 11:52:50 +03:00
a511bea4cc
FEATURE: admin UI to merge two users. ( #9509 )
2020-04-22 14:07:51 +05:30
13956017da
Update lefthook.
...
Support for `LEFTHOOK=0` was broken in the old version. See commit 3a6522ed6307e995a86179488b01dab22146502d of lefthook.
2020-04-22 14:58:48 +08:00
ee63c35c35
DEV: use array for matching multiple values
2020-04-22 12:25:59 +05:30
c028e1aca7
FIX: use absolute url for `/user_avatar/` links
2020-04-22 12:08:59 +05:30
628ba9d1e2
FEATURE: Promote bookmarks with reminders to core functionality ( #9369 )
...
The main thrust of this PR is to take all the conditional checks based on the `enable_bookmarks_with_reminders` away and only keep the code from the `true` path, making bookmarks with reminders the core bookmarks feature. There is also a migration to create `Bookmark` records out of `PostAction` bookmarks for a site.
### Summary
* Remove logic based on whether enable_bookmarks_with_reminders is true. This site setting is now obsolete, the old bookmark functionality is being removed. Retain the setting and set the value to `true` in a migration.
* Use the code from the rake task to create a database migration that creates bookmarks from post actions.
* Change the bookmark report to read from the new table.
* Get rid of old endpoints for bookmarks
* Link to the new bookmarks list from the user summary page
2020-04-22 13:44:19 +10:00
5a98869c5d
FIX: If bookmarking discobot posts, skip the reminder modal ( #9505 )
...
This is to streamline the new user narrative. only works when creating the bookmark, if editing/deleting the modal is shown. This is done via the plugin initializer.
2020-04-22 13:34:58 +10:00
e18aeb799e
FIX: Make sure reminder_type is parsed on bookmark update ( #9503 )
...
Otherwise we are trying to update the reminder type with a string which often evaluates to 0 (At Desktop) which causes reminders to come through early.
2020-04-22 10:44:04 +10:00
d1bee13fda
test fix
2020-04-21 17:57:25 -04:00
b6489d2690
UX: Replaced locked topic "lock" icon with "comment-slash" icon
2020-04-21 17:34:59 -04:00
f51b48b421
PERF: Improve lazy-load performance in Safari
...
Safari starts loading images as soon as attributes are modified. Modern browsers all prefer the srcset attribute over src, so we should remove srcset last, and add it first.
2020-04-21 19:05:33 +01:00
036236d6d6
FIX: properly add 'two-rows' class to header-topic-info container ( #9497 )
2020-04-21 13:01:57 -05:00
a97cb2444c
UX: Fix broken image placeholder styling
2020-04-21 19:00:47 +01:00
63811707e8
DEV: Remove `setupTopicController` event
2020-04-21 13:48:33 -04:00
ffa0a18841
Update bookmark step
...
See https://dev.discourse.org/t/discobot-tutorial-for-bookmarks/27466 for details
2020-04-21 19:35:03 +02:00
c4cc19a2ba
Revert "DEV: allow nav items to override computed property values"
...
This reverts commit 74e4102093
2020-04-21 09:58:46 -07:00
07e0490fe4
DEV: Update mocha ( #9490 )
...
The spec that was blocking the update was fixed in c08753dc34
2020-04-21 18:32:42 +02:00
fe579c918f
DEV: fix failing test relating to sk click propagation
...
* followup to 62459c84
2020-04-21 12:01:16 -04:00
1eb9bc4cec
DEV: encapsulates _events and clearing it at app-events module level ( #9489 )
2020-04-21 17:27:17 +02:00
c9cdd12e97
FIX: Improve selector for copy codeblock button ( #9493 )
...
Previous selector implementation was not accounting for codeblocks in
nested elements, like lists.
2020-04-21 10:12:56 -05:00
62459c845f
DEV: allows a sk component to stop click propagation ( #9495 )
2020-04-21 17:11:40 +02:00
79058a6d99
DEV: makes sk scroll to current selection ( #9492 )
2020-04-21 16:48:49 +02:00
4f834f0008
DEV: allows click to propagate outside of header but not outside of sk ( #9491 )
2020-04-21 16:20:05 +02:00
6559ad0d80
FEATURE: Add copy button to codeblocks ( #9451 )
2020-04-21 08:02:13 -05:00
776caa24c9
DEV: Bump optimist from 3.0.0 to 3.0.1 ( #9476 )
...
Bumps [optimist](https://github.com/ManageIQ/optimist ) from 3.0.0 to 3.0.1.
Mostly about fixing tests and adding a license file
2020-04-21 15:32:24 +10:00
c08753dc34
DEV: Fix topic_timer_spec ( #9483 )
...
File it under "how did it even work".
2020-04-21 14:38:35 +10:00
d123138d3a
FIX: Only confirm bookmark delete if a reminder has been set ( #9484 )
...
We do not need a secondary bootbox confirm if the bookmark has no reminder, because nothing really will be lost in that case.
2020-04-21 14:29:12 +10:00
a781ef7662
FIX: Reject invalid Category slugs ( #9473 )
...
Previously it would sanitize given slug and then save the resulting empty slug.
2020-04-21 03:50:50 +02:00
Joffrey JAFFEUX
Robin Ward
Rafael dos Santos Silva
Vinoth Kannan
Kris
Krzysztof Kotlarek
Mark VanLandingham
Eric Mueller
Neil Lalonde
dependabot-preview[bot]
Justin DiRose
Daniel Waterworth
Dan Ungureanu
Guo Xiang Tan
Arpit Jalan
Martin Brennan
David Taylor
Dax74
Jeff Wong
Jarek Radosz