97eae4e3ad
PERF: avoid using destroy_all when removing stats ( #11358 )
...
destroy_all will load all the active record relation and iterate, this
can get extremely expensive.
2020-11-26 15:29:39 +10:00
c9df679ba1
FIX: Only use full slugs when compiling category backgrounds. ( #11353 )
...
If a category and a sub-category have the same slug, adding a background to one of them will also show it on the other one. This was introduced in 8e3f667214b4c3
2020-11-25 15:40:16 -03:00
059e9cb1d2
REFACTOR: Remove `.erb` from emoji-picker
...
We can't use erb in ember-cli, and it seems the emoji groups rarely
change anyway. This commit migrates the ERB to pre-rendered javascript
that is updated via the `rake javascript:update_constants` task.
2020-11-25 11:23:02 -05:00
9ec0359022
Build(deps): Bump rubocop from 1.4.1 to 1.4.2 ( #11349 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.4.1...v1.4.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 12:42:36 +01:00
834d71d1f7
Build(deps): Bump rails_failover from 0.6.1 to 0.6.2 ( #11350 )
...
Bumps rails_failover from 0.6.1 to 0.6.2.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 11:21:50 +00:00
f5945efae7
DEV: watch more test directories ( #11346 )
...
Much has moved and autospec stopped picking up certain tests.
2020-11-25 11:12:23 +00:00
abb89475a3
FIX: issues with frowning/grinning ( #11235 )
...
- frowning was using slighty_frowning
- slightly_frowning was using frowning
- grinning_face_with_smiling_eyes was not defined
- fronwing_face_with_open_mouth was not defined
2020-11-25 09:09:35 +01:00
5028aaf446
FIX: Add secure media url to SERVER_SIDE_ONLY list ( #11348 )
2020-11-25 15:31:31 +11:00
2348a7972e
FIX: When quoting an attachment, keep the |attachment in markdown ( #11347 )
2020-11-25 15:31:14 +11:00
3e1b94c227
PERF: avoid checking card background and user background when not supplied ( #11299 )
...
Previously we were performing a bunch of needless work when SSO failed
to supply profile and card backgrounds.
2020-11-25 10:53:44 +11:00
51f9a56137
FEATURE: Onebox local categories ( #11311 )
...
* FEATURE: onebox for local categories
This commit adjusts the category onebox to look more like the category boxes do on the category page.
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
2020-11-25 10:53:05 +11:00
416f984c5e
FEATURE: Update onebox and add styling for githubfolder onebox ( #11313 )
2020-11-25 10:51:29 +11:00
436d68d54f
UX: Don't show selected posts interface twice on mobile ( #11328 )
...
Note to reproduce you need a topic with over 3 posts.
2020-11-25 10:50:05 +11:00
f9ff51870b
FIX: Rebake theme fields if upload changes ( #11341 )
...
Updating SVG sprites of a theme did not take effect immediately because
the cache was not cleared.
2020-11-25 10:49:12 +11:00
e527741577
Build(deps): Bump rubocop-ast from 1.1.1 to 1.2.0 ( #11343 )
...
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast ) from 1.1.1 to 1.2.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v1.1.1...v1.2.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 09:17:55 +11:00
ad1a10e6e9
FIX: hides votes from regular users when poll is staff only ( #11342 )
2020-11-24 22:19:06 +01:00
a6613d15f4
Adds discourse-gifs to suggested components ( #11339 )
2020-11-24 14:58:45 -03:00
9c901ee978
Update translations ( #11336 )
2020-11-24 17:25:37 +01:00
0e0c70019b
FIX: Suggested Topics was being set inside a computed property
...
This is bad because changing the `suggested_topics` proeprty could cause
a `set` on `suggested_topics`.
2020-11-24 11:08:11 -05:00
67979b2b21
Remove "Alternative Logos" from popular themes list ( #11337 )
...
Core has had support for dark theme logos for a while now.
2020-11-24 10:13:16 -05:00
0c685a46de
FEATURE: Add user update, anonymize and delete API scopes ( #11335 )
2020-11-24 12:54:24 +00:00
7ad2c2bdd8
FIX: Exclude muted results when suggested related topics at random. ( #11290 )
...
We already do this for new and unread results, but not for randomly suggested topics.
2020-11-24 09:16:10 -03:00
123107c28f
UX: Add group name to error message ( #11333 )
...
The group name used to be part of the error message, but was removed
in a past commit.
2020-11-24 13:06:52 +02:00
2742595b00
FIX: Checkbox value should not leak between themes ( #11327 )
...
This commit includes a hack to ensure didInsertElement is called only
once.
2020-11-24 12:10:28 +02:00
4b538e7cb9
DEV: Skip missing icon warnings in production ( #11334 )
...
The list of SVG icons is unavailable in production, and the previous
refactor here was causing incorrect and noisy console warnings.
This also parses the `svgIconList` string in a dev environment, icons
should now match more accurately.
2020-11-23 21:41:54 -05:00
0d8d568654
Build(deps-dev): Bump parallel_tests from 3.3.0 to 3.4.0 ( #11331 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 3.3.0 to 3.4.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md )
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.3.0...v3.4.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-23 22:27:27 +01:00
5a4811ede8
Build(deps): Bump rubocop from 1.3.1 to 1.4.1 ( #11332 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 1.3.1 to 1.4.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v1.3.1...v1.4.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-23 22:24:48 +01:00
de2d323ccf
UX: Slightly adjust onebox alignment ( #11326 )
...
* fixed header/favicon's vertical alignment
* slightly increased header margin
* made the onebox padding symmetrical
* increased the right margin on small image elements
* removed extraneous pre bottom margin
2020-11-23 22:16:50 +01:00
defbae4007
FIX: Force string conversions to UTF-8 "bytes" ( #11315 )
...
https://meta.discourse.org/t/cant-create-poll-with-some-chinese-options/170836
2020-11-23 17:51:05 +01:00
3394d994e9
FIX: Tests were using jQuery selectors
...
For the most part `querySelectorAll` will work with jQuery selectors,
but the big exception is `:eq(0)` and similar. Those needed to be
replaced.
2020-11-23 11:36:07 -05:00
60bc38e6a8
FIX: Gracefully handle force pushes for remote themes ( #11325 )
...
Force pushing a commit to a theme repository used to break the updater,
because the system was not able to count the commits behind the old and
new version. This operation failed because a force push deleted the old
commits.
The user was prompted with a simple "500 server error" message.
2020-11-23 15:29:22 +02:00
139c5dc356
FIX: use `tag` model instead of tagId property. ( #11298 )
...
In a recent commit 866fa008d42d5bb516a6
2020-11-23 16:40:15 +05:30
20c0da8516
FIX: Improve email validation error handling for external logins ( #11307 )
...
- Display reason for validation error when logging in via an authenticator
- Fix email validation handling for 'Discourse SSO', and add a spec
Previously, validation errors (e.g. blocked or already-taken emails) would raise a generic error with no useful information.
2020-11-23 11:06:08 +00:00
4638c6fc8d
FEATURE: Add 'all subcategories' option in category-selector ( #11099 )
2020-11-23 10:55:32 +02:00
c540bf5e2b
FIX: correct cdn path ( #11324 )
...
This was a typo in a118ec13
2020-11-23 13:03:49 +11:00
a118ec13bc
FIX: stop including GlobalPath in default context ( #11323 )
...
We do not want these method names to clash, instead encapsulate the helpers
so we do not add methods to Kernel
Correct a but exposed by Ruby 2.7
2020-11-23 12:59:45 +11:00
855026eea1
UX: PM title glyph alignment and consistency improvement ( #11314 )
...
* UX: PM title glyph alignment should match public topic-status style
* minor fixes
2020-11-23 12:16:41 +11:00
28db835c4c
FIX: Calculate email attachment size limit correctly ( #11321 )
...
When calculating whether the attached uploads went over the SiteSetting.email_total_attachment_size_limit_kb.kilobytes limit, we were using the original_upload for the calculation instead of the actually attached_upload, which will be smaller in most cases because it can be an optimized image.
2020-11-23 11:16:08 +10:00
790b9856af
FIX: Onebox image alignment ( #11319 )
...
It was overlapping with elements after it and was unnecessarily indented relative to the text before it.
2020-11-23 10:49:02 +11:00
a9eb1163e1
UX: Do not include current user in group-filtered directory results ( #11310 )
...
At the moment, when filtering by group, the directory will unconditionally return the current user at the top of the list. This is quite unexpected, given that the user is deliberately trying to filter the list. This commit makes sure the 'include current user' logic only triggers for unfiltered directories
2020-11-23 10:22:14 +11:00
153997f13a
Build(deps): Bump parallel from 1.20.0 to 1.20.1 ( #11316 )
...
Bumps [parallel](https://github.com/grosser/parallel ) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/grosser/parallel/releases )
- [Commits](https://github.com/grosser/parallel/compare/v1.20.0...v1.20.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-22 22:48:25 +01:00
66ecefba52
FIX: Upload events happened outside of the runloop
...
This could cause test failures when checking for the result of the
events if Ember hasn't applied them yet.
2020-11-20 15:35:00 -05:00
8aa912c885
FIX: iconList is an array in production ( #11308 )
...
This should be investigated further, but hopefully the comment will prevent anyone else to fall in this trap.
2020-11-20 20:00:51 +01:00
0ec62358d9
FEATURE: Add site setting to restrict ignore feature to trust level ( #11297 )
...
This adds a new min_trust_level_to_allow_ignore site setting that enables admins to control the point at which a user is allowed to ignore other users.
2020-11-20 10:05:20 -08:00
1ea6bbab34
FIX: We shouldn't debounce this in testing
...
Eventually we should add a helper to prevent all debouncing in test, but
for now this will really speed up Ember-CLI tests.
2020-11-20 12:39:49 -05:00
d6f2a63efe
FIX: Tests were performing `data[]` queries but without quotes
...
This works in jQuery but not querySelectorAll
2020-11-20 12:39:07 -05:00
8a90a5610f
DEV: allows to check if an icon is in the set ( #11303 )
2020-11-20 17:34:55 +01:00
7539c2ed7f
UX: Revamp category security tab ( #11273 )
2020-11-20 10:44:34 -05:00
dbcf722ab9
DEV: Modulize component tests ( #11300 )
...
It's like the new tests, but still old underneath!
2020-11-20 15:54:09 +01:00
ca9abb4f90
Build(deps): Bump rails_failover from 0.6.0 to 0.6.1 ( #11302 )
...
Bumps rails_failover from 0.6.0 to 0.6.1.
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-20 14:35:36 +00:00
Sam
Roman Rizzi
Robin Ward
dependabot[bot]
Joffrey JAFFEUX
Martin Brennan
jbrw
Bianca Nenciu
Rafael dos Santos Silva
Discourse Translator Bot
Penar Musaraj
David Taylor
Dan Ungureanu
Jarek Radosz
chenyxuan
Vinoth Kannan
Kris
tshenry