Commit Graph

14703 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 1f8695b16a fix broken build 2017-09-09 20:58:37 +02:00
Joffrey JAFFEUX 950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Robin Ward e6d3bbfa1d FIX: Categories admin menu was missing 2017-09-09 09:21:43 -04:00
Joffrey JAFFEUX 8c3f7d9bbc FIX: select-box width was incorrect on mobile 2017-09-09 02:41:31 +02:00
Joffrey JAFFEUX 753bf72921 FIX: adds correct spacing between footer buttons 2017-09-09 02:28:51 +02:00
Joffrey JAFFEUX 253672f3fa makes notification-options design more compliant with existing design 2017-09-09 01:53:10 +02:00
Joffrey JAFFEUX ab700d86ba lighter icon color for categories-admin-actions 2017-09-09 01:52:36 +02:00
Joffrey JAFFEUX a9aa11d7c4 use d-icon names 2017-09-09 01:48:03 +02:00
Joffrey JAFFEUX 5b9819f4ed minor fixes to select-box 2017-09-09 00:49:33 +02:00
David Taylor 1def49cf6c SECURITY: Only publish PM reply messagebus notifications to allowed users 2017-09-08 14:12:15 -07:00
Joffrey JAFFEUX 1d52231f42 FIX: css regression on category-dropdown-button 2017-09-08 21:28:28 +02:00
Joffrey JAFFEUX cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Robin Ward f13776e550 UX: Move `.visited` to entire row, not just the link to a topic 2017-09-08 13:54:41 -04:00
Guo Xiang Tan b7ac33464f Reduce number of Redis calls. 2017-09-08 20:12:53 +08:00
Joffrey JAFFEUX 661ae38a03 FIX: makes sure we only autocomplete valid emoji tones 2017-09-08 09:42:13 +02:00
Arpit Jalan 6d35b62238 add image type attribute to icon link tag 2017-09-08 12:48:30 +05:30
Guo Xiang Tan 5d4221fbe1 PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
Before

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 19
  75: 19
  90: 21
  99: 27
topic:
  50: 56
  75: 62
  90: 64
  99: 99
timings:
  load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```

After

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 18
  75: 18
  90: 20
  99: 28
topic:
  50: 41
  75: 42
  90: 46
  99: 49
timings:
  load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Arpit Jalan 164a388dcc Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
Robin Ward f6fb94d31f UX: Flags lost their red color on dropdown 2017-09-07 16:22:31 -04:00
Leo McArdle e183600563 FIX: redirect loop for new users visiting /new-topic using full screen login 2017-09-07 21:02:41 +01:00
Arpit Jalan a9737e2813 Merge pull request #5133 from guoyunhe/patch-1
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
Joffrey JAFFEUX d2d1c29f48 FIX: topic-notifications was taking too much space on mobile 2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX 3c0a9d4d19 FIX: topic-notifications taking too much space in timeline 2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX 5054065e81 FIX: broken spec 2017-09-07 19:18:27 +02:00
Robin Ward afc075d93b UX: Convert bookmark icon from CSS to a proper icon using our helper 2017-09-07 11:41:19 -04:00
Robin Ward 0ba789de17 Allow for customization of header dropdown icons 2017-09-07 11:18:59 -04:00
Robin Ward 8e88bf019f Add `span` to various labels so they can be targetted 2017-09-07 11:10:11 -04:00
Joffrey JAFFEUX 70d0e175a2 FIX: default select-box-row should be aligned vertically 2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX 0374dc1a0e FIX: keys were incorrectly set to category 2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX 633d2fde45 removes select-box minWidth property
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX ca58a8228c minor css fixes on select-box 2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX d04aa5c7af FIX: component height computation was wrong 2017-09-07 16:55:36 +02:00
Leo McArdle 0ce9098339 add admin-user-details plugin outlet (#5141) 2017-09-07 16:17:27 +02:00
David Taylor 7d350d0d75 Revert plugin js changes (#5139)
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134)"

This reverts commit b840170f8d.

* Revert "Do not load javascripts for disabled plugins (#5103)"

This reverts commit a14ab48829.
2017-09-07 15:15:29 +02:00
Joffrey JAFFEUX dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
Guo Xiang Tan 4d840d10db PERF: Reduce number of Redis hits per requests. 2017-09-07 13:34:27 +08:00
Robin Ward a1957b7723 FIX: Stop moving notifications on large screens 2017-09-06 17:35:35 -04:00
Régis Hanol 8a935a4b5f FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days 2017-09-06 22:35:08 +02:00
Joffrey JAFFEUX 0fca5ed533 FIX: stricter check on presence of notification_level_change
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
Robin Ward 825452df76 Refactor header CSS for composability 2017-09-06 11:34:10 -04:00
Robin Ward 777f024b8c Clean up weird indentation 2017-09-06 11:34:10 -04:00
Joffrey JAFFEUX ccf5005feb FEATURE: uses select-box for topic-notifications-button component
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
David Taylor b840170f8d Add disabled_plugins to preloadstore for login_required anonymous users (#5134) 2017-09-06 12:18:58 +02:00
David Taylor a14ab48829 Do not load javascripts for disabled plugins (#5103)
* Do not load javascript for disabled plugins

* Appease rubocop
2017-09-06 10:06:47 +02:00
Guo Yunhe 7d29ccf207 bbcode find close tag loop end condition
Only break loop when close tag has been found. Otherwise, keep searching until the end of string.
2017-09-06 09:13:57 +03:00
Guo Xiang Tan 8463b676df Revert "Activate mini-profiler when in profiling env."
This reverts commit d61109388c.
2017-09-06 11:26:03 +08:00
Guo Xiang Tan d61109388c Activate mini-profiler when in profiling env. 2017-09-06 11:19:20 +08:00
Guo Xiang Tan 672b7cb9a5 Require missing dependency. 2017-09-05 09:39:56 +08:00
Guo Xiang Tan 7786c6c6f2 Remove duplicated scope. 2017-09-05 09:15:06 +08:00
Robin Ward 51ffbf1c1f FIX: Remove duplicate event typo 2017-09-04 15:39:58 -04:00
minusfive fd91e53e68 Cleaned, de-duplicated/DRYed and organized discourse.css (common, mobile and desktop) 2017-09-04 10:56:28 -07:00
Robin Ward db929e58fc FIX: Don't allow staff to approve users with unverified emails 2017-09-04 12:55:39 -04:00
Robin Ward be1cce503c FIX: Don't bind events in `defaultState` 2017-09-04 11:48:36 -04:00
Joffrey JAFFEUX afe6f46b03 merges after_save 2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX caedefd675 FIX: correctly resets user_themes template
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Arpit Jalan 3b7128102c FIX: disable follow in topic summary links
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
Guo Xiang Tan 5c1143cd55 Add missing test case for `PostController#timings`. 2017-09-04 16:36:02 +08:00
Arpit Jalan ebbdd4fe0f FIX: error when rebaking posts 2017-09-02 22:22:29 +05:30
Robin Ward dfe347fb1d FIX: Wizard tests don't need `Discourse` defined 2017-09-01 12:26:42 -04:00
Robin Ward c6ff387ce9 Use more semantic names for various tracking icons
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron 46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward cb56dcdf2e FIX: Use proper `iconNode` when compiling virtual dom templates 2017-09-01 11:20:33 -04:00
Vinoth Kannan 0fb7831749 FEATURE: Add placeholders to broken and large image files (#5113) 2017-09-01 10:26:13 -04:00
Sam Saffron e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive b3b6eeff97 Ensure css applies to .user-main > .about icons regardless of tag 2017-09-01 06:32:27 -07:00
minusfive 611d62e4a5 Cleanup, deduplicate, debug user css, separated user-info component css 2017-09-01 06:32:27 -07:00
Robin Ward dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
2017-09-01 09:28:16 -04:00
Arpit Jalan 66f2925348 SECURITY: do not include links from whispers in topic summary map
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Robin Ward ef0f346eec Add custom style for header buttons 2017-08-31 12:10:54 -04:00
Joffrey JAFFEUX 56468582ee FIX: visual regressions on title-wrapper 2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX 0957ac9ee2 FIX: minor css tweaks to title-wrapper 2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX 84e992363c FIX: use maximum z-index for select-box when expanded 2017-08-31 00:55:05 +02:00
Robin Ward 75b2aa2edd Better support for inline modals 2017-08-30 17:52:49 -04:00
Robin Ward a48abc6556 Tweaks for better modal distinction between fixed/inline 2017-08-30 17:38:49 -04:00
Robin Ward 6361618188 `fixed-modal` is a better name 2017-08-30 15:52:29 -04:00
Robin Ward 3d95bac3fb Migrate away from `#discourse-modal` to `.d-modal` 2017-08-30 15:29:51 -04:00
Robin Ward 8fcd5af5b1 UX: Use a template for the `d-modal` component 2017-08-30 15:20:49 -04:00
Robin Ward 64bb0f9f05 Add a class to target the sugested topics message 2017-08-30 13:50:39 -04:00
Robin Ward 3aed047b7e UX: Add another div to aid in styling via flexbox 2017-08-30 13:43:56 -04:00
minusfive 5fd4970602 Cleanup nav-stacked .active state styles, remove unnecessary nesting 2017-08-30 09:14:56 -07:00
minusfive 8781c6bfcb Removed unnecessary outer link-tos from admin/settings|watched-words navs 2017-08-30 09:14:56 -07:00
Joffrey JAFFEUX 746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan 0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Sam 9a861c1b43 Correct previous commit
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam 5cdb486332 UX: large topic creation area on mobile
This refines the iOS hack and allows for height 100%
on the composer

Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam c705159d22 Remove email column from user table 2017-08-29 11:50:56 -04:00
Sam b3fd091379 annotate stuff 2017-08-29 10:48:22 -04:00
Joffrey JAFFEUX 98c6c7e35a FIX: css regression on select-box 2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX cb4f690937 uses new select-box for quick topic edit 2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX dcc5f93344 FIX: disable highlighting when no value set on select-box 2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX 21c4e38eec clean select-box css 2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX 861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joshua Rosenfeld e3e6fd6ea0 FIX: Only show topic timer to staff 2017-08-28 23:49:30 -04:00
Sam 50203794e6 FIX: staged users should get emails on must_approve_users sites 2017-08-28 17:32:07 -04:00
Sam 41e7bdff38 FIX: don't refresh notifications in a tight loop 2017-08-28 16:52:00 -04:00
Sam 9f0f086b3e FEATURE: allow API to mark accounts as approved on creation 2017-08-28 15:36:46 -04:00
Bianca Nenciu fa69e0dd77 Improved metadata for tags. (#5067) 2017-08-28 13:11:34 -04:00
Leo McArdle fd2cd63b08 FIX: make /new-topic redirect survive full screen login (#5105) 2017-08-28 12:40:31 -04:00
Bianca Nenciu 6bc74ceb50 Split alias levels in mentionable and messageable levels. (#5065)
* Split alias levels in mentionable and messageable levels.

* Fixed some tests.

* Set messageable level to everyone by default.

* By defaults, groups are not mentionable or messageable.

* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
David Taylor ce2250d7aa Add avatar-flair plugin outlet for user card (#5104) 2017-08-28 12:26:42 -04:00
minusfive d70ecf1c53 Simplify user-nav styles to facilitate theming 2017-08-28 09:24:41 -07:00
Bianca Nenciu bb3a5910d7 Support for sending PMs to email addresses (#4988)
* Added support for sending PMs to email addresses.

* Made changes after review.

* Added settings validator.

* Fixed tests.
2017-08-28 12:07:30 -04:00
Joffrey JAFFEUX b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Arpit Jalan be972912cb FIX: do not show full name field when accepting invite if full names are disabled
https://meta.discourse.org/t/require-password-for-trusted-user-invites/13750/58?u=techapj
2017-08-27 12:15:32 +05:30
Robin Ward a77ede05e2 FIX: Don't re-render if you find composer messages after destroying 2017-08-26 00:41:24 -04:00
Robin Ward b93f491035 Add option for button type under posts 2017-08-26 00:00:52 -04:00
Robin Ward 27b10a709b Revert "FIX: Un-revert the btn class added to the topic post menu"
This reverts commit aa07d23caa.
2017-08-25 23:50:00 -04:00
Joffrey JAFFEUX 5d12db1fb5 FIX: html not showing in select-box header 2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX 918f5045b4 FEATURE: display subcategories when filtering on parent name 2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX 2efb39289c FIX: select-box fragile specs 2017-08-26 01:24:17 +02:00
Robin Ward aa07d23caa FIX: Un-revert the btn class added to the topic post menu 2017-08-25 17:08:34 -04:00
Joffrey JAFFEUX 296ea6c7b1 FIX: castInteger on initial value 2017-08-25 22:41:35 +02:00
Robin Ward 7f16323ba4 REVERT: btn class looked ugly, let's revert for now 2017-08-25 16:06:56 -04:00
Neil Lalonde 398604ac71 FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users 2017-08-25 15:20:06 -04:00
minusfive d911d3ff6e Namespaced Sass color brightness function to avoid conflict w/CSS filter 2017-08-25 11:10:11 -07:00
Joffrey JAFFEUX 14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Robin Ward 075cc1a8bb FIX: some button classes 2017-08-25 13:44:28 -04:00
Robin Ward 493fd707f8 UX: Add missing `btn` class to `flat-button` 2017-08-25 13:16:18 -04:00
Robin Ward 4e9c4f0768 Add option to collapse buttons in post menu 2017-08-25 13:11:53 -04:00
Robin Ward 324b02a830 Add option to move the poster name in with the avatar 2017-08-25 13:11:53 -04:00
Neil Lalonde ea969d1ed0 FEATURE: add Thai language 2017-08-25 12:33:09 -04:00
Neil Lalonde 2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
minusfive cdcc5d6174 Extracted/DRYed user-stream-item component CSS from user.css into own files
- Renamed 'stream-item' component to 'user-stream-item'
- Replaced generic 'item' class with clearer 'user-stream-item' class
- Retained 'item' class for backward compatibility, marked as 'DEPRECATED'
- Extracted CSS pertaining 'user-stream-item' component to component CSS files
- Removed unnecessary duplication from 'user-stream-item' CSS
- Removed unnecessary nesting from 'user-stream-item' CSS
2017-08-25 08:38:27 -07:00
Joffrey JAFFEUX bbd428fb94 FIX: more consistent filter from keyboard on select-box 2017-08-25 01:48:32 +02:00
minusfive 8a06d3d312 Fix + remove unnecessary indentation, dead code, cleanup user.css 2017-08-24 14:46:01 -07:00
Jeff Atwood c8ce3c6dee make composer edu panel close button more visible 2017-08-24 13:49:33 -07:00
minusfive 512858c2e7 Removed no-longer-used styles from group.scss 2017-08-24 10:07:36 -07:00
minusfive c01dc26ea6 Add no-content message for user/activity/replies, fix no-content display 2017-08-24 09:51:39 -07:00
Joffrey JAFFEUX f3388043db FIX: avoids select-box being over composer popup 2017-08-24 18:49:35 +02:00
minusfive cdf0fefe8c Removed icons + no-glyph classes from /user sub-navs, normalized indentation 2017-08-24 09:41:27 -07:00
Joffrey JAFFEUX 39a89419b6 uses select-box for theme selection on user profile 2017-08-24 18:33:01 +02:00
Joffrey JAFFEUX d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Robin Ward a6251f717b Convert user card buttons to `{{d-button}}` components 2017-08-24 12:23:08 -04:00
Joffrey JAFFEUX 9c446fcb4d FIX: modify select-box orientation when composer resizes 2017-08-24 17:14:55 +02:00
Joffrey JAFFEUX 21d6c7f6b3 FIX: duplicated categories in select-box 2017-08-24 16:54:10 +02:00
Joffrey JAFFEUX d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
This reverts commit 1d90f6016a.
2017-08-24 16:04:47 +02:00
Guo Xiang Tan 0531ef2e20 Fix calling `exists?` on Arrays. 2017-08-24 09:56:07 +09:00
Guo Xiang Tan 4b4169c8fd Merge pull request #5053 from fantasticfears/session-controller
Spec for local auth check
2017-08-24 09:42:54 +09:00
Guo Xiang Tan 91d3929f52 Merge pull request #5078 from lelelelemon/master
change count>0 to exists
2017-08-24 09:24:42 +09:00
Guo Xiang Tan 027b999828 Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
junwen yang 8124f26a6e change count>0 to exists 2017-08-23 22:54:51 +00:00
minusfive 38eef177d4 Cleanup & debug .nav-stacked styles 2017-08-23 13:58:41 -07:00
Robin Ward 950c9e50ac Add wrapper div to aid in styling 2017-08-23 14:47:09 -04:00
Sam f766ea4257 Correct short url decoding for sha1s leading with zero
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Joffrey JAFFEUX 1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic"
This reverts commit 7b4e302677.
2017-08-23 16:33:03 +02:00
Leo McArdle 3986367f3f update pr based on review 2017-08-23 14:55:34 +01:00
Joffrey JAFFEUX 7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Sam 8dfb1be4d1 FEATURE: unlisted *only* means not listed in topic lists
Remove security by obscurity feature that tries for exact slug match

If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Neil Lalonde 224796a7d4 FIX: wrongs counts on tags with deleted topics 2017-08-22 16:55:05 -04:00