b223cdb493
Strip spaces from group names upon creation
2013-07-24 00:00:17 -04:00
25f8692a79
Strip leading/trailing spaces from login
2013-07-23 23:03:38 -04:00
38b8e9b1b4
get rake autospec working in rails 4
2013-07-24 11:49:26 +10:00
be9217d4c8
add server-side filesize check on uploads
2013-07-24 00:54:41 +02:00
cf102be953
Allow deletion of a post belonging to a deleted topic, so that users can be destroyed
2013-07-23 11:50:58 -04:00
9ac6c6e2e9
Merge pull request #1233 from sir-pinecone/improve-group-deletion
...
Add confirmation modal to admin group deletion
2013-07-23 00:43:06 -07:00
ef201e02d7
Merge pull request #1238 from ZogStriP/moar-bullets
...
change the pipe into a bullet in the lightbox overlay
2013-07-23 00:41:47 -07:00
478ae6d6c7
correct bug where delete stub job would fail when attempting to delete stubs off deleted topics
...
skip deleting stubs if a post is actively flagged
2013-07-23 16:11:44 +10:00
060c79ecc0
remove dupes before correcting topic_ids in user action consistency check job
2013-07-23 12:44:20 +10:00
4b269de724
correct: http://meta.discourse.org/t/cant-save-adding-a-group-permission-to-a-category/8537
...
can not save category after adding a new custom group
2013-07-23 10:10:36 +10:00
0acc96c94e
work around for http://meta.discourse.org/t/activerecord-statementinvalid-exception-raised-in-models-user-action-rb/7275/4
2013-07-23 09:48:18 +10:00
7b1f9928e4
staff can change trust levels
2013-07-23 09:13:48 +10:00
dbf6fb0232
change the pipe into a bullet in the lightbox overlay
2013-07-22 22:41:08 +02:00
fd1d376975
Merge pull request #1235 from stephankaag/remove_all
...
Remove some calls to `all`
2013-07-22 12:26:00 -07:00
3e7b418ea8
First Try: Include Post History (context) in Notification Emails
2013-07-22 15:06:37 -04:00
0e3b8fbb24
Remove some calls to `all`. They are not required, and Rails4 raises warnings about them.
2013-07-22 20:44:11 +02:00
ed745c3fdd
Merge pull request #1222 from ZogStriP/fix-s3-related-issues
...
Fix s3 related issues
2013-07-22 07:30:41 -07:00
80a0943f54
Merge pull request #1228 from ZogStriP/fix-thumbnailing-with-cdn-enabled
...
FIX: thumbnailing isn't working with CDN enabled
2013-07-22 07:22:59 -07:00
8b181e0803
Merge pull request #1230 from ZogStriP/add-newuser-max-attachments-setting
...
add newuser-max-attachments setting
2013-07-22 07:22:23 -07:00
1f3c5cb656
allow end user to recover a post they delete
...
automatically delete stubs after 1 day
2013-07-22 17:48:47 +10:00
9616767bff
Add confirmation modal to admin group deletion
2013-07-22 02:48:23 -04:00
58e7c3e1f3
push some work out of AR callbacks into PostCreator, add a couple of helpers for post and topic creation in test
...
fix it so the auto_track false marks topics as new
2013-07-22 15:07:20 +10:00
31bb08bcdd
added an option to bypass auto tracking of topics on post creation
2013-07-22 15:07:20 +10:00
9e4b0df7ff
69 specs fail in rails 4 now ...not too bad
2013-07-22 15:07:20 +10:00
2986798ba7
add newuser-max-attachments setting
2013-07-22 02:39:17 +02:00
649ab85740
FIX: thumbnailing wasn't working with CDN enabled
2013-07-22 00:37:23 +02:00
945ee5dda0
opps. missed a comment
2013-07-20 12:13:31 +02:00
33977252c9
rollback to previous s3 syntax (ie. subdomains)
2013-07-20 11:30:36 +02:00
8406a4230c
FIX: click tracking on attachments wasn't working
2013-07-19 01:27:09 +02:00
751b757c1d
FIX: Some failing specs
2013-07-18 12:26:38 -04:00
81616a46ba
db consistency check for mismatching topic_ids in user_actions
...
fix up post mover so it remaps user actions as well
move specs for post mover into post_mover_spec
2013-07-17 16:40:56 +10:00
c2be81a76e
Merge pull request #1199 from ZogStriP/uploads
...
adds the `max_attachment_size_kb` setting
2013-07-16 23:03:42 -07:00
5c27dd175a
make sure we handle both s3 url formats
2013-07-17 00:32:09 +02:00
7ae2fe304d
renamed s3 to s3_store
2013-07-17 00:27:52 +02:00
f40cad0f4b
changed s3 urls to using the folder convention
2013-07-17 00:27:52 +02:00
3136638b4b
FIX: CDN doesn't work with S3
2013-07-16 22:16:33 +02:00
75282576b9
Merge pull request #1195 from initforthe/post-analyser-backtrace-fix
...
Post analyser backtrace fix
2013-07-16 07:34:54 -07:00
c49731a91b
fix failing server side quote localisation change
2013-07-16 17:48:48 +10:00
943f88fb88
make specs more robust
2013-07-16 16:18:05 +10:00
352ac9e60c
Finalize read only and post only categories, finished off UI work
2013-07-16 15:46:11 +10:00
ecf17cfebb
work in progress, add fidelity to category group permissions (full, create posts, readonly)
2013-07-16 15:46:11 +10:00
5ce05ff5cb
adds the `max_attachment_size_kb` setting
...
so that we can specify a different max upload size for attachments and images.
2013-07-16 02:01:36 +02:00
0e504aac9b
FIX: You can reset your password even if logins are required.
2013-07-15 12:12:54 -04:00
ed60f24502
Merge pull request #1194 from ZogStriP/uploads
...
[Upload] Great deal of renaming
2013-07-15 07:06:18 -07:00
19e0feac75
Merge pull request #1185 from novemberkilo/master
...
Reduce complexity of TopicView
2013-07-15 07:05:41 -07:00
f3279a67fc
Failing test
2013-07-15 11:22:59 +01:00
00d7d8b809
ooops, fixed CookedPostProcessor specs
2013-07-15 00:18:17 +02:00
3397c2235f
display the size of the attachment in the preview
...
instead of adding it during post processing
2013-07-14 12:28:24 +02:00
6f2ce93ab2
FIX: create an upload when FastImage throws an exception
...
FastImage might throw an exception when it isn't able to recognize a
file as being an image (ie. happens when users changes the extension
manually)
Also improved upload specs a lot
2013-07-13 23:42:19 +02:00
9c243aa9ce
Simplify avatar lookup class
2013-07-12 23:10:21 +02:00
a43ed88699
Prefer your own topics in Suggested
2013-07-12 14:38:20 -04:00
6ca5df0a09
Can recover deleted topics. Deleted topics show the first post as deleted in the UI.
2013-07-12 12:09:17 -04:00
9c5b5e3c7d
Refactor TopicView - extract filter method to FilterBestPosts
...
Still much to do but this should reduce the complexity scores
for TopicView
2013-07-12 15:54:54 +02:00
89152116c6
Only send digests to active users
2013-07-11 18:47:36 -04:00
19c169540c
Staff can enter and view deleted topics
2013-07-11 16:39:35 -04:00
7fd8bb75d9
Merge pull request #1177 from ZogStriP/attachments
...
Attachments
2013-07-11 06:49:20 -07:00
1aef6de4b0
automatically approve invited users on forum where moderators must approve (keep in mind only moderators can invite)
...
speed up specs a touch
allow invite controller to accept an email in absence of user (cleans up API)
2013-07-11 11:22:00 +10:00
b94d26d798
update back-end specs
2013-07-10 22:59:54 +02:00
8814f9ed05
Fix a case when a staff user views a topic with a deleted post by a nuked user; might be a temporary solution until we decide what to do with nuked records
2013-07-10 16:52:47 -04:00
cc47616cdb
Merge pull request #1157 from abbat/email-custom-headers
...
Add custom headers for email messages
2013-07-10 07:12:51 -07:00
7977deb3bf
Don't allow editing of title and category of an archived topic
2013-07-09 16:54:46 -04:00
b7327942af
Add `deleted_by` to `Trashable` tables
2013-07-09 15:46:36 -04:00
baf698f3c9
Merge pull request #1127 from rylnd/refactor_tmp_directory
...
Refactor #tmp_directory into helper module
2013-07-09 12:17:42 -07:00
ba7a4e9845
Merge pull request #1165 from novemberkilo/feature/log-trust-level-boosts
...
Log all changes of user trust level by an admin
2013-07-09 12:16:08 -07:00
591a5c0e13
Refactor temp directory methods into helper module
2013-07-09 13:59:31 -05:00
3c38062802
Check for updates: edge cases when the message on the dashboard doesn't make sense.
2013-07-09 14:01:08 -04:00
b0dbb0ea13
And add tests for empty string & null
2013-07-09 20:19:10 +04:00
d98f288aa4
FIX: Recovering a deleted post was not updating a topic's statistics
2013-07-09 12:15:55 -04:00
5cda0e556c
Merge pull request #1111 from jamesaanderson/flash-video-onebox
...
Add flash video onebox support
2013-07-09 06:55:56 -07:00
806bd98f99
Update category's topic_count immediately when trashing or recovering a topic; this ensures that a category can be deleted without waiting for the category_stats job to run.
2013-07-08 15:23:20 -04:00
cfc4dda9ff
FIX: OpenGraph should feature the desired post, if found in the set.
2013-07-08 12:21:39 -04:00
013ad0fdda
Added `In-Reply-To` and `References` email headers. Additionally removed username from
...
email replies and new posts to keep the subjects collapsable.
2013-07-08 11:48:40 -04:00
d51a3cf50f
Add flash video onebox as disabled setting by default
2013-07-08 06:37:44 -07:00
45d85f4054
If the change doesn't go through, don't log anything
2013-07-08 12:51:35 +02:00
d77ce23de2
Log all changes of user trust level by an admin
2013-07-08 11:53:22 +02:00
f1a31cd9e6
Merge pull request #1163 from ZogStriP/refactor-cooked-post-processor
...
refactored CookedPostProcessor
2013-07-07 22:01:48 -07:00
f6a8f6cfe5
don't notify on moderator actions, they just cause noise,
...
also filter out pms properly while at it
2013-07-08 12:44:55 +10:00
91238af6f1
correct failing specs
2013-07-08 12:25:38 +10:00
ac7253a938
refactor CookedPostProcessor & specs
2013-07-08 01:39:08 +02:00
4e04c4dddd
Add custom headers for email messages
...
See http://meta.discourse.org/t/custom-headers-in-emails-site-settings/7480
2013-07-07 04:37:44 +04:00
6251935b1e
removed auto_link_images_wider_than setting
2013-07-06 22:19:16 +02:00
6cd6484b5e
New mode for Wordpress: Filter ONLY posts liked by moderators
2013-07-05 16:07:24 -04:00
58d082d01e
OOPS: Left in some debugging info in specs. Removed
2013-07-05 15:06:21 -04:00
4c90b16681
FIX: Next pages were missing on `<noscript>` content. Also fixed some long standing bugs.
2013-07-05 14:45:54 -04:00
84ce04dfa5
Use POST for send_activation_email action
2013-07-05 12:26:46 -04:00
50767be722
user where as opposed to find to compensate for deleted topics
2013-07-05 15:21:04 +10:00
9afea0ed07
spec for change
2013-07-05 14:23:29 +10:00
07ebd20776
Merge pull request #1143 from ahx/fix-cas-email-name-and-improve-authentication-specs
...
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes.
2013-07-04 14:48:52 -07:00
ea11286ab6
Merge pull request #1131 from novemberkilo/feature/temporary-boost-trust-levels
...
Feature: Admin can modify user trust levels
2013-07-04 06:57:59 -07:00
661f2057f7
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes.
...
* Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay!
* Return "casuser", instead of "casuser@" when no cas_domainname is configured.
* If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname.
Now it just returns the username instead of adding an "@" if cas_domainname is not configured.
This especially makes sense on CAS setups where the username equals the users email adress.
The old behaviour, if cas_domainname is configured, was not changed.
* Fetch the email from CAS attributes if provided
If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that.
If not, behave as before (username or username@cas_domainname).
* Fetch the (full) name from CAS attributes if provided
If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 12:01:39 +02:00
b662cb6c02
If a user read to the end of an auto closing topic, when it is closes just pretend they read the close message.
2013-07-04 11:47:12 +10:00
7504da13e3
FIX: Whitespec in specs changed. We should really figure out a better way of ensuring correctness here.
2013-07-03 19:24:49 -04:00
f08e9d8822
Merge pull request #1142 from ZogStriP/fix-can-no-longer-paste-image-in-chrome-post-editor
...
FIX: can no longer paste image in Chrome post editor
2013-07-03 16:08:51 -07:00
5a56af03bc
FIX: can no longer paste image in Chrome post editor
2013-07-04 00:39:23 +02:00
41729aab14
Stub site setting methods instead of setting them
2013-07-03 16:54:41 -04:00
2c8ed8414c
If an auto-closing topic is manually closed, remove the auto-close countdown
2013-07-03 16:54:41 -04:00
3da37506da
Back end - temporary boosting of trust levels
2013-07-03 10:30:40 +02:00
4d4a5735d2
logic to bypass trust level filter for high scoring posts
2013-07-03 12:37:17 +10:00
05fe33111e
FIX: Moving a post should also update its TopicLink records
2013-07-02 16:42:25 -04:00
7f70bc3bbd
Add `discourse.forum` to all List-Ids
2013-07-02 15:21:34 -04:00
075ed1ab53
Refactor user blocking code; hide the Block button in admin
2013-07-02 14:42:53 -04:00
fab1be7c8e
Adds a List-Id header to outgoing mail
2013-07-02 14:13:46 -04:00
5770879472
Refactor: Move Topic Details into better objects, identity map, tests, query string filters
2013-07-02 10:36:46 -04:00
f6b850e7a4
allow skipping the validations on creation if its an api call AND skip_validations is specified
...
this allows wordpress plugin to post very very short titles or titles that would otherwise be disallowed
2013-07-02 12:23:19 +10:00
46c6949b6e
Merge pull request #1123 from stephankaag/rails4-new
...
Refactor routes in order to be compatible with Rails 4
2013-07-01 16:07:22 -07:00
e39cc464b1
Refactor routes in order to be compatible with Rails 4
2013-07-01 20:00:06 +02:00
b92e912ac9
add min replies, min score and min trust level params for wordpress
2013-07-01 21:29:45 +10:00
023d18cab2
FIX: Admins should be able to post short titles. This is especially important for when syndicating
...
a blog via the wordpress plugin into Discourse.
2013-06-29 17:57:10 -04:00
e076661759
Merge pull request #1110 from ZogStriP/fix-updating-min-topic-title-length-needs-a-restart
...
FIX: updating needs a restart
2013-06-29 14:10:49 -07:00
e77c396a19
Merge pull request #1107 from ZogStriP/patch-1
...
Removed a debug leftover
2013-06-29 04:12:52 -07:00
121d08e25f
FIX: updating needs a restart
2013-06-29 03:49:54 +02:00
9656759ecf
fix deep link to post in search
2013-06-29 03:22:17 +02:00
2ccf339437
Removed a debugging "put"
2013-06-28 23:16:13 +02:00
a352b70bfc
Permit changing my own username's case without an error saying it is already taken
2013-06-28 16:21:46 -04:00
b37b6ce664
Minor spec clean-up
2013-06-28 14:43:35 -04:00
2deaf8ef98
Custom Wordpress Serializer and Path, with Specs
2013-06-28 13:56:13 -04:00
6106057328
FIX: Can view best filter while logged in
2013-06-28 12:20:06 -04:00
1ec12fc808
this spec is just refusing to work on jenkins
2013-06-28 16:07:36 +10:00
ca6325a3fe
a pile of complicated and hard to follow specs were replaced by something that makes sense to old people like myself
2013-06-28 15:38:47 +10:00
3c67cf8acd
remove timecop, specs were failing and we can avoid it here anyway
2013-06-28 15:14:44 +10:00
4512956c68
don't run the wrong sentinel on message, message is validated in the post, in effect some flags were being rejected incorrectly
2013-06-28 12:14:40 +10:00
8e50b49cf1
Try to fix specs that are failing in jenkins
2013-06-27 17:23:06 -04:00
1355c1e3b0
Fix links to uncategorized when SiteSetting.uncategorized_name is set
2013-06-27 16:16:06 -04:00
5d6ad8f39c
Show a useful message when a banned user tries to log in
2013-06-27 15:14:42 -04:00
6145e99baa
navigate to message fixed, changed to button
...
added spec to catch this regression in future
2013-06-27 16:59:07 +10:00
63d967e634
Merge pull request #1097 from ZogStriP/blob-blob-blob
...
provide a way to give a default filename to pasted images...
2013-06-26 16:24:51 -07:00
278ae7e413
Fix exporter spec brokenness in random mode
2013-06-26 17:02:24 -04:00
72745d257d
provide a way to give a default filename to pasted images in the lightbox overlay
2013-06-26 21:54:08 +02:00
03afe9280d
Fix failing import spec with seed 30239
2013-06-26 11:42:52 -04:00
38abac8877
no idea why, but jenkins does not like this pending spec
2013-06-26 16:38:52 +10:00
bb0c3302f3
oddly enough having this code in a pending block causes an error in jenkins
2013-06-26 16:28:07 +10:00
48d7a33157
Flag UI now displays deleted status for post/topic correctly on old flags
...
Commented out a spec that was failing in order random, with a TODO
2013-06-26 16:18:50 +10:00
148d2f2cd4
bug fixes
2013-06-26 16:00:17 +10:00
65dc04c00e
simplify flag reporting and correct it so it properly displays old flags
2013-06-26 15:57:55 +10:00
d3eae56e71
soften the lightbox overlay
2013-06-26 02:44:20 +02:00
92562c2090
Merge pull request #1057 from house9/list-controller-1
...
refactor list_controller
2013-06-25 17:36:56 -07:00
3af12ba7d3
Merge pull request #1088 from ComputerDruid/fix-ipv6
...
Fix ipv6 addresses in the database
2013-06-25 17:25:48 -07:00
9f6b7889a8
views: convert 'ip' (bigint) -> 'ip_address' (inet)
...
This fixes all known issues when connecting to discourse over IPv6.
This table has no primary key, so the migration is done with update_all,
for each ip address in the views table. Since this table can potentially
grow quite large, this process might take a long time. I don't know any
way around this, though.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the View model class, which should keep the
migration from failing if that class is modified in the future.
2013-06-25 19:47:25 -04:00
2e478d8537
TopicLinkClick: convert 'ip' (bigint) -> 'ip_address' (inet)
...
When accessed over IPv6, the ip address of the user is a 128-bit number,
too big for PostgreSQL's bigint data type. Since PostgresSQL has the
built-in inet type, which handles both IPv4 and IPv6 addresses, we
should use that instead. Where this is done elsewhere in the codebase,
the column is called ip_address, so we should follow that convention as
well.
This migration uses a SQL command to populate the new field from the old
one, so as not to rely on the TopicLinkClick model class, which should
keep the migration from failing if that class is modified in the future.
2013-06-25 19:41:19 -04:00
b2d300fe0b
Add ability to give users a title. Show them under usernames beside posts. Needs love from a designer.
2013-06-25 18:39:20 -04:00
a86b35c873
Remove the access_password site setting
2013-06-25 15:05:25 -04:00
9a19c0d9c4
Fix for multiple paragraph emails with text em-dashes in them (--).
2013-06-25 14:06:05 -04:00
2e12eb2b62
refactor list_controller
...
- minor refactoring of actions 'category' and 'category_feed'
- fix defect in 'category' where check was for literal
string 'uncategorized' instead of SiteSetting.uncategorized_name
- major refactoring on defined topic actions
2013-06-25 08:29:00 -07:00
674e26e6c3
Updated tests to decrease string repetition
...
Removed an unused variable
Some minor style changes
2013-06-25 22:15:41 +08:00
7d1e8239e0
Merge pull request #1070 from house9/top-menu
...
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-25 02:51:57 -07:00
52b8e6014b
forgot to commit the test
2013-06-24 22:56:03 +02:00
06be760257
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-24 10:04:18 -07:00
ea932b74e7
values is a much more consistent name than all_values ... we use {}.values not {}.all_values
...
also fixes random ordering of tests failure in site settings
2013-06-23 15:07:49 +10:00
22d6f6784c
Merge pull request #1075 from ZogStriP/fix-lightboxing-when-using-s3
...
FIX: lightbox wasn't working when using s3 upload
2013-06-23 22:11:45 -07:00
7c726bd235
Merge pull request #1079 from ZogStriP/do-not-lightbox-oneboxed-images
...
do not lightbox oneboxed images
2013-06-23 22:07:25 -07:00
361062d53e
do not lightbox oneboxed images
2013-06-24 02:10:21 +02:00
0b94c3c456
fix all sorts of issues with random spec order
...
SiteSetting no longer persisted across tests
2013-06-23 13:35:25 +10:00
251aca3b00
lets not fail in order random
2013-06-23 13:35:25 +10:00
08aa23f0ca
FIX: lightbox wasn't working when using s3 upload
2013-06-22 13:38:42 +02:00
bb908d5913
Email parsing uses Traditional Markdown Linebreaks by default. Added JS tests for line breaks.
2013-06-21 11:37:26 -04:00
bfdbf373f3
Don't show invisible topics in uncategorized on categories page
2013-06-21 11:36:00 -04:00
e53aa45f54
I think this is more correct, admins/mods should always be able to invite
2013-06-21 16:35:27 +10:00
f39f44ddbf
Categories page should not show invisible topics
2013-06-20 16:07:53 -04:00
0e984762d5
Oops, forgot to check in the email fixtures :P
2013-06-20 13:07:42 -04:00
0d10b5c9c4
More email receiving logic
2013-06-20 12:38:37 -04:00
9f3d5b9f1e
Merge pull request #1044 from ZogStriP/clean-orphan-uploaded-files
...
added a rake task to clean orphan uploaded files
2013-06-20 07:53:50 -07:00
8e6a903f9b
Merge pull request #1046 from house9/admin-user-index-2
...
extract Admin::UsersController#index to its own query class
2013-06-20 07:52:22 -07:00
70683c1f09
Merge pull request #1034 from chrishunt/rebake-oneboxes
...
Optionally rebake oneboxes with posts:rebake task
2013-06-20 01:18:57 -07:00
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
8c4aac7f94
Migrate all jasmine specs to Qunit. Removed Jasmine.
2013-06-19 18:18:35 -04:00
e0ff74ead0
extract Admin::UsersController#index to its own query class
...
- move query to its own class
- use postgres ILIKE case insensitive
- removed duplicated list of trust levels
2013-06-19 13:48:45 -07:00
e263bb3c0a
Anons should be able to see post history
2013-06-19 16:43:16 -04:00
4a17d6dca6
added a rake task to clean orphan uploaded files
2013-06-19 21:51:41 +02:00
5ef6714d48
New site setting: `minimum_topics_similar`, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
82d1465d18
Ugly Hack: Remove improperly parsed headers from Mail::Message
2013-06-19 12:14:01 -04:00
6491bda4ab
fix the positioning for replies
...
fix stubs
2013-06-19 18:23:01 +10:00
ef76e18215
Optionally invalidate onebox in PostAnalyzer#cook
2013-06-19 00:19:42 -07:00
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
d5191adfc9
Remove useless jasmine spec
2013-06-18 18:08:37 -04:00
62e21b8175
Markdown moved to Qunit
2013-06-18 18:05:08 -04:00
f0ebca51cc
Moved Formatter, KeyValueStore and Onebox jasmine tests to QUnit.
2013-06-18 17:23:00 -04:00
8af9952b25
Change all headers to X-Discourse-* instead of Discourse-*
2013-06-18 15:54:02 -04:00
60fce196c7
More Qunit tests including a CLI runner
2013-06-18 13:44:20 -04:00
eea00afb80
tos and privacy urls redirect based on site settings
2013-06-18 10:52:04 -04:00
6989851cd4
Merge pull request #1038 from ZogStriP/keep-uploads-reverse-index-up-to-date
...
Keep uploads reverse index up to date
2013-06-18 00:43:31 -07:00
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
8acdc18bc8
First stab at polling support for POP3S / reply by email
2013-06-17 16:49:02 -04:00
7bdc616040
keep uploads reverse index up to date
2013-06-17 22:46:48 +02:00
ae3543872c
renamed the `sha` column to the proper `sha1`
2013-06-17 22:16:14 +02:00
281a08a99f
Allow people to capitalize a word when ninja-editing a post
2013-06-17 15:57:13 -04:00
3c7eb3a4e8
FIX: null dates crashed the client app. `last_posted_at` was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
876a570e3a
Fix to prevent check for all upper case for non-ascii messages
2013-06-17 12:22:50 -04:00
797b99db7c
Moved a bunch of tests to QUnit. Added basic `Discourse.Site` support to test suite.
2013-06-17 11:38:30 -04:00
dd5cd1df4f
Merge pull request #1037 from ZogStriP/imagineering
...
Imagineering
2013-06-16 22:01:10 -07:00
0052e78bfe
render error when people attempt to save an invalid group name
...
hide controls when we showing an automatic group
2013-06-17 13:43:06 +10:00
af45b5a11e
proper column naming
...
silly schemaless database habits are hard to kill
2013-06-17 04:02:17 +02:00
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
5de03814fb
created `optimized_image` model
2013-06-17 02:49:34 +02:00
2c3f757951
moved `has_been_uploaded` and `uploaded_regex` to the `Upload` model
2013-06-17 02:49:34 +02:00
c11f4456ae
cleaned up CookedPostProcessor and improved specs
2013-06-17 02:49:34 +02:00
8a98310cf9
make sure we only do the work once
2013-06-17 02:49:34 +02:00
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
e603c85fa0
Merge pull request #1032 from Krugloff/patch-1
...
It maybe worth load pluralizations rules before compile?
2013-06-16 16:58:16 -07:00
4650ce3556
Merge pull request #1026 from chrishunt/link-twitter-handles
...
Link Twitter handles and hashtags in Twitter onebox
2013-06-16 16:50:57 -07:00
b545a49d32
Merge pull request #1025 from ZogStriP/reverse-index-take-2
...
Reverse index take 2
2013-06-16 16:49:57 -07:00
c964c5c0d5
Add test for load plurals before precompile
2013-06-16 02:38:28 +04:00
f62c421c91
Render category descriptions differently on the categories page
2013-06-14 11:18:44 -04:00
4491b1f06f
Link hashtags in Twitter onebox
2013-06-13 21:09:37 -07:00
b84ee29c43
Link Twitter handles in Twitter onebox
2013-06-13 21:00:47 -07:00
037f62928b
add proper post_uploads reverse index
2013-06-13 23:44:24 +02:00
bd1b4d3130
Include a custom reply address when reply by email is enabled.
2013-06-13 17:00:00 -04:00
4db8204a15
Remove topic links when a post is deleted
2013-06-13 13:41:54 -04:00
49c09898e2
The EmailBuilder now creates the Reply by Email Key if necessary.
2013-06-13 12:40:06 -04:00
cf9b6beb13
Add specs for all user notifications, including whether they support
...
reply by email.
2013-06-13 12:40:01 -04:00
e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
66f5a3f6f6
FIX: Emoji sizes in emails should be done by the EmailStyler
2013-06-13 12:15:05 -04:00
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
80f1e9a0d9
Merge pull request #1021 from ZogStriP/less-brittle-specs
...
less brittle specs to os-specific line endings
2013-06-13 02:27:07 -07:00
2e2553c18c
less brittle specs to os-specific line endings
2013-06-13 11:09:11 +02:00
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
384d743e7b
refactoring of site settings
2013-06-13 12:41:27 +10:00
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
246148d4ff
Make topics invisible when first post is automatically hidden because of spam flags
2013-06-12 16:02:11 -04:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
54d8c963d0
fix tests and allow SE onebox to onebox Meta cause I need that for an post I am writing
2013-06-12 12:23:24 +10:00
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
eb91a0c9df
Merge pull request #1012 from ZogStriP/extract-imgur-support-to-a-gem
...
Extract imgur support to a gem
2013-06-11 16:59:53 -07:00
a362d62b42
Do not return mail password in EmailController
2013-06-11 16:00:13 -07:00
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
82b5f57e40
Make it possible to set a site setting to empty string
2013-06-11 14:31:38 -04:00
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
c2cfbce9ce
automatically updating times for posts on topic
...
moved moment.js into localization file (we need to localize it)
added helpers for date formatting use, moment().shortDate() moment().longDate() moment().shortDateNoYear()
2013-06-11 17:25:50 +10:00
fa8a84f20c
removed sugar.js, port functionality to moment and underscore.js
...
bring in latest ace from local so we don't mess up with https
2013-06-11 15:27:26 +10:00
ab5507ac06
Merge pull request #1002 from chrishunt/add-stack-exchange-onebox
...
Add Stack Exchange onebox
2013-06-10 12:38:03 -07:00
93bbe190c0
Moved Email components into a module
2013-06-10 15:34:10 -04:00
9b1d0baf45
Send a message to moderators when a newuser_spam_host_threshold is exceeded. Send it no more than once per day per user.
2013-06-10 13:17:32 -04:00
1fb0b424ed
Add Stack Exchange onebox
2013-06-10 09:27:13 -07:00
68d849419b
FIX: Don't email '(user deleted)' posts. Seriously.
2013-06-10 12:02:04 -04:00
ad6705cca7
Update Ember to latest master (RC5)
2013-06-10 10:14:42 -04:00
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
15efecd536
Remove html rendering test for commit onebox
...
This is a very brittle test. We want to be able to change our markup
without breaking tests.
2013-06-09 21:32:13 -07:00
cbec9efc16
Merge branch 'master' of github.com:discourse/discourse
2013-06-10 09:48:51 +10:00
d741798d9c
Add onebox for GitHub pull requests
2013-06-08 11:01:06 -07:00
9aa2cc2262
extra spec
2013-06-08 23:56:40 +10:00
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
b2a6755a48
Merge pull request #984 from Supermathie/moreentropy
...
More entropy for foreign titles
2013-06-07 14:23:26 -07:00
bb77d2c38b
More entropy for foreign titles
...
* Treat strings with non-ASCII characters as having more entropy
2013-06-07 14:47:07 -04:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
1b5ec42173
FIX: Regression where a topic rollback would not properly report errors to the client.
2013-06-07 12:36:37 -04:00
3ae72259a6
Merge pull request #979 from iancmyers/strong-parameters
...
All parameters for #create in PostsController pass through strong_parameters
2013-06-07 09:17:29 -07:00
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
5fa20ce357
more progress towards full migration to moment.js
2013-06-07 18:27:42 +10:00
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
93fc0e74bc
Test correct login behavior when pending approval
2013-06-06 18:36:16 -07:00
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
e7b38fb188
Move duplicated request to helper method
2013-06-06 18:36:16 -07:00
4a182f8bba
Fix spec doc; sends welcome email for active users
2013-06-06 18:36:16 -07:00
a5a229598d
missed a spot
2013-06-07 09:17:34 +10:00
564d242832
Notify moderators when someone is automatically blocked because of spam flags
2013-06-06 18:49:19 -04:00
11afa0c11b
work in progress migrate to moment
2013-06-07 08:49:22 +10:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
b062b4a98e
Unapproved users should not receive digest emails. Fixes #974
2013-06-06 11:45:18 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
a3d62fdf69
Temporarily roll back ember rc5. We identified some things we need to fix.
2013-06-06 01:25:43 -04:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
729e4080a6
Merge pull request #958 from ZogStriP/fix-have-onebox-ignore-internal-links
...
FIX: Have onebox ignore internal links
2013-06-05 12:09:53 -07:00
112d57e899
Merge pull request #960 from iancmyers/strong-parameters
...
Began implementing strong_parameters
2013-06-05 12:03:17 -07:00
01855b70b4
FIX: Have onebox ignore internal links
2013-06-05 20:53:07 +02:00
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
a0bd51862e
Upgrade Ember to RC5. Disabled a deprecation warning that I believe is in error.
2013-06-05 12:07:18 -04:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
74502172f3
speed up test
2013-06-05 12:48:34 +10:00
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
56ee7cdc1f
Merge pull request #956 from ZogStriP/fix-image-upload-to-s3
...
fix image uploads on s3/imgur
2013-06-04 16:34:42 -07:00
5f85aaee1d
correct message bus regression
...
implement automatically updating dates in list
2013-06-05 09:32:44 +10:00
978785720a
Redirect to root after login if no path provided
...
If we do not do this, then people that login from /login will just be
redirected back to the login page. We'd rather have them see the root
path.
2013-06-04 16:10:10 -07:00
92a4828f72
Redirect all controllers to login if required
...
We want to skip the filter for sessions controller so that we can login
and we want to skip the filter for static pages because those should be
visible to visitors.
2013-06-04 16:10:10 -07:00
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
ef976ba891
fix pending tests
2013-06-03 17:07:44 +10:00
8b69ee26ff
forking in passenger was bust, message bus subscriptions would stop working after fork
2013-06-03 16:50:30 +10:00
da22c0f359
omit single quotes from slug
2013-06-03 09:08:34 +10:00
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
Michael Campagnaro
Sam
Régis Hanol
Neil Lalonde
Robin Ward
Stephan Kaag
Michael Campagnaro
Tom Russell
Navin
Ryland Herrick and Vipul A M
Anton Batenev
James A. Anderson & Jalil Mohammed
Andreas Haller
Jeff Atwood
Dan Johnson
Jesse House
Martin Feckie
Chris Hunt
Krugloff
Chris Hunt
Jeff Atwood
Michael Brown
Ian Christian Myers
Juan de Dios Herrero