793f933b6b
FIX: Move check to right serializer.
2017-09-12 17:52:13 +08:00
d3a409456f
PERF: Bypass AR and execute SQL directly.
2017-09-12 17:52:13 +08:00
c06c88b479
cleaner title attribute for select-box
2017-09-12 01:36:58 +02:00
18114c7bdb
Revert "FIX: pinned-button sometimes not shown when unpinned is null"
...
This reverts commit 01f0b56331
2017-09-12 01:03:16 +02:00
b875d17e1f
fix linter error
2017-09-11 23:51:42 +02:00
2c284874b4
FIX: icon showing as null
2017-09-11 22:47:47 +02:00
01f0b56331
FIX: pinned-button sometimes not shown when unpinned is null
2017-09-11 20:04:07 +02:00
90dd1609eb
FIX: memoization in PostAnalyzer.raw_mentions ( #5172 )
...
Due to a missing 's' when assigning the computed value to @raw_mentions, the raw_mentions function in PostAnalyzer would never retrieve a memoized value.
2017-09-11 20:01:24 +02:00
d7d9923b8e
FIX: display email validation error messages
2017-09-11 13:22:14 -04:00
e924920bec
uses select-box for pinned-button
...
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
f1639bf4f5
make eslint happy
2017-09-11 16:49:09 +02:00
5a51953c8e
UX: '.visited' wasn't applied in categories view and suggested topics
2017-09-11 16:42:51 +02:00
81e576ae37
FIX: Missing color on queued posts dropdown
2017-09-11 09:47:16 -04:00
2708243584
FIX: makes sure the select-box doesn’t go over header
2017-09-11 11:23:46 +02:00
b2dcb51e48
adds missing spacing around links in reason text
2017-09-11 10:42:53 +02:00
7f9220a2cd
minor select-box fixes
...
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
cf624bead0
FIX: cross browser issues on safari and edge
2017-09-10 22:25:31 +02:00
6d6fe7b3a9
adds more specificity to .dropdown-select-box
2017-09-10 20:57:34 +02:00
238557883f
FIX: queued posts had a red background
2017-09-10 14:26:55 -04:00
87b4615eee
FIX: Bookmark icon was not coloured on mobile
2017-09-10 14:14:52 -04:00
8e7e43a2d0
FIX: Duplicate class name
2017-09-10 14:09:29 -04:00
4b558638c8
FEATURE: improves keyboard handling of select-box
...
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
a11eec47bb
FIX: display localised title when using notifications-button
2017-09-10 11:38:52 +02:00
bba26e48a0
FIX: positioning issues with notifications-button
2017-09-10 11:36:57 +02:00
1f8695b16a
fix broken build
2017-09-09 20:58:37 +02:00
950b9e9eaf
FIX: keeps as much as possible the same api for select-box components
2017-09-09 20:29:07 +02:00
e6d3bbfa1d
FIX: Categories admin menu was missing
2017-09-09 09:21:43 -04:00
8c3f7d9bbc
FIX: select-box width was incorrect on mobile
2017-09-09 02:41:31 +02:00
753bf72921
FIX: adds correct spacing between footer buttons
2017-09-09 02:28:51 +02:00
253672f3fa
makes notification-options design more compliant with existing design
2017-09-09 01:53:10 +02:00
ab700d86ba
lighter icon color for categories-admin-actions
2017-09-09 01:52:36 +02:00
a9aa11d7c4
use d-icon names
2017-09-09 01:48:03 +02:00
5b9819f4ed
minor fixes to select-box
2017-09-09 00:49:33 +02:00
1def49cf6c
SECURITY: Only publish PM reply messagebus notifications to allowed users
2017-09-08 14:12:15 -07:00
1d52231f42
FIX: css regression on category-dropdown-button
2017-09-08 21:28:28 +02:00
cf6fb7622e
Replaces all notification-options like dropdowns with select-box
2017-09-08 20:47:39 +02:00
f13776e550
UX: Move `.visited` to entire row, not just the link to a topic
2017-09-08 13:54:41 -04:00
b7ac33464f
Reduce number of Redis calls.
2017-09-08 20:12:53 +08:00
661ae38a03
FIX: makes sure we only autocomplete valid emoji tones
2017-09-08 09:42:13 +02:00
6d35b62238
add image type attribute to icon link tag
2017-09-08 12:48:30 +05:30
5d4221fbe1
PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
164a388dcc
Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
...
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
f6fb94d31f
UX: Flags lost their red color on dropdown
2017-09-07 16:22:31 -04:00
e183600563
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-07 21:02:41 +01:00
a9737e2813
Merge pull request #5133 from guoyunhe/patch-1
...
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
d2d1c29f48
FIX: topic-notifications was taking too much space on mobile
2017-09-07 20:13:32 +02:00
3c0a9d4d19
FIX: topic-notifications taking too much space in timeline
2017-09-07 19:55:56 +02:00
5054065e81
FIX: broken spec
2017-09-07 19:18:27 +02:00
afc075d93b
UX: Convert bookmark icon from CSS to a proper icon using our helper
2017-09-07 11:41:19 -04:00
0ba789de17
Allow for customization of header dropdown icons
2017-09-07 11:18:59 -04:00
8e88bf019f
Add `span` to various labels so they can be targetted
2017-09-07 11:10:11 -04:00
70d0e175a2
FIX: default select-box-row should be aligned vertically
2017-09-07 17:03:48 +02:00
0374dc1a0e
FIX: keys were incorrectly set to category
2017-09-07 16:56:38 +02:00
633d2fde45
removes select-box minWidth property
...
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
ca58a8228c
minor css fixes on select-box
2017-09-07 16:56:00 +02:00
d04aa5c7af
FIX: component height computation was wrong
2017-09-07 16:55:36 +02:00
0ce9098339
add admin-user-details plugin outlet ( #5141 )
2017-09-07 16:17:27 +02:00
7d350d0d75
Revert plugin js changes ( #5139 )
...
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134 )"
This reverts commit b840170f8d#5103 )"
This reverts commit a14ab48829
2017-09-07 15:15:29 +02:00
dd27c0c80e
FIX: supports emojis in pinned topic excerpt
2017-09-07 11:06:04 +02:00
4d840d10db
PERF: Reduce number of Redis hits per requests.
2017-09-07 13:34:27 +08:00
a1957b7723
FIX: Stop moving notifications on large screens
2017-09-06 17:35:35 -04:00
8a935a4b5f
FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days
2017-09-06 22:35:08 +02:00
0fca5ed533
FIX: stricter check on presence of notification_level_change
...
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
825452df76
Refactor header CSS for composability
2017-09-06 11:34:10 -04:00
777f024b8c
Clean up weird indentation
2017-09-06 11:34:10 -04:00
ccf5005feb
FEATURE: uses select-box for topic-notifications-button component
...
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
b840170f8d
Add disabled_plugins to preloadstore for login_required anonymous users ( #5134 )
2017-09-06 12:18:58 +02:00
a14ab48829
Do not load javascripts for disabled plugins ( #5103 )
...
* Do not load javascript for disabled plugins
* Appease rubocop
2017-09-06 10:06:47 +02:00
7d29ccf207
bbcode find close tag loop end condition
...
Only break loop when close tag has been found. Otherwise, keep searching until the end of string.
2017-09-06 09:13:57 +03:00
8463b676df
Revert "Activate mini-profiler when in profiling env."
...
This reverts commit d61109388c
2017-09-06 11:26:03 +08:00
d61109388c
Activate mini-profiler when in profiling env.
2017-09-06 11:19:20 +08:00
672b7cb9a5
Require missing dependency.
2017-09-05 09:39:56 +08:00
7786c6c6f2
Remove duplicated scope.
2017-09-05 09:15:06 +08:00
51ffbf1c1f
FIX: Remove duplicate event typo
2017-09-04 15:39:58 -04:00
fd91e53e68
Cleaned, de-duplicated/DRYed and organized discourse.css (common, mobile and desktop)
2017-09-04 10:56:28 -07:00
db929e58fc
FIX: Don't allow staff to approve users with unverified emails
2017-09-04 12:55:39 -04:00
be1cce503c
FIX: Don't bind events in `defaultState`
2017-09-04 11:48:36 -04:00
afe6f46b03
merges after_save
2017-09-04 13:40:11 +02:00
caedefd675
FIX: correctly resets user_themes template
...
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
3b7128102c
FIX: disable follow in topic summary links
...
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
5c1143cd55
Add missing test case for `PostController#timings`.
2017-09-04 16:36:02 +08:00
ebbdd4fe0f
FIX: error when rebaking posts
2017-09-02 22:22:29 +05:30
dfe347fb1d
FIX: Wizard tests don't need `Discourse` defined
2017-09-01 12:26:42 -04:00
c6ff387ce9
Use more semantic names for various tracking icons
...
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
46ebd0ee40
correct spec and allow for zero allowed iframes
2017-09-01 12:08:55 -04:00
cb56dcdf2e
FIX: Use proper `iconNode` when compiling virtual dom templates
2017-09-01 11:20:33 -04:00
0fb7831749
FEATURE: Add placeholders to broken and large image files ( #5113 )
2017-09-01 10:26:13 -04:00
e283e6aea0
FEATURE: allowed_iframes site setting for allowing iframes
...
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
b3b6eeff97
Ensure css applies to .user-main > .about icons regardless of tag
2017-09-01 06:32:27 -07:00
611d62e4a5
Cleanup, deduplicate, debug user css, separated user-info component css
2017-09-01 06:32:27 -07:00
dffb1fc4ee
FEATURE: Use Glimmer compiler for widget templates
...
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.
Example:
```javascript
createWidget('post-link-arrow', {
template: hbs`
{{#if attrs.above}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
{{fa-icon "arrow-up"}}
</a>
{{else}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
{{fa-icon "arrow-down"}}
</a>
{{/if}}
`,
click() {
DiscourseURL.routeTo(this.attrs.shareUrl);
}
});
```
2017-09-01 09:28:16 -04:00
66f2925348
SECURITY: do not include links from whispers in topic summary map
...
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
ef0f346eec
Add custom style for header buttons
2017-08-31 12:10:54 -04:00
56468582ee
FIX: visual regressions on title-wrapper
2017-08-31 15:08:09 +02:00
0957ac9ee2
FIX: minor css tweaks to title-wrapper
2017-08-31 11:16:08 +02:00
84e992363c
FIX: use maximum z-index for select-box when expanded
2017-08-31 00:55:05 +02:00
75b2aa2edd
Better support for inline modals
2017-08-30 17:52:49 -04:00
a48abc6556
Tweaks for better modal distinction between fixed/inline
2017-08-30 17:38:49 -04:00
6361618188
`fixed-modal` is a better name
2017-08-30 15:52:29 -04:00
3d95bac3fb
Migrate away from `#discourse-modal` to `.d-modal`
2017-08-30 15:29:51 -04:00
Guo Xiang Tan
Joffrey JAFFEUX
Darren Lee
Neil Lalonde
Régis Hanol
Robin Ward
David Taylor
Arpit Jalan
Leo McArdle
Guo Yunhe
minusfive
Sam Saffron
Vinoth Kannan