b651605d6e
FIX: tags added while editing a pending approval topic do not show up ( #6959 )
2019-02-14 15:42:40 +11:00
37666c3d18
UX: Signup form labels were too constrained, minor cleanup
2019-02-13 21:07:34 -05:00
484bd82278
FIX: Add onceoff job to remove double quotes from s3 etags
2019-02-14 05:19:41 +05:30
0476169692
make prettier happy
2019-02-13 22:16:38 +01:00
94fe0af900
FIX: upload emojis sequentially to prevent rate limit
2019-02-13 22:07:37 +01:00
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
560cc4e73e
FIX: sets categoryId but do not scope when replying as new topic ( #7002 )
2019-02-13 15:19:58 +01:00
fe4254b8f3
FIX: reverse consolidated pageviews stacked chart order ( #7001 )
2019-02-13 12:24:18 +01:00
641b079c78
FIX: add support for missing verbs in user api key
...
Previously "write" scope was missing put and delete verbs which should be
allowed.
Also closes : #6982
2019-02-13 15:49:43 +11:00
1328a127ee
FIX: translate bootbox confirmation dialog ( #6981 )
2019-02-13 14:04:56 +11:00
467cfc9e08
FIX: remove extra periods ( #6998 )
...
Periods are belong in the translation files not in our templates, if we have them in the templates sentences can not be localized properly.
2019-02-13 12:54:34 +11:00
47fe34d794
FEATURE: makes create-account userfields using dropdowns accessible ( #6991 )
2019-02-13 12:52:55 +11:00
3da35081e5
UX: Embedded post collapse button hover color fix
2019-02-12 17:21:33 -05:00
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
86fe423f5e
FIX: Clear the cache after destroying theme_fields
2019-02-12 16:39:40 +00:00
91f0468f4e
FIX: Allow unbaked theme fields to be destroyed
...
The after_commit hook was attempting to re-bake theme_fields after they were destroyed, which caused an exception to be thrown
2019-02-12 16:14:43 +00:00
59640ef373
DEV: Add additional hooks for theme-creator plugin
2019-02-12 14:17:34 +00:00
b8b1759de9
UX: show envelope when tag is only used in PM
...
UX: use regular envelope instead of solid envelope
REFACTOR: %s/enveloppe/envelope/g
2019-02-12 11:34:25 +01:00
90ce448675
PERF: Cache build_not_found_page
2019-02-12 21:20:33 +11:00
d997b01a24
FIX: Scale down swipe in detection to 20px from edge of the screen
...
...and slightly increase velocity required for menu actions
2019-02-11 21:22:50 -08:00
c3cbff55be
FIX: only respond to menu open swipes on Andorid
2019-02-11 20:56:25 -08:00
e0c16d3a8a
minor refactoring to improve code readability
2019-02-11 17:24:02 +05:30
dcd7b92532
FIX: some posters were not getting added to topic_allowed_users when moving posts to a new PM
...
If a user posted twice in a topic then subsequent posters were not getting added as topic_allowed_users.
2019-02-11 17:05:21 +05:30
2c12336c6b
FIX: Display post updated date in non-JS view for crawler
2019-02-11 16:48:22 +05:30
c50db76f5d
FIX: do not treat TIFF, BMP, WEBP as images
...
Treating TIFF and BMP as images cause us to add them to IMG tags, this is very inconsistent across browsers.
You can still upload these files they will simply not be displayed in IMG tags.
2019-02-11 16:28:43 +11:00
c719658f9f
`human?` helper method on a user
...
This is cleaner than hard coding `id > 0` in ruby code.
2019-02-08 13:34:54 -05:00
60fa4fe692
DEV: Make interface route/controller more resilient to missing values
2019-02-08 16:54:15 +00:00
0d1fa54957
compensate for border overhang in category list alignment
2019-02-08 11:49:06 -05:00
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
7c55de6e6f
UX: Alignment fix for names with emoji
2019-02-08 11:07:04 -05:00
747fea8458
DEV: Remove unused import
2019-02-08 16:05:39 +00:00
95eb4c67f2
FIX: Allow reverting theme/text settings from cookie back to default
2019-02-08 15:39:44 +00:00
62043e6904
UX: Hide branch/private repo options in admin theme import modal
2019-02-08 10:17:29 -05:00
7aecd3c2f5
Update app/services/user_silencer.rb
...
Co-Authored-By: eviltrout <robin.ward@gmail.com>
2019-02-08 08:50:50 -05:00
bc3efab816
FIX: When disagreeing with a flag that silenced a user, unsilence them
...
Previously it would unhide their post but leave them silenced.
This fix also cleans up some of the helper classes to make it easier
to pass extra data to the silencing code (for example, a link to the
post that caused the user to be silenced.)
This patch also refactors the auto_silence specs to avoid using
stubs.
2019-02-08 08:50:50 -05:00
44d9bc12c9
FEATURE: color-palettes component ( #6992 )
2019-02-08 14:01:14 +01:00
babd80dfd1
FIX: Allow subexpressions in raw handlebars helpers
...
Helpers registered via `registerUnbound` did not receive parameters if they were subexpressions.
For example: `{{helper1 key=(helper2 value)}}`
2019-02-08 12:58:10 +00:00
95b5c5898e
FIX: Prevent duplicate params for raw template theme handlebars helpers
2019-02-08 12:54:00 +00:00
e3324737ee
FIX: position invite footer button before archive ( #6990 )
2019-02-08 12:21:51 +01:00
e9ec5238fc
DEV: Remove ignored columns
2019-02-08 12:12:38 +01:00
8a152566e3
FIX: improves positioning of footer buttons on mobile ( #6989 )
2019-02-08 12:09:56 +01:00
e54612c914
fix tests ( #6987 )
2019-02-08 11:38:15 +01:00
f849169619
UX: Modifications to admin/customize layout
2019-02-07 22:27:35 -05:00
cbedb6a1ac
FEATURE: Hidden site setting to always include topic excerpt
2019-02-07 22:45:21 +01:00
2a007bafa2
FEAT: Allow image resize by width or height
...
`|150x` resizes to 150px wide + auto-height. `x150` resizes to 150px tall and auto-width.
Resize value can be from 1 to 999 (incl. for percentages).
2019-02-07 15:04:39 -05:00
c0ccf21970
FIX: hides topic-footer-mobile-dropdown when no content ( #6985 )
2019-02-07 18:37:20 +01:00
6c195640b9
FEATURE: adds an API to register topic footer buttons
2019-02-07 14:43:33 +01:00
92c52c0724
FEATURE: displays report description when hovering activity metrics ( #6983 )
2019-02-07 13:33:05 +01:00
1cacfddda4
Prevent usercard badge section from overflowing
2019-02-06 22:39:10 -05:00
984f1d96b0
Add max-width so long badges don't force short badges to truncate
2019-02-06 20:51:54 -05:00
94f8c4ecac
UX: Truncate (don't wrap) badges in user cards if the text is long
2019-02-06 20:18:12 -05:00
fc4c015bee
FEATURE: Shortcut 'g s' goes to first suggested topic
2019-02-07 08:43:07 +11:00
56a9f777cb
UX: Turn off autocomplete on composer title
2019-02-06 14:37:29 -05:00
ab2c2ea605
FIX: validate Invite email against `EmailValidator.email_regex` ( #6975 )
2019-02-06 22:38:06 +05:30
ca03b2ff30
Move SCSS variables for topic post width
...
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
057d1dc077
UX: disable browser's autocomplete in search menu
2019-02-06 17:06:23 +01:00
f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes ( #6973 )
...
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
381793243e
FIX: include error message if the "accept invite" process fails
2019-02-06 19:20:25 +05:30
1a72242746
line-height adjustment
2019-02-05 21:44:06 -05:00
a52b2c9625
UX: Moving the create theme buttons, adding buttons to theme index
2019-02-05 21:40:17 -05:00
e7821a63e7
FIX: Users should able check the emails for self
2019-02-05 23:31:19 +05:30
ba724d7f25
FIX: S3 endpoint broke bucket creation in non-default region
2019-02-05 18:17:02 +01:00
a3b47c1dd1
FEATURE: Allow string theme settings to display with multiple lines
...
To use, add `textarea: true` to the theme settings.yml. For example:
```
my_setting:
default: "some string"
textarea: true
```
2019-02-05 14:14:53 +00:00
7b7bc3db39
FIX: Rescue and display import errors when updating theme via git
2019-02-05 13:49:16 +00:00
31ffcf989c
UX: Use translatedLabel for aria-label in buttons.
2019-02-05 13:11:07 +02:00
2c222e16fe
FEATURE: Returning falsy value from upload handler stops upload. ( #6969 )
2019-02-05 10:54:11 +01:00
b6e3ef4a90
Minor icon color fix
2019-02-04 22:14:18 -05:00
58d5fc3632
UX: Minor button icon color fixes
2019-02-04 12:46:12 -05:00
9de906ddab
FIX: Register pan events for touch only
...
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
2019-02-04 08:27:40 -08:00
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
2a2be093ca
UX: checkboxes were too close to other inputs
2019-02-01 21:07:57 -05:00
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
37c28cf0b7
UX: Header icon color fix
2019-02-01 09:51:12 -05:00
eb617dea4b
DEV: Run prettier on `report.js.es6`
...
The prettier version I was running was different to the CI pipeline
2019-02-01 13:22:31 +00:00
5c9426be48
SECURITY: Escape HTML in dashboard report tables
2019-02-01 13:10:59 +00:00
925606f8b1
FIX: Login button icons should be white
2019-02-01 11:01:59 +00:00
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
bbaa3e9166
Header icon focus color fix
2019-01-31 19:31:09 -05:00
95e16ab0a6
UX: Badge checkmarks should be round
2019-01-31 15:27:46 -05:00
6141290399
FIX: Mobile button colors
2019-01-31 15:13:54 -05:00
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
3500acf2f6
FIX: refresh admin/customize/themes route after import
...
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
2019-01-31 14:29:09 -05:00
0dfcbdeb54
ok/cancel button fix
2019-01-31 14:20:27 -05:00
3d394a6144
prettier
2019-01-31 14:06:32 -05:00
3eb000a968
UX: Overflow hidden was causing some icons to be cropped
2019-01-31 14:03:11 -05:00
94f16ba931
UX: Make button icons use lighter color instead of opacity
2019-01-31 13:59:49 -05:00
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
4786b7ff81
FEATURE: when only option is "existing topic", autofocus input field
2019-01-31 11:23:04 +05:30
f83533e1cb
FIX: use absolute url for `/images/example.png` links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
4763d6c9d7
FEATURE: add the show user action to the user-card-after-username plugin outlet
2019-01-30 14:56:14 -08:00
bb8808985a
REFACTOR: Remove a couple more `self` uses
2019-01-30 14:41:49 -05:00
dca5486b78
REFACTOR: Prefer `this` over `self`
2019-01-30 14:29:45 -05:00
c02e81fe01
FIX: regression with composer warnings
...
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
2019-01-30 11:37:16 -05:00
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
096974d178
FIX: user_id attribute not found in posters array
2019-01-30 15:28:03 +05:30
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
0e5c7f5da7
DEV: Update annotations.
2019-01-30 09:34:51 +08:00
ac004297fa
PERF: Add index on `user_id` to `single_sign_on_records`.
2019-01-30 09:34:19 +08:00
fc5b2de85d
FEATURE: add topic list before status plugin outlet for mobile
2019-01-29 17:15:31 -08:00
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00
0d0303e7ea
FIX: more resilient lookup in plugin-api ( #6961 )
...
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.
This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.
Original stacktrace:
```
"Error: Assertion Failed: expected container not to be destroyed
at new EmberError (ember:2929:31)
at assert (ember:1793:23)
at Container.lookup (ember:17736:64)
at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
at eval (javascripts/discourse/initializers/init-code-review:78:11)
at eval (select-kit/mixins/plugin-api:86:19)
at Array.forEach (<anonymous>)
at eval (select-kit/mixins/plugin-api:85:44)
at Array.forEach (<anonymous>)"
```
2019-01-29 16:54:04 +01:00
32f9fd1e51
FIX: add autocomplete=off to composer textarea
...
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete
This is likely a chrome bug but this change is very safe regardless.
2019-01-29 15:05:29 +02:00
f7deb52c90
FIX: Class name for external-link on customize page
2019-01-28 17:15:36 -05:00
62a0f88e97
FIX: More link in topic page search shouldn't navigate to full page result
2019-01-29 02:26:55 +05:30
3d52f690b3
UX: Add post action text in non-JS topic view
2019-01-28 22:51:06 +05:30
fb5c94246c
DEV: Remove underscore from `learn_more` key in theme export
...
Follow up from 033cd4f3
2019-01-28 16:00:33 +00:00
0d0ca4f070
DEV: Automatically remove placeholder 'URL' metadata values from themes
2019-01-28 11:55:58 +00:00
77d26b9df6
FIX: Support application/gzip theme imports, and improve error message
2019-01-28 11:51:14 +00:00
033cd4f31d
DEV: Include "_learn_more" key in theme `about.json`
...
This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.
2019-01-28 11:34:11 +00:00
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
cd3a167c63
FIX: javascript error when opening rename tag modal
2019-01-25 17:34:05 -05:00
94e2b77c5f
Fix theme component name's color when theme is selected
2019-01-25 17:25:12 -05:00
84a3da4b18
FIX: match drafts using key when deleting
...
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
2019-01-25 13:55:40 -05:00
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times ( #6953 )
2019-01-25 19:29:45 +01:00
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load ( #6951 )
2019-01-25 16:48:20 +01:00
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
65caf04ddc
clean up unused code
...
Unused PM topic list column 'Users' is removed
2019-01-25 20:13:54 +05:30
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
f461a9971f
FIX: makes staff_logins show only admins ( #6948 )
2019-01-25 11:28:52 +01:00
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
868528f862
Slight shadow adjustment to hide overflow
2019-01-24 14:49:39 -05:00
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
a518950e52
FIX: Use context sensitive "create topic" via keyboard if possible
2019-01-24 13:20:33 -05:00
8e795d82f9
UX: Bump up notification panel width to accommodate larger text
2019-01-24 12:48:48 -05:00
755b47b4bc
UX: change topic reminder notification icon
2019-01-24 10:07:24 -05:00
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete ( #6942 )
2019-01-24 15:19:19 +01:00
49193ca3bf
FIX: includes staff in staff_logins report ( #6945 )
2019-01-24 14:46:56 +01:00
c88fd49591
DEV: refactor user preferences path method
2019-01-24 18:39:13 +05:30
b9bf751b88
FIX: link to the user preferences page is incorrect in user admin page
2019-01-24 18:31:00 +05:30
dda918f862
UX: removes width constraint in user-card badge section
2019-01-24 20:53:14 +08:00
b1297a5f5a
FIX: replaces inline button message with d-button
2019-01-24 13:19:52 +01:00
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action ( #6941 )
2019-01-24 10:46:06 +01:00
22f43abb0e
UX: protection for very wide category-logo images on narrow screens
2019-01-24 17:16:18 +08:00
12df8c5c82
General style cleanup, removing unused styles
2019-01-23 21:37:39 -05:00
7d92fa3a5e
Mobile SCSS cleanup and removing unused styles
2019-01-23 14:36:53 -05:00
48c9234545
FIX: Lazy Loading: copy only present srcset
...
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
2019-01-23 14:04:43 -05:00
a9734eef81
UX: removes margins from categories in suggested topics message
2019-01-24 02:12:16 +08:00
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses ( #6932 )
2019-01-23 17:40:37 +01:00
0aa049791e
DEV: refactoring admin-backups-index ( #6933 )
2019-01-23 17:40:24 +01:00
60974932c4
DEV: refactoring api-keys ( #6931 )
2019-01-23 17:40:05 +01:00
9a594fed01
Removing unused bootstrap.scss file
2019-01-23 11:22:23 -05:00
5feeac221e
Groups on user profile missing margin
2019-01-23 10:10:17 -05:00
096a81158a
FIX: siteNavigationElement was reversed ( #6934 )
2019-01-23 15:47:39 +01:00
afd449089f
FEATURE: Import and export themes in a .tar.gz format ( #6916 )
2019-01-23 14:40:21 +00:00
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post ( #6930 )
2019-01-23 14:38:20 +01:00
d720215183
UX: admin badge page improvements
2019-01-23 11:29:51 +01:00
2e59a37687
FEATURE: List unused theme components ( #6924 )
2019-01-23 09:20:13 +00:00
b21266ed6f
FIX: corrects selector for move-to modal styles
2019-01-23 16:18:38 +08:00
70b56c8332
FIX: 'anon' css class is missing for anonymous users
2019-01-23 10:13:36 +05:30
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
62adc2eb98
User admin page button height fix
2019-01-22 14:00:38 -05:00
66f6382090
FIX: Icon missing due to typo
2019-01-22 13:01:21 -05:00
f0fd875918
UX: Improving aligment within topic timer modal
2019-01-22 12:33:46 -05:00
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
f32de88dfc
FIX: Don't notify of pending flags if min_flags_staff_visibility not met
2019-01-22 11:01:18 -05:00
fc710de3ab
DEV: refactoring admin user index ( #6927 )
2019-01-22 16:44:55 +01:00
31a700daf8
DEV: refactoring emoji-uploader ( #6926 )
2019-01-22 16:44:40 +01:00
bce9c37f15
DEV: refactoring permalink-form ( #6925 )
2019-01-22 15:09:21 +01:00
ea8373351b
DEV: refactoring ip-lookup ( #6923 )
2019-01-22 15:09:04 +01:00
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
ea0e188c8f
FIX: improves stacked-chart layout on ie11 ( #6922 )
2019-01-22 11:47:54 +01:00
9148f7675b
FIX: better handling of resizing in stacked charts ( #6921 )
2019-01-22 11:20:50 +01:00
7161304842
minor cosmetic improvements to charts ( #6919 )
2019-01-22 10:22:41 +01:00
b1b27d9f7b
FEATURE: add total on stacked-chart tooltip ( #6917 )
2019-01-22 09:57:34 +01:00
3359b3baca
FEATURE: Do not autoclose topics due to user flagging that are authored by staff
2019-01-21 15:50:53 -08:00
fe6d571021
FIX: Alignment for small-actions, gap, removing unneeded clearfix
2019-01-21 17:57:47 -05:00
4ddc28f194
FIX: Whitespace breaks activity column in Firefox
2019-01-21 16:26:34 -05:00
d82628987a
FIX: Badges appeared in wrong badge group
...
Some badges always appeared in the "Other" group (the default group) and some badges were always moved back into the original group during seeding.
Now badges are either in the correct, seeded group or stay in a custom group if the admin moved the badge into a custom group.
2019-01-21 21:09:33 +01:00
8546f0020e
UX: Invert pikaday png for dark themes
2019-01-21 13:47:46 -05:00
ba5e17a7a9
FIX: IE11 layout glitches
...
IE11 requires a unit on the third parameter (flex-basis) of the flex property
2019-01-21 13:40:55 -05:00
ec71091216
FIX: Don't override user flair styles in topic map
2019-01-21 12:37:49 -05:00
916219f48e
Remove "Users" heading in wizard homepage preview
2019-01-21 11:31:00 -05:00
3e1e9fce7e
FIX: better legend labels for stacked-charts ( #6914 )
2019-01-21 17:10:10 +01:00
a9edcb2e10
fixes few icons deprecations warnings ( #6915 )
2019-01-21 16:56:05 +01:00
b95165b838
FEATURE: adds a new chart report to track pageviews ( #6913 )
2019-01-21 15:17:04 +01:00
52f2e0d6b9
SECURITY: fix possible XSS with badges ( #6912 )
2019-01-21 13:08:26 +01:00
2d354ec9b0
FIX: `ForumsController` doesn't need to inherit from `ApplicationController`.
...
Application controller has a whole bunch of before/after actions which
we have no need for.
2019-01-21 14:37:04 +08:00
502b1316d0
DEV: s/this._super()/this._super(...arguments) ( #6908 )
2019-01-19 10:05:51 +01:00
61fff098ed
minor email/whisper icon alignment fix
2019-01-18 20:59:52 -05:00
3b7ac3f6eb
UX: We don't have bulk select on mobile, so we should hide the button
2019-01-18 20:26:58 -05:00
df0303c912
UX: Improve button alignment, fix invite header
2019-01-18 20:08:52 -05:00
e6e4a073a5
alignment fix due to font-size bump
2019-01-18 16:24:27 -05:00
4f897dde50
UX: Improve alignment of new post badge on mobile
2019-01-18 16:17:24 -05:00
247ab4a830
Align notification in unread education message
2019-01-18 15:40:07 -05:00
59028035df
FIX: Update about/license URLs when updating theme from remote source
2019-01-18 17:46:57 +00:00
95f9a369a5
FIX: ensures visits reports are correcttly differencing mobile/all ( #6905 )
2019-01-18 17:24:18 +01:00
7908a522a0
FIX: postLabel was not working for totals ( #6904 )
2019-01-18 17:06:43 +01:00
b1b8c37e62
FIX: Correctly import theme assets with spaces in filename
...
This issue is caused by the filename restrictions in `OptimizedImage#ensure_safe_paths!`. Difficult to add a test for this because image optimization is bypassed in test mode.
2019-01-18 15:20:11 +00:00
45f66826ee
PERF: delete potentially large associated tables before user_destroyer.destroy transaction
2019-01-18 16:10:03 +01:00
f8f281cdad
UI: update "latest" canvas layout in wizard
2019-01-18 09:56:39 -05:00
457e6c7b37
FIX: Mods weren't able to see emails in admin user list
2019-01-18 15:37:30 +01:00
f40c97c367
Remove support for `theme_var` and `theme_color_var` fields
...
These are remnants of the old 'customization' system, and have been superseded by theme settings
2019-01-18 12:04:23 +00:00
197e3fd722
FIX: Keep original subject in emails to staged users
...
Renaming a topic shouldn't be visibile to staged users when the topic was created via email.
2019-01-18 11:07:54 +01:00
b20ad9d684
FIX: since Ember 3 interceptClick was not working on buffered links ( #6898 )
2019-01-18 11:01:19 +01:00
95e3841974
FIX: Remove old reference and use `MiniScheduler::Stat`.
2019-01-18 16:36:11 +08:00
f89a32e759
FIX: Text logo does not show up on non ember pages.
2019-01-18 15:11:42 +08:00
cf6223226d
DEV: Do the draft conflict check async. ( #6895 )
2019-01-18 15:51:56 +11:00
2274d6d7ac
FIX: refresh "/categories" on logo click ( #6891 )
...
* FIX: refresh discovery categories on logo click
* Fix prettier offence
2019-01-18 12:08:42 +08:00
9f52306861
Keep avatar image at native size for normal font-size, remove unneeded clearfix
2019-01-17 21:54:22 -05:00
8c5c4200ec
prettier
2019-01-17 21:13:52 -05:00
5307e9337f
HACK: Reduce icon jitter while scrolling with composer open in iOS
2019-01-17 21:04:05 -05:00
d5d994e24a
UX: Improving user stream alignment and spacing
2019-01-17 17:29:27 -05:00
43bb16de27
Prevent header icons from overflowing with long title present
2019-01-17 16:11:40 -05:00
7401901939
UX: Badge alignment adjustments
2019-01-17 15:46:55 -05:00
2818afb267
FIX: Do not hide posts automatically when flagged by staff user
2019-01-18 01:33:55 +05:30
3c987132cb
Prevent placeholder text from being cut-off
2019-01-17 14:39:28 -05:00
3501533a2b
DEV: unpin Prettier version, apply to YAML files
...
We had Prettier pinned because of https://github.com/prettier/prettier/issues/5529 . Since that bug is fixed, unpinning.
Prettier now supports YAML, so this applies Prettier to all .yml except for translations, which should not be edited directly anyway.
2019-01-17 13:05:39 -05:00
b664674d2b
make smaller text size bigger
2019-01-17 12:11:31 -05:00
b9215ddaea
FIX: Navigate to full page search when enter key used in topic
2019-01-17 22:34:23 +05:30
b9355f316a
Minor size/alignment fixes for font size increase
2019-01-17 11:42:03 -05:00
675bf94133
UX: Bump up base font size 1px, add smaller text size option
2019-01-17 10:30:34 -05:00
24b59afe2a
FIX: Wrap theme javascript inside IIFE to prevent using global namespace
2019-01-17 14:44:10 +00:00
5bfa661a87
FIX: Theme settings are referenced in JS by `settings`, not `themeSetting`
2019-01-17 12:24:21 +00:00
880311dd4d
FEATURE: Support for localized themes ( #6848 )
...
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.
- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).
- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.
- Theme developers should access defined translations using the new theme prefix variables:
JavaScript: `I18n.t(themePrefix("my_translation_key"))`
Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`
- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript
- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
2019-01-17 11:46:11 +00:00
740d047365
FIX: regression lead to a 404 when trying to filter user posts ( #6893 )
2019-01-17 11:31:23 +01:00
aa2cc4ab31
FIX: Liked notification consolidation has to account for user like frequency setting.
2019-01-17 14:33:23 +08:00
384135845b
FEATURE: introduce ultra_low priority queue
...
This commit introduces an ultra low priority queue for post rebakes. This
way rebakes can never interfere with regular sidekiq processing for cases
where we perform a large scale rebake.
Additionally it allows Post.rebake_old to be run with rate_limiter: false
to avoid triggering the limiter when rebaking. This is handy for cases
where you want to just force the full rebake and not wait for it to trickle
2019-01-17 14:53:19 +11:00
7d84648d11
FEATURE: Remove full quotes only from new posts. ( #6862 )
2019-01-17 13:24:32 +11:00
e7d2a0d42f
UX: Larger/Largest font-sizes should be 1px larger on mobile
2019-01-16 20:59:31 -05:00
d5ecf8e8c2
FIX: properly clean out post and user actions on destroy user
...
This corrects 2 issues:
First is a regression with d7c08e21
2019-01-17 12:40:30 +11:00
d7c08e217a
PERF: delete user and post actions vs destroy on user destroy
...
Users can have 100s of thousands of post and user actions, we do not want
to destroy each individually cause the tracking is enormous and the amount
of queries we would need is enormous.
This gives up on the `after_commit` hook on `post_actions` which ships a message
to clients to synchronize a post, so some phantom post_actions may remain
in the UX in the rare occasion we delete a user. The phantoms will be gone
on reload.
2019-01-17 11:19:37 +11:00
1d4d4b81e6
remove stray chars
2019-01-16 15:05:43 -08:00
58008dd2fe
FIX: sort topics/posts/links in descending order in user summaries
...
This should only change the order on freshly imported instances with no likes.
This makes the user summary show the latest topics/posts/links instead of the firsts until the users get some likes.
2019-01-16 23:58:46 +01:00
f0999f27a7
UX: soften the "problems" alert on dashboard
2019-01-16 14:58:19 -08:00
6079a3e4d0
FEATURE: allow calling user destroyer without a transaction
...
This additional option allows us to destroy a user in "pieces" in cases
where database is very big and stuff tends to time out
2019-01-17 07:56:17 +11:00
16a7102dad
FIX: `Ember.warn` needs an `id`
...
This way errors can be customized/silenced in the console.
2019-01-16 14:53:13 -05:00
98f26bcaf5
Revert "FIX: makes click-interceptor working with touchstart ( #6890 )"
...
This reverts commit fd2dd8d67d
2019-01-16 17:47:40 +00:00
fd2dd8d67d
FIX: makes click-interceptor working with touchstart ( #6890 )
...
Probable regression due to the removal of Modernizr.
2019-01-16 17:56:43 +01:00
18055f5e37
DEV: show remote theme repository URL
2019-01-16 11:09:16 -05:00
1ac4dc5b73
FIX: makes whisper state more resilient ( #6889 )
...
This commit also moves some logic from model to controller.
2019-01-16 15:23:06 +01:00
b46b6e72d1
FIX: Only add the trust level name for numeric trust levels
...
Previously the TrustLevelAndStaffSetting would display 'new user' for staff/admin
2019-01-16 12:04:12 +00:00
79eb1b8e16
FIX: Add watching_first_post to NOTIFIABLE_TYPES ( #6887 )
2019-01-16 11:49:15 +00:00
54f95bb335
rm period ( #6886 )
2019-01-16 10:58:43 +01:00
486df57a23
FIX: tweaking topic footer dropdowns ( #6882 )
...
- no description on mobile for notifications
- better reason text positioning
2019-01-16 10:27:27 +01:00
f06b773d25
FIX: Don't show liked consolidated notification when frequency is never.
2019-01-16 17:08:59 +08:00
e7b49c42c4
FIX: Allow liked notifications consolidation to be disabled.
2019-01-16 16:17:04 +08:00
f8db93df5f
FIX: Consolidated like notifications links to wrong user on user page.
2019-01-16 15:55:18 +08:00
27e2b6575b
FIX: Liked notifications should not be consolidated across multiple users.
2019-01-16 15:01:13 +08:00
71a69c1976
Revert "FIX: refresh topic list on logo click"
...
This reverts commit 037776881b
2019-01-15 22:54:53 -05:00
1591c42a06
FIX: profile picture not showing up on user admin page
2019-01-16 09:21:11 +05:30
40533bc570
REFACTOR: `filterBy` in `UserStream`.
...
Follow up to ebe65577ed
2019-01-16 10:53:44 +08:00
ebe65577ed
FEATURE: Consolidate likes notifications. ( #6879 )
2019-01-16 10:40:16 +08:00
037776881b
FIX: refresh topic list on logo click
...
Fixes a regression where, when homepage is set to "categories", clicking on logo would no longer reload topic list.
2019-01-15 17:01:09 -05:00
b69e57e2f3
FIX: Prevent layout changes while images are lazy-loading
...
This commit moves the temporary image to be adjacent to the original image in the DOM. Previously the temporary image was appended to the parent element. Normally this makes no difference because the temporary element has position:absolute. However, if the `:last-child` selector is being used on the parent, it can cause layout changes during loading.
2019-01-15 17:35:55 +00:00
70cdb42173
FIX: Tooltip for unlisted topics wasn't shown in topic list
...
The locale key had to be renamed, because this key is also used as CSS class.
The "invisible" CSS class makes the icon invisible. "unlisted" doesn't have that effect.
2019-01-15 16:13:06 +01:00
c4422fdc13
UX: sort admins and moderators by last seen date on /about page
...
UX: only show active admins and moderators on /about page
2019-01-15 17:26:11 +05:30
59e5af466b
FIX: call method only if it exists
...
discourse-objects creating empty Discourse object in window. It fails the _registerPluginCode method call since it is not exist.
2019-01-15 15:55:32 +05:30
f75915efa4
FIX: `expandAllPinned` was not resetting after visiting a category
...
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.
See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
2019-01-14 13:02:25 -05:00
0cb2b7d603
FIX: add meta details for user summary page
2019-01-14 19:49:14 +05:30
1ebd3dbbd0
FEATURE: Allow the base font size to be changed on a per-user basis ( #6859 )
2019-01-14 13:21:46 +00:00
59e3eecfa6
FEATURE: allow staff to select existing message via ID or URL
2019-01-14 15:29:05 +05:30
a121d40771
FIX: do not show PM topics when moving posts to an existing public topic ( #6876 )
2019-01-14 15:00:45 +05:30
08d21cc758
FIX: do not show full name on summary page unless the setting is enabled
2019-01-14 07:00:44 +05:30
93eb0a0690
UX: better help text for private invite-only instance
2019-01-12 18:40:00 +05:30
49593d1a00
FIX: Fix registration dialog popup for 'full screen' social logins
...
Regression following the ember3 upgrade. In addition to fixing, this commit consolidates our social registration logic into one place, and adds tests for the behaviour.
2019-01-12 12:08:13 +00:00
dcdcaebd0f
FIX: checkEmail was calling itself ( #6878 )
2019-01-12 11:12:17 +01:00
8176d26dbd
UX: Reducing usage of btn-small, simplifying styles
2019-01-11 19:41:09 -05:00
e4c593f1e7
removing some dupe styles, adding button class
2019-01-11 15:41:51 -05:00
95f263995d
FIX: Previous annotations were broken
2019-01-11 14:30:19 -05:00
5e0f9eadb8
FIX: show user avatar on User summary page ( #6872 )
2019-01-11 23:39:06 +05:30
83f0afbec9
Usercards sometimes not wrapping correctly in Safari
2019-01-11 12:50:16 -05:00
a3839495e0
Update annotations
2019-01-11 12:19:43 -05:00
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
dbe42068a2
REFACTOR: Move option to return emails into the serializer
...
This makes more sense than having the guardian take an accessor.
The logic belongs in the Serializer, where the JSON is calculated.
Also removed some of the DRYness in the spec. It's fewer lines
and made it easier to test the option on the serializer.
2019-01-11 11:17:23 -05:00
0fa92699e2
UX: Don't save automatically when resetting site settings in admin page.
2019-01-11 16:39:21 +08:00
2956c52e57
FIX: Show title as home logo if title has been set and logo is blank.
...
https://meta.discourse.org/t/default-text-logo-not-working/103936
2019-01-11 15:46:58 +08:00
99856478d6
FIX: use discourse route_for function to check url route
...
it takes care if there is a relative url root
2019-01-11 14:58:45 +08:00
29ff184508
d60b9df fix, was too broad
2019-01-10 21:50:00 -05:00
d60b9dfba4
UX: Close button shouldn't get :visited color
2019-01-10 21:47:38 -05:00
9f39ac8366
FIX: ember3 regression, uses model as bufferedProperty for badges ( #6875 )
2019-01-11 00:46:03 +01:00
49e3a83062
FIX: minor regression when acting on queued post
2019-01-10 15:32:33 -05:00
0744e84604
UX: always scope the composer categories dropdown to current category
2019-01-11 01:07:23 +05:30
a8ff4a8a78
UX: search all categories even if category-chooser is scoped to particular category
2019-01-10 21:19:53 +05:30
978cc0cfca
FIX: Remove expired subscription for push notifications
...
All other errors get logged, but do not stop the system from sending further push notifications.
2019-01-10 15:41:04 +01:00
1fdbf0fc9b
FIX: uses compiler version to force rebaking of themes ( #6870 )
...
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 12:36:13 +01:00
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
c2bca9cabe
Make rubocop happy.
2019-01-10 10:52:15 +08:00
d10694150e
Revert "FIX: Partial reply key search in email sent logs."
...
This reverts commit e9b2018bc8
2019-01-10 10:05:56 +08:00
798e98a7cc
remove safari check from isAppleDevice ( #6869 )
2019-01-10 13:02:55 +11:00
51b13ec86f
FIX: show lock glyph to a user without permissions to see quote ( #6854 )
2019-01-10 09:48:05 +08:00
cb0f6d653b
DEV: Minor fixes to b63b399799.
2019-01-10 09:38:22 +08:00
b63b399799
DEV: remove uploaded_meta_id column from category ( #6725 )
...
* DEV: remove uploaded_meta_id column from category
* remove uploaded_meta part
2019-01-10 09:37:21 +08:00
a52baf4b28
FEAT: use category logo image as meta image ( #6865 )
2019-01-10 09:33:13 +08:00
e9b2018bc8
FIX: Partial reply key search in email sent logs.
...
Follow up to c85b9c6ed3
2019-01-10 09:25:14 +08:00
c85b9c6ed3
FIX: searching email logs by reply key ( #6868 )
...
* you can't use LIKE or ILIKE on a UUID
2019-01-10 07:51:58 +08:00
312e282b6a
FIX: Apply classes when lazily loading images
...
If an image had extra classes (for example oneboxes), then while loading
the copy of the image would lose those classes and look differently
until the image had loaded fully.
This fix copies the classes while loading.
2019-01-09 12:56:25 -05:00
439eff4709
revert null checking around interceptClick
2019-01-09 09:44:30 -08:00
2d3e50ae7c
FIX: Match default `<code>` padding to highlightjs padding
...
Without this, the height of posts changes once highlightjs is lazy-loaded, potentially causing scrolling issues
2019-01-09 17:36:51 +00:00
8b3ddcf646
FIX: Add topic status to flagged topics list
...
Previously at a glance it was impossible to tell if a topic was closed
before digging deeper.
2019-01-09 10:59:35 -05:00
1f12a377fa
minor refactoring of card-contents-base mixin
2019-01-09 19:32:30 +05:30
b7c501bf52
FIX: full page search results are unclickable
...
data-ember-action can have empty value in favor of data-ember-action-ID attribute
2019-01-09 10:59:37 +05:30
2748822576
FEATURE: Remove option for Google Plus sharing ( #6864 )
...
* Remove option for Google Plus sharing
* remove google+ share translations
2019-01-09 10:17:50 +08:00
25269a37aa
FIX: do not show #uncategorized in category drop if setting is disabled ( #6856 )
2019-01-09 09:44:24 +08:00
f73fe36772
FEATURE: PWA compatibility checks in the Dashboard ( #6850 )
2019-01-09 08:46:11 +08:00
Arpit Jalan
Kris
Vinoth Kannan
Régis Hanol
Joffrey JAFFEUX
Sam
Jeff Wong
Robin Ward
David Taylor
Dan Ungureanu
Penar Musaraj
Gerhard Schlager
Bianca Nenciu
Vinoth Kannan
Guo Xiang Tan
Neil Lalonde
Blake Erickson
Joe
Angus McLeod
Daniel
Maja Komel
Jeff Atwood
Guo Xiang Tan
Saurabh Patel
Michael Brown
Zach Whitehead
Rafael dos Santos Silva