22e713d2b0
FIX: Add skip_validations in one more place for narrative bot plugin
...
Followup to bbb814e58e
2019-11-20 15:43:42 +00:00
bbb814e58e
FIX: Allow advanced tutorial when title emojis are disabled
...
We already skip validations for other uses of PostCreator in the narrative bot, so this commit adds it in the `reply_to` action as well
2019-11-20 15:29:06 +00:00
555711ccb5
FIX: Use correct MIME type for theme exports ( #8379 )
2019-11-20 17:19:16 +02:00
3b5c214ac3
DEV: fix linting
2019-11-20 14:03:45 +00:00
d541183906
DEV: Make it possible to deprecate plugin outlet properties
2019-11-20 13:56:26 +00:00
b28767f158
DEV: lodash is actually on 4.17.15 ( #8378 )
2019-11-20 11:16:09 +01:00
fa317becc8
DEV: upgrades chart.js from 2.7.3 to 2.9.3 ( #8374 )
2019-11-20 11:08:26 +01:00
d45bd7f131
FIX: Abort CensoredWordsValidator early if censored_words_regexp nil ( #8375 )
...
* Abort CensoredWordsValidator early if censored_words_regexp nil. Sometimes censored_words_regex can end up nil, erroring the validator. This handles the nil condition and also adds a spec for the validator
2019-11-20 20:05:06 +10:00
7543db086a
Bump onebox version.
...
- FIX: Amazon video oneboxes were not working.
2019-11-20 14:47:59 +05:30
aa2b3e71b4
Minor refactor of bin/unicorn cache clean
...
* move git ls-files for plugins folder into one line
2019-11-20 08:47:51 +10:00
9652fdd111
DEV: if tmp is missing create it
...
Some scripts and people may be nuking the entire tmp folder
2019-11-20 09:29:34 +11:00
dd89a13e22
DEV: disable flaky spec
...
This is erratically failing in our production CI
2019-11-20 08:56:07 +11:00
02cb01406e
FIX: Allow secure uploads if global s3 setting active and enable_s3_uploads validations ( #8373 )
...
The secure media functionality relied on `SiteSetting.enable_s3_uploads?` which, as we found in dev, did not take into account global S3 settings via `GlobalSetting.use_s3?`. We now use `SiteSetting.Upload.enable_s3_uploads` instead to be more consistent.
Also, we now validate `enable_s3_uploads` changes, because if `GlobalSetting.use_s3?` is true users should NOT be enabling S3 uploads manually.
2019-11-20 07:46:44 +10:00
9b60900b8d
FIX: More `Promise` uses that were not imported
2019-11-19 15:58:40 -05:00
46841888b7
FIX: For a single authenticator, do not interrupt registration flow
...
Followup to 0a14b9b42a
2019-11-19 19:15:11 +00:00
565a967192
FIX: email excerpts for posts starting with a quote were displaying a username
...
If a post starts with a post quote and has no other text content,
then the email excerpt was the name of the person quoted and
nothing else. The intention was to show the contents of the
first paragraph or div after the quote.
With this change, a quote followed by an image will use the
image as the excerpt. A quote followed by a onebox will use the
onebox.
2019-11-19 12:35:23 -05:00
7ba2b677a6
DEV: Use enum instead of id for topic timer query
...
Follow up to 266e486037
2019-11-19 10:10:14 -07:00
266e486037
FIX: Turn off auto bumping for topics with scheduled bumps
...
If a topic has a timer scheduled to bump a topic it should be excluded
from being auto bumped.
2019-11-19 07:27:49 -07:00
7886a3e58a
DEV: Update annotations
2019-11-19 10:21:06 +00:00
d3e7768ea8
Revert "FIX: parallel spec system needs needs a dedicated upload folder for each worker. ( #8372 )"
...
This reverts commit 42e5176bc3
2019-11-19 15:02:18 +05:30
42e5176bc3
FIX: parallel spec system needs needs a dedicated upload folder for each worker. ( #8372 )
2019-11-19 13:16:20 +05:30
f83125f0c2
DEV: minor refactoring to reduce the code duplication.
2019-11-19 08:04:24 +05:30
57bbcf4c5d
FIX: 'default_categories_muted' site setting not working for anonymous users.
2019-11-19 07:48:16 +05:30
f49ef851df
FIX: do not insert conflict rows into category user
...
This could fail under certain race conditions
2019-11-19 12:23:11 +11:00
93d7abe372
FIX: Automatically recover from bad sprockets cache in development ( #8364 )
...
We were having issues in development mode where the JS code had errors due to a bad cache. When starting a server in development mode in bin/unicorn we now get the git sha of the discourse HEAD and get a git sha of all plugins, and store them in a file. If the sha has changed then we delete tmp/cache to refresh the assets cache.
2019-11-19 09:15:09 +10:00
a4dbec5bf9
FIX: unable to remove required tag group from a category
2019-11-18 15:54:00 -05:00
228c4814be
FIX: errors when using tags with colons in their name
2019-11-18 13:20:37 -05:00
0350247130
DEV: Exclude plugin specs when running chdir cop
2019-11-18 16:00:18 +00:00
eaf6096890
DEV: Use rubocop-discourse gem to add custom chdir cop
...
Followup to b27e009655
2019-11-18 15:39:41 +00:00
6f9afde9a8
UX: Allow enter key to submit test email in admin panel
2019-11-18 15:36:06 +00:00
97dad94bfd
DEV: Bump eslint-config-discourse to 1.0.6
...
Also fixes an inconsistency in Prettier version number.
2019-11-18 10:14:21 -05:00
0e759add0f
DEV: Better topic participants summary spec
2019-11-18 09:43:14 -05:00
a3df065058
PERF: Do fewer queries when converting posts. ( #8358 )
...
- Avoid using User#find and then fetching the user_stat association just to update a counter - We did this for every post in the topic.
- Avoid having to query the topic_allowed_user table everytime we want add a new topic_allowed_user
- Use pluck to fetch just what we need.
2019-11-18 11:04:21 -03:00
172832f353
DEV: Submit forms via `type=submit` button, not explicit form action ( #8368 )
2019-11-18 13:26:26 +00:00
3650c64bca
FIX: Ensure load-more considers current position ( #8357 )
...
The loadMore action was not called if user was already at the bottom
of the page.
2019-11-18 15:09:47 +02:00
352d43b101
FIX: Better handling of Group model state ( #8356 )
...
The group card and group members page were affecting each other and were
leaking members list and the query parameters which led to bad UX
experience and sub-optimal performance (client made more queries because
it was loading fewer members).
This commit refactors the group model to make it more consistent, remove
dead code, move error handling outside of model.
2019-11-18 14:59:28 +02:00
acb8d6f946
Revert "Revert unintended prettier version downgrade"
...
This reverts commit ee02b7e04d
2019-11-18 09:32:03 -03:00
ee02b7e04d
Revert unintended prettier version downgrade
2019-11-18 09:30:52 -03:00
1c1c3cae85
FIX: Enter key should submit password reset form, not refresh the page
2019-11-18 11:54:41 +00:00
84107c61a7
FIX: PM glyph in user-menu should always be shown to staff
2019-11-18 17:25:07 +08:00
e6442a2d2f
FIX: we don't need to refresh dates so often ( #8367 )
2019-11-18 10:04:07 +01:00
45648e46ba
FIX: attempts to be correct about dst when using recurrence ( #8366 )
2019-11-18 10:02:58 +01:00
3bb7ad4be1
FEATURE: remove support for 'suppress_from_latest' category setting. ( #8308 )
2019-11-18 12:28:35 +05:30
4e4844f4db
REFACTOR: reduce the number of db queries.
2019-11-18 12:06:13 +05:30
79b8c08d45
DEV: give categories-separator class to HR after cateogries
...
This allows for better styling of the hamburger menu
2019-11-18 17:31:01 +11:00
af0cc89b11
Mark upload show paths as is_asset_path ( #8365 )
...
* this is to avoid excessive rate limiting, especially
for secure media on media-heavy topics
2019-11-18 16:56:20 +11:00
d28de23ac8
FEATURE: block screaming frog SEO spider by default
...
This crawler is not respectful and often can make 1000s of reqs a minute.
Block by default, site operators can amend this default if they want to.
2019-11-18 16:48:07 +11:00
a9704da34c
FIX: A pmOnly tag should link to messages ( #8361 )
...
isPrivateMessages represents that the tag list is shown in the context
of private messages and pmOnly represents that the tag is used only in
private messages.
2019-11-18 16:44:08 +11:00
975165f25f
FIX: Don't error CleanUpInactiveUserJob when user is missing ( #8362 )
2019-11-18 16:14:15 +11:00
7d389df5e7
DEV: correct spec to allow for new default
...
b4bfc27b
2019-11-18 16:05:58 +11:00
David Taylor
Dan Ungureanu
Daniel Waterworth
Joffrey JAFFEUX
Martin Brennan
Arpit Jalan
Martin Brennan
Sam Saffron
Robin Ward
Neil Lalonde
Blake Erickson
Vinoth Kannan
Vinoth Kannan
Penar Musaraj
Roman Rizzi
Joe
Krzysztof Kotlarek