Robin Ward
abdb334823
UX: Allow for customization of the heart icon
2017-10-04 11:07:59 -04:00
Guo Xiang Tan
1310181664
FIX: Adding a public topic timer deletes a private topic timer.
2017-10-04 16:31:40 +08:00
Sam
ebdf8d6718
remove uneeded code
2017-10-04 15:05:58 +11:00
Sam
14310d2eee
UX: title in JS must match title on Server
...
Corrects title flashing with incorrect value on front page reloads
2017-10-04 15:04:42 +11:00
Kyle Zhao
0342324b47
FEATURE: support regex in rake post:remap ( #5201 )
2017-10-04 11:47:53 +11:00
Robin Ward
2ce6e0bb07
UX: Perform icon replacements before calling icon renderer
2017-10-03 15:38:59 -04:00
Neil Lalonde
1faae3c765
rename forgot_password_strict to hide_email_address_taken
2017-10-03 15:28:31 -04:00
Neil Lalonde
e47f5cedd2
FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup
2017-10-03 15:28:30 -04:00
Robin Ward
cc4a102b26
UX: Allow customization on header dropdown sizes
2017-10-03 15:24:18 -04:00
Robin Ward
c72ceb1f2d
An option to not display categories in the hamburger
...
This is mostly useful if your site has very few categories.
2017-10-03 14:39:56 -04:00
Robin Ward
4b7256d2e4
FIX: `d-header` in common is `z-index: 1001`
2017-10-03 14:31:25 -04:00
Robin Ward
4fbe4218c4
FIX: Header primary color was too dark in dark mode
2017-10-03 13:01:05 -04:00
Régis Hanol
daf1dda700
FIX: username autocomplete in assign modal wasn't working
2017-10-03 12:49:45 +02:00
Guo Xiang Tan
a5b7d34fe2
Merge pull request #5199 from xrav3nz/poll-feed-integration-test
...
TEST ONLY: PollFeed integration test
2017-10-03 14:33:22 +08:00
Guo Xiang Tan
a966f2134c
Merge pull request #5215 from gschlager/email_templates
...
Add specs for EmailTemplatesController
2017-10-03 14:30:19 +08:00
Guo Xiang Tan
3e53dbcade
UX: Only include tag hashtag postfix when necessary.
...
https://meta.discourse.org/t/links-to-tags-not-working-in-final-post-unless-autocompleted/69884/6?u=tgxworld
2017-10-03 13:54:50 +08:00
Guo Xiang Tan
81c0092326
Revert "FIX: not serving non brotli cdns from cdn_url"
...
This reverts commit eaa896d8ee
.
2017-10-03 10:52:28 +08:00
Sam
eaa896d8ee
FIX: not serving non brotli cdns from cdn_url
...
(this means that access control allow origin could break)
2017-10-03 11:20:08 +11:00
Robin Ward
1022535c2b
UX: Add a two week suspension timeframe
2017-10-02 15:23:58 -04:00
Robin Ward
56793d6853
FIX: Better flagging CSS on mobile
2017-10-02 15:14:07 -04:00
Robin Ward
f7c967b754
Add forever to the suspension dropdown
2017-10-02 15:04:22 -04:00
Arpit Jalan
469c6776c6
FIX: exporting admin dashboard reports were broken
...
http://eileencodes.com/posts/actioncontroller-parameters-now-returns-an-object-instead-of-a-hash/
2017-10-02 19:30:23 +05:30
Gerhard Schlager
5bb326a452
Add specs for EmailTemplatesController
2017-10-02 14:53:27 +02:00
Guo Xiang Tan
8140e54675
FIX: More fixes for `Group#mentionable` and `Group#messageable` feature.
2017-10-02 17:45:58 +08:00
Guo Xiang Tan
91c5f928c2
FIX: `Group#mentionable` and `Group#messageable` not fully working.
2017-10-02 16:50:58 +08:00
Guo Xiang Tan
4ae3a4e89e
UX: Label should toggle checkbox.
...
https://meta.discourse.org/t/clicking-label-for-automatically-set-as-primary-group-doesnt-toggle-setting/71086/2
2017-10-02 16:07:53 +08:00
OsamaSayegh
79f3d299a1
Don't allow category definition topics to be converted to PMs ( #5216 )
2017-10-02 10:04:58 +02:00
Kyle Zhao
ac666ddf17
PollFeed: check 'content:encoded' for content first
2017-10-02 01:16:11 -04:00
Guo Xiang Tan
0f2c5f5fc9
FIX: Don't raise error when trying to download avatar from URL.
2017-10-02 12:59:41 +08:00
Guo Xiang Tan
974836962d
Fix invalid method call.
2017-10-02 12:50:22 +08:00
Guo Xiang Tan
4e07bbfbbf
FIX: Only allow intergers for page params.
2017-10-02 10:45:54 +08:00
Guo Xiang Tan
77ea063751
FIX: Missing attribute.
2017-10-02 10:24:37 +08:00
Eleanor Demis
ac04f5e0cc
update response error when deleting tags ( #5213 )
2017-09-30 16:31:32 +02:00
Guo Xiang Tan
4eeb6014f4
Don't raise an error if user has been destroyed.
2017-09-30 09:09:40 +08:00
Neil Lalonde
d5d66e969e
FIX: js error when logging in using another Discourse site as sso provider
2017-09-29 14:02:45 -04:00
Robin Ward
2c2fe7eee4
FIX: Remove unused mixin
2017-09-29 11:09:25 -04:00
Robin Ward
00b190af75
Revert "A safe way to create class variables in a multisite environment."
...
The approach taken by this interface was flawed. We need a better
solution.
2017-09-29 11:06:12 -04:00
Guo Xiang Tan
a370d7c7fd
FIX: Compatibility between Client and Server routing.
...
mend
2017-09-29 10:34:50 -04:00
Robin Ward
c1f174f554
FIX: Okay, try going back to the old way. Too many exceptions.
2017-09-29 10:19:35 -04:00
Robin Ward
0caf6a0f7d
Support for HTML values in widget hbs templates
2017-09-29 09:56:14 -04:00
Régis Hanol
f6c484881b
FIX: wasn't able to save watched/tracked/muted categories/tags
2017-09-29 13:09:48 +02:00
Arpit Jalan
689f949fdb
Merge pull request #5209 from techAPJ/has-messages
...
FIX: update group.has_messages field weekly
2017-09-29 09:12:26 +05:30
Arpit Jalan
d64853dfa0
FIX: update group.has_messages field weekly
2017-09-29 08:23:07 +05:30
Sam
05dd97ffe0
correct iPad sizing
2017-09-29 11:49:10 +10:00
Guo Xiang Tan
6baea9948b
Revert "fix the build"
...
This reverts commit 8b74c7d325
.
2017-09-29 08:57:06 +08:00
Robin Ward
df81d109e5
The ability to attach `attrs` when embedding widgets
2017-09-28 16:08:43 -04:00
Robin Ward
01c6224ca5
Include the `currentRouteName` in the page change event
2017-09-28 14:31:20 -04:00
Robin Ward
954013a45c
Use `appEvents` for page tracking so widgets can listen to it easily
2017-09-28 14:20:32 -04:00
Neil Lalonde
c7aa354ee8
UX: round instead of ceil for time gaps
2017-09-28 14:11:37 -04:00
Robin Ward
34f98f362f
Add a plugin hook to specify a class on the body of the document
2017-09-28 13:17:09 -04:00
Joshua Rosenfeld
ca3d6921a0
Add group name css target
2017-09-28 11:43:52 -04:00
Robin Ward
7df349afd6
Allow reopened widgets to use `hbs` templates
2017-09-28 11:13:30 -04:00
Robin Ward
132cbac600
Split out header contents for easier customization
2017-09-28 10:46:07 -04:00
Régis Hanol
8b74c7d325
fix the build
2017-09-28 15:50:01 +02:00
Régis Hanol
cd6dff58dd
FIX: add user option/profile fields that were not permitted
2017-09-28 14:59:53 +02:00
Sam
b2575a8ce3
improve keyboard height detection
2017-09-28 21:25:03 +10:00
Guo Xiang Tan
d79fee9ff3
Fix undefined method for Nil class error.
2017-09-28 17:38:53 +08:00
Guo Xiang Tan
5d53eefcab
Fix broken test.
2017-09-28 16:09:58 +08:00
Sam
cfed431ef2
More height hacks for iPhone
2017-09-28 18:06:00 +10:00
Guo Xiang Tan
30fa5379ce
Merge pull request #5195 from henrik/patch-1
...
100.years.ago -> Time.at(0)
2017-09-28 15:47:06 +08:00
Guo Xiang Tan
5f1c29e424
FIX: Display json response when `Discourse::InvalidAccess` is raised for
...
non json requests.
2017-09-28 15:31:16 +08:00
Guo Xiang Tan
373fd8990e
PERF: N+1 when generating not found page.
2017-09-28 15:31:16 +08:00
Sam
d36d5ba8ac
Correct iPad fudge factors for keyboard size detection
2017-09-28 17:26:54 +10:00
Sam
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
Guo Xiang Tan
4319d8a142
FIX: Missing template error when rendering `topics#show` error message.
2017-09-28 11:06:44 +08:00
Sam
b80320da5e
no verbose logging for failed downloads of gravatars
2017-09-28 11:32:26 +10:00
Régis Hanol
3a75242c38
add more logs to pull hotlinked images
2017-09-28 01:00:13 +02:00
Régis Hanol
dd07094bd7
bump log level to debug download issues
2017-09-27 23:26:07 +02:00
Robin Ward
41c3941c4c
FEATURE: Support regular expressions for watched words
2017-09-27 15:48:57 -04:00
Robin Ward
fa41913ba5
FIX: Don't count private content in New User of the Month
2017-09-27 15:03:24 -04:00
Régis Hanol
6a7920ad75
FIX: wasn't able to change default theme
2017-09-27 20:05:31 +02:00
Robin Ward
7578d8fc44
Add a `DiscourseEvent` for when a topic is closed
2017-09-27 14:00:53 -04:00
Robin Ward
3e13becf33
A safe way to create class variables in a multisite environment.
...
This should allow plugins to set class variables that will not
stomp on other plugins.
2017-09-27 13:00:47 -04:00
Arpit Jalan
6700aed8ab
fix typo
2017-09-27 22:17:19 +05:30
Gerhard Schlager
1a37812625
FIX: show error message when keys are missing in email template
...
FIX: log email template changes in the Staff Log
2017-09-27 13:50:04 +02:00
Sam
a311dd06fe
UX: mess with iPad and iPhone sizing to compensate for keyboard
...
iOS still has no mechanism for figuring out how big the keyboard is, so
we fudge it.
2017-09-27 16:50:28 +10:00
Guo Xiang Tan
2568312475
FIX: Use exact patht to ensure we always redirect with the right format.
2017-09-27 11:55:06 +08:00
Joshua Rosenfeld
fbfc4de3eb
Move staged below active
2017-09-26 16:46:37 -04:00
Régis Hanol
af01e62b14
FIX: wasn't allowed to set a user's title anymore
2017-09-26 20:13:24 +02:00
Régis Hanol
28c54b42c5
FIX: wasn't able to update user options anymore
2017-09-26 20:00:10 +02:00
Robin Ward
460ed3c8cf
Revert "Allow `NotFound` to specify an optional `Location` for the resource"
...
This reverts commit 4ae66c9e01
.
2017-09-26 12:58:24 -04:00
Régis Hanol
e687a1e8e3
UX: visited style wasn't applied to PM on mobile
2017-09-26 18:13:32 +02:00
Robin Ward
06072b3d99
UX: Pending Posts at the bottom of topics looked wonky
2017-09-26 10:27:24 -04:00
Robin Ward
451340d058
UX: Round up dates
2017-09-26 10:13:34 -04:00
Robin Ward
9e17fd8907
FIX: Support for menu glyphs that are optional
2017-09-26 09:50:43 -04:00
Robin Ward
faa37c3070
FIX: Missing "no activity" message.
2017-09-26 09:37:53 -04:00
Robin Ward
85eae96a11
UX: Cancel button looked ugly on post warning modal
2017-09-26 09:23:50 -04:00
Robin Ward
4ae66c9e01
Allow `NotFound` to specify an optional `Location` for the resource
2017-09-26 09:10:18 -04:00
Guo Xiang Tan
367fb1c524
FIX: Onebox fails on encoded URL.
...
https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364
2017-09-26 18:34:54 +08:00
Guo Xiang Tan
69e170efe8
Require right dependency.
2017-09-26 17:28:53 +08:00
Jeff Atwood
fda65a52ea
Merge pull request #5204 from discourse/web-share
...
FEATURE: Use new WebShare API on supported platforms
2017-09-26 02:16:54 -07:00
Guo Xiang Tan
6f5051861c
Remove unused option.
2017-09-26 14:47:38 +08:00
Guo Xiang Tan
5d37f8673b
PERF: Only send down suggested payload when loading last chunk.
2017-09-26 14:42:27 +08:00
Guo Xiang Tan
c37598ddbc
Merge pull request #5200 from gschlager/embed
...
FIX: do not escape already escaped chars in URL
2017-09-26 09:07:57 +08:00
Rafael dos Santos Silva
796e1d4c17
FEATURE: Use new WebShare API on supported platforms
2017-09-25 19:15:28 -03:00
Robin Ward
b0eab6756d
UX: Weird alignment issue on flags
2017-09-25 16:29:48 -04:00
Robin Ward
7eeb5188bf
FIX: Broken word wrapping on flags page
2017-09-25 16:22:40 -04:00
Robin Ward
073b74cf3f
FIX: Linting and broken test
2017-09-25 13:11:41 -04:00
Robin Ward
cb78ffd328
<<<<<<< HEAD
...
=======
>>>>>>> FEATURE: Add ability to claim topics on flagged topics page
Bump Plugin API version
2017-09-25 12:28:01 -04:00
Robin Ward
d1ebc62065
The ability to display errors on flagging actions.
2017-09-25 12:28:01 -04:00
Robin Ward
e809996c2a
Allow `modifyClass` to operate on optional classes.
...
This is useful if you want to modify an admin class that might not be
present for regular users.
2017-09-25 12:28:00 -04:00
Robin Ward
09ed2ed749
Add Suspend User to flags page
2017-09-25 12:28:00 -04:00
Robin Ward
079f108ceb
UX: Improve interface for flagging with many flaggers
2017-09-25 12:28:00 -04:00
Robin Ward
64fae87470
FIX: `Object.assign` is not fully supported
2017-09-25 12:28:00 -04:00
Robin Ward
8323e22d0c
Rename `auto-update-input` to more accurate `future-date-input`
2017-09-25 12:28:00 -04:00
Robin Ward
6bce3004d9
UX: Nicer selection of suspend duration
2017-09-25 12:28:00 -04:00
Robin Ward
677b016387
Send a suspension message via email to a user
2017-09-25 12:26:41 -04:00
Robin Ward
2a56cf8bb6
Tests + Refactoring for Suspension Modal
2017-09-25 12:26:06 -04:00
Robin Ward
6e48884274
Extract out common "cancel" link functionality from modals
2017-09-25 12:25:15 -04:00
Robin Ward
4020409bbf
Add support for suspension message
2017-09-25 12:25:14 -04:00
Robin Ward
daceeb9700
Refactor user suspension modal
2017-09-25 12:25:14 -04:00
Robin Ward
561fa7d0cd
FEATURE: Site Setting to hide suspension reason on the public profile
2017-09-25 12:25:14 -04:00
Robin Ward
d7c37d9369
Add front end service for staff controls
2017-09-25 12:25:14 -04:00
Robin Ward
5cf50f0034
Adjust flagged posts to use the store
2017-09-25 12:25:14 -04:00
Robin Ward
5fd3b6615b
Remove some `Discourse.Site` constants
2017-09-25 12:25:14 -04:00
Robin Ward
cc1a461254
Convert flags admin to flexbox
2017-09-25 12:25:14 -04:00
Robin Ward
1af4acbb3d
Add tests to flagged topics
2017-09-25 12:25:14 -04:00
Robin Ward
5e69217793
Add filtering support to flags
2017-09-25 12:25:14 -04:00
Robin Ward
be0eb0a554
Refactor flagged posts into components
2017-09-25 12:25:14 -04:00
Robin Ward
40eba8cd93
FEATURE: View flags grouped by topic
2017-09-25 12:25:14 -04:00
Robin Ward
bbbd974487
REFACTOR: Convert admin flagged posts to a component
2017-09-25 12:25:14 -04:00
KAJATIGER
3d2ded5d14
adding a tagName field
2017-09-25 19:22:50 +05:30
KAJATIGER
e868956412
adding a button at a new plugin outlet location in backup#index
2017-09-25 19:22:50 +05:30
Guo Xiang Tan
4e5e7dc736
FIX: Fix ActiveRecord API that was removed in Rails 5.1.
2017-09-25 16:16:37 +08:00
Guo Xiang Tan
88555f32cf
Improve specs.
2017-09-25 13:49:00 +08:00
Guo Xiang Tan
e542884b00
FIX: Incorrect notification state being published.
2017-09-25 13:48:59 +08:00
Guo Xiang Tan
23b787e0a6
Require dependency otherwise it causes Sidekiq to lock up in development.
2017-09-25 13:48:59 +08:00
Guo Xiang Tan
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
Gerhard Schlager
6f6b47f096
FIX: do not escape already escaped chars in URL
2017-09-22 17:36:44 +02:00
Gerhard Schlager
1a435414d5
FIX: handle URL encoded email addresses
2017-09-22 14:26:06 +02:00
Leo McArdle
68d7c08f4d
pass model to user-preferences-account plugin outlet
2017-09-20 21:59:43 -04:00
Joffrey JAFFEUX
2a17684546
FIX: do not display uncategorized as a possible parent category
2017-09-20 20:47:50 +02:00
Gerhard Schlager
87b4246c14
FIX: notify about whispered reply
2017-09-19 15:51:10 +02:00
Henrik Nyh
77cc33b231
100.years.ago -> Time.at(0)
...
A bit more robust ;)
2017-09-19 08:48:50 +01:00
Gerhard Schlager
a5408650bd
FIX: composing a message to a group via URL didn't work
2017-09-18 17:04:12 +02:00
Joffrey JAFFEUX
81def3b8b4
FIX: regression preventing display of custom emojis in the picker
2017-09-18 09:38:18 +02:00
Régis Hanol
efbbf3167e
remove debugger
2017-09-16 01:33:37 +02:00
Régis Hanol
8ed318c4fe
display 'similar to' earlier when composing a post
2017-09-16 01:03:29 +02:00
Jeff Atwood
dd101e4f1d
Merge pull request #5189 from discourse/jomaxro-patch-1
...
Add CSS targets to nav pills
2017-09-15 12:01:41 -07:00
Robin Ward
e4e27a4b83
New API for replacing an icon
2017-09-15 13:54:47 -04:00
Robin Ward
ad77634854
FIX: More CSS regressions with notifications in non-english
2017-09-15 13:24:43 -04:00
Joshua Rosenfeld
38057be0c1
Add CSS targets to nav pills
2017-09-15 10:54:10 -04:00
Joffrey JAFFEUX
5acf3504bf
minor changes to emoji-picker
...
- refactoring of globals
- removing autofocus, causing issues on mobile
- improve unbinding of listeners
2017-09-15 16:03:28 +02:00
Régis Hanol
8b7089c126
UX: topic links were all grey to anonymous users (regarding of their visited state)
2017-09-15 12:12:39 +02:00
Neil Lalonde
0bcde4b4f4
UX: reduce height of textarea for flags of type "Something Else" on small mobile devices
2017-09-14 15:18:57 -04:00
Robin Ward
38064c5776
FIX: Broken notifications in non-english locales
2017-09-14 14:26:31 -04:00
Régis Hanol
797936d2c5
FIX: don't leak whisper count in user card
2017-09-14 20:08:16 +02:00
Neil Lalonde
39adf2588a
FIX: don't mute topics when dismissing unread
2017-09-14 14:02:55 -04:00
Joffrey JAFFEUX
7f69ace112
FIX: makes sure select-box is under header and over avatar on mobile
2017-09-14 19:59:32 +02:00
Joffrey JAFFEUX
562e48dfb7
adds a dsl to simplify testing of the select-box
2017-09-14 19:50:32 +02:00
Neil Lalonde
16fe7aa307
FEATURE: automatically handle flags and posts that have been waiting in a queue for a long time. Flags will be deferred. Posts waiting for approval will be rejected. Control how old the records need to be with the auto_handle_queued_age site setting.
2017-09-14 12:01:06 -04:00
Robin Ward
42aea15070
Add some container DIVs for easier styling
2017-09-14 11:54:42 -04:00
Robin Ward
cb8918d034
It's bad practice to have `body` be the parent of everything
2017-09-14 11:24:14 -04:00
Robin Ward
8c2d6118ff
Remove some of the last few `fa-icon` helpers
2017-09-14 11:20:36 -04:00
Robin Ward
b2ffaf93a3
Use icon helpers for notification dropdown
2017-09-14 11:20:36 -04:00
Gerhard Schlager
f3d3129113
FIX: Use default locale for edit reason when owner of post gets changed
2017-09-14 17:17:37 +02:00
Gerhard Schlager
efef422416
FIX: Use default locale for moderator post when posts are moved
2017-09-14 17:17:37 +02:00
Arpit Jalan
4e49b3b140
FIX: do not create new email token if there already exists a confirmed one
2017-09-14 10:52:29 +05:30
Régis Hanol
7aa0d044de
FIX: link to sub-categories in group activity feed wasn't working
2017-09-13 23:14:46 +02:00
Joffrey JAFFEUX
7a4ddc2bb1
FIX: makes state of select-box more resilient to model changes
2017-09-13 18:44:40 +02:00
Régis Hanol
d9465bac13
add 'staged' column to user export
2017-09-13 18:09:11 +02:00
Régis Hanol
a6fc42753c
FIX: don't include last_wiki_edit when there's no revision
2017-09-13 17:46:58 +02:00
Régis Hanol
0096ee40da
FIX: only show participants the user can see
2017-09-13 17:14:03 +02:00
Robin Ward
e5db126a8e
FIX: Small fixes to enable better testing of components
2017-09-13 10:33:36 -04:00
Joffrey JAFFEUX
b537bf1ba4
FIX: better alignments of categories/tags in .topic-category
2017-09-13 16:24:36 +02:00
Jeff Atwood
11cc8ff52d
Merge pull request #5181 from vinothkannans/image-placeholder-styling
...
UX: Placeholder images color changed & tootip added
2017-09-13 02:49:34 -07:00
Vinoth Kannan
6e9671c2c3
UX: Placeholder images color changed & tootip added
2017-09-13 15:16:38 +05:30
Joffrey JAFFEUX
3713278a4b
FIX: reason paragraph styling broken on mobile
2017-09-13 10:24:02 +02:00
Joffrey JAFFEUX
64c154d9df
FIX: prevents click on select-box to close timeline-container on mobile
2017-09-13 10:00:10 +02:00
Guo Xiang Tan
26c6447161
Fix bugs in profiling scripts leading to incorrect results.
2017-09-13 15:33:59 +08:00
Neil Lalonde
7181fce71e
remove unused file pending_flags_mailer.rb
2017-09-12 18:00:51 -04:00
Neil Lalonde
beea5cac48
FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email
2017-09-12 18:00:51 -04:00
Neil Lalonde
6831efe2e9
FIX: no notification was being sent when a post is hidden by community flags
2017-09-12 15:43:44 -04:00
Robin Ward
9b3b39d8a2
FIX: Users should be able to activate their emails even if unapproved
...
Note in discourse `active` means "Email is active" - they still can't
login until approved
2017-09-12 15:04:39 -04:00
Leo McArdle
104d97695d
FIX: don't activate un-confirmed email on omniauth authentication ( #5176 )
2017-09-12 17:36:17 +02:00
Robin Ward
c097fbbdff
FIX: Don't append `.no-results` if there's nothing to display
2017-09-12 11:19:17 -04:00
Robin Ward
bc613e1df5
Adjust nesting of search divs
2017-09-12 11:14:13 -04:00
Robin Ward
171d9e5aed
SECURITY: Prevent users from updating to blacklisted email domains
2017-09-12 10:11:08 -04:00
Régis Hanol
85ef3696de
UX: show date of last edit on wiki topics
2017-09-12 15:37:47 +02:00
Guo Xiang Tan
51e1c0b6ce
Revert "FIX: Move check to right serializer."
...
This reverts commit 793f933b6b
.
2017-09-12 18:11:08 +08:00
Guo Xiang Tan
793f933b6b
FIX: Move check to right serializer.
2017-09-12 17:52:13 +08:00
Guo Xiang Tan
d3a409456f
PERF: Bypass AR and execute SQL directly.
2017-09-12 17:52:13 +08:00
Joffrey JAFFEUX
c06c88b479
cleaner title attribute for select-box
2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX
18114c7bdb
Revert "FIX: pinned-button sometimes not shown when unpinned is null"
...
This reverts commit 01f0b56331
.
2017-09-12 01:03:16 +02:00
Joffrey JAFFEUX
b875d17e1f
fix linter error
2017-09-11 23:51:42 +02:00
Joffrey JAFFEUX
2c284874b4
FIX: icon showing as null
2017-09-11 22:47:47 +02:00
Joffrey JAFFEUX
01f0b56331
FIX: pinned-button sometimes not shown when unpinned is null
2017-09-11 20:04:07 +02:00
Darren Lee
90dd1609eb
FIX: memoization in PostAnalyzer.raw_mentions ( #5172 )
...
Due to a missing 's' when assigning the computed value to @raw_mentions, the raw_mentions function in PostAnalyzer would never retrieve a memoized value.
2017-09-11 20:01:24 +02:00
Neil Lalonde
d7d9923b8e
FIX: display email validation error messages
2017-09-11 13:22:14 -04:00
Joffrey JAFFEUX
e924920bec
uses select-box for pinned-button
...
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
Régis Hanol
f1639bf4f5
make eslint happy
2017-09-11 16:49:09 +02:00
Régis Hanol
5a51953c8e
UX: '.visited' wasn't applied in categories view and suggested topics
2017-09-11 16:42:51 +02:00
Robin Ward
81e576ae37
FIX: Missing color on queued posts dropdown
2017-09-11 09:47:16 -04:00
Joffrey JAFFEUX
2708243584
FIX: makes sure the select-box doesn’t go over header
2017-09-11 11:23:46 +02:00
Joffrey JAFFEUX
b2dcb51e48
adds missing spacing around links in reason text
2017-09-11 10:42:53 +02:00
Joffrey JAFFEUX
7f9220a2cd
minor select-box fixes
...
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX
cf624bead0
FIX: cross browser issues on safari and edge
2017-09-10 22:25:31 +02:00
Joffrey JAFFEUX
6d6fe7b3a9
adds more specificity to .dropdown-select-box
2017-09-10 20:57:34 +02:00
Robin Ward
238557883f
FIX: queued posts had a red background
2017-09-10 14:26:55 -04:00
Robin Ward
87b4615eee
FIX: Bookmark icon was not coloured on mobile
2017-09-10 14:14:52 -04:00
Robin Ward
8e7e43a2d0
FIX: Duplicate class name
2017-09-10 14:09:29 -04:00
Joffrey JAFFEUX
4b558638c8
FEATURE: improves keyboard handling of select-box
...
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX
a11eec47bb
FIX: display localised title when using notifications-button
2017-09-10 11:38:52 +02:00
Joffrey JAFFEUX
bba26e48a0
FIX: positioning issues with notifications-button
2017-09-10 11:36:57 +02:00
Joffrey JAFFEUX
1f8695b16a
fix broken build
2017-09-09 20:58:37 +02:00
Joffrey JAFFEUX
950b9e9eaf
FIX: keeps as much as possible the same api for select-box components
2017-09-09 20:29:07 +02:00
Robin Ward
e6d3bbfa1d
FIX: Categories admin menu was missing
2017-09-09 09:21:43 -04:00
Joffrey JAFFEUX
8c3f7d9bbc
FIX: select-box width was incorrect on mobile
2017-09-09 02:41:31 +02:00
Joffrey JAFFEUX
753bf72921
FIX: adds correct spacing between footer buttons
2017-09-09 02:28:51 +02:00
Joffrey JAFFEUX
253672f3fa
makes notification-options design more compliant with existing design
2017-09-09 01:53:10 +02:00
Joffrey JAFFEUX
ab700d86ba
lighter icon color for categories-admin-actions
2017-09-09 01:52:36 +02:00
Joffrey JAFFEUX
a9aa11d7c4
use d-icon names
2017-09-09 01:48:03 +02:00
Joffrey JAFFEUX
5b9819f4ed
minor fixes to select-box
2017-09-09 00:49:33 +02:00
David Taylor
1def49cf6c
SECURITY: Only publish PM reply messagebus notifications to allowed users
2017-09-08 14:12:15 -07:00
Joffrey JAFFEUX
1d52231f42
FIX: css regression on category-dropdown-button
2017-09-08 21:28:28 +02:00
Joffrey JAFFEUX
cf6fb7622e
Replaces all notification-options like dropdowns with select-box
2017-09-08 20:47:39 +02:00
Robin Ward
f13776e550
UX: Move `.visited` to entire row, not just the link to a topic
2017-09-08 13:54:41 -04:00
Guo Xiang Tan
b7ac33464f
Reduce number of Redis calls.
2017-09-08 20:12:53 +08:00
Joffrey JAFFEUX
661ae38a03
FIX: makes sure we only autocomplete valid emoji tones
2017-09-08 09:42:13 +02:00
Arpit Jalan
6d35b62238
add image type attribute to icon link tag
2017-09-08 12:48:30 +05:30
Guo Xiang Tan
5d4221fbe1
PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Arpit Jalan
164a388dcc
Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
...
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
Robin Ward
f6fb94d31f
UX: Flags lost their red color on dropdown
2017-09-07 16:22:31 -04:00
Leo McArdle
e183600563
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-07 21:02:41 +01:00
Arpit Jalan
a9737e2813
Merge pull request #5133 from guoyunhe/patch-1
...
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
Joffrey JAFFEUX
d2d1c29f48
FIX: topic-notifications was taking too much space on mobile
2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX
3c0a9d4d19
FIX: topic-notifications taking too much space in timeline
2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX
5054065e81
FIX: broken spec
2017-09-07 19:18:27 +02:00
Robin Ward
afc075d93b
UX: Convert bookmark icon from CSS to a proper icon using our helper
2017-09-07 11:41:19 -04:00
Robin Ward
0ba789de17
Allow for customization of header dropdown icons
2017-09-07 11:18:59 -04:00
Robin Ward
8e88bf019f
Add `span` to various labels so they can be targetted
2017-09-07 11:10:11 -04:00
Joffrey JAFFEUX
70d0e175a2
FIX: default select-box-row should be aligned vertically
2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX
0374dc1a0e
FIX: keys were incorrectly set to category
2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX
633d2fde45
removes select-box minWidth property
...
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX
ca58a8228c
minor css fixes on select-box
2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX
d04aa5c7af
FIX: component height computation was wrong
2017-09-07 16:55:36 +02:00
Leo McArdle
0ce9098339
add admin-user-details plugin outlet ( #5141 )
2017-09-07 16:17:27 +02:00
David Taylor
7d350d0d75
Revert plugin js changes ( #5139 )
...
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134 )"
This reverts commit b840170f8d
.
* Revert "Do not load javascripts for disabled plugins (#5103 )"
This reverts commit a14ab48829
.
2017-09-07 15:15:29 +02:00
Joffrey JAFFEUX
dd27c0c80e
FIX: supports emojis in pinned topic excerpt
2017-09-07 11:06:04 +02:00
Guo Xiang Tan
4d840d10db
PERF: Reduce number of Redis hits per requests.
2017-09-07 13:34:27 +08:00
Robin Ward
a1957b7723
FIX: Stop moving notifications on large screens
2017-09-06 17:35:35 -04:00
Régis Hanol
8a935a4b5f
FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days
2017-09-06 22:35:08 +02:00
Joffrey JAFFEUX
0fca5ed533
FIX: stricter check on presence of notification_level_change
...
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
Robin Ward
825452df76
Refactor header CSS for composability
2017-09-06 11:34:10 -04:00
Robin Ward
777f024b8c
Clean up weird indentation
2017-09-06 11:34:10 -04:00
Joffrey JAFFEUX
ccf5005feb
FEATURE: uses select-box for topic-notifications-button component
...
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
David Taylor
b840170f8d
Add disabled_plugins to preloadstore for login_required anonymous users ( #5134 )
2017-09-06 12:18:58 +02:00
David Taylor
a14ab48829
Do not load javascripts for disabled plugins ( #5103 )
...
* Do not load javascript for disabled plugins
* Appease rubocop
2017-09-06 10:06:47 +02:00
Guo Yunhe
7d29ccf207
bbcode find close tag loop end condition
...
Only break loop when close tag has been found. Otherwise, keep searching until the end of string.
2017-09-06 09:13:57 +03:00
Guo Xiang Tan
8463b676df
Revert "Activate mini-profiler when in profiling env."
...
This reverts commit d61109388c
.
2017-09-06 11:26:03 +08:00
Guo Xiang Tan
d61109388c
Activate mini-profiler when in profiling env.
2017-09-06 11:19:20 +08:00
Guo Xiang Tan
672b7cb9a5
Require missing dependency.
2017-09-05 09:39:56 +08:00
Guo Xiang Tan
7786c6c6f2
Remove duplicated scope.
2017-09-05 09:15:06 +08:00
Robin Ward
51ffbf1c1f
FIX: Remove duplicate event typo
2017-09-04 15:39:58 -04:00
minusfive
fd91e53e68
Cleaned, de-duplicated/DRYed and organized discourse.css (common, mobile and desktop)
2017-09-04 10:56:28 -07:00
Robin Ward
db929e58fc
FIX: Don't allow staff to approve users with unverified emails
2017-09-04 12:55:39 -04:00
Robin Ward
be1cce503c
FIX: Don't bind events in `defaultState`
2017-09-04 11:48:36 -04:00
Joffrey JAFFEUX
afe6f46b03
merges after_save
2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX
caedefd675
FIX: correctly resets user_themes template
...
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Arpit Jalan
3b7128102c
FIX: disable follow in topic summary links
...
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
Guo Xiang Tan
5c1143cd55
Add missing test case for `PostController#timings`.
2017-09-04 16:36:02 +08:00
Arpit Jalan
ebbdd4fe0f
FIX: error when rebaking posts
2017-09-02 22:22:29 +05:30
Robin Ward
dfe347fb1d
FIX: Wizard tests don't need `Discourse` defined
2017-09-01 12:26:42 -04:00
Robin Ward
c6ff387ce9
Use more semantic names for various tracking icons
...
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron
46ebd0ee40
correct spec and allow for zero allowed iframes
2017-09-01 12:08:55 -04:00
Robin Ward
cb56dcdf2e
FIX: Use proper `iconNode` when compiling virtual dom templates
2017-09-01 11:20:33 -04:00
Vinoth Kannan
0fb7831749
FEATURE: Add placeholders to broken and large image files ( #5113 )
2017-09-01 10:26:13 -04:00
Sam Saffron
e283e6aea0
FEATURE: allowed_iframes site setting for allowing iframes
...
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive
b3b6eeff97
Ensure css applies to .user-main > .about icons regardless of tag
2017-09-01 06:32:27 -07:00
minusfive
611d62e4a5
Cleanup, deduplicate, debug user css, separated user-info component css
2017-09-01 06:32:27 -07:00
Robin Ward
dffb1fc4ee
FEATURE: Use Glimmer compiler for widget templates
...
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.
Example:
```javascript
createWidget('post-link-arrow', {
template: hbs`
{{#if attrs.above}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
{{fa-icon "arrow-up"}}
</a>
{{else}}
<a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
{{fa-icon "arrow-down"}}
</a>
{{/if}}
`,
click() {
DiscourseURL.routeTo(this.attrs.shareUrl);
}
});
```
2017-09-01 09:28:16 -04:00
Arpit Jalan
66f2925348
SECURITY: do not include links from whispers in topic summary map
...
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Robin Ward
ef0f346eec
Add custom style for header buttons
2017-08-31 12:10:54 -04:00
Joffrey JAFFEUX
56468582ee
FIX: visual regressions on title-wrapper
2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX
0957ac9ee2
FIX: minor css tweaks to title-wrapper
2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX
84e992363c
FIX: use maximum z-index for select-box when expanded
2017-08-31 00:55:05 +02:00
Robin Ward
75b2aa2edd
Better support for inline modals
2017-08-30 17:52:49 -04:00
Robin Ward
a48abc6556
Tweaks for better modal distinction between fixed/inline
2017-08-30 17:38:49 -04:00
Robin Ward
6361618188
`fixed-modal` is a better name
2017-08-30 15:52:29 -04:00
Robin Ward
3d95bac3fb
Migrate away from `#discourse-modal` to `.d-modal`
2017-08-30 15:29:51 -04:00
Robin Ward
8fcd5af5b1
UX: Use a template for the `d-modal` component
2017-08-30 15:20:49 -04:00
Robin Ward
64bb0f9f05
Add a class to target the sugested topics message
2017-08-30 13:50:39 -04:00
Robin Ward
3aed047b7e
UX: Add another div to aid in styling via flexbox
2017-08-30 13:43:56 -04:00
minusfive
5fd4970602
Cleanup nav-stacked .active state styles, remove unnecessary nesting
2017-08-30 09:14:56 -07:00
minusfive
8781c6bfcb
Removed unnecessary outer link-tos from admin/settings|watched-words navs
2017-08-30 09:14:56 -07:00
Joffrey JAFFEUX
746c5927e1
Replaces remaining {{category-chooser}} by {{category-select-box}}
...
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues
Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan
0a53c589c4
Fix linting.
2017-08-30 15:36:45 +08:00
Sam
9a861c1b43
Correct previous commit
...
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam
5cdb486332
UX: large topic creation area on mobile
...
This refines the iOS hack and allows for height 100%
on the composer
Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam
c705159d22
Remove email column from user table
2017-08-29 11:50:56 -04:00
Sam
b3fd091379
annotate stuff
2017-08-29 10:48:22 -04:00
Joffrey JAFFEUX
98c6c7e35a
FIX: css regression on select-box
2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX
cb4f690937
uses new select-box for quick topic edit
2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX
dcc5f93344
FIX: disable highlighting when no value set on select-box
2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX
21c4e38eec
clean select-box css
2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX
f101fec19c
FIX: improves uncategorized support for category-select-box
2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX
861dbe3b51
select-box refactoring
...
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joshua Rosenfeld
e3e6fd6ea0
FIX: Only show topic timer to staff
2017-08-28 23:49:30 -04:00
Sam
50203794e6
FIX: staged users should get emails on must_approve_users sites
2017-08-28 17:32:07 -04:00
Sam
41e7bdff38
FIX: don't refresh notifications in a tight loop
2017-08-28 16:52:00 -04:00