3c0de22bf0
FIX: wasn't able to remove a user's primary group
2017-08-04 18:13:20 +02:00
519b70ea46
FIX: always trigger the ':user_updated' event
...
We don't always use the UserUpdated class to update a user's record
2017-08-04 18:12:10 +02:00
99527af38a
FIX: show rejected emails with unrecognized errors ( #5026 )
...
Although 407a23663d
2017-08-04 16:20:44 +02:00
40fc6c429a
Merge pull request #5018 from discourse/wekbit-embedded-referer
...
FIX: First load of embed comments would always fail on WebKit
2017-08-04 14:12:26 +09:00
8cc8010564
Maintain backwards compatibility before `Jobs::MigrateUploadExtensions` runs.
2017-08-03 11:56:55 +09:00
a47e297508
Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
...
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
5942ad83c0
Skip inline onebox for domain only
2017-08-02 17:27:58 -04:00
65d5cd7239
FIX: generate valid markdown from <br></b> in an email ( #5022 )
...
* FIX: generate valid markdown from <br></b> in an email
* FIX: don't generate markdown for empty <strong> or <em> tags in emails
2017-08-02 23:02:59 +02:00
57a214e920
FIX: First load of embed comments would always fail on WebKit
2017-08-02 17:43:31 -03:00
a4e1920604
FIX: inline oneboxer not applying to lists
2017-08-02 16:10:08 -04:00
f6bc572fb8
FEATURE: option to enable inline oneboxes for all domains
...
Also, change to prefer title over open graph which is often way too sparse
2017-08-02 14:27:31 -04:00
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
3de45ce0cd
FIX: use case insensitive group name search when applying group rules from SSO
2017-08-02 11:30:37 -04:00
9bc3038728
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-02 21:33:56 +09:00
b6ce93a965
Add specs for 1c80c233cf
2017-08-02 20:58:35 +09:00
e43799134c
fix the regexp used to valide user's website
2017-08-02 10:19:24 +02:00
97fa64d846
FIX: non tag/category # searches should be passed through
2017-08-01 18:15:14 -04:00
71ad3a48c2
Correct flaky distributed cache test
...
make distributed cache more testable
2017-08-01 16:11:48 -04:00
5b76b9e888
Ensure that we cleanup after tests.
2017-08-01 23:42:26 +09:00
7d5b6e2b3c
Disable MessageBus's keepalive when Redis is readonly.
2017-08-01 23:07:52 +09:00
24edbbb89c
fix rubocop offenses
2017-07-31 20:34:02 -04:00
fa3c240e8b
Merge pull request #4981 from dmacjam/fix_limited_search_results
...
FIX: limited search results
2017-07-31 20:23:57 -04:00
836dee1120
FIX: add additional email to tests and clean up resulting mess
2017-07-31 22:27:29 +00:00
88ba052446
secure default for the 'find_related_post_with_key' site setting
2017-08-01 00:03:04 +02:00
cdf7a020c1
correct mistake in spec
2017-07-31 16:40:59 -04:00
7c1d7fb423
Merge branch 'master' into fix_limited_search_results
2017-07-31 15:55:31 -04:00
f1eccd113c
Replace rmmseg gem for cppjieba_rb since better dictionary ( #5006 )
...
* Rename locale to ts config in search module to make it clear
* Replace rmmese-cpp for cppjieba_rb
2017-07-31 15:28:48 -04:00
6c997b65d9
optimize enqueuing activation email code
2017-07-31 22:57:39 +05:30
0b01d0e95d
FIX: staff cannot manually activate accounts after 48 hours has elapsed
...
https://meta.discourse.org/t/staff-cannot-manually-activate-invited-accounts-after-48-hours-has-elapsed/66292/14?u=techapj
2017-07-31 22:24:09 +05:30
5d528f0d15
Merge pull request #4958 from dmacjam/search_posts_by_filetype
...
FEATURE: Search posts by filetype
2017-07-31 11:55:34 -04:00
4a5907b116
Merge branch 'master' into search_posts_with_images
2017-07-31 10:44:41 -04:00
f8edf2636c
Fix rspec tests for search pagination.
2017-07-31 12:16:23 +02:00
c7f76aa554
fix the receiver_spec
2017-07-31 11:29:39 +02:00
305b9b2da0
Add spec to ensure that even staged users contain a primary email.
2017-07-31 12:16:08 +09:00
24e0e000b9
FIX: Always validate presence of user's primary_email.
2017-07-31 11:47:29 +09:00
b059a0f789
extract url escaping to a dedicated class method and improved tests
2017-07-29 22:16:51 +05:30
1fe553873c
FIX: preserve fragment identifier when escaping url
2017-07-29 17:22:45 +05:30
56fd3e1cd4
attempt to stablise flaky spec
2017-07-28 16:59:37 -04:00
9a76559345
FIX: Remove unused test
2017-07-28 11:59:12 -04:00
4620dfe92d
FEATURE: Add group settngs to allow users to leave a group freely.
...
https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565
2017-07-28 15:00:25 +09:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
4f574e7c93
FEATURE: support inline bbcode blocks eg: [quote]test[/quote]
2017-07-27 17:55:17 -04:00
68b3dd43ce
fix intermittent failing tests, some watched word refactoring
2017-07-27 12:27:01 -04:00
75374c76b3
UX: Display button to message group on group page.
...
https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065
2017-07-27 17:51:25 +09:00
2442bba131
UX: Better group creation workflow.
...
* Owners and users can now be added to a group during creation.
https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3
2017-07-27 16:12:42 +09:00
dc42d4411d
correct flaky spec
2017-07-26 13:22:19 -04:00
24cb950432
FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block
2017-07-26 11:01:09 -04:00
27539e15e1
Allow whitespace around % scaler in markdown image syntax ( #5000 )
2017-07-26 10:54:20 -04:00
ea0e90b2b0
Merge branch 'master' into search_posts_with_images
2017-07-26 10:15:55 -04:00
b59dfb86f4
UX: Include group name in email when group is invited to a PM.
...
https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996
2017-07-26 15:51:44 +09:00
d3a975e99a
Improve specs to check top level stylesheets for SCSS compilation errors.
...
https://meta.discourse.org/t/fwd-growth-institute-pm-error-in-css-on-embed/66824/4
2017-07-26 10:50:51 +09:00
e3ac6585bd
FIX: Search by topic_id should not be restricted by `SiteSetting.min_search_term_length`.
2017-07-26 09:52:39 +09:00
96267f0845
Merge pull request #4960 from discourse/category-description-error
...
FIX: Explicit error when category description post is bad
2017-07-26 08:54:22 +09:00
658c2f52c0
add diagnostics for flaky test
2017-07-25 17:09:13 -04:00
ad8643bfe2
attempt to stablise spec in travis
2017-07-25 16:58:19 -04:00
ccbcbd0343
remove 2 failures that happen if discobot booted
2017-07-25 16:08:03 -04:00
a20bb931b1
FIX: specs failed if discourse-push-notifications booted
2017-07-25 15:52:53 -04:00
d8c27e3871
Merge branch 'master' into search_posts_by_filetype
2017-07-25 14:41:20 -04:00
d67fe4c674
FIX: block all emails associated to a user when destroying their record
2017-07-25 17:44:46 +02:00
f2d5bcd439
Stop writing to STDOUT/ERR during tests
2017-07-25 11:37:25 -04:00
c5b5c861f6
extend wait_for in case redis chokes up in test
2017-07-25 11:29:12 -04:00
4cd9822611
Remove warnings in `ColumnDropper.mark_readonly` test.
2017-07-25 09:38:55 +09:00
be3c9bca0b
Remove comment that is no longer relevant.
2017-07-25 08:58:40 +09:00
4da98cdcfe
FIX: allow bbcode to be unquoted for default
2017-07-24 18:36:17 -04:00
04eac9f14a
lets attempt to get these specs working!
2017-07-24 18:35:20 -04:00
f67e715ef1
comment out specs that break others
...
will check in a fixed spec tomorrow
2017-07-24 17:28:24 -04:00
c08a7aee8f
clean up skipped tests
...
tighter connection handling in scheduler
2017-07-24 15:06:24 -04:00
80bb127cd3
use time zone for extra safety
2017-07-24 13:08:17 -04:00
7ebb9874a8
freeze time in spec
2017-07-24 13:00:15 -04:00
40abcfc2f5
FIX: smart quote edge case with quotes
2017-07-24 12:21:49 -04:00
045a2abcec
FEATURE: remove the timecop gem
...
We should only have one way of mocking time, misuse of timecop
was causing build stability issues
2017-07-24 12:11:10 -04:00
d940166a89
Re-enable skipped `Scheduler::ScheduleInfo` test.
2017-07-25 00:03:03 +09:00
8ee31d3c85
Re-enable skip tests for `Email::Styles`.
2017-07-24 23:16:54 +09:00
e82efc7b03
Fix `SiteSetingExtension` specs to coerce int to string.
2017-07-24 22:54:42 +09:00
0ab0c82f11
Reenable skipped `Email::Receiver` spec.
2017-07-24 22:27:24 +09:00
6b17178533
Validate uniquness of `api_key`.
2017-07-24 21:46:08 +09:00
54b508dda3
Add back test to ensure user can't edit name after `SiteSetting.username_change_period`.
2017-07-24 20:47:34 +09:00
d9c3ebe299
Reintroduce specs that wasn't causing random failures.
2017-07-24 19:32:38 +09:00
640ced004d
FIX: wasn't unfreezing time in email processor spec
2017-07-24 11:01:53 +02:00
1b0750d7ef
Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups
...
Group owners can invite users to groups
2017-07-24 16:21:19 +09:00
fa09a02201
Fix specs.
2017-07-24 15:56:08 +09:00
25448b70e4
Fix specs.
2017-07-24 15:52:56 +09:00
c12edda766
Use `Timecop.freeze` instead of `Timecop.travel`.
2017-07-24 15:40:57 +09:00
86dbd76191
Fix random spec failure due to ordering.
2017-07-24 15:25:07 +09:00
7f1e74a272
Not sure how this spec actually worked in the past.
2017-07-24 14:13:23 +09:00
381a2a55be
Clear the cache after each test otherwise we are leaking state.
2017-07-24 11:41:37 +09:00
93f2c97266
simplify spec
2017-07-22 22:49:04 -04:00
687fbf5f09
simplify spec
2017-07-22 22:47:16 -04:00
b9757bd02e
remove readonly column specs for now
2017-07-22 22:20:57 -04:00
7caf82f03c
simplify spec
2017-07-22 22:01:11 -04:00
8ef4d6d812
this was failing erratically
2017-07-21 17:14:06 -04:00
2f8f2aa1dd
FEATURE: Whitelists for inline oneboxing
2017-07-21 15:41:47 -04:00
89ef5d36a9
FIX: Explicit error when category description post is bad
2017-07-21 16:07:29 -03:00
fff5e2c3a5
Merge pull request #4984 from LeoMcA/unrecognized-error-email
...
FEATURE: send rejection email for unrecognized errors
2017-07-21 20:40:18 +02:00
574681dc47
FIX: Show emoji in inline oneboxes
2017-07-21 14:24:48 -04:00
407a23663d
FEATURE: send rejection email for unrecognized errors
2017-07-21 18:26:52 +01:00
e1ce47a901
Pass the full CommonMark spec
2017-07-21 13:20:52 -04:00
ddc0134b48
add DiscourseEvent triggers necessary to update a user's permissions before they're notified
2017-07-21 11:03:54 -04:00
2a17f1ccd7
FIX: Group owners should be able to invite users to their groups.
...
https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12
2017-07-21 23:48:25 +09:00
4eb7f7cd10
Add rspec tests for search pagination.
2017-07-21 10:43:02 +02:00
fe05587134
Fix incorrect filename.
2017-07-21 13:37:32 +09:00
fc90dd3592
Work in progress, CommonMark spec
2017-07-20 17:47:16 -04:00
d2490cbbb8
Test failures for Inline Onebox
2017-07-20 16:01:16 -04:00
3882722195
FEATURE: Inline (Mini) Oneboxing
...
see:
https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400?source_topic_id=66066
2017-07-20 15:38:04 -04:00
44fb2a2833
DEV: support multiple capture groups for text post process
2017-07-20 15:33:44 -04:00
e7c170bb00
test v8 heap stats and aggregate all
2017-07-20 13:23:48 -04:00
1096dcd602
correct bbcode parsing edge case
2017-07-20 13:02:40 -04:00
911ffbb98c
Correct mention edge cases
...
@sam. was not correctly detected as a mention
2017-07-20 11:52:38 -04:00
d0b027d88d
FEATURE: phase 1 of supporting multiple email addresses
2017-07-20 11:22:27 +09:00
b534778f46
FIX: Escape URL before attempting to resolve it.
2017-07-18 10:04:24 +09:00
627f5ddbd1
Correct specs
2017-07-17 18:00:25 -04:00
c7b0764089
correct more edge cases with new engine
2017-07-17 17:44:48 -04:00
8921058c67
FIX: medium URL with @ incorrectly handled as mention
...
Also:
- remove unused code
- rename bbcode_ruler to bbcode.ruler
- add md.core.textPostProcess.ruler to apply at end of chain (excluding links)
2017-07-17 17:44:48 -04:00
cdb3706025
Track clicks on topics in search results
2017-07-17 15:42:32 -04:00
21e02d6969
Include the `search_log_id` in search results
2017-07-17 12:10:32 -04:00
d0c5205a52
Feature: Change markdown engine to markdown it
...
This commit removes the old evilstreak markdownjs engine.
- Adds specs to WhiteLister and changes it to stop using globals
(Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
6b6ad9391b
Clean up job for search logs
2017-07-14 14:30:58 -04:00
d7f783ffed
Replace search mock tests with integration test
2017-07-14 14:30:58 -04:00
97e211f837
FEATURE: Log Search Queries
2017-07-14 14:30:58 -04:00
9792e03c63
FIX: Group name was being reverted to non-localized version.
...
https://meta.discourse.org/t/localized-staff-group-names-changed/65360/16
2017-07-14 14:15:33 +09:00
79a084dd58
Revert "remove old markdown engine work-in-progress"
...
This reverts commit ee470b5317
2017-07-12 18:10:51 -04:00
bcbb9f208d
Revert "Integrate new engine, correct old specs"
...
This reverts commit f1b38ba4fb
2017-07-12 18:10:07 -04:00
3613ebee5b
Revert "correct specs"
...
This reverts commit 2c6284ece3
2017-07-12 18:09:57 -04:00
2c6284ece3
correct specs
2017-07-12 18:03:56 -04:00
f1b38ba4fb
Integrate new engine, correct old specs
...
corrects edge cases with
- full quotes
- [url] with nested tags
- engine overrides
- onebox applying to non http srcs
2017-07-12 17:44:40 -04:00
ee470b5317
remove old markdown engine work-in-progress
2017-07-12 17:44:40 -04:00
76981605fa
FIX: don't raise error when inviting existing user to private topic via email
...
https://meta.discourse.org/t/inviting-existing-user-to-a-private-topic-message-via-email-shows-error-message/65994
2017-07-12 21:51:21 +05:30
677267ae78
Add onceoff job for uploads migration of column extension. Simplify filetype search and related rspec tests.
2017-07-12 17:19:27 +02:00
5d139e461c
FIX: multi option poll not working (new engine)
2017-07-11 14:43:34 -04:00
1c917cc391
Added test.
2017-07-11 13:59:37 -04:00
3f950a756a
FEATURE: support image dimensions via Markdown image
2017-07-11 12:13:03 -04:00
45f4ce379e
Fix broken specs.
2017-07-11 13:16:48 +09:00
b605d5d61b
FIX: Translation should return overrides first before attempting to fallback.
...
https://meta.discourse.org/t/errors-after-migrating-to-a-new-version-1-9-0-beta3/65709/14?u=tgxworld
2017-07-11 12:51:12 +09:00
f529cb1674
Remove validation for invalid interpolation keys.
...
* Our codebase currently supports custom interpolations keys that are
not present in the original translation. The proper fix should
be to make `TranslateOverride` aware of such keys.
2017-07-11 11:12:11 +09:00
c5b1317a15
Remove code that is no longer being used.
2017-07-11 11:11:51 +09:00
ba9898c5a9
FIX: smarter newline handling for <img> tags on line alone
...
Run all of pretty text spec on new engine
2017-07-10 12:22:15 -04:00
c66b9dcdbd
add 'us-east-2' S3 region
2017-07-10 15:36:38 +02:00
a338a7a53e
Fix the build.
2017-07-10 11:12:21 +09:00
2255724637
UX: Add validator for `SiteSetting#sso_overrides_email`.
2017-07-10 10:08:55 +09:00
f1a6449e4b
SECURITY: Remove disposable invite feature
2017-07-07 20:24:39 -04:00
fcfc895167
FIX: new sign-ups via google are added to groups
...
This fix ensures that users that are signing up via google oauth are
automatically added to any groups.
A similar fix will probably need to be added to other oauth providers.
2017-07-07 14:08:58 -06:00
a509146ea5
FIX: support non-english tags in tag input field
2017-07-07 14:48:08 -04:00
6f09df0deb
FIX: don't create tags autolinks inside links (new engine)
2017-07-07 13:04:25 -04:00
74f6894606
oops checked in a broken test
2017-07-07 11:08:04 -04:00
436b894f7a
FIX: mention not working after a newline (new engine)
2017-07-07 11:06:50 -04:00
13f3de4bf6
Nuke all `SiteSetting.stubs` from our codebase.
2017-07-07 15:09:14 +09:00
e7e16de3e0
Remove use of stubs in specs.
2017-07-07 13:18:53 +09:00
a4399c2eab
FIX: Translation overrides were not cached by locale properly.
2017-07-07 12:28:00 +09:00
5b67cd1937
Merge pull request #4956 from techAPJ/pm-recipients
...
FEATURE: new site setting to limit message recipients
2017-07-06 22:57:33 +05:30
7cffbc8ba8
FEATURE: new site setting to limit message recipients
...
New site setting `max_allowed_message_recipients` to limit message
recipients
https://meta.discourse.org/t/one-of-my-users-just-group-messaged-100-other-user-with-a-spam-offer/65612/7?u=techapj
2017-07-06 22:52:49 +05:30
8c445e9f17
Fix backend code for searching by a filetype as a combination of uploads and topic links. Add rspec test for extracting file extension in upload.
2017-07-06 19:19:31 +02:00
f0a674d620
Add extraction of upload extension. Add rspec test for search of post
...
with upload by extension.
2017-07-06 19:16:07 +02:00
e92acb4c40
FIX: `Jobs::PullHotlinkedImages#is_valid_image_src` returns true for a generic string.
2017-07-06 18:31:15 +09:00
fcb2f68565
FIX: duplicate topics and posts in summary email because user has muted tags and topics contain multiple tags
2017-07-04 16:12:10 -04:00
3964929c75
FIX: summary email excludes all untagged topics if user has muted some tags
2017-07-04 12:52:25 -04:00
a7a8ccb100
Merge pull request #4948 from tgxworld/fix_translation_fallback_not_using_overrides
...
FIX: Translation fallback was not using fallback's translation override.
2017-07-04 09:08:22 +09:00
d2ba543ed3
correct case where %20 decoded as space in auto link
...
correct case where onebox is not applied when url is decoded
2017-07-03 16:32:53 -04:00
340a3ee5cb
correct spec to handle not null visibility_level
2017-07-03 16:03:26 -04:00
845170bd6b
FEATURE: add support for group visibility level
...
There are 4 visibility levels
- public (default)
- members only
- staff
- owners
Note, admins and group owners ALWAYS have visibility to groups
Migration treated old "non public" as "members only"
2017-07-03 15:26:57 -04:00
c79418d334
DEV: Move RTL into lib where it belongs
2017-07-03 15:26:57 -04:00
984778d3ac
FIX: handle moving first post to a closed/archived topic
2017-07-03 21:21:20 +05:30
72c92b0f4e
FIX: include canonical meta tag on category pages
2017-07-03 13:25:22 +05:30
52e654b3ac
FIX: Translation fallback was not using fallback's translation override.
...
https://meta.discourse.org/t/discobot-falling-back-to-site-locale-is-not-using-customized-copies/65140
2017-07-03 14:52:27 +09:00
16d356ab4e
FEATURE: resending invite should include original custom message
...
https://meta.discourse.org/t/will-resent-invite-include-original-custom-message/64699
2017-06-30 18:13:33 +05:30
d941ed90d6
support for bbcode [code] blocks
2017-06-29 16:04:10 -04:00
de50d8cd35
Support for [email] [url] [img] bbcodes
2017-06-29 14:00:09 -04:00
e7b9b1312e
FEATURE: remove all invites
...
https://meta.discourse.org/t/remove-all-invitations-button-for-the-admin-panel/65207
2017-06-29 22:30:10 +05:30
c6b83f4714
Correct logic so hashtags are properly ignored in links
2017-06-29 12:48:20 -04:00
5e156fbe85
FIX: `Group.search` should look up `Group#full_name` too.
...
https://meta.discourse.org/t/mentioning-group-by-full-name-doesnt-work/63437/3
2017-06-29 16:37:59 +09:00
9294826f31
Allow inclusion of elided text from emails when sending to a category… ( #4844 )
...
* Allow inclusion of elided text from emails when sending to a category address
2017-06-29 13:03:14 +09:00
0e391a72a1
use custom whitelister for tables
2017-06-28 16:08:29 -04:00
cfbda863e8
implement unicode emoji replacements
2017-06-28 13:47:30 -04:00
b93edc9945
FIX: Make sure censored words are on boundaries in topic titles
2017-06-28 13:13:40 -04:00
4c5109ff5b
FEATURE: site setting for Markdown typographer
...
It ships anyway with markdown.it so we might as well expose it
2017-06-27 16:50:13 -04:00
0d62420cbe
Space prior to onebox stops onebox resolution
2017-06-27 16:16:17 -04:00
232de90607
explicit autolink should not be oneboxed
2017-06-27 15:34:16 -04:00
5897ae945a
FIX: stop using inline quote for local onebox
2017-06-27 10:57:38 -04:00
0e0092d738
corrected a parsing edge cases for bbcode blocks
2017-06-27 10:07:06 -04:00
cdf8baac3b
fix specs due to new default emoji set
2017-06-26 23:36:30 +02:00
21f7ac1f25
correct spec, require closing tag for bbcode blocks
2017-06-26 16:51:55 -04:00
db485ae0da
FIX: Support for skipping redirects on certain domains (like steam)
2017-06-26 15:38:43 -04:00
8967d50dc2
Clean up sanitization code
...
- remove html table test, this is soon to be deprecated
- move sanitization tests into pretty text.rb
- fix up whitelister so it makes a copy of options
2017-06-26 15:21:47 -04:00
69b2d64334
FIX: letter avatars in quotes on subfolders installs are broken
2017-06-23 17:12:13 -04:00
814c8804d4
correct text highlighting for no highlight
2017-06-23 14:35:46 -04:00
b7386958ed
don't leak state into other tests
2017-06-23 12:01:33 -04:00
234694b50f
Feature: CommonMark support
...
This adds the markdown.it engine to Discourse.
https://github.com/markdown-it/markdown-it
As the migration is going to take a while the new engine is default
disabled. To enable it you must change the hidden site setting:
enable_experimental_markdown_it.
This commit is a squash of many other commits, it also includes some
improvements to autospec (ability to run plugins), and a dev dependency
on the og gem for html normalization.
2017-06-23 12:01:33 -04:00
a9c0df0b58
FIX: always try to convert PNG to JPG when pasting an image
2017-06-23 12:13:48 +02:00
80e348d226
PERF: Speed up slow tests in our test suite.
...
Before
```
Finished in 7 minutes 23 seconds (files took 4.15 seconds to load)
7145 examples, 0 failures, 10 pending
```
After
```
Finished in 6 minutes 12 seconds (files took 4.41 seconds to load)
7145 examples, 0 failures, 10 pending
```
2017-06-22 11:23:31 +09:00
8fd915a11a
Revert "FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out"
2017-06-21 16:18:24 -04:00
aaaa93c216
FIX: Full page search was removing advanced search terms
2017-06-21 15:51:15 -04:00
6796de8bf2
FIX: replace site_name with email_prefix in subject when use_site_subject is true
2017-06-21 21:15:49 +05:30
4c98bd9d5f
FIX: Can't update status_type of topic timers.
...
https://meta.discourse.org/t/topic-timers-internal-error-500/64805
2017-06-21 15:31:15 +09:00
aad1c9bef2
Add rspec tests for searching by a filetype.
2017-06-20 21:21:56 +02:00
1716747810
FIX: add path to cookies so sessions on the same domain but different subfolders don't log each other out
2017-06-20 13:30:36 -04:00
eaf46431d4
Add extraction of file extension in TopicLink and related rspec tests.
2017-06-19 17:09:54 +02:00
bf002e0873
Add extraction of image_url for oneboxed images. Fix search by images filter name.
2017-06-19 15:18:02 +02:00
b9fbc95ef4
Add spec to notify us when translations have invalid interpolation keys.
2017-06-19 12:39:30 +09:00
b24bdc5b20
FIX: discourse_hub_spec stub_request should include query params
2017-06-18 14:40:28 -05:00
c5f42f0e97
fix discourse_hub_spec
2017-06-16 15:31:13 -04:00
a6450f7377
REFACTOR: Allow `delete_removed_posts_after` SiteSetting to be bypassed.
2017-06-16 12:27:51 +09:00
d82dbd565b
FIX: Remove dependency on `rest-client`.
2017-06-16 09:42:41 +09:00
cae09ee4c8
Fix failing specs.
2017-06-16 09:39:54 +09:00
b5ec241716
FIX: Validate interpolation keys used in translation overrides.
...
https://meta.discourse.org/t/discobot-translation-missing-error/64429/6?u=tgxworld
2017-06-16 08:54:48 +09:00
eb9f306e64
FIX: fail to send email notification if post has img tag with no src attribute
2017-06-15 10:36:19 -04:00
ac1f84d3e1
SECURITY: theme key should be an anon cache breaker
2017-06-15 09:36:27 -04:00
f1750be2be
Fixes woman_shrugging name conversion
2017-06-15 08:26:29 +02:00
b5249fb4ca
FIX: Send request membership PM to last 5 active group owner.
2017-06-15 11:37:09 +08:00
b98a930364
Merge pull request #4896 from dmacjam/multiple-tags-logical-and-search
...
FEATURE: Advanced search supports logical AND of multiple tags
2017-06-14 14:39:23 -04:00
d6c63cc5b2
FIX: user's default group should only be set once
...
Setting a user's default groups based on their email address should only be done once, ie. when they confirm their email address.
Previously we were doing this everytime we'd save a user record 🤷
2017-06-14 19:20:18 +02:00
95e1843d33
Improves native emoji conversion
2017-06-14 17:42:52 +02:00
ab6086bce9
Transforms native skin toned emojis to valid names
2017-06-14 15:35:37 +02:00
2fdf9068eb
FIX: Create notification for group users when group has been invited.
...
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509
2017-06-14 14:53:49 +09:00
299339a373
Fixes emoji name to code missing tones
2017-06-13 14:10:26 -04:00
34996b4eff
FIX: show invite validation error message in response
2017-06-13 22:41:53 +05:30
009f0921dc
FEATURE: Whitelist hosts for internal crawling
2017-06-13 12:59:54 -04:00
826f332766
Merge pull request #4901 from jjaffeux/emoji-5.0
...
Emoji next
2017-06-13 11:12:41 -04:00
5d63a7f4a6
FIX: pull hotlinked images even when they have no extension
2017-06-13 13:27:05 +02:00
a5d3abc9b6
FIX: Create group membership request on behalf of user.
2017-06-13 17:49:21 +09:00
54e8fb0d89
FEATURE: new 'allow_staff_to_upload_any_file_in_pm' site setting
2017-06-12 22:41:29 +02:00
a3729b51eb
FIX: Always allow the host the forum is hosted on
2017-06-12 13:22:51 -04:00
b9c94aa234
FEATURE: add required user fields to invite accept form
...
UX: make "accept invitation" page consistent with sign up modal
2017-06-12 20:43:07 +05:30
eab3562864
Merge pull request #4905 from tgxworld/strip-zero-width-chars-from-search-term
...
FIX: Strip zero-width characters from search terms.
2017-06-12 18:01:02 +09:00
5994c85ea9
FIX: Raise the right error when email params is missing.
2017-06-12 17:48:32 +09:00
e888369f51
UX: Don't send emails for discobot notifications.
2017-06-12 17:00:27 +09:00
b5bead1fe3
FIX: Don't use `target=_blank` for local oneboxes
2017-06-09 12:15:36 -04:00
76712da166
Add backend code for searching posts with images.
2017-06-09 10:30:21 +02:00
602e4d0da4
FIX: Return `nil` when the `reply_key` is missing
2017-06-08 14:28:48 -04:00
038454bde2
FIX: always confirm emails when SSO says so
2017-06-08 01:05:33 +02:00
e8f0771dc9
FIX: the 'clean_up_uploads' jobs would delete images used in site settings
...
when they were entered using absolute URLs, with the CDN or simple a different format than the one used in the database
2017-06-07 22:53:15 +02:00
54bb2a6bc2
FIX: Don't redirect to wizard when resetting password
2017-06-07 12:36:52 -04:00
5794ff53a1
FIX: Copy custom fields when moving first post of a topic.
...
https://meta.discourse.org/t/transfer-poll-votes-when-moving-a-topic-into-an-existing-one/63678
2017-06-07 19:04:48 +09:00
684b05f510
FIX: Strip zero-width characters from search terms.
2017-06-07 18:19:47 +09:00
2cad739262
FIX: Better error message when username change fails.
...
https://meta.discourse.org/t/500-error-on-username-edit/64064
2017-06-07 10:45:53 +09:00
da736f70a4
Merge pull request #4845 from vinothkannans/download-onebox-images
...
FEATURE: pull onebox images
2017-06-07 09:55:04 +09:00
53b95f009f
FIX: If HEAD is not supported, try GET. Also set cookies
2017-06-06 13:53:49 -04:00
209383faab
FEATURE: pull onebox images
2017-06-06 18:51:58 +05:30
8f7d81fde6
Add rspec test for searching posts with images.
2017-06-06 14:39:53 +02:00
09d34b7642
emoji images are now v5 not v3
...
TODO: we should not hardcode this
2017-06-05 16:10:36 +02:00
ac6c1acbed
FIX: Groups that do not have any owners should not allow membership requests.
2017-06-05 10:02:37 +09:00
a10c939775
FIX: do not show website name on TL0 profile
2017-06-04 18:30:28 +05:30
a1ebd67237
Revert "FEATURE: new setting to prioritize open topics in search"
2017-06-03 01:54:35 +05:30
b8a87a0996
FEATURE: new setting to prioritize open topics in search
2017-06-03 00:33:53 +05:30
b4060778d9
FIX: you should always be allowed to see actions you created
2017-06-02 14:24:06 -04:00
096177d0d5
confirm we notify on the destination, not source
2017-06-02 11:20:40 -04:00
eaec35d230
Fix tag related advanced search tests into one context. Fix dynamic locale and select clause in search by all tags. Fix separator for all tags to plus sign.
2017-06-02 12:39:07 +02:00
af3dc4e537
FIX: Publish group's categories to user when adding user to group.
...
https://meta.discourse.org/t/joining-a-group-doesnt-take-effect-unless-the-browser-is-hard-refreshed/57357/11?u=tgxworld
2017-06-02 17:38:14 +09:00
a7fc93acac
FIX: post mover not clearing reply_to_user_id
2017-06-01 18:00:14 -04:00
2ee144c27f
FEATURE: Add DiscourseEvent trigger when a user logs in.
...
* Also adds a event trigger when user logs in for the first time.
2017-06-01 17:44:49 +09:00
bd486100c0
Remove stubs on DiscourseEvent in tests.
2017-06-01 16:21:00 +09:00
b0dd05fdc6
FIX: Inherit topic auto close when changing topic's category.
2017-05-31 17:40:21 +09:00
607998af33
FEATURE: dropdown to filter staff action logs
2017-05-30 11:25:42 -04:00
6d1fafaff6
Add rspec tests for advanced search by tags.
2017-05-30 13:01:17 +02:00
0aed2533ac
Revert unread optimisation, has too many edge cases
2017-05-26 09:04:13 -04:00
4d9481bf47
Fix build.
2017-05-26 16:04:59 +08:00
56f98de7b2
Use webmock to stub external web requests.
2017-05-26 15:19:09 +08:00
f8f1548fd4
Revert "FIX: Use Excon to do its own stubbing"
...
This reverts commit 80af54460a
2017-05-26 13:04:25 +08:00
e57d2f5cb8
FIX: Don't do anything if avatar url returns an invalid status code.
2017-05-26 13:02:40 +08:00
b584264d82
FIX: Don't show "resend email" option when user approval is on
2017-05-25 15:29:05 -04:00
29fac1ac18
PERF: improve performance of unread queries
...
Figuring out what unread topics a user has is a very expensive
operation over time.
Users can easily accumulate 10s of thousands of tracking state rows
(1 for every topic they ever visit)
When figuring out what a user has that is unread we need to join
the tracking state records to the topic table. This can very quickly
lead to cases where you need to scan through the entire topic table.
This commit optimises it so we always keep track of the "first" date
a user has unread topics. Then we can easily filter out all earlier
topics from the join.
We use pg functions, instead of nested queries here to assist the
planner.
2017-05-25 15:07:30 -04:00
cdbe027c1c
Refactor `FileHelper` to use keyword arguments.
2017-05-24 13:54:26 -04:00
f12490eae0
FIX: order:latest not working for search within topic
...
FEATURE: use 'l' as a shorthand for order:latest
2017-05-24 11:24:41 -04:00
3b0cbf7013
FIX: Always allow downloads from CDN
2017-05-23 16:32:54 -04:00
d2121ca272
FIX: Missing HTTP stub
2017-05-23 15:08:19 -04:00
b81e7be9a1
FEATURE: Rate limit how often we'll crawl a destination IP
2017-05-23 15:03:04 -04:00
36e477750c
FIX: Use same code path for downloading images
2017-05-23 14:51:30 -04:00
e5e7a15a85
SECURITY: Never crawl by IP
2017-05-23 13:07:18 -04:00
93a5fc62bf
FEATURE: A site setting to prevent crawling on private IP blocks
2017-05-23 11:56:06 -04:00
80af54460a
FIX: Use Excon to do its own stubbing
2017-05-22 18:19:20 -04:00
b51126dd5e
FIX: Reset the WebMock after before every test
2017-05-22 17:52:31 -04:00
9dddb81cf6
FIX: remove memoization on class method used in a job
2017-05-22 23:35:41 +02:00
4e8beda332
Merge pull request #4866 from JaredReisinger/admin-user-pagination
...
Add pagination to /admin/users/list API
2017-05-22 15:12:59 -06:00
d4b16b487e
FIX: Another onebox head request
2017-05-22 17:00:19 -04:00
a8d1e44943
FIX: Onebox will do a HEAD request first for redirects
2017-05-22 16:52:26 -04:00
4c690f7089
Use `FinalDestination` to ensure public redirects for onebox
2017-05-22 16:42:49 -04:00
b23fc2bf84
Helper to find the final destination for a URL
2017-05-22 15:52:41 -04:00
6231318462
Merge pull request #4877 from rimian/plugin_helper
...
FEATURE: Require spec helpers for plugins
2017-05-22 15:22:55 -04:00
a7f337fa93
FIX: CDN wasn't properly applied to category background images when using S3
2017-05-22 18:37:01 +02:00
76229535ac
Remove old test case.
2017-05-22 18:23:09 +08:00
08c36fa968
REFACTOR: Clean up some code associated with topic timers.
2017-05-22 18:10:29 +08:00
238a156300
FIX: `TopicTimestampChanger` should not allow timestamps in the future.
2017-05-22 16:03:49 +08:00
4382a0bb07
Rename `PostTimestampChanger` -> `TopicTimestampChanger`.
2017-05-22 15:01:33 +08:00
2b5dfb6e8e
avoid double lookup for plugin helpers
2017-05-22 14:50:53 +10:00
330338af3a
FIX: Don't hardcode text in smoke test.
2017-05-22 08:01:33 +08:00
908433a7a0
SECURITY: Validate the `entity` when downloading a CSV
2017-05-19 16:00:51 -04:00
28f486cb7a
FIX: Regular users shouldn't be able to invite to PMs if disabled
2017-05-19 12:57:21 -04:00
2b66918199
Wrong function call.
2017-05-19 22:33:06 +08:00
130e7f214b
Account for sites using text site logo in smoke test.
2017-05-19 22:25:08 +08:00
8ab9f30bbd
FIX: User can't remove bookmark from a deleted post.
2017-05-19 12:25:12 +08:00
8febaa8be7
FEATURE: Require spec helpers for plugins
...
* Follows any symlinked plugins
2017-05-19 12:38:36 +10:00
4fb335f1f0
FIX: don't process the same incoming email more than once
2017-05-18 16:43:07 +02:00
13e489b4ca
replace the upload type whitelist with a sanitizer
2017-05-18 12:13:13 +02:00
f4cc71d643
Allow username and password to be passed via ENV for smoke test.
2017-05-18 12:17:31 +08:00
cbe8e05f79
disable test that fails randomly
2017-05-17 12:46:50 -04:00
a0f03936ff
FIX: saving invisible primary group field that you don't belong to
2017-05-17 12:46:50 -04:00
a1b8a3b52b
FIX: supports bare <li> when converting html to markdown
2017-05-17 15:05:11 +02:00
92036616db
Make test less vulnerable to changes.
2017-05-17 19:30:13 +08:00
b0e4555a86
Allow Basic Authentication to be set in smoke test.
2017-05-17 19:24:43 +08:00
3df46833b3
Fix the build.
2017-05-17 16:14:06 +08:00
6a1f579c6e
FIX: don't search for plugins in nested subdirectories
2017-05-16 17:28:56 -04:00
645f648ea7
Merge remote-tracking branch 'upstream/master' into admin-user-pagination
2017-05-16 13:36:47 -07:00
763f156d91
FIX: require re-activation if SSO changes email and updates it
2017-05-16 16:18:18 -04:00
4b449914b8
FIX: admins could never remove self from messages
2017-05-16 16:06:24 -04:00
7821400141
FEATURE: staff can set a timer to remind them about a topic
2017-05-16 14:49:50 -04:00
dd0cb6a117
FIX: Add missing test
2017-05-15 16:57:09 -04:00
bd0bb879e5
FIX: Don't count likes from system users in the new user of the month
2017-05-15 13:14:32 -04:00
e1dd543a93
FEATURE: allow users to select theme on single device
2017-05-15 12:48:16 -04:00
44d7fe89ed
FIX: unescape emoji in pretty title
...
This makes emoji in title consistent, it is later escaped back when needed
2017-05-15 10:28:05 -04:00
8491f8c48b
add smoke test for visiting categories
2017-05-12 17:42:38 -04:00
62d245dde3
Try bumping the timeout for the smoke test
2017-05-12 16:40:38 -04:00
1dcd61fa34
Add pagination to /admin/users/list API
...
Prior to this, only the first 100 active/new/etc. users were available
via the `/admin/users/list` API. This change adds support for a
`page=#` querystring parameter so that *all* of the users can be
retrieved. Requests for pages past the last user result in an
empty-list response; requests for negative pages (or zero) just return
the first page.
Added tests to cover pagination.
2017-05-12 13:28:35 -07:00
1fb08d24d9
FIX: Latest onebox adds more attributes to links for security
2017-05-12 15:49:56 -04:00
8b9799507c
fix deploy problems due to renamed table
2017-05-12 15:17:25 -04:00
2d96a0785d
FEATURE: theme selection is now global per-user
2017-05-12 12:41:34 -04:00
47ce674798
PERF: bypass wizard check after 15 topics are created
2017-05-12 10:18:43 -04:00
b479aa0598
Set custom fields before saving in fabricator.
2017-05-12 14:01:31 +08:00
41711e53b7
Fix typo.
2017-05-12 10:31:31 +08:00
8eecd42856
FIX: Delete topic timer after completion.
2017-05-12 10:28:51 +08:00
55b61e9bea
rename topic_status_update to topic_timer
2017-05-11 18:27:53 -04:00
52ae63d5d7
FIX: when searching PMs also search group PMs
...
Users belonging to a group could not search for PMs unless explicitly added
to the PM unless admin
2017-05-11 15:59:03 -04:00
10f2db67ba
Add test for class_name in EmbedController
2017-05-11 15:16:16 -04:00
9b84cd832c
confirm in:private works for non staff
2017-05-11 15:06:45 -04:00
1019bbda46
FEATURE: set a timer to delete a topic
2017-05-11 12:52:29 -04:00
3ade46de0b
FIX: Don't send system message for new user of the month if disabled
2017-05-11 11:33:16 -04:00
9641d2413d
REFACTOR: upload workflow creation into UploadCreator
...
- Automatically convert large-ish PNG/BMP to JPEG
- Updated fast_image to latest version
2017-05-11 00:16:57 +02:00
7d9b5514ba
FIX: correctly invalidate theme css cache on scheme change
2017-05-10 15:47:11 -04:00
04b5516bf2
improve upload functionality
2017-05-10 15:47:11 -04:00
27362c5a4b
improve spec
2017-05-10 15:47:11 -04:00
bc0b9af576
FEATURE: support uploads for themes
...
This allows themes to bundle various assets
2017-05-10 15:47:11 -04:00
f709899a1d
Allow theme field object model to support uploads
2017-05-10 15:46:42 -04:00
4db76796b9
FEATURE: Setting to poll feeds more frequently
2017-05-10 14:30:12 -04:00
b57b635d30
FIX: Extract `div` tags within `span`s
2017-05-09 12:33:54 -04:00
c2829dce22
FIX: base sql vanishes after badge creation
2017-05-09 09:25:57 -04:00
55d3547540
Fix random test failure.
2017-05-09 11:27:05 +08:00
fc00032ec8
Check for 404 from spec rather than failure
2017-05-08 16:33:43 -04:00
addc85cd08
FIX: Don't let users edit wiki posts unless they can reply
2017-05-08 16:23:11 -04:00
009e120e13
FIX: Don't raise an error when the img attribute cannot be found
2017-05-08 15:35:31 -04:00
afe04b8bbb
FIX: Possible 500 error if category saved incorrectly
2017-05-08 15:17:58 -04:00
4f6e5fed2a
We don't need to raise an error when no post is present. Just noop.
2017-05-08 15:08:29 -04:00
96c59c5b82
FIX: Don't notify or return flags on system users
2017-05-08 13:13:35 -04:00
257c0dea70
Merge pull request #4852 from tgxworld/pull_the_plug_on_daily_mailing_list
...
Remove daily mailing mode option as it doesn't scale.
2017-05-08 09:10:46 -04:00
e89d0a6b20
FIX: importing a theme via file was broken
2017-05-08 12:03:24 +05:30
e61959e6a8
FIX: `CustomEmoji` may contain an invalid upload_id.
...
https://meta.discourse.org/t/white-screen-after-deleting-custom-emoji/61608
2017-05-05 14:53:38 +08:00
2b21e5ea7e
UX: Display translated group name for automatic groups.
2017-05-05 14:34:47 +08:00
71a266b673
Remove daily mailing mode option as it doesn't scale.
...
https://meta.discourse.org/t/daily-updates-option-for-mailing-list-mode/45029/14?u=tgxworld
2017-05-05 12:21:50 +08:00
441e0059af
Fix tests that was testing the wrong class.
2017-05-05 10:59:07 +08:00
777f1f0f47
FIX: Return a 404 if the auth session is not present
2017-05-04 15:35:24 -04:00
4ebbad991e
FIX: properly clean up related color schemes on delete
2017-05-04 14:03:17 -04:00
7a15b44ac3
rename on_remove, on_drop
2017-05-04 14:03:17 -04:00
6a6eed4ed2
DEV: column dropper class for cleaner removal of superflous columns
...
Also fixes issues during deploy cause target column was renamed in
theme_fields
2017-05-04 10:15:41 -04:00
4101db8b36
FIX: Invalid creation of `Theme` in wizard builder.
2017-05-04 11:44:23 +08:00
Régis Hanol
Leo McArdle
Guo Xiang Tan
Guo Xiang Tan
Sam
Rafael dos Santos Silva
Erick Guan
Neil Lalonde
Arpit Jalan
Jakub Macina
Robin Ward
David Taylor
Bianca Nenciu
Blake Erickson
Alberto Aguirre
Joffrey JAFFEUX
Vinoth Kannan
Rimian Perkins
Jared Reisinger
Pat David