Jarek Radosz
9a6e4b1fa1
FIX: Make InlineUploads handle more URL formats ( #9467 )
...
It previously failed to match URLs with characters other than `[a-zA-z0-9\.\/:-]`. This meant that `PullHotlinkedImages` would sometimes download an external image and then never use it in any posts.
2020-04-21 03:47:48 +02:00
Jarek Radosz
20f3be1e9c
DEV: Use the `type: :multisite` spec setting ( #9245 )
...
Fixes recent spec flakiness.
Also includes:
DEV: Prevent accidental exit from specs
2020-03-20 16:18:34 +01:00
Sam Saffron
e7cf4579a8
DEV: improve usability of subfolder specs
...
Previously people were not consistent about mocking which left internals in
a fragile state when running subfolder specs.
This introduces a simple helper `set_subfolder` which you can use to set
the subfolder for the spec. It takes care of proper configuration of subfolder
and teardown.
```
# usage
set_subfolder "/my_amazing_subfolder"
```
You should no longer stub base_uri or global_settings
2019-11-15 16:48:24 +11:00
Régis Hanol
0cfe47471f
FIX: add support for version query parameter in InlineUploads
2019-09-13 18:21:19 +02:00
Régis Hanol
aa511c5b59
FIX: support <img> in code blocks when inlining uploads
...
Simpler code is better :)
Also added moar specs to ensure <img> tag inside code blocks are properly ignored.
2019-09-12 21:25:14 +02:00
Vinoth Kannan
321f559c7c
FIX: make markdown regexp patterns case insensitive.
2019-09-12 22:25:15 +05:30
Sam Saffron
93b0ffc85c
DEV: improve subfolder inline logic
...
This follows up on #503a11cc88f with a spec
2019-09-11 12:02:42 +10:00
Sam Saffron
cd894b7d17
FIX: inline_uploads not working on subfolder setups
2019-09-05 15:32:33 +10:00
Guo Xiang Tan
faea594436
DEV: Extract common regexps for multisite.
2019-07-29 19:01:36 +08:00
Vinoth Kannan
4bbf341ab1
SPEC: add additional test with 'cdn_url'.
...
dc6b13e4d2
2019-07-17 11:16:35 +05:30
Vinoth Kannan
dc6b13e4d2
FIX: when 'raw' started with non-image upload url it's not converted to short-url.
...
dd0f0494c6
2019-07-17 11:13:50 +05:30
Vinoth Kannan
dd0f0494c6
FIX: convert hotlinked non-image urls to short url.
...
3840ace978
2019-07-17 09:15:09 +05:30
Vinoth Kannan
7890f10693
SPEC: improve the code readability
...
3840ace978
2019-07-16 19:21:16 +05:30
Vinoth Kannan
3840ace978
FIX: skip markdown conversion for hotlinked non image urls
2019-07-16 18:05:17 +05:30
Régis Hanol
155cad8b85
FIX: only add image size when with & height are in pixels
2019-07-05 20:34:11 +02:00
Guo Xiang Tan
7c86f16aa3
FIX: Support carriage return in `InlineUploads`.
...
Follow up to 8deaef3872
.
2019-06-21 14:07:06 +08:00
Guo Xiang Tan
8deaef3872
FIX: Don't replace img tags within anchor tags with markdown format.
...
Follow up to 9a25b0d614
.
2019-06-21 12:32:02 +08:00
Guo Xiang Tan
9a25b0d614
FIX: Edge case with anchor tag in `InlineUploads`.
2019-06-21 09:55:56 +08:00
Guo Xiang Tan
53efb7bd24
FIX: BBcode edge case for `InlineUploads`.
2019-06-20 11:47:51 +08:00
Guo Xiang Tan
34f382b758
FIX: `InlineUploads` should replace attachment links with markdown text.
2019-06-19 11:15:02 +08:00
Guo Xiang Tan
5d16d10a9e
DEV: Fix edge case for `InlineUploads`.
2019-06-14 13:48:03 +08:00
Guo Xiang Tan
befb074c98
DEV: `InlineUploads` should process CDN upload URLs as well.
2019-06-14 13:14:37 +08:00
Guo Xiang Tan
41abebcbce
DEV: Support both `http` and `https` for `InlineUploads`.
2019-06-14 12:48:31 +08:00
Guo Xiang Tan
7a0d031bc4
FIX: `InlineUploads` matching on external bbcode img url.
2019-06-13 13:47:36 +08:00
Guo Xiang Tan
782e583844
FIX: Edge cases with markdown references for `InlineUploads`.
2019-06-13 12:08:01 +08:00
Guo Xiang Tan
93c552afda
FIX: `InlineUploads` does not correct urls with uppercase extension.
2019-06-13 11:19:33 +08:00
Guo Xiang Tan
641521896c
FIX: Cover more edge cases in `InlineUploads`.
2019-06-12 17:06:58 +08:00
Sam Saffron
739696fdf0
DEV: improve spec to specify all code block formats
...
Previously we only covered a few, this covers a few more formats.
2019-06-12 18:34:30 +10:00
Guo Xiang Tan
73bf880f74
FIX: Correct more edge cases with `InlineUploads`.
2019-06-12 10:44:25 +08:00
Guo Xiang Tan
ff48fbdfda
FIX: `InlineUploads` raises an error when img tag is invalid.
2019-06-12 10:31:00 +08:00
Guo Xiang Tan
ee142c2173
DEV: More improvements to `InlineUploads`.
...
* Convert inline links to short path
```
<link> <link>
<link>
```
to
```
<short_path> <short_path>
<short_path>
```
2019-06-07 11:49:30 +08:00
Guo Xiang Tan
95db609586
DEV: Support more formats of inline images.
2019-06-06 15:50:56 +08:00
Guo Xiang Tan
5819e446dd
Make lint happy.
2019-06-04 16:14:21 +08:00
Guo Xiang Tan
1991af2abb
DEV: Switch `InlineUploads` to a regexp based implementation.
2019-06-04 15:54:25 +08:00
Guo Xiang Tan
d93e5fb00d
DEV: Class that converts MD with old attachment links to new MD.
2019-06-04 15:54:25 +08:00