806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
0f296cd42b
Refactor + Fix: Wasn't correctly loading activity streams. Code is a lot more Ember-y now.
2013-05-22 12:06:37 -04:00
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
45361934b9
User the BasicUserSerializer for the invited user
2013-05-21 12:03:51 -04:00
046e6e5d86
Simplified grouping on user views, fixed issue with messages not loading on initial load. Really
...
simplified the restricted user route.
2013-05-21 11:50:01 -04:00
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
7e3e6ab78d
icon tweak on merge/split
2013-05-20 12:34:15 -07:00
dee45d8dba
Changed `elementId` to be `id`
2013-05-20 15:31:05 -04:00
42248a7164
Removed many unnecessary paths that included `content.x` when just `x` would do.
2013-05-20 15:27:58 -04:00
9544cfd7dc
`target="controller"` is unnecessary. By default it will target the controller.
2013-05-20 14:37:05 -04:00
a79d53c628
Removed many unnecessary `controller.` uses in templates.
2013-05-20 13:45:14 -04:00
c7aebbf4d6
Replace Ember.Text* insertions with helpers.
2013-05-20 12:56:36 -04:00
1097d51b33
Replaced {{view Discourse.TextField}} with {{textfield}} helper.
2013-05-20 12:47:59 -04:00
b794830a25
Replaced `Em.run.next` with the more proper `Em.run.schedule('afterRender')`
...
when we are waiting for rendering to finish.
2013-05-20 12:20:10 -04:00
a3dce9afd7
don't error out on not posts if its a json request
2013-05-20 17:32:53 +10:00
fc57578c85
proper 404 for json request 404
2013-05-20 17:28:32 +10:00
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
546a2b654a
Improve style of security tab of category modal
2013-05-17 16:09:52 -04:00
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
2265c046ba
Some tweaks to category modal
2013-05-17 11:19:58 -04:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
8f46653345
refactor
2013-05-17 09:03:52 +10:00
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
7daca77443
Remove modal state to choose move type. Instead use two buttons on the multi select popup, one
...
for split and one for merge.
2013-05-16 14:22:41 -04:00
1e9497d9ef
FIX: Add unseen "*" icon on category list for new topics.
2013-05-16 13:36:58 -04:00
d554a59102
Support for a new site setting: `newuser_spam_host_threshold`. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
88417725b5
we need some, albeit hacky way of clearing these old pms, make at least some way of finding them
2013-05-16 17:30:30 +10:00
7e1c5ae5b7
glyph in secure categories to the right, like pms
2013-05-16 16:55:07 +10:00
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
27dfb7a948
FIX: @username mentions when there are multiple code blocks in a post.
...
Meta: [All of my internal users show as coming from 127.0.0.1!](http://meta.discourse.org/t/all-of-my-internal-users-show-as-coming-from-127-0-0-1/6607 )
This fixes the regular expression used to identify @ inside <code> or <pre> blocks in the `postConversion` hook.
2013-05-16 01:59:07 +02:00
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
b1bfda0e11
Don't show new user education when editing a reply.
2013-05-15 15:16:42 -04:00
ae78954fc0
Fix the 'no more topics' message for categories with non-ascii names
2013-05-15 11:44:45 -04:00
18634ad00d
Don't cache the problems list with the rest of the dashboard data
2013-05-15 11:09:12 -04:00
d4b8e727fc
Remove templateName from topic_closing_view because it doesn't use a template
2013-05-15 10:08:08 -04:00
05ed2af08f
Add post count to similar posts popup. Fix alignment.
2013-05-14 16:53:17 -04:00
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
008b308939
Fix: comma
2013-05-14 12:49:53 -04:00
101ba5d8fe
Add Create Topic button to /categories page
2013-05-14 12:47:28 -04:00
df2a718446
FIX: Load more user admin details, even when passed from a list
2013-05-14 12:03:46 -04:00
957d95c1cc
Fix rerender of topic close message when you navigate away from a closing topic
2013-05-13 16:25:17 -04:00
6d47d4854e
Don't reload the page when auto close time is changed
2013-05-13 16:25:17 -04:00
b7cdee4d5c
Add title tag to the admin options button in the composer
2013-05-13 16:25:17 -04:00
bdca804796
Add a touchend event to the admin menu. Hopefully helps IE11 Touch.
2013-05-13 15:29:16 -04:00
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
a27046bacd
fix cache hole
2013-05-13 11:09:03 +10:00
d68e3f7369
optimisations (cut down on category queries, cut down on expensive current_user query)
2013-05-13 11:07:22 +10:00
98d9f174ae
fix spec
2013-05-13 11:07:22 +10:00
8900ba4779
Fixes staticController bug with requiring an HTML response.
2013-05-10 18:52:10 -04:00
2f3dc63dd3
FIX: Oneboxes weren't being rendered
2013-05-10 18:50:05 -04:00
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
8ebed7a4b1
FIX: user education displays [object Object]
2013-05-10 15:15:21 +02:00
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
c1185d92eb
Trivial: Remove extra comma
2013-05-08 12:13:23 -04:00
0d8c962fdf
Fix: Multi-Select should close when an operation succeeds. A little refactoring, too.
2013-05-08 12:04:10 -04:00
4e16badeae
Merge pull request #833 from kubabrecka/admin_api_l10n
...
Localize admin API section
2013-05-08 07:39:02 -07:00
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
05bc63b102
Localize admin API section
2013-05-08 09:13:10 +02:00
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
6843ba7ed6
Fix regression: default to JSON type on GET requests.
2013-05-07 17:17:21 -04:00
52ee1928cc
Oops, I made a spec fail by refactoring after I made the test pass and didn't check the tests
2013-05-07 15:40:18 -04:00
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
bd99d5a40c
Calls to Discourse.ajax no longer need `getURL` -- will be done automatically.
2013-05-07 15:16:27 -04:00
0b4fc5d81c
Deprecate `success` and `error` in `Discourse.ajax`
2013-05-07 11:25:21 -04:00
6cbcd6e4a6
The last of the callback style AJAX have been converted to promises.
2013-05-07 10:58:41 -04:00
dfd423a188
Thanks JSHINT!
2013-05-07 10:33:04 -04:00
be191a95da
More promises instead of callbacks.
2013-05-07 10:27:12 -04:00
4200f4107b
Merge branch 'master' of github.com:discourse/discourse
2013-05-07 10:27:09 -04:00
4606cb4f3b
FIX: hide/show preview in composer preference is saved in local storage
2013-05-07 12:34:47 +02:00
20493106cd
fix post trashing
2013-05-07 17:56:56 +10:00
Matt Van Horn
Sam
Robin Ward
Navin
Chris Hunt
Jeff Atwood
Neil Lalonde
Leonard Garvey
Josh Susser and Avdi Grimm
Brian Plexico
Régis Hanol
Lee Machin
Kuba Brecka