e29f4a3496
Work in Progress: Reply By Email:
...
- Add support classes and settings to enable reply by email
- Split out Email builder to be more OO, add many specs
2013-06-13 12:39:56 -04:00
7f7ef29e42
Fix for message saying 'There are no more 29-category topics.'
2013-06-13 12:18:11 -04:00
ef18a3ad5c
Locales should be sorted in dropdown
2013-06-13 12:18:11 -04:00
3f03ce3c8c
Merge pull request #1018 from abbat/patch-1
...
pluralizationRules for Russian translation
2013-06-13 07:21:35 -07:00
cb40ceb9e8
Merge pull request #1019 from ZogStriP/reverse-index-of-user-uploads
...
added a reverse index of user uploads + rake task
2013-06-13 07:20:55 -07:00
f7de9f17d5
refactor validators
...
add a new setting for min pm body length
use that setting for flags
scale entropy check down for pms
2013-06-13 18:18:43 +10:00
875ee62d45
we don't need these move events, they always get in the way of me profiling cause they flood the uis with event
2013-06-13 13:17:26 +10:00
28853177fd
fix autoclose to work with jquery 1.9 and moment js
2013-06-13 12:03:44 +10:00
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
770c1faeb1
added a reverse index of user uploads + rake task
2013-06-13 01:43:50 +02:00
246148d4ff
Make topics invisible when first post is automatically hidden because of spam flags
2013-06-12 16:02:11 -04:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
2c68dd1c12
Put h3 footer messages inside the footer tag for easier styling
2013-06-12 13:02:48 -04:00
848bd01ecd
pluralizationRules for Russian translation
2013-06-12 20:04:40 +04:00
28ac110a3c
Add eu-west-1 to s3 regions
2013-06-12 12:02:47 -04:00
a104c37d63
Experiment: QUnit for integration Ember integration tests
2013-06-12 11:56:59 -04:00
8c888f424b
Fix change username
2013-06-12 11:24:32 -04:00
1a1115321d
Remove a console.log
2013-06-12 10:45:07 -04:00
5d7f22ed63
Include the latest class on the a tag in posters list
2013-06-12 10:45:07 -04:00
1ecdd73a71
Merge pull request #1016 from abbat/master
...
Russian translation (draft)
2013-06-12 07:44:51 -07:00
ae1f5b3de0
goodbye NaNy
2013-06-12 16:38:02 +10:00
2a43d70869
refactor
2013-06-12 16:00:43 +10:00
165751e71b
compact is better
2013-06-12 15:47:58 +10:00
d5b07464ea
partial fix for suggested js error
2013-06-12 15:24:45 +10:00
201891f51f
refactor and fix bug I introduced
2013-06-12 14:56:31 +10:00
eca2931a63
double notification is not really something we need.
2013-06-12 14:14:15 +10:00
f6060d5ff6
Russian translation (draft)
2013-06-12 06:58:16 +04:00
74041be23b
bring back some instrumentation
2013-06-12 11:47:03 +10:00
c1f6169b48
hidden and deleted state in user stream
2013-06-12 11:14:08 +10:00
6bf2f15610
use lodash cause we like lodash (faster and we can remove templating easily)
2013-06-12 10:23:47 +10:00
eb91a0c9df
Merge pull request #1012 from ZogStriP/extract-imgur-support-to-a-gem
...
Extract imgur support to a gem
2013-06-11 16:59:53 -07:00
334194ef82
Merge pull request #1013 from ZogStriP/replaced-lightbox-with-magnific-popup
...
replaced colorbox with magnific popup lightbox
2013-06-11 16:58:59 -07:00
48ee32f23e
Get value for each property in i18n helper
2013-06-11 16:42:12 -07:00
a362d62b42
Do not return mail password in EmailController
2013-06-11 16:00:13 -07:00
ba3d07ddcb
replaced colorbox with magnific popup lightbox
2013-06-12 00:32:48 +02:00
bddc9dd4b8
FIX: Replace modal with an empty view when closed. Fixes the bug where you'd edit a category, close
...
and then click edit again.
2013-06-11 16:41:09 -04:00
8a2d635e62
removed imgur support
2013-06-11 21:51:41 +02:00
a53f958c78
Fix error when trying to edit a category with empty slug
2013-06-11 15:43:07 -04:00
82b5f57e40
Make it possible to set a site setting to empty string
2013-06-11 14:31:38 -04:00
811a0df68b
Make s3 region site setting a drop down
2013-06-11 14:24:04 -04:00
ffde23f09f
FIX: Header was sometimes being shown twice in a topic
2013-06-11 13:31:07 -04:00
0cbf7c2417
FIX: Error viewing user page when not logged in.
2013-06-11 12:58:12 -04:00
82116d5db5
FIX: Change username view was not loading. Also you can always edit yourself.
2013-06-11 12:35:46 -04:00
8b4e3402c2
Small improvements to digest emails and preview mechanism.
2013-06-11 12:27:11 -04:00
45cff9c674
Merge pull request #1011 from chrishunt/add-parens
...
Add missing parentheses to moment()
2013-06-11 09:01:04 -07:00
d5c7e6b5f4
Add missing parentheses to moment()
2013-06-11 08:46:14 -07:00
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
c27d5dc2bd
regression, empty suggested list after posting a topic
2013-06-11 18:10:28 +10:00
c2cfbce9ce
automatically updating times for posts on topic
...
moved moment.js into localization file (we need to localize it)
added helpers for date formatting use, moment().shortDate() moment().longDate() moment().shortDateNoYear()
2013-06-11 17:25:50 +10:00
6d85dc1724
bring in unread items to "latest" as well as new items.
2013-06-11 15:51:43 +10:00
4d7a520a8c
don't render 0 ... also this file needs some love
2013-06-11 15:27:26 +10:00
4e01b84695
fix digest
2013-06-11 15:27:26 +10:00
fa8a84f20c
removed sugar.js, port functionality to moment and underscore.js
...
bring in latest ace from local so we don't mess up with https
2013-06-11 15:27:26 +10:00
eed5875505
fix bug with wrapping
2013-06-11 15:27:26 +10:00
a92bb46966
edit date to use formatter, compensate for invalid local time (at least don't blow up)
2013-06-11 15:27:26 +10:00
850123dce8
FIX: User Pill errors
2013-06-10 18:51:25 -04:00
ab5507ac06
Merge pull request #1002 from chrishunt/add-stack-exchange-onebox
...
Add Stack Exchange onebox
2013-06-10 12:38:03 -07:00
93bbe190c0
Moved Email components into a module
2013-06-10 15:34:10 -04:00
78000fe870
Fix category delete
2013-06-10 14:20:06 -04:00
9b1d0baf45
Send a message to moderators when a newuser_spam_host_threshold is exceeded. Send it no more than once per day per user.
2013-06-10 13:17:32 -04:00
0d83f373b8
Add some logic to jumpTop/jumpBottom when best of is enabled
2013-06-10 13:07:54 -04:00
1fb0b424ed
Add Stack Exchange onebox
2013-06-10 09:27:13 -07:00
3b7d3aa487
FIX: Search wasn't using the lowercase username for finding the context.
2013-06-10 10:42:06 -04:00
ad6705cca7
Update Ember to latest master (RC5)
2013-06-10 10:14:42 -04:00
b4a4774165
extend consumer email warning to yahoo & outlook
2013-06-10 00:08:06 -07:00
4f606ffd8e
Some minor cleanups
...
1. Change map to keys
2. Remove overshadow
3. Remove var
2013-06-10 10:38:10 +05:30
6a6496eedf
Merge pull request #995 from novemberkilo/master
...
Refactoring Post model
2013-06-09 16:19:06 -07:00
2d14b54096
Merge pull request #988 from chrishunt/add-dynamic-favicon
...
Add 'dynamic favicon' setting
2013-06-09 16:13:54 -07:00
3fdba0019b
Extract callbacks and validations for Post
...
Move Post create callbacks to PostCreate
Extract Post validations
Move stripped_length_validator to lib/validators
2013-06-09 20:47:04 +02:00
26f378e022
Merge pull request #989 from chrishunt/redirect-when-cant-edit
...
Fix RestrictedUserRoute
2013-06-08 07:16:22 -07:00
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
3bdfdd7c04
Redirect when can_edit === false or undefined
2013-06-07 22:09:51 -07:00
af1c14939e
Add 'dynamic favicon' setting
2013-06-07 17:15:49 -07:00
eab38b5c34
JSHint fix :(
...
)
2013-06-07 18:08:08 -04:00
b46b533e70
Create the composer view with the defaultContainer. This is in prep for redeploying
...
on RC5. Ideally we'll change how the composer is instantiated altogether but that will
have to wait for a future release.
2013-06-07 18:04:51 -04:00
a6f67d85eb
also should have caught this earlier
2013-06-08 07:47:48 +10:00
1e725629cd
no idea how this was even working
2013-06-08 07:45:45 +10:00
fa4cfa1269
ScreenTrack refactor - removes logic from TopicView didInsertElement
2013-06-07 17:20:10 -04:00
34e1f376f6
Add [PM] to subject of email notifications for private messages
2013-06-07 15:50:11 -04:00
463be6fadf
Merge pull request #982 from jd-erreape/add_scopes_to_roleable
...
Added role scopes to roleable
2013-06-07 12:08:26 -07:00
cdc3a57a91
Merge pull request #983 from ZogStriP/fix-combobox-not-working-properly
...
FIX: combobox were not working properly
2013-06-07 12:08:04 -07:00
3f5c12ca1b
FIX: combobox were not working properly
2013-06-07 20:45:31 +02:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
668a4a3042
Move MessageBus subscribing/unsubscribing out of view
2013-06-07 14:28:33 -04:00
5217602ec3
FIX: RSS paths render a 404 for missing topics.
2013-06-07 12:52:12 -04:00
36fe8fbc6d
Added role scopes to roleable
2013-06-07 18:26:06 +02:00
3ae72259a6
Merge pull request #979 from iancmyers/strong-parameters
...
All parameters for #create in PostsController pass through strong_parameters
2013-06-07 09:17:29 -07:00
7c715e76e8
Refactor: Light pass of didInsertElement calls of views
2013-06-07 12:13:46 -04:00
1b92d9d7f8
Added roleable module for User model
2013-06-07 12:33:48 +02:00
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
d1784f1f87
more moment goodness
2013-06-07 18:27:42 +10:00
000847b8d2
date helper uses the formatter now
2013-06-07 18:27:42 +10:00
5fa20ce357
more progress towards full migration to moment.js
2013-06-07 18:27:42 +10:00
2f59c5c513
Set line height on entire row, not two columns
2013-06-06 18:37:25 -07:00
d50a598e62
Notify admin of successful user approval
2013-06-06 18:37:25 -07:00
f6ce985121
Send activation email after user approved
2013-06-06 18:37:25 -07:00
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
1eed1e240b
Merge pull request #977 from chrishunt/add-apple-touch-icon
...
Add 'apple touch icon url' site setting
2013-06-06 17:40:12 -07:00
7ff42377ac
$.browser is gone from jQuery 1.9 ... and this is a check for ie7 and 6 ... don't care
2013-06-07 10:38:39 +10:00
6ed79e66bc
jquery 1.9.1 upgrade ... remove jquery rails
2013-06-07 09:12:46 +10:00
564d242832
Notify moderators when someone is automatically blocked because of spam flags
2013-06-06 18:49:19 -04:00
11afa0c11b
work in progress migrate to moment
2013-06-07 08:49:22 +10:00
268a5debbf
Add 'apple touch icon url' site setting
2013-06-06 14:43:05 -07:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
b758427572
Fix annoying jshint :)
2013-06-06 16:48:15 -04:00
ba5f2d23a1
Fixed ContainerView code to build views correctly
2013-06-06 16:45:25 -04:00
8f32aed944
Only use HTML templates for the digest email.
2013-06-06 15:08:56 -04:00
7bc80c2dcf
Changed HTML Digest template. Removed margins, shrunk logo.
2013-06-06 14:45:32 -04:00
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
f268b882fd
The posts rebake task should regenerate links too.
2013-06-06 13:52:30 -04:00
526f2af69a
FIX: Touch events conflicted on mobile safari with `{{action}}`s, preventing admin menu
...
option from working. Mobile Safari works with click so this seems to fix it.
2013-06-06 13:16:36 -04:00
06e83c9e6a
FIX: Hitting enter while the invite dialog is up should submit the form, not refresh the
...
entire page :)
2013-06-06 12:06:43 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
a3d62fdf69
Temporarily roll back ember rc5. We identified some things we need to fix.
2013-06-06 01:25:43 -04:00
255a614142
keep /srv/status exposed
2013-06-06 14:40:10 +10:00
7b70330e85
FIX: Javascript errors when navigating to some topics
2013-06-05 20:53:48 -04:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
4d1e8356b8
FIX: Again, try to get a flexible absolute logo_url
2013-06-05 18:23:43 -04:00
8328aa97fd
FIX: HTML email should use image_tag to get the correct path to the image
2013-06-05 18:01:40 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
eb673c7e5d
Merge pull request #963 from chrishunt/chrishunt/refresh-user-list-after-approval
...
Refresh admin user list after approval
2013-06-05 12:07:49 -07:00
112d57e899
Merge pull request #960 from iancmyers/strong-parameters
...
Began implementing strong_parameters
2013-06-05 12:03:17 -07:00
469bf044c3
Remove superfluous }
2013-06-05 21:54:07 +03:00
a523fa56ac
Don't require authentication for invites
2013-06-05 11:12:37 -07:00
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
8f14e46964
Hide registration on login modal if 'invite only'
2013-06-05 11:06:54 -07:00
24da1ab07e
Add 'invite only' site setting
2013-06-05 11:06:05 -07:00
7d089fdfb5
FIX: Compile templates properly with the latest handlebars
2013-06-05 14:00:02 -04:00
07cd87f941
FIX: Couldn't navigate to Categories list via link
2013-06-05 12:40:06 -04:00
a0bd51862e
Upgrade Ember to RC5. Disabled a deprecation warning that I believe is in error.
2013-06-05 12:07:18 -04:00
f05c30ab8d
Refresh admin user list after approval
2013-06-05 08:57:25 -07:00
f0d4a38433
Admin flags UI shows when it's loading and when there are no results
2013-06-05 10:24:50 -04:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
913a607528
need to punch through account creation stuff
2013-06-05 14:01:24 +10:00
2dfba8d6de
we need to be able to do username checks for registration to work
2013-06-05 12:50:42 +10:00
2509d0f4fa
Merge pull request #959 from chrishunt/chrishunt/login-required-fixes
...
'login required' site setting improvements
2013-06-04 19:09:40 -07:00
93be638d93
message format is awesome, remove 0 unread and 0 new links.
2013-06-05 12:04:54 +10:00
3074300f76
Allow customization of 'login required' message
2013-06-04 18:53:36 -07:00
3774808a6e
Redirect to '/' if OmniAuth login from '/login'
2013-06-04 18:35:20 -07:00
e52e46a609
fix blank created_at .. date is unbound, we should rename it to unboundDate
2013-06-05 11:32:53 +10:00
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
28aeb1d36c
Remove static navigation from login page
2013-06-04 18:20:03 -07:00
5e305eaf0a
missing skip filter for omniauth
2013-06-05 10:30:51 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
56ee7cdc1f
Merge pull request #956 from ZogStriP/fix-image-upload-to-s3
...
fix image uploads on s3/imgur
2013-06-04 16:34:42 -07:00
5f85aaee1d
correct message bus regression
...
implement automatically updating dates in list
2013-06-05 09:32:44 +10:00
122f9188c9
Redirect Ember routes to login if login required
2013-06-04 16:10:10 -07:00
789289a290
Show login modal on header buttons if required
2013-06-04 16:10:10 -07:00
978785720a
Redirect to root after login if no path provided
...
If we do not do this, then people that login from /login will just be
redirected back to the login page. We'd rather have them see the root
path.
2013-06-04 16:10:10 -07:00
92a4828f72
Redirect all controllers to login if required
...
We want to skip the filter for sessions controller so that we can login
and we want to skip the filter for static pages because those should be
visible to visitors.
2013-06-04 16:10:10 -07:00
85ceb5efa7
Add 'login required' site setting
2013-06-04 16:10:10 -07:00
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
f58dd7a6fb
Set properties of AdminApi after ajax response
2013-06-04 11:05:44 -07:00
11e703f6a0
Merge pull request #953 from chrishunt/chrishunt/fix-featured-topic
...
Add missing handlebar in featured_topics template
2013-06-04 10:31:44 -07:00
02b1f78410
FIX: Include preloaded data even if the request type isn't explicitly text/html
2013-06-04 12:56:12 -04:00
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
2259e97d42
Add a count of blocked users on the dashboard
2013-06-04 11:53:19 -04:00
5ef4bcdecc
Add missing handlebar in featured_topics template
2013-06-04 08:33:47 -07:00
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
24131bcc0e
correct regressions, not loading topics on click
2013-06-03 19:03:57 +10:00
978bc0ca4e
auto refresh suggested list
2013-06-03 14:54:51 +10:00
3ef16f292d
remove dead code
...
update title properly when count in list changes
remove broken (*) title notification from topic cause its just weird
2013-06-03 10:38:57 +10:00
1833c124d9
FIX? : Sometimes preloaded data is missing
2013-06-02 14:05:38 -04:00
33d0a6a876
FIX: Safety checks for categories index
2013-06-02 11:20:08 -04:00
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
0606725b29
fix some /tos and /privacy issues
2013-05-31 16:43:29 -07:00
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
476ffcc627
make delete user button a Danger Button
2013-05-31 12:50:11 -07:00
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
2982c23265
add quotes around favicon URL
2013-05-31 12:18:41 -07:00
a4d88fbaa7
New categories weren't getting correct default colors
2013-05-31 13:42:46 -04:00
fea3f326a9
FIX: Persona login was not using promises
2013-05-31 13:16:14 -04:00
0af0a214b2
Refactor: Back all modals by controllers
2013-05-31 12:29:38 -04:00
830b7805e9
Merge pull request #927 from bplexico/extract_invite_redeemer
...
Extract InviteRedeemer from Invite
2013-05-31 08:30:42 -07:00
b35b3da077
allow eviction of computer help for @geek
2013-05-31 15:09:19 +10:00
b228a7c185
Merge pull request #923 from eriko/cas_support
...
remove hardcoded value and replace with SiteSetting.cas_domainname
2013-05-30 21:39:29 -07:00
d2c1eb090e
Merge pull request #921 from nirnanaaa/postgres-truefalse
...
removed t's and f's from models
2013-05-30 21:38:26 -07:00
41187a5de1
Merge pull request #931 from ZogStriP/more-file-upload-test-coverage
...
added more file uploads test for better coverage
2013-05-30 21:36:33 -07:00
e5f8297670
Merge pull request #928 from jd-erreape/master
...
Refactored some class methods to scopes in order to achieve a better 'Rails way'
2013-05-30 21:31:53 -07:00
6cc0f8f2d4
added more file uploads test for better coverage
2013-05-31 03:13:37 +02:00
42714b424f
For 403 errors, show the same html page as 404
2013-05-30 16:39:39 -04:00
afa519b3ae
Only pass searchContext type, id in search request
2013-05-30 12:54:34 -07:00
807f763fb0
Merge remote-tracking branch 'upstream/master'
2013-05-30 21:42:26 +02:00
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
b82a5dfd56
Move logic to reject slugs that are just numbers into the slug module
2013-05-30 11:54:02 -04:00
0591d5be11
Extract InviteRedeemer from Invite
2013-05-30 11:49:11 -04:00
7d5c313456
Don't allow category slugs that are numbers
2013-05-30 11:09:09 -04:00
5d444be72b
Support incomplete topic urls like /t/just-a-slug; fix error when using route /t/:topic_id/:post_number
2013-05-30 10:39:15 -04:00
3898d90142
fix bugs with sync being wonky
2013-05-30 20:44:53 +10:00
d20056ad0e
correct watcher, live updates for unread
2013-05-30 16:49:58 +10:00
6ad86aa305
read state is now published
2013-05-30 16:49:58 +10:00
8874c9ea75
Add message format support that can be used on complex localization strings
...
Add message about new and unread topics at the bottom of topics
move localization helper into lib
2013-05-30 16:49:57 +10:00
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
f2da06a78f
gmefile lock
2013-05-30 16:49:57 +10:00
90167e427b
highlight logic changed
2013-05-30 16:49:57 +10:00
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
33683715a9
work in progress live unread / new counts
2013-05-30 16:49:57 +10:00
33ff87bf44
work in progress, live unread / new counters
2013-05-30 16:49:57 +10:00
4e2c6f43d1
correct broken pm draft
2013-05-30 08:55:23 +10:00
364a59d344
remove hardcoded value and replace with SiteSetting.cas_domainname
2013-05-29 15:47:49 -07:00
830b93a16b
Reduced complexity of admin flags controller, split up into methods, moved reports into model.
2013-05-29 16:49:34 -04:00
364113a4d5
removed t and f 's from group model
...
removed t and f 's from user model as mentioned in #919
removed t's and f's from category model
2013-05-29 22:10:43 +02:00
5ae7707000
Refactor: Convert repeated {{view Discourse.xyz}} to registered view helpers
2013-05-29 15:14:31 -04:00
57d5355ce8
wat
2013-05-29 15:00:35 -04:00
4d5c145198
Refactor: Adds `Discourse.Utilities.registerViewHelper` to register view helpers
2013-05-29 14:32:39 -04:00
3d0587d8ce
Refactor: move category slug helper to Category model
2013-05-29 14:18:02 -04:00
fe3ac50aae
Use `{{aceEditor}}` helper to display the ace editor
2013-05-29 14:09:21 -04:00
0601bb6d74
Trivial JS clean up
2013-05-29 14:09:17 -04:00
6abd9ddd2d
Add warning on admin dashboard if production env is configured to send email through gmail
2013-05-29 14:00:35 -04:00
acb2623b4b
JSHINT: extra comma
2013-05-29 13:30:03 -04:00
9717a344c3
Refactor: Less reliance on views for logic for topic list
2013-05-29 13:28:07 -04:00
4cf1d9c266
Display details about the search context in the placeholder
2013-05-29 12:19:31 -04:00
b1bdebd611
url for uncategorized category topic list is always /category/uncategorized
2013-05-29 12:06:33 -04:00
f151b30044
Show excerpts on Categories page
2013-05-29 11:46:01 -04:00
2e26fca36b
FIX: Hitting ESC while autocomplete is open shouldn't close the composer.
2013-05-29 11:28:41 -04:00
5cb1cc6fcb
FIX: Categories pill wasn't always being highlighted properly.
2013-05-29 11:02:37 -04:00
27c1f1044c
FIX: Regression, messages were hidden
2013-05-28 21:24:45 -04:00
92dc59fba9
Properly assign draft keys to Categories List view.
2013-05-28 21:16:24 -04:00
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
d75b160385
Enable subscribing to notifications on start, instead of currentUser
...
change which was hokey.
2013-05-28 17:12:37 -04:00
fc7fefb581
Merge pull request #913 from chrishunt/chrishunt/style-api-button
...
Add styling to 'Generate API Key' button
2013-05-28 13:26:30 -07:00
c73455bfa2
FIX: Missing `()` made notifications invisible
2013-05-28 16:17:32 -04:00
ee319ea7f7
FIX: Issues that didn't show up originally
2013-05-28 15:57:11 -04:00
264dd65410
Fix replying in a topic that is uncategorized after allow_uncategorized_topics is set to false
2013-05-28 15:53:01 -04:00
560fb15d8a
Include pinned topics in category list.
...
- removes an (n+1) query for user data
- supports the preload store for the data to avoid a second request
- fix a bug where uncategorizes was reporting (0, 0, 0) for topics by week, month, year
2013-05-28 15:36:16 -04:00
e75f881d58
Add styling to 'Generate API Key' button
2013-05-28 12:10:18 -07:00
dda831fd41
Fix a regression that broke pre-fill of username when sending private message
2013-05-28 14:17:35 -04:00
320b35bf90
Merge pull request #910 from novemberkilo/master
...
WIP - Reduce complexity of Post#raw_links
2013-05-28 10:07:41 -07:00
8d47f92c27
Merge pull request #908 from chrishunt/chrishunt/extract-topic-status-update
...
Extract topic status update
2013-05-28 10:00:49 -07:00
f190a96b30
Allow stuff in gutter to be selected
2013-05-28 12:57:33 -04:00
a4b90ac54f
Prevent avatars from wrapping on topic list
2013-05-28 12:57:32 -04:00
21a54567ff
Extract TopicStatusUpdate from Topic
2013-05-28 09:01:04 -07:00
dd54736d06
Refactor: Removed the last of the references to `Discourse.currentUser`.
2013-05-28 11:52:31 -04:00
57f97880e6
Refactor: Instead of getting `currentUser` from the Discourse namespace, use
...
`Discourse.User.current()`
2013-05-28 11:25:56 -04:00
9a409d9440
fix comment and remove url setting as it is not used.
2013-05-28 08:06:18 -07:00
1d5952a92f
Extract analysis type methods to a module and refactor Post#raw_links
2013-05-28 16:41:18 +02:00
55526e24d6
FIX: The `title` attribute was missed when refactoring UserAction streams
2013-05-28 10:20:56 -04:00
54a798eb12
Add Topic#age_in_days for determining age of topic
2013-05-27 18:02:15 -07:00
d2f2a8e218
refactoring
2013-05-28 09:13:53 +10:00
b73bb49076
FIX: More search results was broken.
2013-05-27 17:49:49 -04:00
f184090444
FIX: You can't change a subject whilst Flagging
...
Meta: [You can't change a subject whilst Flagging](http://meta.discourse.org/t/you-can-t-change-a-subject-whilst-flagging/6887 )
This revert a change made by @eviltrout in b794830a25emberjs/ember.js#1235 will soon be merged in and we'll have a proper radio button control in Ember.js.
2013-05-27 22:29:24 +02:00
62a20f5655
FIX: Couldn't access "Uncategorized" category from category list.
2013-05-27 14:15:52 -04:00
b1ef2ea1e1
Fix TopicPostersSummary when a suggested topic includes a user who has been deleted
2013-05-27 14:12:15 -04:00
197909246c
Weigh staff likes higher when calculating scores. New site setting: `staff_like_weight`
...
can set the factor (default is 3)
2013-05-27 12:46:08 -04:00
8b0b77c161
Bounce the popup tips again when you click submit button again
2013-05-27 11:51:27 -04:00
1879176e80
FIX: Invited by link was broken on user activity.
2013-05-27 11:05:41 -04:00
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
bf16b4f381
Merge pull request #903 from chrishunt/chrishunt/extract-post-move
...
Extract post move
2013-05-26 19:10:50 -07:00
6024529f81
Extract PostMover from Topic into its own class
2013-05-26 18:42:04 -07:00
661ddbb158
introduce strong_parameters
2013-05-27 11:06:09 +10:00
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
f58bcf7fe3
Refactored duplication in user action
2013-05-26 16:07:20 +03:00
b8fbac582e
Add Topic#url for determining url for a Topic
2013-05-25 17:44:32 -07:00
f2b5e20840
Add Topic#max_post_number to find max post number
2013-05-25 17:44:32 -07:00
c4cce68613
Add Post#is_first_post?
...
We should be able to ask a post if it's the first in a topic
2013-05-25 17:44:32 -07:00
74b661317c
FIX: User stream was loading the same page over and over once you scrolled past 60
...
items.
2013-05-25 14:08:09 -04:00
63c63c2939
Remove unused parameters from posters_summary
2013-05-24 15:33:50 -07:00
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
ada79260b3
Change composer error message when title is too long or too short, and make sure the submit button is 'disabled' when title is too long
2013-05-24 17:10:07 -04:00
e2774cc2df
Merge pull request #896 from xtream/master
...
Removed unnecesary method
2013-05-24 14:09:44 -07:00
d26b87bd3c
Add Site Setting allow_uncategorized_topics. Uncheck it to force people to choose a category for all new topics.
2013-05-24 16:56:43 -04:00
e5e904aa4e
minor refactorings
2013-05-24 13:36:33 -07:00
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
3037e9adf6
FIX: Clearing flags wasn't making topics visible again.
2013-05-24 16:03:20 -04:00
d1fdc66ca4
FIX: For spam detection, don't count total occurances of links of the same host, but
...
post count including that host.
2013-05-24 15:20:58 -04:00
bd779834e5
Use search context for filtering search results by current category or user
2013-05-24 14:04:26 -04:00
48d39d2f8c
Oops jshint fail again
2013-05-24 12:45:58 -04:00
e600b45155
Composer uses bouncing popup messages beside fields with invalid values when you click the submit button
2013-05-24 12:26:17 -04:00
962f0dd5f9
Search correctly passes context data to server
2013-05-24 12:21:53 -04:00
bca006feca
removed unnecesary method
2013-05-24 18:03:02 +02:00
69bb70fbd3
Removed bindings to `Discourse.site`
2013-05-24 11:56:40 -04:00
56764f817b
Fix JsHint
2013-05-24 11:02:17 -04:00
1dae46021e
Category controller should use the correct category object
2013-05-24 10:57:26 -04:00
c0c97487d8
Merge pull request #888 from novemberkilo/master
...
Refactor to reduce complexity of Post#save_reply_relationships
2013-05-24 07:04:28 -07:00
a1520f0dee
implement save :)
2013-05-24 21:04:26 +10:00
a8ae81df4b
sorry this is meant to be staff styling :)
2013-05-24 13:32:57 +10:00
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
2cd95bc649
lets try out annotations
2013-05-24 12:35:14 +10:00
fc3c93d237
almost fixed the regression of not allowing top level filters
2013-05-24 09:54:39 +10:00
84fd366322
Navigating should set a searchContext (unused right now).
2013-05-23 18:51:40 -04:00
eb0c102931
Migration logic from SearchView to a controller, where it should be.
2013-05-23 17:42:57 -04:00
0bdee973a0
allow disabling of local logins. In the instance where an .edu is using cas they may not want a user to be able to log in once the users credentials have been revoked in the system that feeds the CAS authentication server. This is very optional
2013-05-23 13:44:14 -07:00
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
9aacde2f2d
Refactor Post#save_reply_relationships
2013-05-23 18:09:06 +02:00
ba4eaa0297
Helper to create reply relationship with post
2013-05-23 18:08:24 +02:00
d7219a6fbc
Helper to add a number to quoted_post_numbers
2013-05-23 18:07:45 +02:00
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
c4b5821ef8
Revert annotation and non-English I18n changes
2013-05-23 06:44:47 -07:00
3dfc034e8d
Merge pull request #881 from novemberkilo/master
...
Improve flog metric for Post#extract_quoted_post_numbers
2013-05-23 00:21:27 -07:00
7271b90655
annotate topic model
2013-05-22 22:36:01 -07:00
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
0f296cd42b
Refactor + Fix: Wasn't correctly loading activity streams. Code is a lot more Ember-y now.
2013-05-22 12:06:37 -04:00
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
45361934b9
User the BasicUserSerializer for the invited user
2013-05-21 12:03:51 -04:00
046e6e5d86
Simplified grouping on user views, fixed issue with messages not loading on initial load. Really
...
simplified the restricted user route.
2013-05-21 11:50:01 -04:00
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
7e3e6ab78d
icon tweak on merge/split
2013-05-20 12:34:15 -07:00
dee45d8dba
Changed `elementId` to be `id`
2013-05-20 15:31:05 -04:00
42248a7164
Removed many unnecessary paths that included `content.x` when just `x` would do.
2013-05-20 15:27:58 -04:00
9544cfd7dc
`target="controller"` is unnecessary. By default it will target the controller.
2013-05-20 14:37:05 -04:00
a79d53c628
Removed many unnecessary `controller.` uses in templates.
2013-05-20 13:45:14 -04:00
c7aebbf4d6
Replace Ember.Text* insertions with helpers.
2013-05-20 12:56:36 -04:00
1097d51b33
Replaced {{view Discourse.TextField}} with {{textfield}} helper.
2013-05-20 12:47:59 -04:00
b794830a25
Replaced `Em.run.next` with the more proper `Em.run.schedule('afterRender')`
...
when we are waiting for rendering to finish.
2013-05-20 12:20:10 -04:00
a3dce9afd7
don't error out on not posts if its a json request
2013-05-20 17:32:53 +10:00
fc57578c85
proper 404 for json request 404
2013-05-20 17:28:32 +10:00
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
546a2b654a
Improve style of security tab of category modal
2013-05-17 16:09:52 -04:00
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
2265c046ba
Some tweaks to category modal
2013-05-17 11:19:58 -04:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
8f46653345
refactor
2013-05-17 09:03:52 +10:00
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
7daca77443
Remove modal state to choose move type. Instead use two buttons on the multi select popup, one
...
for split and one for merge.
2013-05-16 14:22:41 -04:00
1e9497d9ef
FIX: Add unseen "*" icon on category list for new topics.
2013-05-16 13:36:58 -04:00
Robin Ward
Neil Lalonde
Sam
Régis Hanol
Anton Batenev
Chris Hunt
Jeff Atwood
Vipul A M
Navin
Juan de Dios Herrero
Ian Christian Myers
Stephan Kaag
Jeff Atwood
DI2uNk
Brian Plexico
Erik Ordway
nirnanaaa
Janis Miezitis
Matt Van Horn
Victor Cruz Dueñas
Leonard Garvey
Josh Susser and Avdi Grimm