30f55cd64b
UX: improve search result consistency ( #27289 )
2024-06-04 15:34:21 +10:00
eebf332025
FEATURE: expand the admin sidebar when filtering ( #27312 )
...
Even when the admin sidebar sections are collapsed, they should expand while filtering. When the filter is removed, sections should go back to the previous state.
In addition, trim whitespace from the filter section.
2024-06-04 12:23:21 +10:00
472c02bda8
Build(deps-dev): Bump lefthook from 1.6.14 to 1.6.15 ( #27309 )
...
Bumps [lefthook](https://github.com/evilmartians/lefthook ) from 1.6.14 to 1.6.15.
- [Release notes](https://github.com/evilmartians/lefthook/releases )
- [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md )
- [Commits](https://github.com/evilmartians/lefthook/compare/v1.6.14...v1.6.15 )
---
updated-dependencies:
- dependency-name: lefthook
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-04 06:47:40 +08:00
625c715856
FIX: Lazy TikTok embeds height in chat ( #27306 )
2024-06-03 11:20:47 -03:00
a64f021f49
DEV: Convert user-posts-stream to native class syntax ( #27278 )
...
This is the final model in Discourse core to be converted
2024-06-03 15:03:50 +01:00
adeda6c6a5
FIX: Restore cmd+click ability in topic-info ( #27305 )
2024-06-03 16:01:20 +02:00
29b826c8f7
DEV: Convert DiscourseURL to native class syntax ( #27284 )
2024-06-03 14:59:05 +01:00
a3d0a9edbb
DEV: Convert almost all routes to native class syntax ( #27281 )
...
Only remaining ones are `routes/discourse.js` and `routes/application.js`. Those two both contain legacy `actions: {}` hashes which need to be updated before being converted to native class syntax.
2024-06-03 14:58:53 +01:00
602ef2c819
FIX: Store special characters in permalink URL as encoded characters
...
see https://meta.discourse.org/t/permalink-not-working-with-cyrilics-symbols/301130
2024-06-03 13:20:24 +02:00
9061282515
FIX: Permalinks with external URL didn't work with subfolders
2024-06-03 13:20:24 +02:00
387e906610
REFACTOR: All kinds of permalinks should return relative URLs
...
Mixing relative and absolute URLs is unnecessary and confusing.
2024-06-03 13:20:24 +02:00
4e80c9eb13
FIX: chat direct message group user limit is off by 1 ( #27014 )
...
This change allows the correct number of members to be added when creating a group direct message, based on the site setting chat_max_direct_message_users.
Previously we counted the current user within the max user limit and therefore the count was off by 1.
2024-06-03 12:11:49 +04:00
82cccf89e1
DEV: attempts to remove using_session patch ( #27292 )
...
I suspect it's not useful anymore, if it ever was, and might cause more harm than good.
2024-06-03 09:38:03 +02:00
fed9055818
DEV: Remove admin-revamp and introduce foundations for admin config ( #27293 )
...
This commit removes the `/admin-revamp` routes which were introduced as a part of an experiment to revamp the admin pages. We still want to improve the admin/staff experience, but we're going to do them within the existing `/admin` routes instead of introducing a completely new route.
Our initial efforts to improve the Discourse admin experience is this commit which introduces the foundation for a new subroute `/admin/config` which will house various new pages for configuring Discourse. The first new page (or "config area") will be `/admin/config/about` that will house all the settings and controls for configuring the `/about` page of Discourse.
Internal topic: t/128544
2024-06-03 10:18:14 +03:00
aec892339e
DEV: Add rspec tests for `SignalTrapLogger` ( #27302 )
...
Follow-up to 23c38cbf11
2024-06-03 13:40:21 +08:00
d68983e060
DEV: Use same `Socket.getaddrinfo` arguments as selenium-webdriver ( #27301 )
...
Follow up to c408b53689
2024-06-03 13:11:40 +08:00
23c38cbf11
DEV: Log Unicorn worker timeout backtraces to `Rails.logger` ( #27257 )
...
This commit introduces the following changes:
1. Introduce the `SignalTrapLogger` singleton which starts a single
thread that polls a queue to log messages with the specified logger.
This thread is necessary becasue most loggers cannot be used inside
the `Signal.trap` context as they rely on mutexes which are not
allowed within the context.
2. Moves the monkey patch in `freedom_patches/unicorn_http_server_patch.rb` to
`config/unicorn.config.rb` which is already monkey patching
`Unicorn::HttpServer`.
3. `Unicorn::HttpServer` will now automatically send a `USR2` signal to
a unicorn worker 2 seconds before the worker is timed out by the
Unicorn master.
4. When a Unicorn worker receives a `USR2` signal, it will now log only
the main thread's backtraces to `Rails.logger`. Previously, it was
`put`ing the backtraces to `STDOUT` which most people wouldn't read.
Logging it via `Rails.logger` will make the backtraces easily
accessible via `/logs`.
2024-06-03 12:51:12 +08:00
4b2bd4d682
FEATURE: Allow "move to inbox" and "move to archive" for private messages using new bulk topic dropdown ( #27236 )
...
This commit re-introduces the "Move to Inbox" and "Move to Archive"
bulk topic actions, which we had in the old modal but had not yet added
to the new "experimental" dropdown, which isn't really experimental at
this point.
Once this is merged we can remove the old modal and only
rely on the new dropdown.
2024-06-03 14:37:28 +10:00
a8f0a927a0
Build(deps-dev): Bump sass from 1.77.3 to 1.77.4 ( #27294 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.77.3 to 1.77.4.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.77.3...1.77.4 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-03 10:38:10 +08:00
c7292c1ffc
Build(deps): Bump net-imap from 0.4.11 to 0.4.12 ( #27295 )
...
Bumps [net-imap](https://github.com/ruby/net-imap ) from 0.4.11 to 0.4.12.
- [Release notes](https://github.com/ruby/net-imap/releases )
- [Commits](https://github.com/ruby/net-imap/compare/v0.4.11...v0.4.12 )
---
updated-dependencies:
- dependency-name: net-imap
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-03 10:37:25 +08:00
858a37ef58
Build(deps): Bump sass-embedded from 1.77.2 to 1.77.4 ( #27297 )
...
Bumps [sass-embedded](https://github.com/sass-contrib/sass-embedded-host-ruby ) from 1.77.2 to 1.77.4.
- [Commits](https://github.com/sass-contrib/sass-embedded-host-ruby/compare/v1.77.2...v1.77.4 )
---
updated-dependencies:
- dependency-name: sass-embedded
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-03 10:37:12 +08:00
3ca0b81d02
Build(deps-dev): Bump rubocop from 1.64.0 to 1.64.1 ( #27296 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.64.0 to 1.64.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.64.0...v1.64.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-03 10:37:01 +08:00
f590732bd7
Build(deps-dev): Bump parser from 3.3.1.0 to 3.3.2.0 ( #27298 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 3.3.1.0 to 3.3.2.0.
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v3.3.1.0...v3.3.2.0 )
---
updated-dependencies:
- dependency-name: parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-03 10:36:50 +08:00
c408b53689
DEV: puts debugging information when CI encounters resolution errors ( #27300 )
...
We have been seeing flaky socket resolution errors on CI and need more
debugging information to figure out why
2024-06-03 10:26:02 +08:00
50e573e797
FIX: ensures bulk-select on messages page is working ( #27291 )
...
The issue was simple, we were just not returning the helper in the `user-private-messages` controller which was preventing any action to happen.
Follow up: we should write specs for this toggle.
2024-06-03 10:04:38 +10:00
510c022131
FIX: ensures bulk-select is correctly working on mobile ( #27290 )
...
Prior to this fix we were opening a modal before closing the `DMenu` modal, given `DModal` expects only one modal at a time it was closing the latest modal and instantly closing the one we just opened.
2024-06-03 10:03:57 +10:00
62b1b69e82
UX: constrain width of chat transcripts in posts ( #27288 )
2024-05-31 16:26:46 -04:00
82529a1c06
Update server.en.yml ( #27286 )
...
* Update server.en.yml
Added "sidebar" and "header pulldown" keywords to the navigation_menu site setting
* Update server.en.yml
fixed typo pulldown -> dropdown
2024-05-31 08:26:34 -07:00
69c7ed7b59
Update server.en.yml ( #27285 )
...
changed `navigation menu` description to make explicit you are choosing between sidebar and header dropdown, and sidebar is recommended.
2024-05-31 08:06:05 -07:00
4f6f904320
UX: keep recent search items on same line as icon ( #27280 )
2024-05-31 10:49:38 -04:00
96a686c8dc
DEV: Attempt to fix flaky spec ( #27270 )
2024-05-31 10:57:43 -03:00
0a9be3bfd8
DEV: Convert helpers to native class syntax ( #27279 )
2024-05-31 14:40:52 +01:00
c0abae054d
DEV: Convert app.js to native class syntax ( #27277 )
2024-05-31 14:40:41 +01:00
0b25d64750
DEV: Convert adapters to native class syntax ( #27276 )
2024-05-31 14:40:32 +01:00
58d69e84e1
Build(deps): Bump json_schemer from 2.2.1 to 2.3.0 ( #27266 )
...
Bumps [json_schemer](https://github.com/davishmcclurg/json_schemer ) from 2.2.1 to 2.3.0.
- [Changelog](https://github.com/davishmcclurg/json_schemer/blob/main/CHANGELOG.md )
- [Commits](https://github.com/davishmcclurg/json_schemer/compare/v2.2.1...v2.3.0 )
---
updated-dependencies:
- dependency-name: json_schemer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-31 15:05:13 +02:00
602a0268dd
Build(deps-dev): Bump lefthook from 1.6.13 to 1.6.14 ( #27268 )
2024-05-31 13:44:02 +02:00
faad8842d4
DEV: Avoid extra whitespace in rawRenderGlimmer ( #27272 )
2024-05-31 13:41:14 +02:00
81fe4ed248
Update translations ( #27274 )
2024-05-31 12:27:26 +02:00
a9cccf07c6
REVERT: UX: keep recent search items on same line as icon ( #27264 )
...
This was making the hamburger menu un-scrollable on mobile.
2024-05-31 10:01:44 +02:00
5eae8ced9e
UX: keep recent search items on same line as icon ( #27264 )
2024-05-30 16:10:02 -04:00
31283968cb
UX: contain background for deleted small actions ( #27263 )
2024-05-30 16:09:45 -04:00
8eec9da0b4
DEV: Plugin modifier application for About admins ( #27261 )
2024-05-30 10:44:53 -05:00
766231b102
FIX: Prevent crash importing topics on a tagged embeddable host ( #27254 )
2024-05-30 12:04:36 -03:00
59c1b80203
UX: adjust category badge size for new default font-size ( #27262 )
2024-05-30 10:59:06 -04:00
359dccf191
Build(deps-dev): Bump the embroider group with 5 updates ( #27250 )
...
Bumps the embroider group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [@embroider/compat](https://github.com/embroider-build/embroider/tree/HEAD/packages/compat ) | `3.5.0` | `3.5.1` |
| [@embroider/core](https://github.com/embroider-build/embroider/tree/HEAD/packages/core ) | `3.4.9` | `3.4.10` |
| [@embroider/macros](https://github.com/embroider-build/embroider/tree/HEAD/packages/macros ) | `1.16.1` | `1.16.2` |
| [@embroider/router](https://github.com/embroider-build/embroider/tree/HEAD/packages/router ) | `2.1.7` | `2.1.8` |
| [@embroider/webpack](https://github.com/embroider-build/embroider/tree/HEAD/packages/webpack ) | `4.0.0` | `4.0.1` |
Updates `@embroider/compat` from 3.5.0 to 3.5.1
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/compat )
Updates `@embroider/core` from 3.4.9 to 3.4.10
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/core )
Updates `@embroider/macros` from 1.16.1 to 1.16.2
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/macros )
Updates `@embroider/router` from 2.1.7 to 2.1.8
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/router )
Updates `@embroider/webpack` from 4.0.0 to 4.0.1
- [Release notes](https://github.com/embroider-build/embroider/releases )
- [Changelog](https://github.com/embroider-build/embroider/blob/main/CHANGELOG.md )
- [Commits](https://github.com/embroider-build/embroider/commits/HEAD/packages/webpack )
---
updated-dependencies:
- dependency-name: "@embroider/compat"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/core"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/macros"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/router"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
- dependency-name: "@embroider/webpack"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: embroider
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-30 14:11:57 +01:00
28fe3c339e
FIX: Allow triggering Discobot when bookmarking the entire topic ( #27255 )
2024-05-30 09:58:51 -03:00
5aefda1dee
FIX: allows listing messages of any thread ( #27259 )
...
Before this fix we could only list messages of a thread if it was part of a `threading_enabled` channel or if the thread was set to `force`.
Due to our design of also using a thread id when this is just a chain of replies so we can switch from threading enabled to disabled at any time, we will allow `Chat:: ListChannelThreadMessages` to list the messages of any thread, the only important requirements are:
- having a thread id
- being able to access this thread
To allow this, this commit simply removes the check on `threading_enabled` or `force`.
2024-05-30 10:20:40 +02:00
222a5f4677
UX: Show shortcut for admin sidbar filter ( #27258 )
...
This adds a small indicator of the Ctrl+/ shortcut that
exists for the admin sidebar filter, since it's not very
obvious that you can do that. This should help people
who are struggling with the long list of links -- it's
much faster to use the keyboard and search for what
you are looking for.
2024-05-30 15:06:02 +10:00
52cc83df18
Build(deps-dev): Bump sass from 1.77.2 to 1.77.3 ( #27251 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.77.2 to 1.77.3.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.77.2...1.77.3 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-30 11:34:27 +08:00
ecdb391a70
Build(deps-dev): Bump qunit from 2.20.1 to 2.21.0 ( #27252 )
...
Bumps [qunit](https://github.com/qunitjs/qunit ) from 2.20.1 to 2.21.0.
- [Release notes](https://github.com/qunitjs/qunit/releases )
- [Changelog](https://github.com/qunitjs/qunit/blob/main/History.md )
- [Commits](https://github.com/qunitjs/qunit/compare/2.20.1...2.21.0 )
---
updated-dependencies:
- dependency-name: qunit
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-30 11:34:18 +08:00
Kris
Krzysztof Kotlarek
dependabot[bot]
Jan Cernik
David Taylor
Jarek Radosz
Gerhard Schlager
David Battersby
Joffrey JAFFEUX
Osama Sayegh
Alan Guo Xiang Tan
Martin Brennan
Tobias Eigen
Discourse Translator Bot
Mark VanLandingham
Sérgio Saquetim