c45dbe4159
enable eol-last for eslint and ember-template-lint ( #12678 )
...
enable eol-last for eslint and ember-template-lint
Fixed a handlful of .hbs files where newlines weren't present
2021-04-12 17:22:00 -07:00
436c8e9bcd
DEV: eslint rules should be defined in eslint-config-discourse ( #11812 )
2021-01-22 15:48:23 +01:00
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
1c2358ba16
DEV: Tidy up imports. ( #11364 )
...
Only allow one import definition per file and add a new eslint rule to enforce it.
2020-11-27 11:30:16 -03:00
b302321451
REFACTOR: Test assertions should be imported.
...
Previously they were global functions.
2020-10-28 11:39:06 -04:00
1e4c0d1857
Remove more global variables from tests.
...
* Use `sinon` instead of `sandbox` and require an import.
* You need to import `currentURL` to use it.
2020-10-26 13:32:11 -04:00
51d10db7f2
REFACTOR: Import `visit` helper rather than using a global variable
2020-10-15 13:22:05 -04:00
3862036422
REFACTOR: Use imports for `sinon` and `setResolver`
...
I also took the opportunity with this commit to move some test specific
stuff out of `discourse-loader` which is loaded on the front end of the
application. The test module building now happens in the `test_helper`
bundle.
2020-10-09 13:54:54 -04:00
71d37953d5
REFACTOR: Import `QUnit` and related helpers rather than globals
...
We used many global functions to handle tests when they should be
imported like other libraries in our application. This also gets us
closer to the way Ember CLI prefers our tests to be laid out.
2020-10-07 11:50:49 -04:00
80dfaeb0d2
DEV: upgrades dev config ( #10588 )
2020-09-04 13:33:03 +02:00
2f11457263
REFACTOR: Use `Array.isArray` instead of `_.isArray`
2020-09-03 10:03:33 -04:00
ff4de97dfd
REFACTOR: Move `bootbox` to an import instead of global variable ( #10533 )
2020-08-26 12:57:13 -04:00
499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage ( #8782 )
2020-02-05 10:14:42 -06:00
3f172deab5
DEV: uses central eslint-config-discourse ( #8150 )
...
* DEV: uses centrain eslint-config-discourse
Discourse project or plugins can now have a central configuration by doing:
`yarn add --dev eslint-config-discourse@latest`
* adds postinstall script
2019-10-08 11:56:24 +11:00
c573fa780b
DEV: prevents asyncTestDiscourse/controllerFor/fixture to leak ( #7717 )
2019-06-06 13:10:41 +02:00
b339d67401
DEV: refactors select-kit helper to prevent it to leak into global state ( #7708 )
2019-06-06 10:47:10 +02:00
de013262a7
DEV: refactors textarea-selection helper to prevent leaking ( #7709 )
2019-06-05 19:20:46 +02:00
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
669bfaba30
DEV: setTextareaSelection helper ( #7609 )
2019-05-27 16:33:27 +02:00
f75915efa4
FIX: `expandAllPinned` was not resetting after visiting a category
...
This resulted in a bug where if you saw a pinned topic in a category,
then went back to latest, the same topic would show an excerpt even
though it shouldn't on the latest view.
See:
https://meta.discourse.org/t/pinned-post-excerpt-no-longer-appears-after-refreshing-the-page/106222
2019-01-14 13:02:25 -05:00
1a3655b787
DEV: s/Em/Ember ( #6874 )
2019-01-11 17:54:23 +01:00
0f5aeab003
DEV: enable no-alert & no-console eslint rules
2018-11-14 23:17:56 +01:00
04baddf731
DEV: migrate tests to async/await
2018-07-30 12:21:05 +02:00
4774cabb84
Update .eslintrc to support new ES6 globals.
2018-06-30 08:20:34 +08:00
315b9d796d
select-kit refactoring
...
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
39f3dbd945
Introduces select-kit
...
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:
```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
0da529010a
FEATURE: support for multi-combo-box
2017-11-09 10:57:53 -08:00
ae1743c61f
[WIP] select-box-kit refactoring
2017-10-19 12:51:08 -07:00
562e48dfb7
adds a dsl to simplify testing of the select-box
2017-09-14 19:50:32 +02:00
0a53c589c4
Fix linting.
2017-08-30 15:36:45 +08:00
c8eba5d20c
Add two common eslint rules.
2017-08-21 21:42:31 +09:00
f02bf8e4c3
FIX: Make .eslintrc file compatible with eslint 4 take 2
2017-06-22 17:22:42 -03:00
2e9ab29817
FIX: Make .eslintrc file compatible with eslint 4
2017-06-22 17:09:16 -03:00
cc525b1a8d
Upgrade QUnit to latest version
2017-06-15 10:12:07 -04:00
666e3e2890
Fix eslint.
2017-06-12 14:48:50 +09:00
e5bbfe1f1b
Lint inner function declarations to prevent Safari breakage
2016-07-14 10:22:39 -04:00
bba0fd0654
REFACTOR: PreloadStore to ES6
2016-07-11 12:57:05 -04:00
d1e85bdd8b
FEATURE: Use virtual dom framework for faster post rendering
2016-02-11 11:00:40 -05:00
975edceff4
Add semi colon linting to Javascript
2015-09-15 17:08:50 -04:00
22844b9e46
Ember 1.12 support
2015-08-13 11:14:16 -04:00
Faizaan Gagan
Joffrey JAFFEUX
Roman Rizzi
Robin Ward
Mark VanLandingham
Régis Hanol
Maja Komel
Guo Xiang Tan
Rafael dos Santos Silva