Commit Graph

11126 Commits

Author SHA1 Message Date
Maja Komel 87bf0ec7ae
FIX: fix locale key 2019-06-04 13:35:17 +02:00
Guo Xiang Tan fcb7422213 DEV: Avoid hard-coding notification types integer in client side code.
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
2019-06-04 17:30:46 +08:00
Joffrey JAFFEUX 9585a16264
FIX: ensures correct i18n key is used (#7686) 2019-06-04 11:22:44 +02:00
Joffrey JAFFEUX 4283281397
FIX: ensures we have data to compute average (#7685) 2019-06-04 11:21:55 +02:00
Joffrey JAFFEUX b79d02ff48
FEATURE: displays average for 2 columns tables which support average 2019-06-04 11:08:26 +02:00
Maja Komel c9a34aa10c FIX: add title attribute for notifications 2019-06-04 17:02:12 +08:00
Joffrey JAFFEUX 497a1d2d9f
FEATURE: uses native date picker on mobile (#7541) 2019-06-04 10:44:55 +02:00
Joffrey JAFFEUX c4419b7369
REFACTOR: badge-selector component (#7683) 2019-06-04 10:30:56 +02:00
Maja Komel 2863e7c181 FIX: fix select badge as user title on badge page (#7682) 2019-06-04 18:19:30 +10:00
Guo Xiang Tan 1991af2abb DEV: Switch `InlineUploads` to a regexp based implementation. 2019-06-04 15:54:25 +08:00
Joffrey JAFFEUX 0c5498c9a4
REFACTOR: exception controller (#7675) 2019-06-03 23:34:23 +02:00
Régis Hanol b792db9d92 FIX: redirect to top was always redirecting to 'All' 2019-06-03 20:18:14 +02:00
Kris 9a3dd6b59a UX: Add missing classes to user preferences 2019-06-03 13:35:40 -04:00
Penar Musaraj 16982d2a69
Update UI for wizard themes further reading step (#7669) 2019-06-03 10:47:17 -04:00
Dan Ungureanu c1e7a1b292 UX: Merge settings related to muted tags. (#7656) 2019-06-03 12:23:23 +10:00
Dan Ungureanu 28dcf445b7 DEV: Pass editor to plugin hook handling composer uploads. (#7673) 2019-06-03 12:07:25 +10:00
romanrizzi a0a2823536 DEV: Fix indentation 2019-05-31 10:19:19 -03:00
Joffrey JAFFEUX 1db7fd6f9b
REFACTOR: topic-list model (#7658) 2019-05-31 13:15:45 +02:00
Joffrey JAFFEUX 63264158cf
REFACTOR: user-posts-stream model (#7657) 2019-05-31 13:02:15 +02:00
Sam Saffron 3b8819f0ab FEATURE: add support for defer topic functionality
This feature allows end users to "defer" topics by marking them unread

The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
2019-05-31 15:44:35 +10:00
Sam Saffron 077dcc0642 FEATURE: add autocomplete discourse on full page search
This teaches chrome not to try autocompleting it.
2019-05-31 10:27:44 +10:00
Roman Rizzi c169456ee5
DEV: Create new component to reify the user fields (#7655) 2019-05-30 16:17:16 -03:00
Robin Ward c4fa20d644 FIX: Broken test, also typoed property 2019-05-30 14:27:28 -04:00
Robin Ward 5e89714f77 FIX: Linting via prettier 2019-05-30 13:58:06 -04:00
Robin Ward 7a9e85b1d7 FIX: Don't show the "Flag to delete" message to staff
If they can't delete, flagging should not either.
2019-05-30 13:31:40 -04:00
Joffrey JAFFEUX 7a21f78f8c
prettier (#7653) 2019-05-30 17:28:07 +02:00
Joffrey JAFFEUX 0fbbff86ab
REFACTOR: rest model (#7652) 2019-05-30 17:11:17 +02:00
Daniel Waterworth bfb26b720b FIX: the en_US locale depends on en 2019-05-30 08:46:43 +08:00
romanrizzi e7ee556e87 Support multi-group user search 2019-05-30 08:45:20 +08:00
Kris b24938b5ff UX: Minor composer button alignment adjustments, simplification 2019-05-29 14:37:32 -04:00
Joffrey JAFFEUX c77bc525cb
REFACTOR: new-topic route (#7639) 2019-05-29 16:46:58 +02:00
Joffrey JAFFEUX ba66d6fd82
FIX: icon deprecation s/group/users (#7638) 2019-05-29 16:29:01 +02:00
Joffrey JAFFEUX 034502af21
FIX: incorrectly removed moveTypes array (#7637) 2019-05-29 16:23:32 +02:00
Joffrey JAFFEUX bb6337d6c6
REFACTOR: choose-topic component (#7636) 2019-05-29 16:21:13 +02:00
Joffrey JAFFEUX b2fc80e4b7
REFACTOR: build-topic-selection mixin (#7635) 2019-05-29 16:09:19 +02:00
Joffrey JAFFEUX 468cfa39f7
REFACTOR: rename-tag controller (#7634) 2019-05-29 15:58:12 +02:00
Joffrey JAFFEUX f2858e03c8
REFACTOR: preferences/email controller (#7633) 2019-05-29 15:53:42 +02:00
Joffrey JAFFEUX 5e7e32510a
FIX: lookup should be done against locale of reference (#7632) 2019-05-29 15:45:44 +02:00
Joffrey JAFFEUX 05206a61ab
FIX: displays text of asset-version changed modal (#7631) 2019-05-29 15:38:14 +02:00
Guo Xiang Tan f0620e7118 FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD take 2.
Previous attempt was missing `post_uploads` records.
2019-05-29 09:26:32 +08:00
Joffrey JAFFEUX 76569b2018 FIX: ensures post-small-action is using timezone to display dates 2019-05-29 08:45:28 +08:00
Bianca Nenciu 43e33302e1 FIX: Position emoji-picker around d-editor. 2019-05-29 08:27:14 +08:00
Penar Musaraj 7c9fb95c15 Temporarily revert "FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. (#7603)"
This reverts commit b1d3c678ca.

We need to make sure post_upload records are correctly stored.
2019-05-28 16:37:01 -04:00
Osama Sayegh f3c07e27d9
FIX: correct translations for logs error rate notice (#7622)
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.

I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
Bianca Nenciu 91ff8684fd FIX: Use the right property for post ID. 2019-05-28 22:00:58 +03:00
Kris 67d8ceedf1 Remove unused variable 2019-05-28 14:31:52 -04:00
Kris c57ab12238 UX: Move preview button to bottom right of mobile composer 2019-05-28 14:19:33 -04:00
Joffrey JAFFEUX bc14452585
FIX: ensures events have access to correct context (#7621) 2019-05-28 19:40:28 +02:00
Guo Xiang Tan b1d3c678ca FEATURE: Support `[description|attachment](upload://<short-sha>)` in MD. (#7603) 2019-05-28 11:18:21 -04:00
Robin Ward 9bdfaa195e FIX: We shouldn't memoize the last time something is read 2019-05-28 10:51:18 -04:00
Joffrey JAFFEUX 6decdfce5c
DEV: reduces memory footprint of tests - step 1 (#7591) 2019-05-28 12:15:12 +02:00
Penar Musaraj dfcc2e7ad8 Revert "FEATURE: Send notification when member was accepted to group. (#7503)"
This reverts commit 42c82d544e.
2019-05-27 15:19:59 -04:00
Penar Musaraj c108131ad4 Revert "Fix JS error in group summary notification message"
This reverts commit b1268e00b8.
2019-05-27 15:19:38 -04:00
Penar Musaraj b1268e00b8 Fix JS error in group summary notification message 2019-05-27 14:54:51 -04:00
Robin Ward d95a68b837 FEATURE: When suspending a user, allow the Delete + Replies action
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Joffrey JAFFEUX 192562745f
DEV: uses focus helper for d-editor tests (#7610) 2019-05-27 17:31:11 +02:00
Bianca Nenciu 42c82d544e
FEATURE: Send notification when member was accepted to group. (#7503) 2019-05-27 17:28:41 +03:00
Joffrey JAFFEUX 395f0ca126
FIX: attempts to prevent stacked-chart from being cut off (#7608) 2019-05-27 15:43:27 +02:00
Bianca Nenciu e284b6e075
FIX: Update tags on change. (#7581) 2019-05-27 16:04:26 +03:00
Joffrey JAFFEUX d93f753b17
apply prettier on gigantic find and replace (#7604) 2019-05-27 10:42:53 +02:00
Joffrey JAFFEUX bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 (#7592) 2019-05-27 10:15:39 +02:00
Dan Ungureanu da39d66e83
DEV: Improve support for plugins. (#7332)
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
Joffrey JAFFEUX 6398ded798 Revert "FIX: ensures selection is lookedup into async content (#7586)"
This reverts commit c238f0d223.
2019-05-25 15:50:41 +02:00
Robin Ward 4b796eebe0 UX: Try tweaking how soon images are lazily loaded 2019-05-24 15:52:48 -04:00
Kris dbd14a805c UX: Wrap long names on user admin page 2019-05-24 13:39:16 -04:00
Penar Musaraj 963f6fbd40 Add icon for "Move to Inbox" footer button 2019-05-24 11:53:14 -04:00
Osama Sayegh e20c30987c
FEATURE: detect theme errors and catch them (#7589)
* FEATURE: detect theme errors and catch them

* Bump COMPILER_VERSION

* Feedback

* Override eslint no console for one line

* Can't use our ajax method

* remove emoji from translation file
2019-05-24 17:25:55 +03:00
Joffrey JAFFEUX 049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) (#7594) 2019-05-24 13:11:33 +02:00
Gerhard Schlager c1e9a70d59 FIX: Fallback locale was not available for extra translations
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
2019-05-24 11:38:26 +02:00
Guo Xiang Tan 1babc3bec6 Follow up to 3388872991. 2019-05-24 09:02:39 +08:00
Kris 3388872991 UX: Separate section for 2FA settings, more consistent layout 2019-05-24 08:58:12 +08:00
Robin Ward 648af78298 FIX: Linting 2019-05-23 12:16:45 -04:00
Robin Ward f73988acd2 Remove unused computed property. 2019-05-23 12:06:18 -04:00
Robin Ward e74cd54fc6 REFACTOR: Replace score bonuses with low/med/high priorities
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
2019-05-23 11:54:45 -04:00
Régis Hanol 943fdc1762 make eslint happy 2019-05-23 12:51:40 +02:00
Régis Hanol 0cc81f95a5 FIX: popover should use target when no data attributes 2019-05-23 12:41:36 +02:00
Robin Ward ca03baf2b2 UX: Hide pending score statuses 2019-05-22 11:26:17 -04:00
Joffrey JAFFEUX cf63a9bb53
FIX: exception when pressing backspace on empty selection (#7587) 2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX c238f0d223
FIX: ensures selection is lookedup into async content (#7586) 2019-05-22 17:11:19 +02:00
Joffrey JAFFEUX 40c903ec23
FIX: ie11 exception on new category popup (#7585) 2019-05-22 15:17:28 +02:00
Gerhard Schlager e224100023 FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled 2019-05-22 11:44:39 +02:00
Joffrey JAFFEUX 0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it (#7583) 2019-05-21 21:26:54 +02:00
Joffrey JAFFEUX 236adc9ccb
FIX: shows parent category name in title anchor (#7576) 2019-05-21 08:33:22 +02:00
Osama Sayegh 0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales (#7545)
* Refactor keyboard shortcuts modal to fix RTL locales

* Feedback

* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
Joffrey JAFFEUX bc8c77723e
FIX: puts focus-event at application level (#7568)
Also attempts to use simpler and newer APIs
2019-05-20 13:48:03 +02:00
Gerhard Schlager b788948985 FEATURE: English locale with international date formats
Makes en_US the new default locale
2019-05-20 13:47:20 +02:00
Joffrey JAFFEUX 9bbf421125
FIX: better node check for clickoutside in widgets (#7573) 2019-05-20 12:45:33 +02:00
Joffrey JAFFEUX 0ddfeb9c64
FIX: ensures mousetrap is reset with the application (#7569) 2019-05-20 10:45:31 +02:00
Joffrey JAFFEUX b05d7042ae
FIX: prevents events on toolbar when in form (#7567)
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.

This commit also prevents d-editor-modal to be filled when it's hidden.
2019-05-17 11:14:09 +02:00
Guo Xiang Tan 148bfc9be5 DEV: Simplify client and server side code to support removing tags.
Follow up to 834c86678f.
2019-05-17 16:39:20 +08:00
David Taylor 5666316285 FEATURE: Display 'last updated' on dashboard, improve release notes link (#7560) 2019-05-17 15:42:45 +10:00
Sam Saffron 25137554ed FIX: _.include is no longer imported from lodash
Instead use toArray and indexOf which is also clearer
2019-05-17 08:58:39 +10:00
Joffrey JAFFEUX ad4d01233b
DEV: attempts to make d-editor tests more resilient (#7556) 2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX 244c03573a
FIX: btn class was duplicated on admin-menu-buttons (#7555) 2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX 0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes (#7557) 2019-05-16 14:37:37 +02:00
Régis Hanol a5a4f9dc1a
DEV: make prettier happy
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 (#7546) 2019-05-16 10:34:19 +02:00
Régis Hanol 501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00
Régis Hanol db89722a98 UX: ignore leading/trailing whitespaces in site settings search 2019-05-15 22:22:20 +02:00
Bianca Nenciu b9fcb2bcdf
DEV: Add before button hook in post-menu. (#7550) 2019-05-15 22:48:23 +03:00
Kris a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles (#7549) 2019-05-15 13:26:25 -04:00
Maja Komel 9a17b19636 FIX: don't hide back button at the bottom of timeline (#7544) 2019-05-15 19:02:48 +02:00
Joffrey JAFFEUX d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Régis Hanol 7707d5db2d Revert "REFACTOR: user-selector (#7529)"
This reverts commit 9a56df89f0.
2019-05-13 19:39:30 +02:00
Robin Ward fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX 7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX 717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
Joffrey JAFFEUX df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX 9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
Joffrey JAFFEUX e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00
Joffrey JAFFEUX 9b75320d63
FIX: track mutations on topic edit category-chooser only on select (#7528) 2019-05-13 10:22:28 +02:00
Penar Musaraj a859ddc77e Improve theme/component delete modal warning 2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases (#7525) 2019-05-10 17:12:10 +02:00
Joffrey JAFFEUX 4096d559b5
REFACTOR: user-stream model (#7515) 2019-05-10 10:05:43 +02:00
Joffrey JAFFEUX a85b7feef4
REFACTOR: composer controller (#7516) 2019-05-10 10:05:29 +02:00
Joffrey JAFFEUX 7aedc92a35
REFACTOR: login-controller (#7514) 2019-05-10 10:05:11 +02:00
Gerhard Schlager 34684af195 FIX: Show error message if message exists 2019-05-09 22:12:51 +02:00
Robin Ward b380ed5282 FEATURE: Claim Reviewables by Topic
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
Bianca Nenciu ea3004ef11
UX: Save scroll position in tags topic list. (#7511) 2019-05-09 20:39:03 +03:00
Dan Ungureanu c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. (#7509) 2019-05-09 14:08:10 +03:00
Joffrey JAFFEUX 977ffa20f4
FIX: variable is different from key (#7512) 2019-05-09 10:03:33 +02:00
Arpit Jalan 427979e7e5
FEATURE: use full screen login by default for social login methods (#7481) 2019-05-09 10:03:01 +05:30
Guo Xiang Tan 8ec1f8cf07 DEV: Correct naming convention for JS file. 2019-05-09 10:18:29 +08:00
Maja Komel 24ca074f3f FIX: short description title on client side when empty description
follow-up 77af097c
2019-05-08 17:07:12 +02:00
Joffrey JAFFEUX 54c2f24ee9
REFACTOR: composer model (#7499) 2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX 4aaee7ee35
REFACTOR: change-timestamp controller (#7498) 2019-05-08 16:26:51 +02:00
Robin Ward b409dab77f Rename `flags_default_topics` to `reviewable_default_topics`
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
Maja Komel 77af097ce0 FIX: add short description to title on client side 2019-05-08 15:03:33 +02:00
David Taylor b717e23ceb FIX: Dynamically adjust scale when rendering wizard canvases
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
Bianca Nenciu 861023f0d6 FIX: Skip attachments in click track. 2019-05-08 11:55:31 +03:00
Guo Xiang Tan 46ea69a73c UX: Initialize client side category model with right search_priority.
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
Robin Ward 5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
Roman Rizzi 0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign (#7497) 2019-05-07 12:25:10 -03:00
Penar Musaraj 446ec1b44a
Set input and textarea font size to 16px on iOS (#7480) 2019-05-07 10:44:43 -04:00
Bianca Nenciu 98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. (#7430) 2019-05-07 16:25:52 +03:00
Arpit Jalan ed70595314 UX: add information about the use of permalinks 2019-05-07 17:13:26 +05:30
Bianca Nenciu 71fb8a4195 DEV: Fix failing click-track tests. 2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX 4bbb34f7cb
REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX f73ed45429
REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX 9507eff927
REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
Bianca Nenciu 4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
Guo Xiang Tan abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan 03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Robin Ward 47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward 31e100530f FEATURE: Flag count in post menu
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
Dan Ungureanu 33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Guo Xiang Tan 8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Guo Xiang Tan ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Sam Saffron 267d129f38 FEATURE: only scroll to bottom for discobot
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
Robin Ward 99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Robin Ward 15c9b00307 FEATURE: Show edit indicator on review queue
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX 5f78bbebe9
FIX: forces a reload of emoji list if clicked on more (#7473)
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
Penar Musaraj b948d97c8f
FEATURE: Show diff of local changes before updating remote theme (#7443) 2019-05-02 21:43:54 -04:00
Robin Ward 3cb0d27d38 DEV: Upgrade our widget handlebars compiler
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX e696903c31
FIX: uses translatedTitle to check validity of topic footer btn (#7472) 2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX 75591664e7
FIX: better handling of category filter deselection (#7468) 2019-05-02 10:03:12 +02:00
Guo Xiang Tan d5c9ac7196 PERF: Use cdn when serving site settings upload. 2019-05-02 15:35:07 +08:00
Guo Xiang Tan 24347ace10 FIX: Properly associate user_profiles background urls via upload id.
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
Sam Saffron 157dc5e298 FEATURE: disable native share API on non tablets/phones
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
Arpit Jalan b5ea50a154
FIX: use full screen login for new-topic route (#7467)
DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
Vinoth Kannan 7869a10d18 Revert "FEATURE: Added unlisted topics option to advanced search (#7447)"
This reverts commit 539723f8ff since it is failing the build.
2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX ae493f4722
UX: fills picker with emoji autocomplete state on `more` click (#7466) 2019-05-01 16:19:45 +02:00
David Taylor 0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons (#7372)
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.

## Core

- Adds an SiteIconManager module which manages automatic resizing and fallback

- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon). 

- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.

- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations

## Wizard

- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload

- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"

- Various copy updates to support the changes

- Remove the "upload-time" resizing for `large_icon`. This is no longer required.

## Site Settings UX

- Move logo/icon settings under a new "Branding" tab

- Various copy changes to support the changes

- Adds placeholder support to the `image-uploader` component

- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings

- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name

## Dashboard Warnings

- Remove PWA icon and PWA title warnings. Both are now handled automatically.

## Bonus

- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
Arpit Jalan c6409fd2cc FIX: pass correct date arguments to server when exporting CSV 2019-05-01 10:46:30 +05:30
Arpit Jalan 002e1f560a FIX: initialize empty object if no custom filters are present 2019-05-01 10:27:19 +05:30
Tim Lange 539723f8ff FEATURE: Added unlisted topics option to advanced search (#7447) 2019-05-01 12:31:13 +10:00
Robin Ward 404b35bd04 FEATURE: Category Reviewable by Group
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
Robin Ward dd29af4475 REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
Roman Rizzi 404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin (#7433) 2019-04-30 15:36:54 -03:00
David Taylor 583226d295 FIX: Linking to `/new-topic` from `/latest`
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.

This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.

Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX 8e68244eea
FIX: prevents google to track certain pages (#7463) 2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX 726dd0fe37 Revert "FIX: prevents google to track certain pages (#7455)"
This reverts commit c863e62998.
2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX c863e62998 FIX: prevents google to track certain pages (#7455) 2019-04-30 13:59:55 +08:00
Guo Xiang Tan dca7f8ecf2 FIX: Loading more broken on groups page.
Regressed in 1f17d52f55.
2019-04-30 10:35:17 +08:00
Neil Lalonde a00354f11f Prettier site-settings/group-list.js.es6 2019-04-29 16:26:13 -04:00
Neil Lalonde 1ba72ccab8 DEV: add site setting type group_list for a list of groups
Add a js test
2019-04-29 16:15:22 -04:00
Penar Musaraj b75720d911 FIX: skip click-tracking for mentions 2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX 5768011cad
FIX: prevents exception in the composer with regexp flags 2019-04-29 16:58:17 +02:00
Penar Musaraj 629ae7a5b7 FIX: Revert tracking links in quotes 2019-04-29 10:30:04 -04:00
Bianca Nenciu aef35faefc FIX: Open links in external tabs. (#7444) 2019-04-29 10:27:29 -04:00
Penar Musaraj ca9fd95a08 FIX: Respect "open external links in new window" in quotes and edit history 2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX 286f2abc65
FIX: prevents exception when clicking directly on site text 2019-04-29 12:07:30 +02:00
Tim Lange 574f39f9d0 FIX: Fixed uploadPlaceholder regex failing on not escaped characters (#7442) 2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX 6952510fc4
FIX: restores skipHeader computed property 2019-04-26 23:43:49 +02:00
Tim Lange 1486328756 UX: Changed post stream placeholder to animation (#7434) 2019-04-26 17:29:48 +01:00
Joffrey JAFFEUX bcca2b5d73
FEATURE: initial implementation of generic filters for reports 2019-04-26 12:17:10 +02:00
Maja Komel 4b455e741e DEV: Ember 3.8.0
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
Vinoth Kannan be0ae2e487 FIX: plain text table detection should work even if html content not found. 2019-04-26 11:16:41 +05:30
Vinoth Kannan dc2ee78f7a UX: Only do plain text table detection in outside code if HTML pasting enabled
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
romanrizzi 34b772575e FIX: Return 'failed' attribute when catching an ajax error and the attribute is present 2019-04-25 14:49:52 -03:00
Joffrey JAFFEUX 7cbc4c1e46
FIX: uses no tags label for tag-drop header (#7438) 2019-04-25 13:16:06 +02:00
Joffrey JAFFEUX e386fa7674
FIX: ensures we have touches when starting pan event (#7435) 2019-04-25 10:36:41 +02:00
Tarek Khalil d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way (#7289)
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
Dan Ungureanu 3aa143a52c
SECURITY: Fix tab nabbing. 2019-04-25 00:11:28 +03:00
Tarek Khalil e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user (#7428) 2019-04-24 16:00:20 +01:00
Penar Musaraj 1a8c6577e0 FIX: refactor padding when exiting composer
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.

The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
Tarek Khalil ad61d87ffb
FIX: Do not replace text of collapsed ignore posts (#7422) 2019-04-24 13:54:46 +01:00
Penar Musaraj a452933071 FIX: disable input zoom on search in iOS 2019-04-24 08:41:20 -04:00
Tim Lange 104a9e79f9 UX: User card loading (#7404) 2019-04-24 11:55:09 +03:00
Joffrey JAFFEUX 7334362b77
FEATURE: generic theme component bbcode wrapper (#7400)
Usage:

```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
Bianca Nenciu b9339e15a1 FIX: Do not track a elements with no href. 2019-04-23 23:13:23 +03:00
Bianca Nenciu b81d169e2a FIX: Do not track user mentions. 2019-04-23 23:08:00 +03:00
Joffrey JAFFEUX c99faa6b25
FIX: improves locale support in tag-drop (#7418) 2019-04-23 17:53:59 +02:00
Joffrey JAFFEUX d4e788c136
FIX: improves share/invite behavior on mobile and especially iOS (#7416) 2019-04-23 17:07:31 +02:00
Tarek Khalil dc60128355
FIX: Hide ignoring users in preference for users with TL less than a member (#7415)
* FIX: Hide ignoring users in preference for users with TL less than a member
2019-04-23 14:47:37 +01:00
Gerhard Schlager a7bc1ecbae FEATURE: Add support for Unicode usernames and group names
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2019-04-23 13:00:27 +02:00
Bianca Nenciu 1867f2dda0
FEATURE: Always track clicks using AJAX. (#7373) 2019-04-23 12:41:36 +03:00
Dan Ungureanu c048b71b29
UX: Replace staff notice icon with user-shield. 2019-04-23 10:37:33 +03:00
Guo Xiang Tan 3ac18b92b3 UX: Editing theme name stays active when switching themes.
* Also fix length of input field.
2019-04-23 14:57:14 +08:00
Bianca Nenciu 58fe45ffd9 UX: Do not close login modal and search menu on outside mouse up event. (#7366) 2019-04-23 13:01:44 +10:00
Arpit Jalan a63ef4cfc8
FEATURE: better wizard privacy controls (#7391) 2019-04-22 19:47:29 +05:30
Dan Ungureanu f112f279ae
UX: Reorder post admin actions for greater consistency. 2019-04-22 10:57:14 +03:00
Guo Xiang Tan caeb035b61 FIX: Automatic scrolling in PM not working.
See https://stackoverflow.com/questions/18779708/scrolltop-with-animate-not-working
2019-04-22 10:52:46 +08:00
Joffrey JAFFEUX 151da50e7c
FIX: prevents exception when the node doesnt exist anymore (#7408) 2019-04-19 18:27:23 +02:00
Dan Ungureanu 57d1dea8a2
FEATURE: Let staff add custom post notices. (#7377) 2019-04-19 17:53:58 +03:00
Joe b150a57383
UX: don't clip staff shield in user cards (#7398) 2019-04-19 01:53:23 -07:00
Régis Hanol 19905e587b
Revert "UX: Show user card on load (#7380)" (#7403)
This reverts commit 66789d73c9.
2019-04-19 10:45:25 +02:00
Tim Lange 66789d73c9 UX: Show user card on load (#7380) 2019-04-19 09:20:03 +02:00
Tim Lange 1d0816b2cf UX: Changed error draft status to icon (#7369) 2019-04-19 09:18:01 +02:00
Kris cbe7166d87 UX: Move total user count 2019-04-19 00:35:50 -04:00
Robin Ward 85d8d5d092 FIX: Lint 2019-04-18 13:49:28 -04:00
Robin Ward 8e77b4d58e FIX: Replace references to flags in the header with review 2019-04-18 13:25:23 -04:00
Sam Saffron 7068b58e85 PERF: flush topic timings less frequently
This is a first step of a performance optimisation, more will follow

Previously we did not properly account for previously read topics while
"rushing" marking times on posts.

The new mechanism now avoids "rushing" sending timings to server if all
the posts were read.

Also to alleviate some server load we only "ping" the server with old timings
once a minute (it used to be every 20 seconds)
2019-04-18 17:31:08 +10:00
Maja Komel 1f17d52f55 UX: new layout for groups page, allow changes to automatic group bio (#7350) 2019-04-17 22:44:30 -04:00
Robin Ward cd2e93b598 FIX: Show when a post has been deleted in the flag review queue 2019-04-17 16:14:36 -04:00
Joe ee808dc682
UX: replace lightbox loading text with spinner (#7393) 2019-04-17 10:24:03 -07:00
Dannii Willis 16bfc29164 Move the trend icons on the admin dashboard inside the span (#7367)
so that it will have the tooltip as well
2019-04-17 18:11:01 +10:00
Maja Komel 5c795bc480 FIX: prevent anonymous users from changing their email/username/name (#7311) 2019-04-17 18:05:02 +10:00
Gerhard Schlager 7e8579b8aa UX: Add translations for lightbox 2019-04-16 17:03:01 +02:00
Joffrey JAFFEUX 5ec19987b4
FIX: attempts to fix a regression making touchs on emojis less reliable (#7383) 2019-04-16 12:31:33 +02:00
Guo Xiang Tan 347663e852 UX: Switch ellipsis direction when expanding web hook event details. 2019-04-16 14:28:23 +08:00
Robin Ward 3ceff0a92a FEATURE: Send the user a notification when their post is approved 2019-04-15 16:20:16 -04:00
Penar Musaraj de10bd7fb4 UI: Footer nav fixes
- moves footer nav to the header on iPads
- disables scrolling events for iPads
- removes footer nav entirely on Chrome PWAs
- toggles DiscourseHub iOS app status bar styling (dark/light) when opening/closing lightboxes and modals
2019-04-15 15:25:40 -04:00
Robin Ward fca3044b10 UX: When editing a reviewable, show created_by 2019-04-15 15:11:34 -04:00
Robin Ward d859e1594e UX: Add a description for scores 2019-04-15 14:21:25 -04:00
Kris 4b74525446 FIX: Group requests page missing wrapper 2019-04-15 14:16:02 -04:00
Penar Musaraj 14eb8eea01 FIX: Prevent input zooming in iOS
Since enabling pinch-to-zoom in iOS (eae22548de), there was an issue with inputs: Safari auto-zooms inputs with font-size under 16px. Now zooming will be disabled while focus is on an input.

This commit also removes a) a lightbox zoom-enabling event (no longer needed) and b) a comment about iOS zoom issues.
2019-04-15 13:05:43 -04:00
David Taylor fd0de64e0d UX: Render wizard previews for high-DPI displays (#7371)
* UX: Render wizard previews for high-DPI displays

Sets up a canvas element of twice the required dimensions, scales all coordinates by 2x, then shrinks the display in css.

* Use window.devicePixelRatio to determine scale factor
2019-04-15 16:16:05 +10:00
Tim Lange 00ee68f799 FIX: Fixed category reordering using arrow icons (#7374) 2019-04-15 10:56:21 +10:00
Robin Ward a5d9afe397 FEATURE: Include a user's pending posts in the topic view
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
2019-04-12 14:25:12 -04:00
Penar Musaraj 51630b5187 Footer nav tweaks 2019-04-12 12:29:54 -04:00
David Taylor 268d4d4c82
FEATURE: Multiple SCSS file support for themes (#7351)
Theme developers can include any number of scss files within the /scss/ directory of a theme. These can then be imported from the main common/desktop/mobile scss.
2019-04-12 11:36:08 +01:00
Dan Ungureanu 0e9a0a31f5
FIX: Show email for staged users in user cards. (#7354) 2019-04-12 12:50:43 +03:00
Sam Saffron 9bd3afda5d FIX: display conextual count on favicon if selected
This also corrects the test suite and moves the two notification counts
so they are closer together.
2019-04-12 10:04:23 +10:00
David Taylor 24ef4f7b2b Remove support for disable_jump_reply user setting (#7359) 2019-04-12 09:03:06 +10:00
David Taylor dc703adad7 FEATURE: Add user preference for title counter mode (#7364) 2019-04-12 09:02:18 +10:00
Penar Musaraj 60db57acc0 Make Prettier happy 2019-04-11 14:15:47 -04:00
Penar Musaraj f060c9b3ff UI: improvements to footer nav for app and PWAs
Adds support for iPad and Chrome PWAs

Better scroll direction logic when reaching bottom of the page
2019-04-11 14:11:26 -04:00
Robin Ward 331a809738 FEATURE: Display the reason for many reviewable items
Queued Posts and Users will now display a reason why they are in the
review queue.
2019-04-11 12:04:45 -04:00
Arpit Jalan 7143572e0c
FIX: correctly retrieve 'login required' setting value on wizard (#7355)
* FIX: correctly retrieve 'login required' setting value on wizard

FEATURE: extract 'invite only' setting in a separate checkbox control

* Update invite_only checkbox locale on wizard.

Co-Authored-By: techAPJ <arpit@techapj.com>
2019-04-11 20:25:08 +05:30
Tim Lange 9a428acce4 UX: Switched composer draft saving to animations (#7356) 2019-04-11 10:03:36 -04:00
Joffrey JAFFEUX 7226240df3
UX: full revamp of local-dates form (#7357) 2019-04-11 11:14:34 +02:00
Kris abd34882d5 UX: Better organization of category settings 2019-04-10 23:00:31 -04:00
Dan Ungureanu 7a7c6af21e
FIX: Fallback to last post when the in-view post cannot be detected.
In certain situations the detection method fails. For example, it fails
for a topic containing: a long post (~1600px height), gap, small action
(focus on this), hidden reply.
2019-04-11 01:14:59 +03:00
Kris 689c7f5410 Minor reviewable alignment fixes 2019-04-10 14:22:46 -04:00
Kris 1b6f18396b UX: Simplify merged reviewable table 2019-04-10 13:22:28 -04:00
Tim Lange fe9c271d44 FIX: Fixed deleted posts layout (#7348) 2019-04-10 19:00:39 +02:00
Penar Musaraj eae22548de
Footer navigation for iOS PWAs and DiscourseHub app (#7347) 2019-04-10 12:23:18 -04:00
Roman Rizzi 536b90e0ef
FEATURE: Support searching custom staff actions (#7346) 2019-04-10 09:53:17 -03:00
Tarek Khalil 442fb2facb FEATURE: Remove ignore feature SiteSetting and enable ignore by default (#7349) 2019-04-10 12:54:59 +02:00
Roman Rizzi 82e051077d Show link to the original topic when it was deleted (#7319)
* Moved i18n keys to core. We show a links that points to the original topic when it was deleted

* Use link-to since it's more idiomatic
2019-04-10 11:25:45 +02:00
Bianca Nenciu b5008586c5 DEV: Remove HTML parser from Tautologistics. (#7344) 2019-04-10 11:21:22 +02:00
Sam Saffron 88f8c9f43e FIX: when banner is removed update all clients
Previously removing a banner raised a null "banner" in the message bus
channel.

Then Ember.Object.create would fail cause it always expects an object in
constructor.
2019-04-10 15:59:29 +10:00
Kris df85d4593e UX: Unify admin intro styles for badges/customize, improve mobile 2019-04-09 20:32:24 -04:00
Robin Ward 9ebfdaa356 UX: Unify reviewable scores + history 2019-04-09 16:43:08 -04:00
Kris 8e9d0ceb67 UX: Mobile - fix editor button space, divider, extra upload icon 2019-04-09 13:15:31 -04:00
Tarek Khalil 307499e48b FIX: Keep highlighted text for quoted replies by ignored users (#7345) 2019-04-09 17:33:12 +02:00
Robin Ward 4552d86605 FIX: Broken tests 2019-04-09 08:33:10 -04:00
Joffrey JAFFEUX a89c90ed5d
FIX: removes link to old dashboard (#7341) 2019-04-09 09:24:41 +02:00
Vinoth Kannan f0f659286f UX: move up profile picture field next to the username 2019-04-09 11:46:03 +05:30
Robin Ward bc949cf684 FIX: Display the username instead of {{username}} 2019-04-08 16:46:05 -04:00
Robin Ward 32a0346069 UX: Don't show the username of the first user in the conversation 2019-04-08 16:39:53 -04:00
Robin Ward cc53f902c6 FIX: Missing translation key for Reviewable -> Deleted 2019-04-08 16:12:41 -04:00
Robin Ward 0fc798c2ef UX: Show the score status
If a review review score has been Approved/Rejected/Ignored then show it
2019-04-08 12:08:18 -04:00
Tarek Khalil 5957991340 FIX: Remove quoted post text and block realtime replies from ignored users (#7336) 2019-04-08 17:44:42 +02:00
Tarek Khalil 02394e9170
FIX: assign `decoratorHelper` (#7338) 2019-04-08 16:17:09 +01:00
Joffrey JAFFEUX 9d2e2867cc
s/fa-icon/d-icon (#7337) 2019-04-08 15:51:38 +02:00
Tarek Khalil 0d2a1fce51
REFACTOR: Pass down `currentUser` to `post-cooked` widget (#7333)
* REFACTOR: Pass down `currentUser` to `post-cooked` widget
2019-04-08 14:50:53 +01:00
David Taylor f524f8f811
Remove Yahoo login support from core and deprecate OpenID2.0 (#7310)
- Plugin developers using OpenID2.0 should migrate to OAuth2 or OIDC. OpenID2.0 APIs will be removed in v2.4.0

- For sites requiring Yahoo login, it can be implemented using the OpenID Connect plugin: https://meta.discourse.org/t/103632

For more information, see https://meta.discourse.org/t/113249
2019-04-08 10:38:25 +01:00
Vinoth Kannan ca57e18f42 UX: display signup cta even if 'must_approve_users' setting enabled. 2019-04-08 12:27:56 +05:30
Guo Xiang Tan 33fa249fa5 SECURITY: Remove XSS in composer preview when applying image scale buttons. 2019-04-08 11:22:14 +08:00
Robin Ward a6f283da30 UX: Show tags on flags too 2019-04-05 14:22:45 -04:00
Régis Hanol 06e3b25d04
FIX: 'currentUser' is a property of the 'widget' 2019-04-05 18:43:04 +02:00
Robin Ward b005a84530 FIX: `decoratorHelper.widget` is not always present 2019-04-05 12:07:24 -04:00
Kris acce7330a3 Typo fix 2019-04-05 11:23:22 -04:00
Kris 43a905279f FIX: Layout was off in single-page user-preferences 2019-04-05 10:59:52 -04:00
Robin Ward cbc311e4ed UX: Update the reviewable count before the message bus
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.

This patch synchronizes the review count every time:

1. The user visits the "Needs Review" page

2. Every time the user performs an action
2019-04-05 10:35:38 -04:00
Tarek Khalil 19a1d35f66
fix linting (#7329) 2019-04-05 15:28:41 +01:00
Tarek Khalil 131eba0366 FIX: Hide post replies content for ignored users (#7320) 2019-04-05 16:13:36 +02:00
Joffrey JAFFEUX 0bd480c600
UX: displays exact date on title attribute of topic timer info (#7326) 2019-04-05 09:44:10 +02:00
Angus McLeod 6f1652bb53 add header cloak after all panels are added (#7325) 2019-04-04 22:54:05 -07:00
Robin Ward aa4a38b08a FIX: computed is not used 2019-04-04 17:38:27 -04:00
Neil Lalonde 83996fc8ea FEATURE: ability to restrict some tags to a category while allowing all others
A new checkbox has been added to the Tags tab of the category settings modal
which is used when some tags and/or tag groups are restricted to the category,
and all other unrestricted tags should also be allowed.
Default is the same as the previous behaviour: only allow the specified set of
tags and tag groups in the category.
2019-04-04 16:40:15 -04:00
Kris 9faebfcfe0 UX: Adjust layout, allow additional responsiveness 2019-04-04 16:20:25 -04:00
Robin Ward dd5b8bd85e FIX: Show replies to the post, not the topic
This makes more sense when reviewing. How many people replied to this
objectionable thing?
2019-04-04 15:13:59 -04:00
Robin Ward 9c8cc73c39 UX: Show user fields when reviewing a user 2019-04-04 14:45:40 -04:00
Robin Ward a5182b0d6c FIX: Rewrite old `/admin/flags` links to use the review queue
Such links might be in present in old PMs. For example, a notification of
outstanding flags.

New PMs should receive the correct link but this prevents 404s in the
other case.
2019-04-04 10:15:23 -04:00
Bianca Nenciu 63fcd445f4 FIX: Use unfiltered URL when viewing all badges. 2019-04-04 12:35:03 +03:00
Robin Ward a4ff593506 UX: Slightly improved reviewable user display, plus link to admin if possible 2019-04-03 17:07:48 -04:00
Robin Ward 111a502231 FIX: Deleting Users should work nicely with Reviewable Users
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.

Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
2019-04-03 16:42:39 -04:00
Joffrey JAFFEUX 974007a3cc
FIX: reverts href removal from user/group cards links (#7318) 2019-04-03 19:16:48 +02:00
Bianca Nenciu bb2005d466 FIX: Add more links to bandge cards. 2019-04-03 18:37:11 +03:00
Robin Ward 62956003c3 FEATURE: Allow users to customize bonuses for reviewable types
A new settings section in the review queue allows admins to specify that
certain types of flags should be weighted higher than others.
2019-04-03 11:18:34 -04:00
Bianca Nenciu 1e1adb1afa FIX: Links in badge summary were not clickable. (#7303) 2019-04-03 11:35:27 +02:00
Maja Komel d32aaf374e UX: add awaiting-approval class to login modal
when local logins are disabled and account is awaiting approval
2019-04-03 11:30:43 +02:00
Guo Xiang Tan d1fa2b71cf FIX: Letters between words incorrectly highlighted within post. 2019-04-03 15:57:51 +08:00
Kris 14cbbc5e13 UX: Reviewables fixes 2019-04-02 16:25:53 -04:00
Penar Musaraj 44fe2eec03 Better fix for Safari user card position
Better than a2c6683e3b
2019-04-02 15:36:47 -04:00
Kris ba727b2875 UX: Restructure queued posts to match flags, fix text 2019-04-02 14:54:55 -04:00
Kris 2ab6eb58c5 UX: Reviewable layout improvements 2019-04-02 13:51:03 -04:00
Penar Musaraj 15e27d9e2c Prettier fix 2019-04-02 11:56:21 -04:00
Joffrey JAFFEUX 40e1ba9d9a
FIX: ensures click on emoji in picker doesnt propagate (#7308) 2019-04-02 17:40:13 +02:00
Joffrey JAFFEUX d8dd130477
UX: gives aria-label to topics count in category-row (#7307) 2019-04-02 17:38:21 +02:00
Joffrey JAFFEUX e77b1cf7ff
UX: ensures only <li> are used as top level in breadcrumb (#7306) 2019-04-02 17:37:53 +02:00
Penar Musaraj a2c6683e3b FIX: inconsistent user card position in Safari
User cards triggered in header were incorrectly positioned in Safari desktop.

Using `position()` instead of `offset()` is more consistent, since header is a fixed element in this scenario.
2019-04-02 10:32:50 -04:00
Arpit Jalan d68d29f37a FIX: only staff can banner topics 2019-04-02 12:46:55 +05:30
Tim Lange a9a35d2c19 FIX: Uncategorized pm not allowing edit (#7276) 2019-04-02 12:54:53 +08:00
Guo Xiang Tan 4175de5071 UX: Wrap title on search log term page with a proper div.
Search log filter selector was not floating right as it should.
2019-04-02 11:55:57 +08:00
Guo Xiang Tan 1a9452f24d UX: Pass period params when looking at search logs for a given term. 2019-04-02 11:51:41 +08:00
Kris 9603c906ec Moving staff counters back to the top of profiles 2019-04-01 21:04:37 -04:00
Robin Ward 6470c85fda UX: Link directly to the post, not to the topic 2019-04-01 14:29:14 -04:00
Penar Musaraj fdf4145d4b
FEATURE: Delegated authentication via user api keys (#7272) 2019-04-01 13:18:53 -04:00
Joffrey JAFFEUX 13a6a04cad
FIX: ensures popover is hidden when changing route (#7300) 2019-04-01 16:23:57 +02:00
Joffrey JAFFEUX 4b1b135ede
FIX: handles boolean with popupMenuOption (#7299)
Handle the case of https://github.com/discourse/DiscoTOC doing this kind of setup:

```
return {
    action: "insertDtoc",
    icon: "align-left",
    label: themePrefix("insert_table_of_contents"),
    condition: !composerController.get("model.canCategorize")
  };
```

In this case there's no function to call, it's already set.
2019-04-01 16:08:14 +02:00
Joffrey JAFFEUX e986e96227
DEV: removes old dashboard (#7295) 2019-04-01 12:39:49 +02:00
Joe 541a15e357 UX: user-card adjustments for users with hidden profiles (#7293)
* adds styles for profile hidden message

* Disable profile links for hidden profiles and add message to indicate the profile is hidden
2019-04-01 10:50:48 +02:00
Dan Ungureanu d59abff2d8
UX: Always use relative age for post notices. 2019-03-31 18:07:05 +03:00
Joe 8b8d528b88 Hide mobile cards when user scrolls (#7291) 2019-03-31 11:16:52 +02:00
Robin Ward c0780434f8 FIX: Better display if the topic is deleted 2019-03-29 16:59:00 -04:00
Robin Ward a55e7ebe8f UX: Better display for deleted users in the review queue 2019-03-29 16:52:58 -04:00
Robin Ward 67454c71c9 FIX: Missing translations for agree/disagree details 2019-03-29 14:14:59 -04:00
Kris 814aee343b UX: Minor profile page restructure 2019-03-29 12:52:42 -04:00
Tim Lange 2c4b3c21a9 UX: Unified emoji escape regex 2019-03-29 12:17:11 -04:00
Bianca Nenciu 31053f30de FEATURE: Let users delete their own topics. (#7267) 2019-03-29 17:10:05 +01:00
Tarek Khalil d26d1b387e
FEATURE: Add ignore duration selection for user notifications preferences page (#7269)
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 13:33:08 +00:00
Tarek Khalil b1cb95fc23
FEATURE: Introduce ignore duration selection (#7266)
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 10:14:53 +00:00
Guo Xiang Tan a6d93f6317 FIX: Avoid error on ajax.abort() when client has not opened the request. 2019-03-29 15:38:38 +08:00
Guo Xiang Tan 8cfd887f33 Make eslint happy. 2019-03-29 12:59:40 +08:00
Guo Xiang Tan 4fa8fe575b UX: Use a step size of 1.
Follow up to 634a213e6d.
2019-03-29 12:14:11 +08:00
Guo Xiang Tan 634a213e6d FIX: Admin chart y axis labels being rounded up/down when value is small. 2019-03-29 12:03:41 +08:00
Guo Xiang Tan e2ad374e5b UX: USe bar chart for admin search logs details page.
A bar chart is better when comparing the values across the X axis.
2019-03-29 11:54:49 +08:00
Guo Xiang Tan 947495e70d Follow up to 8c2fa99f78.
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
Guo Xiang Tan c42df7ddd7 UX: Use the same default period for search logs index and term.
If the period is different, clicking through to view a term is confusing
because a different period will show a different set of stats.
2019-03-29 09:59:28 +08:00
Guo Xiang Tan 8c2fa99f78 FIX: Remove `:term` from `admin/search_logs/term/:term` route.
Search log terms is a string that can contain characters like `/` which
messes with the route.
2019-03-29 09:48:20 +08:00
Guo Xiang Tan c836d67cac UX: Collapse advanced search on mobile when searching.
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
Robin Ward 3660b85614 FIX: Regressions in JS test suite 2019-03-28 14:15:52 -04:00
Robin Ward 8c98c18c2b FIX: Remove old flagging scss, fix more linting 2019-03-28 13:48:35 -04:00
Robin Ward 7ec74afc43 FIX: Lint on JS 2019-03-28 13:36:30 -04:00
Robin Ward b58867b6e9 FEATURE: New 'Reviewable' model to make reviewable items generic
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.

Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Gerhard Schlager d43f4206c7 FEATURE: Add Armenian language 2019-03-28 14:24:14 +01:00
Tim Lange 1b0267b077 FIX: Switching composer action shouldn't trigger abandon popup (#7261) 2019-03-27 21:55:09 +01:00
David Taylor 0d3531c2f1 FEATURE: Allow auth providers to define specific icons
Previously we relied on the provider name matching the name of the icon. Now icon names are explicitly set. Plugin providers which do not define an icon will get the default "sign-in-alt" icon
2019-03-27 13:25:04 +00:00
Bianca Nenciu a9798f0c47
FEATURE: Add page for all group membership requests. (#6909) 2019-03-27 13:30:59 +02:00
Tarek Khalil ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels (#7248)
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
Joffrey JAFFEUX 675d950eab
FIX: corrects link to moderators_activity report (#7265) 2019-03-27 10:14:42 +01:00
Gerhard Schlager de011b53b5 UX: Hide link to incoming email when there is no bounce key
For example, webhooks mark email log entries as bounced without there ever being an incoming email.
2019-03-26 18:00:27 +01:00
Joffrey JAFFEUX b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser (#7260) 2019-03-26 16:45:38 +01:00
Joffrey JAFFEUX 8fb63b2706
FEATURE: unified popover implementation (#7244) 2019-03-26 15:43:27 +01:00
Maja Komel 3aa32c3170 FIX: send only one post request when changing topic notification level (#7254) 2019-03-26 12:04:33 +01:00
Guo Xiang Tan e0cb2a434a Fix regression introduced in dae0bb4c67.
Add tests so it doesn't bite me again.
2019-03-26 17:52:37 +08:00
Guo Xiang Tan dae0bb4c67 FIX: Post blurb incorrect when search contains a phrase match.
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
2019-03-26 17:01:52 +08:00
Penar Musaraj 47a0e4b906 UX: improve mobile search
Improves usability of header search icon while user is already in full page search in mobile.

Currently, hitting search icon a second time empties input and does not scroll up to show search form.

This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
Kris df279251b7 REFACTOR: More consistent user/group page layouts 2019-03-25 14:40:22 -04:00
Gerhard Schlager 60e6070c27 UX: Show spinner during text replacement 2019-03-25 16:47:55 +01:00
Joe ec2123809f FEATURE: user and group cards on mobile (#7246) 2019-03-25 13:37:17 +01:00
Bianca Nenciu f072da1bfe
FEATURE: Add every month / 6 months options to email digest. (#7247) 2019-03-25 12:45:01 +02:00
Tim Lange dcd56cf593 FIX: Fixed changing composer mode escaping title (#7191) 2019-03-25 13:14:26 +05:30
Guo Xiang Tan ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. (#7209) 2019-03-25 10:59:55 +08:00
Guo Xiang Tan ce75e30bf5 UX: Indent category badges to indicate sub-categories. 2019-03-25 10:36:29 +08:00
Tim Lange da187f0967 FIX: Clear unsaved groups when switching user (#7236) 2019-03-22 12:46:36 +01:00
tshenry 48d0465f72 FEATURE: Improve avatar education link (#7240)
* Make profile_path more direct to setting

* Add id to profile picture setting for easy linking
2019-03-22 02:20:48 -07:00
Sam Saffron 68fe6b8d53 FIX: suppress autocomplete on group filter 2019-03-22 17:02:04 +11:00
Guo Xiang Tan 7aab7e9062 Revert "UX: Don't reload page after saving settings when editing category."
This reverts commit dd142eec03.

We need a fully reload when reordering.
2019-03-22 13:10:30 +08:00
Osama Sayegh 67b96ad2ff FIX: discourse client should know about Logster (simpler approach) (#7237)
* Revert "FIX: discourse client should know about Logster (#7232)"

This reverts commit bfcbc4d2d6.

* FIX: discourse client should know about Logster (simpler approach)
2019-03-22 08:48:57 +11:00
Régis Hanol e1e46f0dff FIX: topic with no tags 2019-03-21 19:40:10 +01:00
Maja Komel 1f1d3909e5 UX: add more tag classes to topic view (#7228)
adds tag classes where there is already category-* class
2019-03-21 17:49:50 +01:00
Maja Komel 34730a0b16 UX: show if webhook is disabled (#7217)
+ show in staff logs when webhook is created/updated/destroyed
2019-03-21 16:13:09 +01:00
Osama Sayegh bfcbc4d2d6
FIX: discourse client should know about Logster (#7232) 2019-03-21 16:54:55 +03:00
Tim Lange d16a0db4e1 UX: Enabled sorting for more columns in admin user list (#7208) 2019-03-21 17:16:58 +08:00
Bianca Nenciu fdd2e7f2e7 FIX: Do not update last seen notification ID when forced to enable 2FA." (#7222) 2019-03-21 09:27:22 +01:00
Tim Lange f7b156ffbd UX: Better emoji escaping for topic title (#7218)
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
2019-03-21 09:11:33 +01:00
Gerhard Schlager 41c7423985 UX: Use a less technical term ("replace") for reseeding (#7223) 2019-03-21 16:22:07 +11:00
Penar Musaraj 3c7eb74f51 DEV: no delaying topic scroll in tests 2019-03-20 15:24:06 -04:00
Joffrey JAFFEUX 45ef2ec8cd
DEV: do not wait for closed composer event on test (#7221) 2019-03-20 20:13:15 +01:00
Kris 88a3b89990 UX: Improve user profile header layout on mobile 2019-03-20 14:56:34 -04:00
Maja Komel f3d0d8fe7d Upgrade to Ember 3.7.0 2019-03-20 14:43:25 +01:00
Joe 6f1badc7c9 REFACTOR: user and group card CSS / template refactor (#6812)
* Check if user is a member of a group or if the group has members 
this is used in the template to conditionally show the relevant markup

* Check if user is suspended or if they have a bio
this is used in the template to conditionally show the relevant markup

* Simplify group-card template

* Simplify user-card template

* Refactor user and group cards CSS

* Check if user is new or if user is staff

* Style fixes

- round avatar margin 
- use a more standard margin for buttons
- adds lighter font color for new users
- makes some suspension text bold (used to be <b> tags in template)
- ensures images in group bio are responsive

* user card template fixes

- adds quotes to link href attributes
- wraps some strings in tags for more consistent styling

* group card fixes

- adds quotes to link href attributes
- fixes membership button login action
- wraps some strings with tags for consistent styling

* closure action fixes

* closure action fix

* uses core variables instead of new colors and removes unused styles

* Uses better property names
2019-03-20 10:45:49 +01:00
Guo Xiang Tan 8d1709f6b9 FIX: Disable buttons when loading more results on full page search.
Follow up to d50deac676.
2019-03-20 17:20:34 +08:00
tshenry cc8082138f
Fix typos 2019-03-20 00:06:12 -07:00
Sam Saffron d46ce0cb21 DEV: speed up ember acceptance tests
## Before

```
Acceptance: Composer::Image resizing buttons: 7985ms
Acceptance: Composer::Edit the first post: 3854ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 3707ms
Acceptance: Composer::Composer can toggle between edit and reply: 3704ms
Acceptance: Composer::Tests the Composer controls: 3685ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 3670ms
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 3278ms
Acceptance: Composer::Switching composer whisper state: 3266ms
Acceptance: Composer::Create a topic with server side errors: 3253ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 3189ms
Acceptance: Composer::Create a Topic: 3168ms
Acceptance: Composer::Create an enqueued Topic: 2767ms
Acceptance: Composer::Posting on a different topic: 2394ms
Acceptance: Composer::Composer can switch between edits: 2318ms
Acceptance: Composer::Create an enqueued Reply: 2317ms
Acceptance: Composer::Create a Reply: 2292ms
Acceptance: Composer::Checks for existing draft: 1696ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1415ms
Acceptance: Composer::Composer can toggle whispers: 1296ms
Acceptance: Composer::Loading draft also replaces the recipients: 594ms
```

## After

```
Acceptance: Composer::Composer can toggle layouts (open, fullscreen and draft): 2305ms
Acceptance: Composer::Switching composer whisper state: 2205ms
Acceptance: Composer::Composer draft with dirty reply can toggle to edit: 2185ms
Acceptance: Composer::Composer can toggle between edit and reply: 1719ms
Acceptance: Composer::Composer with dirty edit can toggle to another edit: 1682ms
Acceptance: Composer::Composer with dirty reply can toggle to edit: 1657ms
Acceptance: Composer::Composer can toggle between reply and createTopic: 1412ms
Acceptance: Composer::Posting on a different topic: 1341ms
Acceptance: Composer::Edit the first post: 1327ms
Acceptance: Composer::Create an enqueued Reply: 1306ms
Acceptance: Composer::Composer can toggle whispers: 1265ms
Acceptance: Composer::Composer can switch between edits: 1260ms
Acceptance: Composer::Create a Reply: 1259ms
Acceptance: Composer::Create a topic with server side errors: 1183ms
Acceptance: Composer::Checks for existing draft: 1172ms
Acceptance: Composer::Create a Topic: 1130ms
Acceptance: Composer::Image resizing buttons: 921ms
Acceptance: Composer::Create an enqueued Topic: 731ms
Acceptance: Composer::Tests the Composer controls: 654ms
Acceptance: Composer::Loading draft also replaces the recipients: 540ms

```


That is not a typo... image resizing button went from 8 seconds to 1 second
2019-03-20 16:44:00 +11:00
Guo Xiang Tan d50deac676 FIX: Search spinners hides all results when loading more.
Regression from bc81f64a64.
2019-03-20 13:34:56 +08:00
Bianca Nenciu 50e9a66e89 FIX: Improve UX for second factor enforcement. (#7207) 2019-03-20 15:40:25 +11:00
Vinoth Kannan 0861ca7764 FIX: Don't push browser state if navigated from root url to home page url and vice versa 2019-03-19 19:22:06 +05:30
Régis Hanol 6fb49e74a1
Revert "UX: Better emoji escaping for topic title (#7176)" (#7201)
This reverts commit 0d9bc0aaa6.
2019-03-19 12:02:47 +01:00
Joe 6d7c0c8f13
REFACTOR: scroll-based mobile header switch
This refactor addresses the following issues:

1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.

Other than that, everything should look and act the same.
2019-03-19 18:39:38 +08:00
Tim Lange 0d9bc0aaa6 UX: Better emoji escaping for topic title (#7176) 2019-03-19 09:33:10 +01:00
Guo Xiang Tan dd142eec03 UX: Don't reload page after saving settings when editing category. 2019-03-19 16:08:32 +08:00
Guo Xiang Tan bc81f64a64 UX: Show spinner when searching on full page search. 2019-03-19 15:23:27 +08:00
Gerhard Schlager 3fd04df781
FEATURE: Locale support for seeded categories and topics (#7110) 2019-03-18 21:09:13 +01:00
Maja Komel 5d20d02ffc UX: add tag classes to topics in topics list view (#7198) 2019-03-18 13:58:29 -04:00
David Taylor e2d6edd5ff DEV: Correct email disabled banner tests
Followup to acc121fd27
2019-03-18 17:06:29 +00:00
Dan Ungureanu 976ea160e9
FEATURE: Post notices become old after 14 days. (#7197) 2019-03-18 18:20:49 +02:00
Gerhard Schlager c0a7b06777 Make eslint happy 2019-03-18 16:48:09 +01:00
David Taylor acc121fd27 FIX: Show 'emails disabled' to staff users when disabled for non-staff (#7187) 2019-03-18 16:26:18 +01:00
Tim Lange 22c75e1c04 FIX: Fixed edit category description redirecting without saving (#7192) 2019-03-18 16:14:17 +01:00
Tim Lange 298f18cf70 UX: Enabled pinch to zoom for lightbox (#7161)
* UX: Enabled pinch to zoom for lightbox

* FIX: Prettier for lightbox.js

* FIX: Only change content of meta tag
2019-03-18 10:57:24 -04:00
venarius 3dfa22b55a FIX: Prettified code 2019-03-18 10:54:20 -04:00
venarius 4af0a2f00b FIX: Made reorder more convenient by clamping the entered number 2019-03-18 10:54:20 -04:00
venarius ad363f45f0 FIX: Fixed reorder categories by number not working correctly 2019-03-18 10:54:20 -04:00
David Taylor 4e8c174ee5
FEATURE: Display notification count in title for logged in users (#7184)
This replaces the 'contextual' counters for logged in users. We will still use the old method for anon users
2019-03-18 12:59:47 +00:00
Arpit Jalan 0c01cb2cf3 UX: add instructions to update email when sso_overrides_email is enabled 2019-03-18 16:52:40 +05:30
Guo Xiang Tan 5e410dc5e0
FEATURE: Ability to exclude category from search results. (#7194)
This commit also adds `Category#search_priority` which sets the ground
work to enable prioritizing of posts for certain categories when searching.
2019-03-18 15:25:45 +08:00
Joffrey JAFFEUX de6a7e32bd
FIX: brings back [+ New Topic] btn from share-popup post action (#7182) 2019-03-18 07:30:10 +01:00
Sam Saffron c47b0a8bee Revert "UX: Added tooltips to topic admin menu (#7146)"
This reverts commit d1c4981f65.

Per discussion with @coding-horror it was decided this change is to
far reaching.

Instead we will make smaller strategic changes to tooltips that add
value.
2019-03-18 11:50:18 +11:00
Joffrey JAFFEUX e76b598e0f
FIX: ensures add/remove btn is shown if you can only invite (#7185) 2019-03-15 20:20:42 +01:00
Penar Musaraj 9334d2f4f7
FEATURE: add more granular user option levels for email notifications (#7143)
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by

* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
2019-03-15 10:55:11 -04:00
Tarek Khalil f8480ed911
FEATURE: Exposing a way to add a generic report filter (#6816)
* FEATURE: Exposing a way to add a generic report filter

## Why do we need this change?

Part of the work discussed [here](https://meta.discourse.org/t/gain-understanding-of-file-uploads-usage/104994), and implemented a first spike [here](https://github.com/discourse/discourse/pull/6809), I am trying to expose a single generic filter selector per report.

## How does this work?

We basically expose a simple, single generic filter that is computed and displayed based on backend values passed into the report.

This would be a simple contract between the frontend and the backend.

**Backend changes:** we simply need to return a list of dropdown / select options, and enable the report's newly introduced `custom_filtering` property.

For example, for our [Top Uploads](https://github.com/discourse/discourse/pull/6809/files#diff-3f97cbb8726f3310e0b0c386dbe89e22R1423) report, it can look like this on the backend:

```ruby
report.custom_filtering = true
report.custom_filter_options = [{ id: "any", name: "Any" }, { id: "jpg", name: "JPEG" } ]
```

In our javascript report HTTP call, it will look like:

```js
{
  "custom_filtering": true,
  "custom_filter_options": [
    {
      "id": "any",
      "name": "Any"
    },
    {
      "id": "jpg",
      "name": "JPG"
    }
  ]
}
```

**Frontend changes:** We introduced a generic `filter` param and a `combo-box` which hooks up into the existing framework for fetching a report.

This works alright, with the limitation of being a single custom filter per report. If we wanted to add, for an instance a `filesize filter`, this will not work for us. _I went through with this approach because it is hard to predict and build abstractions for requirements or problems we don't have yet, or might not have._

## How does it look like?

![a1ktg1odde](https://user-images.githubusercontent.com/45508821/50485875-f17edb80-09ee-11e9-92dd-1454ab041fbb.gif)

## More on the bigger picture

The major concern here I have is the solution I introduced might serve the `think small` version of the reporting work, but I don't think it serves the `think big`, I will try to shed some light into why.

Within the current design, It is hard to maintain QueryParams for dynamically generated params (based on the idea of introducing more than one custom filter per report).

To allow ourselves to have more than one generic filter, we will need to:

a. Use the Route's model to retrieve the report's payload (we are now dependent on changes of the QueryParams via computed properties)
b. After retrieving the payload, we can use the `setupController` to define our dynamic QueryParams based on the custom filters definitions we received from the backend
c. Load a custom filter specific Ember component based on the definitions we received from the backend
2019-03-15 12:15:38 +00:00
Bianca Nenciu d352baa1a2
FEATURE: Enforce two-factor authentication. (#6348) 2019-03-15 13:09:37 +02:00
Joffrey JAFFEUX e711d3cb3a
FIX: prevents quote shortcut key to show in composer before quote (#7177) 2019-03-15 12:01:38 +01:00
Tim Lange 37c613dde2 FIX: Outsourced erb part from emoji.js.es6 (#7168) 2019-03-15 15:44:49 +11:00
Vinoth Kannan bec3956f7f
FIX: Topic filters persist when navigating to home page (#7175)
* FIX: Topic filters persist when navigating to home page

* remove the line which no longer needed
2019-03-15 09:45:17 +05:30
Rafael dos Santos Silva fb8bcd7469
FEATURE: Enable experimental Badging API (#7173) 2019-03-14 18:16:16 -03:00
Gerhard Schlager c34a6ba674 REFACTOR: Rename site settings to make them less confusing 2019-03-14 13:40:14 +01:00
Guo Xiang Tan b9ab393d70 Fix favicon not updating on the client side when changed.
Regression from 1c6a2262b3.

Documented the rational for include the url since we can't really test
this properly.
2019-03-14 15:37:43 +08:00
Guo Xiang Tan 1c6a2262b3
FIX: `StaticController#favicon` reads from disk when using local store. (#7160)
Since uploads site settings are now backed by an actual upload, we don't
have to reach over the network just to fetch the favicon. Instead, we
can just read the upload directly from disk.
2019-03-14 04:17:36 +08:00
Dan Ungureanu 81bf4df1a5
DEV: Fix lint. 2019-03-13 21:32:28 +02:00
Dan Ungureanu 18ff790e79
FIX: Use prioritize_username_in_ux in post notices. 2019-03-13 21:17:41 +02:00
Roman Rizzi 77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 (#6977)" (#7165)
This reverts commit 3eebf8be73.
2019-03-13 15:49:47 -03:00
Maja Komel 65f3ed0689 UX: make name optional for confirmation user field (#7149) 2019-03-13 18:40:43 +01:00
Maja Komel 12c37ada2e UX: focus on search box when emoji picker is opened (#7098) 2019-03-13 17:48:40 +01:00
Dan Ungureanu 91bd0becaa DEV: Allow topics to register default topic order criteria. (#7158) 2019-03-13 16:44:08 +01:00
Vinoth Kannan c773f82ba1 DEV: Added qunit test functions and did minor refactoring
135191d1d1
2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX d32557ea32 Revert "FIX: Better emoji escaping for topic title"
This reverts commit 35426b5ad6.
2019-03-13 13:02:56 +01:00
Maja Komel 3eebf8be73
DEV: Upgrade to Ember 3.7.0 (#6977)
* Upgrade to Ember 3.7.0

* use ember source 3.7.0.2

* fix mobile header

* fix navigation
2019-03-13 12:16:06 +01:00
Vinoth Kannan 1b454c73ae FIX: 'topic' can have null value 2019-03-13 16:34:47 +05:30
Tim Lange 35426b5ad6 FIX: Better emoji escaping for topic title
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Vinoth Kannan 135191d1d1 DEV: Option to add extra topic status icons in its widget and component
and did some refactoring
2019-03-13 15:17:26 +05:30
Guo Xiang Tan b0c8fdd7da FIX: Properly support defaults for upload site settings. 2019-03-13 16:36:57 +08:00
Tim Lange d1c4981f65 UX: Added tooltips to topic admin menu (#7146)
* UX: Added tooltips to topic admin menu

* FIX: Prettyfied code

* FIX: Fixed typo

* Update config/locales/client.en.yml

Co-Authored-By: venarius <tim.lange@online.de>
2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX edc6d87862 FIX: invite-panels regressions on private topics (#7157) 2019-03-13 16:34:23 +11:00
Tarek Khalil db08b59eb2
UX: Change `ignore` button color (#7150) 2019-03-12 11:10:18 +00:00
Joffrey JAFFEUX 90965e1c18
FIX: error with two inputs having the same id (#7147) 2019-03-12 09:46:58 +01:00
Bianca Nenciu e6c2faf186 FIX: Disable 'Create Topic' button if tag is staff-only. (#6984)
* FIX: Disable 'Create Topic' button if tag is staff-only.

* FIX: Staff-only tags should always return 404.
2019-03-12 19:23:36 +11:00
venarius dc4541a95c FIX: Text content search warning if more than 50 results 2019-03-11 12:56:15 -04:00
Robin Ward da7406e567 Update app/assets/javascripts/discourse/controllers/full-page-search.js.es6
Co-Authored-By: venarius <tim.lange@online.de>
2019-03-11 11:33:24 -04:00
venarius 5f00624814 FIX: Fixed vanishing select boxes on full search as new content loads 2019-03-11 11:33:24 -04:00
Neil Lalonde cbc8236288 UX: add a paragraph description on the tags tab of the category settings 2019-03-08 16:46:32 -05:00
Dan Ungureanu 35942f7c7c
FEATURE: Special call-out for new / returning posters. (#7115) 2019-03-08 10:48:35 +02:00
Simon Cossar 65464969cd Change searchTearm to searchTerm (#7130) 2019-03-08 09:24:14 +01:00
Joffrey JAFFEUX 3acf8a95f3
UX: various tweaks to search-menu (#7114) 2019-03-08 09:23:44 +01:00
Joffrey JAFFEUX c90267db52
FIX: do not display add/remove participants if you can’t actually do it (#7125) 2019-03-08 09:23:26 +01:00
Kris ccff1d2dbb prettier 2019-03-07 13:30:39 -05:00
Kris 837452794b Target active nav pill with single style 2019-03-07 13:21:42 -05:00
Arpit Jalan 2c8e1d3578 FEATURE: remove all expired invitations by default 2019-03-07 15:28:39 +05:30
Arpit Jalan caef0a56d1 FEATURE: create a new message via URL without specifying user or group 2019-03-07 11:30:24 +05:30
Kris a917a93990 fix active class, remove style 2019-03-06 17:29:19 -05:00
Bianca Nenciu 733deba585 FIX: Loading draft also replaces the recipients (#7122) 2019-03-07 08:14:55 +11:00
Kris 078c02cd24 UX: More consistent structure for active nav-pill 2019-03-06 16:10:22 -05:00
Vinoth Kannan 5ba2ef4274 UX: Display error message if no time frame selected in topic status update 2019-03-07 02:17:29 +05:30
Kris 2db3652338 UX: Fix redeemed invite table layout 2019-03-06 11:05:45 -05:00
Kris 5cf63e43c6 FEATURE: Add about-after-description plugin outlet 2019-03-06 10:26:34 -05:00
Tarek Khalil 0a9a11094d
FEATURE: Save ignored usernames in user preferences (#7117)
* FEATURE: Save ignored usernames in user preferences
2019-03-06 11:21:58 +00:00
Tarek Khalil b58eea1fcb
FEATURE: Hide ignored user's Original Post content (#7113)
* FEATURE: Hide ignored user's Original Post content
2019-03-06 09:20:45 +00:00
Arpit Jalan 05ebb52ec4
FEATURE: defer flags when deleting child replies (#7111) 2019-03-06 14:32:25 +05:30
Kris b5804c410e UX: Add slash to mobile category page totals 2019-03-05 20:16:12 -05:00
Kris 84892429ed UX: Improve layout of invite table 2019-03-05 14:50:27 -05:00
Gerhard Schlager 671cec4bd2 DEV: Use Discourse.getURL for creating URL
follow-up to ccb48bef75
2019-03-05 17:52:18 +01:00
Tarek Khalil 190b19f3c2
FEATURE: Add ignored user list to the User's preference page (#7107)
* FEATURE: Add ignored user list to the User's preference page

## Why?

Part of: https://meta.discourse.org/t/ability-to-ignore-a-user/110254

We want to add list of Ignored users under or along with the muted users preferences section.
This way Users can find and update their list of ignored users.

## UI


![gif](https://user-images.githubusercontent.com/45508821/53746179-8e9b3c00-3e98-11e9-9e90-94b8520896a6.gif)

## Open questions

Two of many options to represent a list of ignored users is that we can:

1. We can represent the ignored user list as a table with the ability to `un-ignore` but NOT to add new ignored users.
2. We can keep it functioning as the `muted user list` where you can `un-ignore` or `ignore` users.
2019-03-05 14:47:51 +00:00
Tarek Khalil f19d36cbba
REFACTOR: Change `watch` wording to `unignore` (#7112)
* REFACTOR: Change `watch` wording to `unignore`
2019-03-05 14:40:31 +00:00
Gerhard Schlager ccb48bef75 UX: Make Uncategorized category less confusing
* Adds warnings to the "Edit Category" dialog
* Doesn't hide the "Security" tab on the "Edit Category" dialog anymore. Instead, it shows an explanation why permissions can't be changed.
* Makes the category name translatable
* Hides the category name from the edit dialog (it can be customized by overriding the translation)
* Creates a translation override if the category has been renamed in the past
2019-03-05 14:42:41 +01:00
Gerhard Schlager 68e4aba369 UX: Don't concatenate title on "Edit Category" dialog 2019-03-05 14:42:41 +01:00
Tarek Khalil 079b0f4bff
FIX: Remove ignore user feature from `user-card-contents` component (#7104)
Based on our discussions, we want to have the `Ignore button will ONLY be on the User’s profile page`.
2019-03-04 15:21:45 +00:00
Joffrey JAFFEUX 2e881adb6e
FIX: select-kit perf and positioning improvements (#7093) 2019-03-04 10:30:22 +01:00
Joffrey JAFFEUX dc4001370c
FEATURE: displays groups in menu search (#7090) 2019-03-04 10:30:09 +01:00
Joffrey JAFFEUX 075b264338
DEV: replaces DOMNodeInserted by the better MutationObserver (#6884) 2019-03-04 10:28:59 +01:00
Arpit Jalan 824d9402a4 FIX: pending counts were not shown on invites tab 2019-03-04 14:14:13 +05:30
Joffrey JAFFEUX bb39a6f7d7 REFACTOR: topic-list-header-column (#7099) 2019-03-04 14:45:52 +11:00
Jeff Atwood 9585e2dff2 change separator from | to • for editor image sizing 2019-03-03 17:55:21 -08:00
Gerhard Schlager 14f9e55977 FIX: Error when filtering site settings
Happened only when none of the logo settings had an image assigned.
2019-03-03 20:43:22 +01:00
Dan Ungureanu fd9671f7fe
DEV: Minor code improvements. 2019-03-02 19:07:54 +02:00
Sam 03a70ef69c FIX: allow underscore and dash in username search
_ and - are technically punctuations, but we allow them in usernames so
accept them in search
2019-03-01 15:23:45 +11:00
Sam cdf34657f6 FEATURE: focus on composer TEXTAREA when iPad has a physical keyboard
This disables a bunch of hacks that bypassed "focus" on iOS (cause focus
events that involve a virtual keyboard on iOS cause browser havoc unless
a physical keyboard is attached)

Also will focus on title on new topic
2019-03-01 11:31:52 +11:00
Dan Ungureanu 6bc8382555 FEATURE: Use smooth scrolling for J/K keyboard shortcuts. (#7084) 2019-03-01 09:31:40 +11:00
Vinoth Kannan be436066ff FIX: Prevent default event and stop bubbling up when card popup is closed in mobile 2019-03-01 01:42:17 +05:30
Penar Musaraj 64a3d63ddc DEV: Rename some icons with deprecated names 2019-02-28 13:03:14 -05:00
David Taylor e67474daf4 UX: Don't link to theme source unless it's http(s) 2019-02-28 17:01:59 +00:00
Joffrey JAFFEUX 1cd64f68f1
FIX: staff/admin shouldn’t be able to create uncategorized topics (#7077) 2019-02-28 15:51:13 +01:00
David Taylor 3517103398 UX: Correct locale key for theme compatibility error 2019-02-28 14:40:33 +00:00
Arpit Jalan c02956e29c
FIX: when posts are moved to a message then small action post should not be publicly visible (#7085)
This fix is inspired from what we do in discourse-assigned plugin.
https://github.com/discourse/discourse-assign/blob/master/lib/topic_assigner.rb#L184
https://github.com/discourse/discourse-assign/blob/master/assets/javascripts/discourse-assign/initializers/extend-for-assigns.js.es6#L125-L133
2019-02-28 19:49:26 +05:30
Maja Komel bb5119b88f FIX: only profile owner can see links to watched/tracked/muted topics (#7083) 2019-02-28 14:58:49 +01:00
Joffrey JAFFEUX 883a18547e
FIX: shows invite panel on mobile from topic footer buttons (#7080) 2019-02-28 14:56:22 +01:00
David Taylor 6296554ed1 DEV: Add additional hook for theme-creator 2019-02-28 10:48:30 +00:00
Sam 06abecdb41 FEATURE: on iPad bluetooth keyboard use ALT-ENTER for post submit
Command and Control can not be properly detected via JavaScript so lean on
Alt that can be detected.
2019-02-28 16:41:31 +11:00
Sam 0b86a99c39 FEATURE: allow iPad users to specify they have a physical keyboard
Sadly there is no clean way of detecting a keyboard is connected to an iPad

If the keyboard is connected we want to disable all the touch related hacks
on iOS

This allows iPad users to specify they have a keyboard connected. Setting
is per device.
2019-02-28 15:59:44 +11:00
Kris cafbb3aea7 UX: Use official Facebook logo 2019-02-27 09:52:06 -05:00
Tarek Khalil 986cc8a0fb FEATURE: Introduce Ignore user (#7072) 2019-02-27 14:49:07 +01:00
Joffrey JAFFEUX 5c476f639c
REFACTOR: user-invited-show (#7078) 2019-02-27 12:59:57 +01:00
Joffrey JAFFEUX 8ff3fc20a6
REFACTOR: tags-show (#7079) 2019-02-27 12:59:39 +01:00
Maja Komel 7d2ea2d4dd FEATURE: image resizing discoverability (#6804) 2019-02-27 11:46:16 +01:00