14738 Commits

Author SHA1 Message Date
Arpit Jalan
6d35b62238 add image type attribute to icon link tag 2017-09-08 12:48:30 +05:30
Guo Xiang Tan
5d4221fbe1 PERF: Avoid calling expensive PostGuardian#can_see_post? multiple times.
Before

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 19
  75: 19
  90: 21
  99: 27
topic:
  50: 56
  75: 62
  90: 64
  99: 99
timings:
  load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```

After

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 18
  75: 18
  90: 20
  99: 28
topic:
  50: 41
  75: 42
  90: 46
  99: 49
timings:
  load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Arpit Jalan
164a388dcc Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
Robin Ward
f6fb94d31f UX: Flags lost their red color on dropdown 2017-09-07 16:22:31 -04:00
Leo McArdle
e183600563 FIX: redirect loop for new users visiting /new-topic using full screen login 2017-09-07 21:02:41 +01:00
Arpit Jalan
a9737e2813 Merge pull request #5133 from guoyunhe/patch-1
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
Joffrey JAFFEUX
d2d1c29f48 FIX: topic-notifications was taking too much space on mobile 2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX
3c0a9d4d19 FIX: topic-notifications taking too much space in timeline 2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX
5054065e81 FIX: broken spec 2017-09-07 19:18:27 +02:00
Robin Ward
afc075d93b UX: Convert bookmark icon from CSS to a proper icon using our helper 2017-09-07 11:41:19 -04:00
Robin Ward
0ba789de17 Allow for customization of header dropdown icons 2017-09-07 11:18:59 -04:00
Robin Ward
8e88bf019f Add span to various labels so they can be targetted 2017-09-07 11:10:11 -04:00
Joffrey JAFFEUX
70d0e175a2 FIX: default select-box-row should be aligned vertically 2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX
0374dc1a0e FIX: keys were incorrectly set to category 2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX
633d2fde45 removes select-box minWidth property
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX
ca58a8228c minor css fixes on select-box 2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX
d04aa5c7af FIX: component height computation was wrong 2017-09-07 16:55:36 +02:00
Leo McArdle
0ce9098339 add admin-user-details plugin outlet (#5141) 2017-09-07 16:17:27 +02:00
David Taylor
7d350d0d75 Revert plugin js changes (#5139)
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134)"

This reverts commit b840170f8da3c2fb841d55e1192a3522cbe5ae87.

* Revert "Do not load javascripts for disabled plugins (#5103)"

This reverts commit a14ab488294215063a08448c29a819edf1b633d8.
2017-09-07 15:15:29 +02:00
Joffrey JAFFEUX
dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
Guo Xiang Tan
4d840d10db PERF: Reduce number of Redis hits per requests. 2017-09-07 13:34:27 +08:00
Robin Ward
a1957b7723 FIX: Stop moving notifications on large screens 2017-09-06 17:35:35 -04:00
Régis Hanol
8a935a4b5f FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days 2017-09-06 22:35:08 +02:00
Joffrey JAFFEUX
0fca5ed533 FIX: stricter check on presence of notification_level_change
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
Robin Ward
825452df76 Refactor header CSS for composability 2017-09-06 11:34:10 -04:00
Robin Ward
777f024b8c Clean up weird indentation 2017-09-06 11:34:10 -04:00
Joffrey JAFFEUX
ccf5005feb FEATURE: uses select-box for topic-notifications-button component
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
David Taylor
b840170f8d Add disabled_plugins to preloadstore for login_required anonymous users (#5134) 2017-09-06 12:18:58 +02:00
David Taylor
a14ab48829 Do not load javascripts for disabled plugins (#5103)
* Do not load javascript for disabled plugins

* Appease rubocop
2017-09-06 10:06:47 +02:00
Guo Yunhe
7d29ccf207 bbcode find close tag loop end condition
Only break loop when close tag has been found. Otherwise, keep searching until the end of string.
2017-09-06 09:13:57 +03:00
Guo Xiang Tan
8463b676df Revert "Activate mini-profiler when in profiling env."
This reverts commit d61109388cb12da7593c4c7ae99a9de35e683f4c.
2017-09-06 11:26:03 +08:00
Guo Xiang Tan
d61109388c Activate mini-profiler when in profiling env. 2017-09-06 11:19:20 +08:00
Guo Xiang Tan
672b7cb9a5 Require missing dependency. 2017-09-05 09:39:56 +08:00
Guo Xiang Tan
7786c6c6f2 Remove duplicated scope. 2017-09-05 09:15:06 +08:00
Robin Ward
51ffbf1c1f FIX: Remove duplicate event typo 2017-09-04 15:39:58 -04:00
minusfive
fd91e53e68 Cleaned, de-duplicated/DRYed and organized discourse.css (common, mobile and desktop) 2017-09-04 10:56:28 -07:00
Robin Ward
db929e58fc FIX: Don't allow staff to approve users with unverified emails 2017-09-04 12:55:39 -04:00
Robin Ward
be1cce503c FIX: Don't bind events in defaultState 2017-09-04 11:48:36 -04:00
Joffrey JAFFEUX
afe6f46b03 merges after_save 2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX
caedefd675 FIX: correctly resets user_themes template
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Arpit Jalan
3b7128102c FIX: disable follow in topic summary links
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
Guo Xiang Tan
5c1143cd55 Add missing test case for PostController#timings. 2017-09-04 16:36:02 +08:00
Arpit Jalan
ebbdd4fe0f FIX: error when rebaking posts 2017-09-02 22:22:29 +05:30
Robin Ward
dfe347fb1d FIX: Wizard tests don't need Discourse defined 2017-09-01 12:26:42 -04:00
Robin Ward
c6ff387ce9 Use more semantic names for various tracking icons
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron
46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward
cb56dcdf2e FIX: Use proper iconNode when compiling virtual dom templates 2017-09-01 11:20:33 -04:00
Vinoth Kannan
0fb7831749 FEATURE: Add placeholders to broken and large image files (#5113) 2017-09-01 10:26:13 -04:00
Sam Saffron
e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive
b3b6eeff97 Ensure css applies to .user-main > .about icons regardless of tag 2017-09-01 06:32:27 -07:00