Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,460 Commits 177 Branches 498 Tags 915 MiB
Commit Graph

37460 Commits

Author SHA1 Message Date
Rafael dos Santos Silva 4595560537
FIX: Use proper icons for App shortcut menu 
Follow up to 3b0fa9b using the new icon URL introduced in e618efe

Will automatically use icons of the primary color of the active theme
 for the user during install.
 2020-05-14 16:32:53 -03:00
Kane York 63b8b3c849
Revert "Reland "DEV: Add checks that assets do not modify cookies to smoke-test.js" (#9774)" (#9783) 
This reverts commit 186c471c44.
 2020-05-14 12:04:09 -07:00
Kane York 186c471c44
Reland "DEV: Add checks that assets do not modify cookies to smoke-test.js" (#9774) 
* Revert "Revert "DEV: Add checks that assets do not modify cookies to smoke-test.js (#9504)" (#9773)"

This reverts commit 732776e2ce.

* FIX: Run cookie tests only after logging in
 2020-05-14 11:35:16 -07:00
Penar Musaraj aee8e62e21
FEATURE: Add endpoint for individual SVG icons (#9765) 2020-05-14 14:17:19 -04:00
Joffrey JAFFEUX 9ad3f4401a
DEV: always pull latest coding standard dependencies (#9782) 2020-05-14 19:31:38 +02:00
David Taylor 956d15d13f
UX: Do not use small onebox images as post/topic images 2020-05-14 18:01:43 +01:00
Mark VanLandingham bec6bace53
DEV: Allow plugins to hide user stats by new guardian method (#9772) 2020-05-14 11:57:35 -05:00
Penar Musaraj 87b9488137 UX: Limit iOS modal keyboard changes to composer 
Followup to 423802fbc
 2020-05-14 12:48:28 -04:00
David Taylor 0c6f30d92a
FIX: Allow lazy-yt thumbnails to fetched by pull_hotlinked_images 
The thumbnails were being correctly downloaded, but the URLs were not being substituted correctly in post_process_cooked because the lazy-yt output did not include the `onebox` class.
 2020-05-14 17:33:16 +01:00
Robin Ward c979f1877b FIX: Deleting old migration 
It was using ActiveRecord which broke migrating a new site. The groups
table now has a unique constraint on group name so this migration from
2014 should not be necessary anymore.
 2020-05-14 12:02:37 -04:00
Régis Hanol ec8f08d0da FIX: don't compute draft for (ro)bots 🤖 in topics list 2020-05-14 17:17:42 +02:00
Robin Ward 42b300b9be DEV: Skip I18n in plugins until they can be updated 2020-05-14 10:40:53 -04:00
Robin Ward aa2d040526 DEV: Update ESLint to remove I18n global 
Also fixes missed imports in core.
 2020-05-14 10:18:12 -04:00
Mark VanLandingham a047004c9a
FIX: Specific email error for replies to digest emails (#9770) 2020-05-14 09:04:58 -05:00
Joffrey JAFFEUX 42e5a5bb39
DEV: do not append/prepend if callback returns nothing (#9778) 2020-05-14 14:38:03 +02:00
Dan Ungureanu 3ed6a0e904
FIX: Detect Wayback Machine using user agent (#9777) 2020-05-14 21:10:07 +10:00
Dan Ungureanu 321879a619
FIX: Load locale first in wizard app 2020-05-14 11:48:55 +03:00
Guo Xiang Tan 9a18bacbe3
DEV: Fix lint. 2020-05-14 16:10:51 +08:00
Guo Xiang Tan a1a798ac7d
DEV: Expose `Composer.serializeOnUpdate` in client side plugin api. 
Also expose `Composer.serializeOnCreate` as well.
 2020-05-14 16:06:29 +08:00
Guo Xiang Tan fdea969f14
DEV: Minor follow up to d7e230c1b9 2020-05-14 16:02:54 +08:00
Guo Xiang Tan 95a80525ae
DEV: Remove erroneous code introduced in d7e230c1b9 2020-05-14 15:58:44 +08:00
Guo Xiang Tan d7e230c1b9
UX: Introduce composer-actions when editing a post. 2020-05-14 15:56:08 +08:00
Sam Saffron 5b603cb3ab
FIX: update mini racer to correct heap dumps 
This corrects an issue where mini racer's `write_heap_snapshot`
produces corrupt heaps cause the file is not flushed.
 2020-05-14 17:52:05 +10:00
Dan Ungureanu b80128a973
FEATURE: Add structured data to follow Google's guidelines (#9764) 
All Schema.org properties are optional, but Google has a set of
properties which are required.
 2020-05-14 10:42:01 +03:00
Guo Xiang Tan d226783405
Revert "DEV: Add `add_controller_callback` server side plugin api." 
This reverts commit 8233610d92.

Too much messy around with blocks to support `before_action` and
`around_action`.
 2020-05-14 15:26:50 +08:00
Vinoth Kannan c014b93854
UX: don't disable "create account" button & display error message for required fields. (#9643) 2020-05-14 12:15:33 +05:30
Sam Saffron 3d050bdaa3
DEV: correct test suite 
We have no choice but to bypass recursive debouncers in test

Otherwise we overrun the stack with frames
 2020-05-14 16:41:34 +10:00
Sam Saffron ce4b5b56e5
FIX: never save draft while it is saving 
Previously if saving a draft took longer than 2 seconds there
could be conditions where drafts could be saved concurrently.
This meant the composer could race with itself and raise conflicts.

This is likely to happen on bad internet connections or where
latency is really high.

Additionally a throttle was added so drafts save unconditionally
every 15 seconds.

Save draft in the model now properly and consistently returns a
promise.
 2020-05-14 15:36:18 +10:00
Guo Xiang Tan a849bdf0c9
FIX: Don't publish typing presence if composer isn't opened. 
Hitting cancel on composer will set composer's reply and title to null
causing our observer to fire.
 2020-05-14 12:52:10 +08:00
Guo Xiang Tan 3d5589e026
DEV: Remove assertions that are not required. 2020-05-14 10:07:55 +08:00
Guo Xiang Tan c5ef465179
DEV: Avoid relative paths when importing in plugins. 2020-05-14 10:05:16 +08:00
Penar Musaraj ad7c964cd1 FIX: Prevent Safari from scrolling when closing composer 
Unlike other browsers, Safari maintains focus on elements even when
they are hidden. And since the composer is fixed-positioned when hidden,
closing the composer on a topic with several replies causes Safari to
scroll the window up.

Deliberately blurring the focused element fixes the issue.
 2020-05-13 21:24:40 -04:00
Kane York 732776e2ce
Revert "DEV: Add checks that assets do not modify cookies to smoke-test.js (#9504)" (#9773) 
This reverts commit 5cb806827a.
 2020-05-13 16:41:18 -07:00
Kane York 5cb806827a
DEV: Add checks that assets do not modify cookies to smoke-test.js (#9504) 
This adds three new checks to the smoke test: that assets and service-worker.js do not
clear invalid cookies, but normal application routes do.

This functions as a test that the nginx config correctly strips out Set-Cookie responses
from the service-worker.js file.
 2020-05-13 16:29:18 -07:00
Robin Ward eab560fe2a
DEV: import I18n instead of global usage (#9768) 
Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
Co-authored-by: Robin Ward <robin.ward@gmail.com>

Co-authored-by: Mark VanLandingham <markvanlan@gmail.com>
 2020-05-13 16:23:41 -04:00
Kane York 1059557ce1
DEV: Standardize ignored_columns removal comments (#9771) 2020-05-13 13:08:15 -07:00
dependabot-preview[bot] e1f11f4374
Build(deps-dev): Bump better_errors from 2.7.0 to 2.7.1 (#9767) 
Bumps [better_errors](https://github.com/BetterErrors/better_errors) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/BetterErrors/better_errors/releases)
- [Commits](https://github.com/BetterErrors/better_errors/compare/v2.7.0...v2.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-13 16:03:56 -04:00
Mark VanLandingham 3d54f497db
DEV: add classes to li's inside user navigation (#9766) 2020-05-13 12:22:14 -05:00
David Taylor cb8f8de422
Revert "FEATURE: Add same site cookie 'None' option to make cross domain systems possible (#9374)" 
samesite=none is not supported in Rack 2.0.8. We can re-apply this change once Rack has been upgraded.

https://meta.discourse.org/t/cooke-samesite-none-not-working-because-of-outdated-rack-version/151331

This reverts commit 94c0228681.
 2020-05-13 16:17:05 +01:00
Joffrey JAFFEUX 9b85e75937
FIX: prevents SvgSprite.bundle to query ThemeField two times (#9762) 2020-05-13 17:11:44 +02:00
dependabot-preview[bot] d69263f934
Build(deps-dev): Bump ruby-prof from 1.3.2 to 1.4.0 (#9761) 
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.3.2 to 1.4.0.
- [Release notes](https://github.com/ruby-prof/ruby-prof/releases)
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.3.2...1.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-13 10:57:39 -04:00
David Taylor ff331e845a
DEV: Prevent 'previous definition' warnings for PARAMETER_API_PATTERNS 2020-05-13 12:54:28 +01:00
David Taylor d4717f5d1e
DEV: Reduce repeated code in discourse_plugin_registry (#9705) 
Use a helper method to simplify creating a new register. Previously this would require creating lots of different methods manually, and adding every register to the clear/reset functions
 2020-05-13 12:25:34 +01:00
RK Aranas 7d857d79bd UX: Fix hard coded value in Crazy in Love badge description 
Currently, the Crazy in Love badge's description has a hard coded
value of 50.This should correspond to the max_likes_per_day value
instead.
 2020-05-13 16:59:28 +08:00
Guo Xiang Tan c405b15914
DEV: Add plugin outlet `revision-user-details-after`. 2020-05-13 15:40:37 +08:00
Martin Brennan 50e63f5202 Skip later today test again :'( 2020-05-13 16:58:26 +10:00
Guo Xiang Tan 623920f13d
FEATURE: Introduce a staff only override key for discourse-presence. 
Merge remote-tracking branch 'origin/coding-standards'
This uses the composer as a bridge for other plugins.
 2020-05-13 14:13:31 +08:00
Sam Saffron 7f841dc21f
PERF: avoid race conditions when creating topic links 
Previously the code was very race condition prone leading to
odd failures in production

It was re-written in raw SQL to avoid conditions where rows
conflict on inserts

There is no clean way in ActiveRecord to do:

Insert, on conflict do nothing and return existing id.

This also increases test coverage, we were previously not testing
the code responsible for crawling external sites directly
 2020-05-13 16:05:57 +10:00
Guo Xiang Tan ca8d11635c
Add missing export in 15e32dc1af. 2020-05-13 13:57:12 +08:00
Guo Xiang Tan 15e32dc1af
FIX: Composer presence shows user as editing when replying. 2020-05-13 13:41:03 +08:00