b1f32f2f57
DEV: TopicTrackingState calls should happen in the background ( #11682 )
...
* DEV: TopicTrackingState calls should happen in the background
It was observed that calling TopicTrackingState on popular topics could result in a large number of calls to redis, resulting in slow response times when posting replies.
These calls should be moved to a background job.
* DEV: PostUpdateTopicTrackingState should execute on default queue
2021-01-11 15:58:27 -05:00
3eae4d3669
FIX: Publish DND ends_at updates in httpdate format ( #11683 )
2021-01-11 14:11:26 -06:00
49b753eee0
FIX: Hiding a post should not trigger the duplicate check ( #11680 )
...
If for some reason a post was allowed to be duplicated (probably via
staff edit) hiding it should be permitted.
2021-01-11 14:56:08 -05:00
2f84ab6e0a
UX: add space between links and text in labels ( #11674 )
2021-01-11 13:35:41 -05:00
422f395042
FIX: Show unassigned component warning when installing multiple components successively ( #11675 )
...
A while ago we made a change to display a warning after installing a theme component when the admin tries to leave the page without adding the new installed component to any themes (see 5e29ae3ef5
2021-01-11 18:29:12 +03:00
116a879ff4
FIX: Reset theme install modal state on close ( #11670 )
...
The theme install modal should reset its state on close, otherwise it might cause confusion when installing multiple components successively.
2021-01-11 18:27:31 +03:00
19cbda15e9
FIX: hidden tags returned in extras of tags index json
2021-01-11 10:21:54 -05:00
efaa63bd1d
FIX: always truncate uncomplete emojis in excerpts ( #11678 )
...
Additional fix after https://github.com/discourse/discourse/pull/11667
Always truncate "broken" emojis from excerpts.
2021-01-11 13:43:11 +11:00
7f78b6ec10
FIX: broken emojis in topic excerpt ( #11667 )
...
When a post is truncated into the excerpt, sometimes we are breaking code of emoji
2021-01-11 10:40:41 +11:00
2e24254773
Build(deps-dev): Bump simplecov from 0.21.1 to 0.21.2 ( #11676 )
...
Bumps [simplecov](https://github.com/simplecov-ruby/simplecov ) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/simplecov-ruby/simplecov/releases )
- [Changelog](https://github.com/simplecov-ruby/simplecov/blob/main/CHANGELOG.md )
- [Commits](https://github.com/simplecov-ruby/simplecov/compare/v0.21.1...v0.21.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 00:23:10 +01:00
9498de420b
Build(deps): Bump uniform_notifier from 1.13.0 to 1.13.1 ( #11677 )
...
Bumps [uniform_notifier](https://github.com/flyerhzm/uniform_notifier ) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/flyerhzm/uniform_notifier/releases )
- [Changelog](https://github.com/flyerhzm/uniform_notifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/uniform_notifier/compare/v1.13.0...v1.13.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 00:21:43 +01:00
b0088361a4
FIX: Do not include URL query in auto-generated CSP header ( #11673 )
2021-01-09 13:52:53 +00:00
9da9b2e1cc
DEV: Add i18n fallback specs ( #11669 )
...
Those fail on the buggy i18n release (1.8.6) and pass on 1.8.5, 1.8.7 (the revert release), and with the second stab at thread safety on the current master (63a79cb929
2021-01-08 17:47:28 +01:00
f6e87e1e5e
DEV: Improvements to Discourse Merger script ( #11660 )
...
After running the Discourse merge script, it was pretty evident it held up well after all these years ;)
Made a few fixes:
Included an environment variable for DB_PASS as likely the password will need to be changed if running the import in an official Docker container (recommended)
Set a hard order for imported categories, otherwise sometimes they'd be imported in a weird order making things unpredictable for parent/child category imports
Fixed a couple of instances where we added unique indexes (such as on category slugs)
Set up upload regex to handle AWS URLs better
Fixed the script to work with frozen string literals
2021-01-08 09:31:39 -06:00
25b4e82601
FEATURE: allow disabling self-deletions of posts ( #11668 )
...
https://meta.discourse.org/t/restoring-deleted-messages/173647/6?u=techapj
2021-01-08 20:35:13 +05:30
caa17386ee
FEATURE: Use the site's small logo as the system user's avatar. ( #11661 )
2021-01-08 10:40:00 -03:00
e63a9facc7
UI: remove extra word from approval_not_required client string ( #11627 )
2021-01-08 12:59:23 +11:00
4928f9cceb
FIX: don't error topic RSS when posts are deleted ( #11641 )
2021-01-08 11:16:15 +11:00
1cf9231045
Build(deps-dev): Bump mock_redis from 0.27.0 to 0.27.2 ( #11664 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.27.0 to 0.27.2.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.27.0...v0.27.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 16:32:28 -05:00
2d11309ac5
Build(deps): Bump unicode-display_width from 1.7.0 to 2.0.0 ( #11662 )
...
Bumps [unicode-display_width](https://github.com/janlelis/unicode-display_width ) from 1.7.0 to 2.0.0.
- [Release notes](https://github.com/janlelis/unicode-display_width/releases )
- [Changelog](https://github.com/janlelis/unicode-display_width/blob/main/CHANGELOG.md )
- [Commits](https://github.com/janlelis/unicode-display_width/compare/v1.7.0...v2.0.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 16:31:21 -05:00
e696cba071
FIX: Don't count HTML comments when calculating reply length. ( #11658 )
...
We'll remove them when we sanitize the post raw content.
2021-01-07 15:44:17 -03:00
2e3b3ec2de
FEATURE: Warn admins when installing a theme that's already installed ( #11651 )
...
Installing multiple copies of the same theme/component is possible, but you rarely need to actually have multiple copies installed. We've seen many times new admins installing duplicates of components because they were unaware it was already installed. This PR makes the theme installer modal loop through the existing themes when you click on 'install', and if there is a theme with a URL that matches the URL you entered, a warning will show up and you will need to click 'install' again to proceed.
2021-01-07 21:03:35 +03:00
4601f3be7e
FEATURE: Send notification emails when users leave do not disturb mode ( #11643 )
2021-01-07 10:49:49 -06:00
3865308e36
FIX: Tab key should autocomplete like enter key does ( #11659 )
2021-01-07 19:43:13 +03:00
c819284660
UX: Improve color scheme choices in user prefs ( #11656 )
2021-01-07 11:15:38 -05:00
ef84fb6469
Build(deps-dev): Bump minitest from 5.14.2 to 5.14.3 ( #11649 )
...
Bumps [minitest](https://github.com/seattlerb/minitest ) from 5.14.2 to 5.14.3.
- [Release notes](https://github.com/seattlerb/minitest/releases )
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc )
- [Commits](https://github.com/seattlerb/minitest/compare/v5.14.2...v5.14.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 10:44:45 -05:00
49f4c75080
FIX: recurring was not working for some cases (eg: hours and unit > 1) ( #11657 )
2021-01-07 12:21:51 +01:00
0c451d14d9
Build(deps): Bump nokogiri from 1.11.0 to 1.11.1 ( #11647 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.0...v1.11.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 11:59:12 +01:00
d8b015e3be
Minor copyedit on flag stat popup ( #11655 )
2021-01-06 20:49:35 -08:00
ee9ea20d95
Build(deps): Bump onebox from 2.2.1 to 2.2.2 ( #11653 )
...
Bumps [onebox](https://github.com/discourse/onebox ) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/discourse/onebox/releases )
- [Changelog](https://github.com/discourse/onebox/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/onebox/compare/v2.2.1...v2.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-06 15:18:05 -08:00
437ca97eac
FIX: Fix bg color of header on published page ( #11652 )
...
This commit correctly sets the bg color of the header on published pages to be var(--header_background) instead of var(--secondary).
2021-01-06 16:54:37 -06:00
aa909f58a9
FIX: Hide notification count on document title in Do Not Disturb ( #11646 )
2021-01-06 16:15:04 -06:00
d15159dff7
UX: Refactor topic list nav ( #11285 )
2021-01-06 16:15:28 -05:00
2275d637e4
DEV: the referenced commit bc97… was rebased into 445d… ( #11626 )
2021-01-07 08:14:54 +11:00
16f564d542
DEV: Bump sanitize from 5.2.1 to 5.2.2 ( #11648 )
...
Bumps [sanitize](https://github.com/rgrove/sanitize ) from 5.2.1 to 5.2.2.
- [Release notes](https://github.com/rgrove/sanitize/releases )
- [Changelog](https://github.com/rgrove/sanitize/blob/master/HISTORY.md )
- [Commits](https://github.com/rgrove/sanitize/compare/v5.2.1...v5.2.2 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-07 08:14:23 +11:00
8b2daf9f75
DEV: Bump mock_redis from 0.26.0 to 0.27.0 ( #11650 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.26.0 to 0.27.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.26.0...v0.27.0 )
2021-01-07 08:12:41 +11:00
e02cc98092
UX: Autocomplete suggestions should be unselected by default ( #11637 )
...
When you type # or @ in the search box, a popup appears with
autocomplete suggestions. Currently, when the popup is rendered it has
the first item selected and upon pressing Enter, the first item is
inserted into the search box. The problem with this behavior is that the
first suggestion may not be what you want, and if you are typing quickly
and hit enter, the first suggestion (which is not what you want) is
inserted in the search box.
This PR amends the popup so that it has no suggestions selected by
default which means the enter key will not insert anything unless you
select a suggestion via the up or down arrow keys.
2021-01-07 08:10:18 +11:00
690f1a257a
FEATURE: Disable post deletions by setting max_post_deletions to zero. ( #11645 )
...
Allow admins to set "max_post_deletions_per_minute" and "max_post_deletions_per_day" to prevent users from deleting their posts.
2021-01-06 15:58:07 -03:00
5b77c6a5d8
UX: Allow quick access profile content to scroll ( #11639 )
2021-01-06 15:32:20 -03:00
118ea89372
FEATURE: Replace arrows when the markdown typographer is enabled. ( #11638 )
...
By inserting this rule before markdown-it's replacement rule, we can replace "-->" with "→", and "<--" with "←".
2021-01-06 12:05:38 -03:00
53f9a0883e
UX: allows to copy/paste a list of | separated values in sk ( #11642 )
...
* UX: allows to copy/paste a list of | separated values in sk
* fixes tests
2021-01-06 12:57:13 +01:00
5f846531a5
DEV: Cleanup variables/mixins SCSS imports ( #11618 )
...
Prepends variables.scss and mixins.scss globally for all assets. With
one notable exception, theme fields, which will be addressed in a
separate PR.
2021-01-05 14:05:34 -05:00
f6b9691ed7
Build(deps): Bump nokogiri from 1.10.10 to 1.11.0 ( #11629 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.10.10 to 1.11.0.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.10.10...v1.11.0 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-05 11:12:05 -05:00
5e982f9295
Build(deps): Bump i18n from 1.8.5 to 1.8.7 ( #11628 )
...
Bumps [i18n](https://github.com/ruby-i18n/i18n ) from 1.8.5 to 1.8.7.
- [Release notes](https://github.com/ruby-i18n/i18n/releases )
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-i18n/i18n/compare/v1.8.5...v1.8.7 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-05 15:32:18 +01:00
95df15bad9
UX: transition to edit URL when adding a category ( #11634 )
2021-01-05 08:34:35 -05:00
afebaf439f
FIX: Validate type when picking an avatar. ( #11602 )
...
This change improves the "UsersController#pick_avatar" validations to raise an error when "allow_uploaded_avatars" is disabled.
2021-01-05 10:29:10 -03:00
45671276bf
Update translations ( #11635 )
2021-01-05 14:27:00 +01:00
64ba5b1d21
FIX: Group SMTP email improvements ( #11633 )
...
Fixes a rare race condition causing the `Imap::Sync` class to create an incoming email and associated post/topic, which then kicks off the PostAlerter to notify others in the PM about a reply in the topic, but for the OP which is not necessary (because the person emailing the IMAP inbox already knows about the OP). Basically, we should never be sending the group SMTP email for the first post in a topic.
Also in this PR:
* Custom attribute accessors for the to/from/cc addresses on `IncomingEmail`, to parse them from an array to a joined string so the logic for this is only in one place.
* Store extra detail against the `IncomingEmail` created in `GroupSmtpMailer`
* regex test Mail header Reply-To as string instead of Field, which fixes `warning: deprecated Object#=~ is called on Mail::Field; it always returns nil`
* Add DEBUG_IMAP to log all IMAP logs as warnings for easier debugging
* Changed the Rails logging to `ImapSyncLog` in the `GroupSmtpMailer`
2021-01-05 15:32:04 +10:00
4f72830eb0
Update minimum required software versions ( #11617 )
...
This matches what we are using in the bundled image
2021-01-05 00:00:14 -03:00
3a0ea9ef22
remove anon download attachment warning ( #11632 )
...
.. as it is no longer applicable for the most part
2021-01-05 08:02:41 +05:30
jbrw
Mark VanLandingham
Robin Ward
Kris
Osama Sayegh
Neil Lalonde
Krzysztof Kotlarek
dependabot[bot]
David Taylor
Jarek Radosz
Justin DiRose
Arpit Jalan
Roman Rizzi
Michael Brown
Penar Musaraj
Joffrey JAFFEUX
tshenry
Jordan Vidrine
Discourse Translator Bot
Martin Brennan
Rafael dos Santos Silva
Jeff Atwood