4bbb43cb2b
DEV: pull plugin repos before linting them
2019-06-14 13:50:15 -04:00
035e63c81f
FIX: Allow the clear callbacks to execute in acceptance tests
2019-06-14 13:29:13 -04:00
73bce82c82
Exclude plugins from RuboCop checks
...
Since official plugins are now in the discourse_test image, rubocop catches issues in plugins.
This is a temporary measure.
2019-06-14 10:06:26 -04:00
a8793d0d9a
REFACTOR: Test Memory Usage Fixes ( #7769 )
...
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.
* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.
* `updateCurrentUser` is more accurate than `replaceCurrentUser`
2019-06-14 14:54:20 +02:00
c3381b845b
DEV: Install diffy in production for `rake posts:inline_uploads` task.
2019-06-14 14:42:53 +08:00
77c06384c0
Fix the build.
2019-06-14 13:56:35 +08:00
5d16d10a9e
DEV: Fix edge case for `InlineUploads`.
2019-06-14 13:48:03 +08:00
ecb2fd8222
DEV: improve db:create to catch all cases
...
- No RAILS_ENV - create multisite / dev / test
- `test` RAILS_ENV - create multisite / test
2019-06-14 15:47:05 +10:00
befb074c98
DEV: `InlineUploads` should process CDN upload URLs as well.
2019-06-14 13:14:37 +08:00
a01488ae67
DEV: improve on rake db:create
...
Followup on 3af00a65
2019-06-14 15:06:07 +10:00
41abebcbce
DEV: Support both `http` and `https` for `InlineUploads`.
2019-06-14 12:48:31 +08:00
7bb94e8716
DEV: Increase wait duration between smoke test further during edit.
...
Otherwise, the app detects that we're replying too quickly.
2019-06-14 12:21:54 +08:00
3af00a65e6
FIX: site settings loading default values when no db
...
This fixes a condition where an intermittent db connection could cause
invalid site settings to be stored
It also removes a catch all we had.
Somewhere around Rails 5 `db:create` started wanting full environment
this is a problem for Discourse since it needs to boot up data from the
db.
This removes the catch all and surgically adds a db / redis bypass to
db:create task.
2019-06-14 14:21:07 +10:00
62f4284865
DEV: 302 status is normal in smoke test
...
Login can redirect there are potentially other cases
2019-06-14 14:21:07 +10:00
eaa7527933
DEV: Switch `posts:inline_uploads` scope to be more generic.
2019-06-14 11:53:34 +08:00
c9db897777
FIX: Remove onebox src from `Jobs::PullHotlinkedImages`.
...
The test that was added is incorrect because the post was not cooked.
2019-06-14 09:21:25 +08:00
457be89445
DEV: only skip migration if a non seeded upload exists
...
Followup to 667b9801
2019-06-14 09:52:02 +10:00
667b98017a
FIX: do not attempt to migrate pre-existing uploads
...
This makes this job re-runnable just in case cause it will skip creation
of new uploads if an upload already exists
2019-06-14 09:39:22 +10:00
4182d8638c
Remove duplicate entry for discourse-yearly-review
2019-06-13 13:56:38 -04:00
35d6fff69e
PERF: use url instead of file key in temporary inventory table.
2019-06-13 22:03:58 +05:30
ed21128ee6
FIX: Do not change directory when decompressing S3 inventory
...
In sidekiq, jobs are run in multiple threads within the same process. `cd` affects the entire process, so can cause unexpected issues in other running jobs.
2019-06-13 17:13:50 +01:00
66b15b9d87
DEV: support installing plugin gems in test images
...
- adds plugin:install_all_gems rake task
- adds UPDATE_ALL_PLUGINS env variable in docker:test
2019-06-13 09:58:57 -04:00
efc05e7224
FIX: remove topic timer info on completion
2019-06-13 17:01:43 +05:30
fbbce235ce
UX: improves change-timestamp modal ( #7766 )
2019-06-13 13:30:33 +02:00
9bce3d5e65
DEV: Multisite support for `rake posts:inline_uploads`.
2019-06-13 16:13:45 +08:00
215216df48
FIX: stop re-downloading backup maxmind
...
We omitted updating the mmdb_time which changed causing a constant
re-download of the maxmind db
2019-06-13 17:42:26 +10:00
77f5577e30
DEV: Improvements to AnswerHub import script.
2019-06-13 11:46:17 +05:30
3ef4ae08f1
DEV: check for specifics when looking at ENABLE_LOGRAGE
...
prior to this change ENABLE_LOGRAGE=0 some_command would enable lograge
2019-06-13 15:59:20 +10:00
9daed05ad0
Fix the build.
2019-06-13 13:53:43 +08:00
7a0d031bc4
FIX: `InlineUploads` matching on external bbcode img url.
2019-06-13 13:47:36 +08:00
782e583844
FIX: Edge cases with markdown references for `InlineUploads`.
2019-06-13 12:08:01 +08:00
93c552afda
FIX: `InlineUploads` does not correct urls with uppercase extension.
2019-06-13 11:19:33 +08:00
fa2a5f6f56
FEATURE: SKIP_DB_AND_REDIS env var ( #7756 )
...
Sometimes we would like to create a base image without any DB access, this
assists in creating custom base images with custom plugins that already
includes `public/assets`
Following this change set you can run:
```
SPROCKETS_CONCURRENT=1 DONT_PRECOMPILE_CSS=1 SKIP_DB_AND_REDIS=1 RAILS_ENV=production bin/rake assets:precompile
```
Then it is straight forward to create a base image without needing a DB or
Redis.
2019-06-13 12:58:27 +10:00
5b55252e10
DEV: Add more wait between edit so we don't end up replying too quickly.
2019-06-13 09:14:17 +08:00
e47ca6633b
DEV: Fix plugin:update_all task
...
Reenable subtask so it loops through all plugins.
Only run for plugins that are git repositories.
2019-06-12 17:21:56 -04:00
b4686934dd
DEV: add spec for removed group bio
2019-06-12 18:03:29 +02:00
19ca2d4772
DEV: reset widget clean callback between tests ( #7761 )
2019-06-12 17:49:02 +02:00
9daba50d48
FIX: Unsubscribe seemed to be missing some events ( #7762 )
...
This forces an unsubscribe from all events.
2019-06-12 17:48:01 +02:00
13b979cb71
FIX: Performing actions on a particular reviewable was displaying an error
...
It was expecting a method to remove the reviewable from the current
list, only we were not displaying a list.
Instead, we refresh the reviewable model with the latest result.
2019-06-12 10:56:30 -04:00
c5dec04970
Fix minor typos in server.en.yml
2019-06-12 09:14:22 -04:00
621b6493f7
DEV: test badge titles presence on badge page
...
follow-up on 2863e7c
2019-06-12 15:04:21 +02:00
36e53db300
Fix the build.
2019-06-12 16:44:17 +05:30
7b66f8fb46
DEV: optimize bulk invite process
2019-06-12 16:33:19 +05:30
f0846ea7cf
DEV: Remove unused line.
2019-06-12 17:38:30 +08:00
641521896c
FIX: Cover more edge cases in `InlineUploads`.
2019-06-12 17:06:58 +08:00
739696fdf0
DEV: improve spec to specify all code block formats
...
Previously we only covered a few, this covers a few more formats.
2019-06-12 18:34:30 +10:00
89c4332ac1
DEV: correct spec making bad assumptions
...
bio_cooked is not meant to be touched directly, on save we "cook" the raw
bio.
2019-06-12 16:31:50 +10:00
0a1b16bb16
FIX: clean up cooked group bio when bio is removed ( #7745 )
2019-06-12 16:18:38 +10:00
73bf880f74
FIX: Correct more edge cases with `InlineUploads`.
2019-06-12 10:44:25 +08:00
ff48fbdfda
FIX: `InlineUploads` raises an error when img tag is invalid.
2019-06-12 10:31:00 +08:00
Penar Musaraj
Robin Ward
Guo Xiang Tan
Sam Saffron
Vinoth Kannan
David Taylor
Arpit Jalan
Joffrey JAFFEUX
Maja Komel
AhmadF.Cheema