Commit Graph

21544 Commits

Author SHA1 Message Date
Robin Ward b9fc9dc9fc FIX: Routing to default homepage with query params was broken 2016-12-22 11:37:17 -05:00
Guo Xiang Tan 5aee2673c7 FIX: Push null fields to last when sorting group members. 2016-12-22 14:55:24 +08:00
Guo Xiang Tan 5605700fa9 UX: Sort groups by name. 2016-12-22 14:46:20 +08:00
Guo Xiang Tan 6955c39c68 UX: Fix width on avatar flair. 2016-12-22 14:30:49 +08:00
Guo Xiang Tan 8551d821a0 FEATURE: Add site setting to disable group directory. 2016-12-22 14:14:22 +08:00
Sam c531f4ded5 remove rails-observers
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.

For example: if we want to upgrade to rails 5 there is no published gem

Internally the usage of observers had quite a few problem.

The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam 019f1a1d06 UserEmailObserver is now removed
no big surprises here was pretty straightforward

after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam 2f6a4cc6de remove UserActionObserver, replace with after_save and service
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Guo Xiang Tan 96c70c74a1 Merge pull request #4619 from tgxworld/group_page_design
UX: Redesign group page to follow user page.
2016-12-22 13:42:28 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Guo Xiang Tan ed72920444 Make eslint happy. 2016-12-22 11:46:15 +08:00
Guo Xiang Tan 288e5faf6b FIX: Sort needs to be stable. 2016-12-22 11:45:41 +08:00
Robin Ward e3301cd0c8 FIX: Don't load poll results while already loading 2016-12-21 21:26:57 -05:00
Sam 0a78ae739d Remove SearchObserver, aim is to remove all observers
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Robin Ward 31cda7b372 FIX: Can't seem to use ES6 in this file 2016-12-21 16:50:57 -05:00
Robin Ward 89bdca9c8c FIX: Backwards compatibility for controller in raw templates 2016-12-21 16:38:57 -05:00
Robin Ward 1463e9ae46 FIX: Couldn't resolve raw customization 2016-12-21 16:19:04 -05:00
Neil Lalonde eb23a8c173 FIX: when changing category, watch for pasted link in title field 2016-12-21 14:57:12 -05:00
Robin Ward e85904b98f FIX: Clamp last read position to height of the widget 2016-12-21 14:24:15 -05:00
Neil Lalonde 783490f763 FIX: with featured links enabled and uncategorized topic not allowed, allow featued links behaviour before choosing a category 2016-12-21 13:40:05 -05:00
Arpit Jalan 0d826ea933 Update Translations 2016-12-21 23:09:02 +05:30
Neil Lalonde b5cc6851cf FIX: tag chooser input was navigating to tag pgaes on some mobile browsers 2016-12-21 12:01:53 -05:00
Robin Ward 44ddc113e7 FIX: Couldn't route to the default route with a query param 2016-12-21 11:18:22 -05:00
Robin Ward ca20560d1f FIX: Should use `RAW_TEMPLATES` scope for header customizations 2016-12-21 10:54:23 -05:00
Robin Ward 71dd94e92d FIX: Didn't mean to upgrade sprockets version with Ember 2016-12-21 10:39:45 -05:00
Régis Hanol eaa40756a8 bump onebox 2016-12-21 16:34:26 +01:00
Guo Xiang Tan 28befcb5d4 Fix specs. 2016-12-21 21:21:39 +08:00
Guo Xiang Tan c897e5599a FIX: Group mobile nav not updating. 2016-12-21 21:16:52 +08:00
Guo Xiang Tan a37a6f57d9 FIX: Automatic groups should be editable via groups page. 2016-12-21 21:11:49 +08:00
Guo Xiang Tan 5e75d5c1bf PERF: N+1 query on groups page. 2016-12-21 20:59:09 +08:00
Guo Xiang Tan 076a08d8e1 FIX: Unactivated users should not be automatically added into groups as well. 2016-12-21 18:15:01 +08:00
Guo Xiang Tan 7228081820 FIX: Automatic group membership should not add staged or unactivated users. 2016-12-21 18:04:26 +08:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Guo Xiang Tan 12407484d8 Merge pull request #4601 from ibnesayeed/clean-mailcatcher
Removed the fallback mailcatcher install command
2016-12-21 17:43:02 +08:00
Guo Xiang Tan 73c98e48a3 Merge pull request #4610 from tgxworld/start_running_vaccum
Revert "Don't vacuum for a long time until we fix it"
2016-12-21 17:41:41 +08:00
Guo Xiang Tan 5d7f3223f0 SECURITY: Users can only bookmark posts which they can see. 2016-12-21 12:01:26 +08:00
Robin Ward 1821a0933d FIX: Missing CSS for back button on progress component 2016-12-20 16:01:15 -05:00
Neil Lalonde c75bebdea2 FIX: uncategorized setting to control whether topic featured links are allowed 2016-12-20 15:55:30 -05:00
Robin Ward 1cbe355c5b FIX: Timeline back button was docking too aggressively 2016-12-20 13:32:54 -05:00
Robin Ward f0f5fbf132 FIX: Never show the last read marker within 1 post of the last 2016-12-20 13:22:22 -05:00
Robin Ward 1be800b673 FIX: Prioritize raw template overrides from plugins 2016-12-20 13:07:09 -05:00
Neil Lalonde 158670ca5e FIX: if categories page is default, redirect to Top was never working 2016-12-20 12:06:58 -05:00
Robin Ward da4e27ca7d FIX: Allow resolution of `javascripts` prefixed raw templates 2016-12-20 11:53:43 -05:00
Robin Ward 16b236899c FIX: `custom-html` tag had broken information 2016-12-20 11:49:30 -05:00
Régis Hanol c302ffe08f FIX: buttons in user admin page weren't working 2016-12-20 12:26:53 +01:00
Régis Hanol 3c3008fec3 FIX: clicking 'Show Email' on admin page wasn't working 2016-12-20 11:35:13 +01:00
Régis Hanol b12b2b1911 change onebox preview key for me consistency 2016-12-20 11:18:47 +01:00
Régis Hanol bf9e59eda9 FIX: add option for the oneboxer to be synchronous 2016-12-20 11:18:03 +01:00
Guo Xiang Tan 6461021046 FIX: Only show membership status on index page. 2016-12-20 15:50:12 +08:00
Guo Xiang Tan 9db5d5b6a7 FIX: Incorrect serializer for groups page. 2016-12-20 15:44:22 +08:00