2b7e50cab8
Prevent fade-out from overlapping button in admin nav
2018-09-10 11:25:41 -04:00
84fc7abb73
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
d4080c020f
FIX: sets trends to 7 days instead of 3 ( #6379 )
2018-09-10 10:40:19 +02:00
04d26c65e2
Refactor `Upload.get_from_url` to check length of sha1.
2018-09-10 10:10:39 +08:00
2ad882113e
FIX: corrects top-referred and trending-search dates ( #6372 )
2018-09-07 16:49:44 +02:00
9e77fd8fc3
FIX: wrong category links on subfolder install in rss feed for a category topic list
2018-09-07 10:03:30 -04:00
d788555994
DEV: Manage pretender with yarn.
2018-09-07 16:01:49 +08:00
039afe0d2c
Apply prettier.
2018-09-07 15:19:34 +08:00
879067d000
FIX: check admin theme cookie against user selectable
...
previously admin got a free pass and could set theme via cookie to anything
including themes that are not selectable
this refactor ensures that only "preview" gets a free pass, all the rest
goes through the same pipeline
2018-09-07 10:47:28 +10:00
797cbf8653
FIX: Remove user fields when anonymizing user
2018-09-07 00:02:56 +02:00
6c1e70d554
FIX: do no reset tags selection on category selection ( #6369 )
...
We will instead implement a server side solution to this in the future.
2018-09-06 10:35:07 +02:00
56b6a4779d
FIX: make route to tag more robust
...
There are some edge cases where code would fail here, so adding protection
2018-09-06 17:24:32 +10:00
1f636c445b
PERF: Add fast path to find uploads before resorting to `LIKE` query.
...
For a normal upload url
Before
```
Warming up --------------------------------------
264.000 i/100ms
Calculating -------------------------------------
2.754k (± 8.4%) i/s - 13.728k in 5.022066s
```
After
```
Warming up --------------------------------------
341.000 i/100ms
Calculating -------------------------------------
3.435k (±11.6%) i/s - 17.050k in 5.045676s
```
2018-09-06 14:44:24 +08:00
d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
b6a139b581
Fix broken spec.
2018-09-06 12:41:43 +08:00
434035f167
FIX: Link post to uploads in `PostCreator`.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
5bdc00c3be
FIX: do not automatically route all actions to hovered posts
...
This feature (hitting d when a post is hovered with mouse deletes) causes a lot of confusion and is very risky.
2018-09-06 10:34:58 +10:00
8cff3c9bbc
UX: Prevent long names from overflowing post
2018-09-05 17:48:31 -04:00
e59622f2ba
FIX: deactivate chart trends for now ( #6364 )
2018-09-05 23:33:29 +02:00
1c65969bb4
post read-state icon alignment
2018-09-05 13:19:36 -04:00
17087eff2a
FIX: Reset tags on category change ( #6363 )
2018-09-05 17:18:52 +02:00
3134dd4763
FIX: Wizard didn't change locale when Enter key was used in drop-down
2018-09-05 15:14:09 +02:00
2801376df5
FIX: Wizard didn't load translations correctly
...
* Translations from the js.* namespace were not found, because the i18n-patches were not loaded.
* The extra-locales didn't use a hash in the URL.
2018-09-05 15:14:09 +02:00
2c5d9269a0
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 11:44:28 +02:00
d9c0dc8687
correct prev commit
...
s3. did not exists it is s3-
2018-09-05 16:11:44 +10:00
83e1315e42
FIX: correct urls in uploads table to point at dualstack
...
Last week we added support for dual stack urls but did not remap the
the old records in the uploads and optimized images table
This caused a few minor edge cases worst was that if you rebaked old
images S3 CDN was not repopulated.
2018-09-05 15:58:04 +10:00
9d35240620
Revert "FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled"
...
This reverts commit c788737eed
2018-09-05 01:53:22 +02:00
c788737eed
FIX: Notifications shouldn't use user locale unless allow_user_locale is enabled
2018-09-05 00:47:39 +02:00
8a952a2cc2
Make prettier happy
2018-09-05 02:00:13 +05:30
5cf1a9a23a
UX: primary & danger buttons should lighten on hover in dark themes
2018-09-04 16:18:10 -04:00
d8b543bb67
FIX: redirect to original URL after social signup
2018-09-05 01:44:23 +05:30
4382fb5fac
DEV: Allow plugins to whitelist specific user custom_fields for editing ( #6358 )
2018-09-04 20:45:36 +10:00
e4498d2a8a
FIX: keep db and job correctly in multisite logs
...
This ensures we report job and db correctly, previously we were
only reporting this on default
2018-09-04 16:05:44 +10:00
ad70502ab8
FIX: ignore invalid usernames in incoming link tracker
...
If an incoming link username has NULL in it simply ignore it
2018-09-04 12:28:32 +10:00
8dc1463ab3
Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.
2018-09-04 10:16:42 +08:00
2f5c21e28c
FIX: return a 400 error instead of 500 for null injections
...
Many security scanners like to inject NULL in inputs causing application
to exception out and return a 500
We now handle this exception and render a 400 status back
2018-09-04 12:11:52 +10:00
3748d3e281
UX: hide associate accounts if second factor is enabled
...
Once second factor is enabled all login via associated accounts is banned
showing this section just leads to confusion
2018-09-04 10:42:39 +10:00
155eb02c7e
UX: remove auth token log from user page
...
This feature is not quite ready so we are deferring on it for a few more weeks
2018-09-04 10:28:33 +10:00
fe6c3b7d2e
Make prettier happy
2018-09-04 00:31:41 +05:30
24a14af15a
FIX: Respect invalidate_oneboxes option for inline oneboxes
2018-09-03 22:33:43 +05:30
f33433bf9e
Validation of params should restrict to max int ( #6331 )
...
* FIX: Validation of params should restrict to max int
* FIX: Send status 400 when "page" param isn't between 1 and max int
2018-09-03 14:45:32 +10:00
59c9051a2e
REFACTOR: Rescue error at the specific spot that is raising the error.
2018-09-03 11:04:58 +08:00
7256b3bf68
REFACTOR: Use `UserAuthTokenLogSerializer` instead of conditionals.
2018-09-03 10:44:22 +08:00
c3a898795a
Merge pull request #6351 from gschlager/btn_primary
...
UX: Primary button didn't have hover effect anymore
2018-09-02 14:26:40 -07:00
f5e0356fb2
correct miscellaneous issues with user login history
2018-09-02 17:24:54 +10:00
8e70b82baa
FIX: maintain theme preview when refreshing ( #6356 )
2018-09-02 17:23:46 +10:00
4194d1f875
UX: Add padding between fa-chevron-up/down and heading for groups page
2018-09-01 10:14:54 +05:30
16974df1e9
FIX: Resetting site setting didn't remove "overriden" state
2018-09-01 02:09:23 +02:00
f0b551b684
UX: avatar on collapsed user profile was the wrong size
2018-08-31 10:38:58 -04:00
39414068ff
FIX: User agent browser detection ( #6352 )
2018-08-31 14:49:38 +02:00
ddfd02ad36
FIX: Deleting backup failed after uploading backup
2018-08-31 13:50:32 +02:00
91b3f200f4
UX: Primary button didn't have hover effect anymore
2018-08-31 12:14:41 +02:00
5310b4841d
UX: Show Rollback and Backup buttons on same line
2018-08-31 12:01:59 +02:00
5a214a687c
FIX: Exclude `UserAuthToken` and `UserAuthTokenLog` in user webhook.
2018-08-31 17:25:56 +08:00
6ada825a4d
fix linting
2018-08-31 10:49:44 +02:00
931cffcebe
FEATURE: Let users see their user auth tokens. ( #6313 )
2018-08-31 10:18:06 +02:00
b3aab1770f
FIX: set old last modified date for invalid avatars
...
In some cases Akami was holding tight to these invalid avatars,
to avoid this happening we explain the avatar image is ancient
then when a new upload is added it automatically is older than
this.
2018-08-31 17:07:31 +10:00
e1975e293f
FIX: when uploads are destroyed clear up avatar refs in user table
...
This also auto corrects twice daily when we ensure consistency
2018-08-31 14:46:42 +10:00
6b9aeeea73
bump onebox version
2018-08-31 08:40:36 +05:30
9b7cab589a
FIX: revert diacritic stripping
...
See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam
2018-08-31 11:46:55 +10:00
f3afc0cf76
Add raw date to title attribute on old flags page ( #6349 )
2018-08-31 11:01:10 +10:00
ae532f8548
FIX: return 422 for an invalid group name on category create
2018-08-30 14:28:55 -06:00
bb93179609
FEATURE: charts will now use tertiary color ( #6342 )
2018-08-30 14:56:11 +02:00
103509b9dd
SECURITY: Prevent users from modifying custom fields
2018-08-30 12:59:36 +01:00
0f812aa768
Make prettier happy.
2018-08-30 15:56:30 +08:00
4f81d4cc8e
Minor fixes to `Jobs::BulkInvite`.
2018-08-30 15:35:16 +08:00
092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
...
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
f0abb4d09a
FIX: Allow user actions to be saved even if the post has nil user
...
This issue made it impossible to delete users if they had flagged a post with nil user
2018-08-30 01:03:32 +01:00
e6970151a6
FEATURE: allow specifying locale via SSO
...
Use:
locale
locale_force_update
To force user locale on users where SiteSetting.allow_user_locale is enabled
Note: If an invalid locale is specified no action will occur
2018-08-30 09:58:03 +10:00
22110d3106
minor copyedit on pm a/r button
2018-08-29 16:51:38 -07:00
72ffabf619
UX: Improve email testing admin tool. ( #6308 )
2018-08-29 23:14:16 +02:00
c1a5a7504e
FIX: Reset email preferences controller. ( #6316 )
2018-08-29 23:10:56 +02:00
4c99acea1b
FIX: Use tight list format for GDocs html to markdown
2018-08-29 16:21:31 +00:00
8ff83d174e
FIX: Changing tag name class to data attribute ( #6326 )
2018-08-29 10:49:19 -04:00
78089e3577
Removing unneeded background color
2018-08-29 08:58:28 -04:00
b2cf725700
FIX: Don't try to send invite email when invite was deleted
2018-08-29 12:43:12 +02:00
1281fb964e
FIX: prevents remove user btn to overflow parent ( #6329 )
2018-08-29 10:11:44 +02:00
26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
...
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
ad34bdca09
UI: minor tweaks to new message participants list ( #6328 )
...
* Icon for button
* Display name when editing on mobile
* Always display name on mobile when less/or 4 participants involved
2018-08-29 10:07:49 +02:00
fb35b0b3c3
FIX: Keep emojis and remove clicks count
2018-08-29 07:26:25 +00:00
44cf3cf975
FIX: queue heartbeats in readonly modes
...
If sidekiq is paused or Discourse is in readonly continue to queue
heartbeats
If we do not do that then a master process can end up reaping sidekiq
workers and causing various badness
This also impacts restore which can do weird stuff TM in cases like this
2018-08-29 12:36:59 +10:00
7516f5159e
FIX: /rules route showed error page
2018-08-28 20:40:37 -04:00
feeaac81df
FIX: Mobile admin menu iOS rendering bug
2018-08-28 16:39:20 -04:00
3a4a6cb41a
alignment fix
2018-08-28 16:27:34 -04:00
7deb86ad8b
A more subtle mobile lightbox hint
2018-08-28 15:25:54 -04:00
740308675b
FEATURE: erode bounce score every time an email is sent
...
Introduces a hidden setting (default is 0.1) that erodes bounce score
every time we send an email. This means that erratic failures are less
painful cause system auto corrects
2018-08-28 17:02:12 +10:00
e25a6e085e
FIX: drop title updates through RSS feeds
...
can create an update loop
2018-08-28 16:25:04 +10:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
ebe7835316
FIX: links in rss feeds are sometimes wrong on subfolder installs
2018-08-27 18:05:15 -04:00
26e05933cd
FIX: Use proper markdown syntax for image urls
2018-08-28 00:29:26 +05:30
b12cf08c57
minor css tweak
2018-08-27 16:38:57 +02:00
4fdc27bab5
UI: improves participants list in messages ( #6320 )
2018-08-27 15:41:34 +02:00
c8ffe0fda3
FIX: term should be handled as text ( #6321 )
2018-08-27 11:58:46 +02:00
cf3b7ccae2
Merge pull request #6295 from nbianca/fix_mobile_images
...
UX: Show only the expand icon in lightboxes on mobile.
2018-08-27 13:07:55 +08:00
53a6c31107
Merge pull request #6310 from nbianca/ux_ip_lookup
...
UX: Improve copying from IP lookup component.
2018-08-27 13:04:35 +08:00
3584af4e51
Merge pull request #6314 from nbianca/groups_directory
...
UX: Do not show the groups directory if disabled.
2018-08-27 13:00:39 +08:00
fb0b54f7f8
UX: Styles for user-cards should the same with badges on / off
2018-08-27 11:16:48 +08:00
1f4af5ab36
UX: Super short tags shouldn't display on same line as title
2018-08-27 10:35:15 +08:00
4205c528d0
FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages
...
These site settings are very hard to explain and only applicable for very
specific Discourse setups.
If an admin "enables staged users" which is used in support scenarios then
all staff can send "messages" directly to an "email".
The setting allows you to extend this to TL4 or any trust level.
Actual use case would be a support type setup with restricted staff. It is
quite rare so hiding this for now and re-evaluate keeping the setting in
2019
2018-08-27 11:38:22 +10:00
2271918be2
FEATURE: Use S3 dualstack endpoints
...
Allows S3 without a CDN to serve images from dualstack domains that also support ipv6
2018-08-27 11:22:46 +10:00
5ccf581e1e
UX: Improve copying from IP lookup component.
...
- Removed trailing whitespaces caused by textarea.
- Clicking the Copy button will show "copied" for 2 seconds.
2018-08-26 22:20:24 +02:00
5be41faa8c
UX: Do not show the groups directory if disabled.
...
Staff could still the groups directory before.
2018-08-26 00:21:16 +02:00
64c4171937
add no-text to PM bulk select button
2018-08-25 00:07:35 -04:00
c3ba822489
remove debug
2018-08-24 16:46:55 -07:00
3743e90316
FIX: second factor input for username password is disabled when hidden.
2018-08-24 16:15:34 -07:00
faf09bb8c8
Replacing default brown category color
2018-08-24 14:18:14 -04:00
2dbd75d4d2
minor css tweaks on reports
2018-08-24 17:16:01 +02:00
9bf4333491
FIX: redirect to wrong URL after account creation on subfolder install
2018-08-24 10:34:44 -04:00
82dcc5cbfa
FEATURE: makes reports loadable in bulk ( #6309 )
2018-08-24 15:28:01 +02:00
a4001c1ea0
FEATURE: Pop revise modal on post edited notification ( #6287 )
...
* Add revision number to notification url
* Pop modal on route change
* Add semicolon
* Ensure modal pops even when navigating within a topic
* Ensure modal pops when visiting from other page
* Fix eslint errors
* Fix prettier errors
* Add callback for notification item click
* Remove stray revisionUrl function
* Rename to afterRouteComplete
2018-08-24 09:13:07 -04:00
932195d828
DEV: Update test case for `TopicEmbed`.
2018-08-24 09:42:12 +08:00
1ba24496ab
Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates
...
FIX: update TopicEmbed's title and user correctly
2018-08-24 09:32:03 +08:00
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
ac11f8df52
correct regression searching with diacritics
2018-08-24 10:00:51 +10:00
29315b73c2
FIX: improve last_modified date returned for avatars
...
instead of hard coding a date:
1. For optimized images use the upload date when on s3
2. For not-found use 10 minutes ago to match the expiry
2018-08-24 09:36:11 +10:00
c26de01399
Use NFKD normalization instead of NFD
2018-08-24 00:52:53 +02:00
bc7b530b0a
FIX: remove diacritics instead of transliterating
2018-08-24 00:38:44 +02:00
f4ae53d52b
Return immediately when there's no html to scrub
2018-08-23 18:00:07 +02:00
2fcf2b899e
FIX: remove diacritics when tokenizing html for search
2018-08-23 17:13:52 +02:00
409ee66839
Add optional "ignore_case" parameter to posts:remap rake task
2018-08-23 14:49:17 +02:00
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
07e11a223c
FIX: prefills username for new message on first post ( #6305 )
2018-08-23 11:09:35 +02:00
3d176d9984
Add missing copy
2018-08-23 09:44:15 +02:00
72ed6ae951
Raise an error if update fails.
2018-08-23 15:40:21 +08:00
bd66fbef7f
FIX: Post time query filter not set correctly when loaded from params.
...
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
2711f173dc
FIX: don't allow inviting more than `max_allowed_message_recipients`
...
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows
* add specs for guardian
* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)
Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences
* groups take only 1 slot in PM
* just return if topic is a PM
2018-08-23 14:36:49 +10:00
b2ce33be26
FIX: tag intersection not populating ( #6296 )
...
* Fix for tag intersection not populating
* Fix prettier
* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
36a7028f19
FEATURE: Clean up `PostReplyKey` records.
...
* Default retention of 90 days.
2018-08-23 10:40:02 +08:00
4436024563
UX: Show only the expand icon in lightboxes on mobile.
2018-08-22 19:21:42 +02:00
a48059fd8f
FIX: uses localized string for 429 in reports ( #6302 )
...
NGINX was retuning an html page instead of single string for some users. Seems safer to not risk showing anything from server anyways.
2018-08-22 18:13:29 +02:00
c08dea386b
FIX: better handling of no prev30Days ( #6301 )
2018-08-22 18:00:11 +02:00
f01169d6ff
FIX: don't send email when the post was deleted
2018-08-22 13:13:58 +02:00
774e6bc795
FIX: handle rate limiting from nginx ( #6300 )
2018-08-22 13:10:57 +02:00
87d443f070
FIX: counters were showing future instead of past ( #6299 )
2018-08-22 12:37:05 +02:00
599cebf8ad
FIX: better message if request for report is rate limited ( #6298 )
2018-08-22 11:25:12 +02:00
758fae7f9f
UX: Keyboard shortcuts will automatically select hovered post
2018-08-22 15:47:17 +10:00
cdea969c6a
FEATURE: Make initial admins TL1
...
* Match register controller TL to rake admin:create
* Don't promote if trust_level > 1
2018-08-22 15:45:24 +10:00
5a6d1ee257
FIX: defer actions in a static method
...
This avoids capturing a huge closure and passing to defer
2018-08-22 14:36:56 +10:00
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
bed34b52b5
UX: Blue "Resend Activation Email" button in wizzard
2018-08-21 22:18:08 +02:00
a00d368d0f
remove empty line
2018-08-21 19:46:04 +02:00
61447a8046
UX: don't show the whisper toggle when replying to a whisper
2018-08-21 19:35:40 +02:00
17dc8f2490
UX: Wizard resends activation email when user exists
2018-08-21 19:13:41 +02:00
3e436e2daf
FIX: doesn't translate group permission keys
2018-08-21 12:56:56 +02:00
baf413d527
FIX: update TopicEmbed's title and user correctly
2018-08-21 18:31:01 +08:00
8bdf14834b
PERF: Restrict number of skipped email log for `Jobs::UserEmail`.
2018-08-21 11:14:43 +08:00
7c69fa8cfd
PERF: Memoize `SkippedEmailLog.reason_types`.
2018-08-21 10:25:06 +08:00
2c70d3f443
Take 2 on ba6f11c521.
2018-08-21 10:06:36 +08:00
2d96160192
FEATURE: improve API error reporting for invalid records
2018-08-21 11:54:34 +10:00
45cd141ed6
Need to clear subcategories
2018-08-20 21:07:07 -04:00
96d1ea03e7
Sorting is hard. This should really fix user profiles.
2018-08-20 18:56:21 +02:00
209ed105f9
FIX: User profiles didn't work when API keys exist
2018-08-20 18:21:40 +02:00
dc5fddbfe6
FIX: Do not show an empty modal when an IP address is allowed or blocked. ( #6265 )
2018-08-20 17:37:30 +02:00
860c1c3dcd
FEATURE: Automatically expire keys if not used for a configurable amount of time. ( #6264 )
2018-08-20 17:36:14 +02:00
1d913d3204
UX: Allow admin to copy IP address details of a user. ( #6270 )
2018-08-20 17:29:20 +02:00
5ed582551a
FIX: SpamRulesEnforcer should use default locale
2018-08-20 15:08:12 +02:00
cc851af750
FIX: HTML lang attribute expects hyphen instead of underscore
2018-08-20 13:55:58 +02:00
14af90df5b
UX: Stop putting usernames in edit reason when changing post owner
2018-08-20 12:28:04 +02:00
b4f92a05b3
FIX: Load more on groups page does not account for params.
...
https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259
2018-08-20 17:08:50 +08:00
658b55c406
FIX: Search does not retrigger when context has changed. Take 2.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
ce4b12ae59
FIX: if we have not target available do not redirect
2018-08-20 13:10:59 +10:00
9c3ba98ef1
FIX: User can't save gravatar as profile picture after refresh.
...
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
8b5e42ea16
FIX: always test and coerce to image on upload
...
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.
We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
975a72ab7a
FEATURE: Make links indexable. ( #6285 )
2018-08-20 10:39:19 +10:00
a15a43605e
Simplifying category page markup
2018-08-17 23:07:07 -04:00
e7e8f4ef4c
Add plugin API for handling uploads with specific file extensions
2018-08-17 16:08:47 +01:00
37d4f27c44
FIX: quality/bugfix dashboard/reports pass ( #6283 )
2018-08-17 16:19:25 +02:00
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
b69f72853f
UX: Show static page title. ( #6273 )
2018-08-17 10:47:11 +02:00
9628c3cf97
FEATURE: automatically correct extension for bad uploads
...
This fixes with post thumbnails on the fly
2018-08-17 14:00:27 +10:00
93201d8dbe
FIX: don't trigger 'flag_reviewed' when no flags were reviewed
2018-08-16 18:11:29 +02:00
3fbf7b164d
FEATURE: emoji 11.0 "recently added" update ( #6275 )
...
Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list
2018-08-16 11:59:45 +02:00
baa72d18f8
FIX: simplify so we ban all auth paths
...
previously plugins that have auth paths were not disallowed and robots
tend to call them
2018-08-16 19:16:47 +10:00
f62073a22a
correct regression uploading images
2018-08-16 18:49:08 +10:00
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
8e240af3ea
FIX: z-index fix for tag input on mobile
2018-08-16 01:17:15 -04:00
8c46ecf7f3
UX: Improving tag topic list navigation consistency
2018-08-16 00:02:26 -04:00
1f17b84b63
FEATURE: more context for error reporting on jobs fails
2018-08-16 12:38:49 +10:00
c8b5e6baae
FEATURE: Use `display: browser` in webmanifest for iOS devices
...
Since iOS doesn't have a back button and can have issues on log in.
See https://twitter.com/firt/status/1021477243909033984
2018-08-15 23:36:08 -03:00
7b412727bb
Fixing HTML structure of tag filtered topic list
2018-08-15 19:45:37 -04:00
243fc9d0f9
FIX: refreshing auto groups when min_username_length is long
2018-08-15 16:59:56 +10:00
33b5cc6bbd
FIX: Add gif to list of allowed decoders
2018-08-15 13:56:57 +10:00
cf788582cc
DEV: split optimize image failure warnings in logs
2018-08-15 13:27:24 +10:00
d4fd19d49a
UX: Replace Google search with Discourse search on not found page
...
* UX: Replace Google search with Discourse search on not found page.
* FIX: Update application_controller_spec.rb.
2018-08-15 11:53:04 +10:00
12bab65167
FIX: going from /categories to /latest on mobile might break infinite scrolling
2018-08-15 01:22:03 +02:00
c358421ca5
FIX: Bulk updating category failed when topic title was too short
2018-08-14 16:37:52 +02:00
7290765a62
FIX: uses touchstart/mousedown for selected tags ( #6268 )
...
It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.
2018-08-14 16:16:13 +02:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
ad5f502332
FIX: add a basic validator for topic params
...
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
983dba37ce
FIX: use BasicUserSerializer for user_badge.granted_by ( #6266 )
...
BasicUserSerializer contains enough information for the badges page,
while UserSerializer issues ~100 SQL queries on the fly when serializing
the field without preloading.
2018-08-14 08:11:14 +10:00
71b65be6f6
SECURITY: prevent use of X-Forwarded-Host to perform XSS
2018-08-13 16:45:22 -04:00
075d80862f
UX: topic-timer modal style fixes
2018-08-13 14:04:20 +08:00
03010571f5
Remove unnecessary code ( #6262 )
...
"border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.
2018-08-13 15:43:03 +10:00
e26437f334
FEATURE: Do encodeURI on share links
...
Some Discourse-supported sharing platforms such as Twitter are unable to determine the end of a unicode URL. If you post a URL "https://example.org/t/测试/1 " on Twitter, it will be a link of href="https://example.org/t/ "
If the URL contains any unicode character (usually in the slug part) , it must be urlencoded with encodeURI(url) before being passed to source.generateUrl(link, title), or it will be a malformed URL in the sharing tweet.
2018-08-13 15:35:56 +10:00
7e68062a46
Topic meta-data flexbox fixes ( #6263 )
...
Topic meta-data flexbox fixes
2018-08-13 13:29:46 +08:00
83fd308963
FEATURE: group error message regarding image optimization failures
2018-08-13 14:48:25 +10:00
ba022234c6
Add onceoff job to fix incorrect upload extensions.
2018-08-13 10:44:08 +08:00
a6820d8767
Add Hungarian locale ( #6260 )
2018-08-13 01:02:35 +02:00
6d813c2b52
FIX: Importers failed to import avatars
2018-08-12 22:02:17 +02:00
448e95b97d
UX: Show anchor icon instead of text when topic bump is disabled
2018-08-11 21:51:13 +02:00
a960a57c72
Improving category reorder modal layout
2018-08-10 22:09:46 -04:00
e53983b53b
Alignment fix
2018-08-10 14:00:06 -04:00
b73950692b
FIX: Parsing non-existent feed should not fail
2018-08-10 18:37:14 +02:00
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
6f6b4ff988
regression: don't return from a block
...
also clean up some warnings (shadowed var, unused var)
2018-08-10 14:53:55 +10:00
0451dba27a
Table margin adjustment
2018-08-09 21:24:26 -04:00
093c3510e6
Rework moderators activity query ( #6230 )
...
* Order rows in query
* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
b9072e8292
FEATURE: Add "Reset Bump Date" action to topic admin wrench ( #6246 )
2018-08-10 10:51:03 +10:00
6db623ef6b
UX: Improve category filtering and include subcategories
...
* category_filtering
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
* category_filtering with subcategory topics
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
4. report_posts
5. report_topics
6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
1. report_posts
2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
1. `in_category_and_subcategories` in `topic_spec.rb`
2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
6ec92d5845
prettier
2018-08-09 20:45:47 -04:00
2e1049a75a
Minor dashboard style adjustments
2018-08-09 20:43:18 -04:00
3cd4dc0f5f
Allow users with group_locked_trust_level to be promoted to tl3 ( #6249 )
2018-08-10 10:42:23 +10:00
6a2ca60b48
FIX: ember click event not reliably working on fx ( #6256 )
2018-08-09 22:41:35 +02:00
04658bb2f1
UX: prevent text from wrapping below notification icons
2018-08-09 12:04:34 -04:00
2c4d7225d8
FIX: permalink redirects with subfolder
2018-08-09 11:05:27 -04:00
701c5ae781
UX: admin permalink form can fit on one line
2018-08-09 11:05:27 -04:00
da1d520d4c
FIX: simplifies mini tag chooser events handling ( #6252 )
2018-08-09 14:23:28 +02:00
bfcf8ed61b
FIX: prevents focus of input on mobile ( #6251 )
2018-08-09 14:23:09 +02:00
523acfcea4
FIX: checks on parent visibility instead of filter itself ( #6250 )
2018-08-09 10:45:53 +02:00
7aef604f7d
regression, if there is not excerpt skip
2018-08-09 15:07:18 +10:00
ed4c0f256e
FIX: check permalinks for deleted topics
...
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
f7b4a2b3ba
FIX: ensure URLs include subfolder in admin emails UI
2018-08-08 16:48:03 -04:00
b53d3457c8
updating color scheme attribution
2018-08-08 16:01:21 -04:00
cc96af07d1
Full-width markdown table on mobile
2018-08-08 15:51:11 -04:00
35bef72d4e
FIX: subfolder redirects to wrong URL if the subfolder appears in the slug
2018-08-08 13:41:29 -04:00
94622b451a
FIX: Search does not retrigger when context has changed.
...
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-08 17:55:37 +08:00
d3a9596d08
Remove unused import
2018-08-08 10:46:43 +01:00
d4d5088324
FIX: Don't require device capabilities when calculating login methods
2018-08-08 10:37:25 +01:00
575d9e0b1a
FIX: Include parameters in function call
2018-08-08 10:09:22 +01:00
ba6f11c521
PERF: Only log the first skipped email when user exceeds daily limit.
...
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
2018-08-08 16:25:00 +08:00
0d45826d22
fix theme previewing ( #6245 )
2018-08-08 10:58:45 +03:00
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
3f6ad65aec
FEATURE: include excerpt in HTML view for pinned topics
2018-08-08 11:15:49 +10:00
4e6e4a83df
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
17d8fea796
Markdown tables should have vertical margin
2018-08-07 16:15:28 -04:00
48ecad53f2
additional hamburger alignment fix
2018-08-07 09:47:01 -04:00
67ec81babf
FIX: fixes last backup/last_update dates ( #6242 )
2018-08-07 08:19:52 -04:00
aa9a9a5a72
FIX: Include auth_providers for anonymous users when login_required
2018-08-07 09:24:16 +01:00
d5a7b818ba
FIX: Move Jobs::CreateAvatarThumbnails to low priority queue.
2018-08-07 16:05:54 +08:00
2b57239389
FIX: Upload's content is the only source of truth for the file type.
2018-08-07 13:15:00 +08:00
6797395bd0
FIX: staff should be allowed to agree and keep post
2018-08-07 10:05:43 +10:00
8477501e83
FIX: imrpoves alert-error styles in counters reports ( #6240 )
2018-08-06 16:59:45 -04:00
7f2f3b8b22
FIX: improves reports resilience ( #6239 )
...
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
c301111461
FIX: display select kit body if no choices ( #6237 )
2018-08-06 11:22:48 -04:00
74269ad585
FIX: hamburger menu category alignment
2018-08-06 11:11:29 -04:00
9b04921616
FIX: don't require auth providers to set full_screen_login_setting
2018-08-06 10:24:39 +01:00
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
4e11811321
FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`.
...
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
2018-08-06 13:29:44 +08:00
18b396ad56
FEATURE: add link to see new commits when updates are available for themes ( #6233 )
...
* FEATURE: add link to see new commits when updates are available for themes
* shorten regexp
2018-08-06 15:29:15 +10:00
cc77a285ee
UX: improves edit reason contrast in dark themes
2018-08-06 10:53:46 +08:00
0cd9e2acb9
fix build
2018-08-04 01:56:26 +02:00
bf4d98e89d
FIX: always store topic links using the upload url
2018-08-04 01:29:32 +02:00
84d822959a
Reducing some specificity, color fix
2018-08-03 17:44:22 -04:00
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
072f5ce825
Increase ruby character size
2018-08-03 13:37:08 -04:00
535732bdc1
FIX: ensure the 'email_revoked' PM template is customizable
2018-08-03 17:10:20 +02:00
280c318c49
FEATURE: allow ruby tags in Markdown
2018-08-03 11:47:36 +10:00
880462a41c
FEATURE: display out of date themes on admin dashboard
...
* FEATURE: disaply out of date themes on admin dashboard
* Update copy
2018-08-03 09:53:48 +10:00
864e279aaf
FIX: wrong links to subcategories in top categories section of user summary
2018-08-02 17:38:42 -04:00
1ca999fdb5
FIX: formats topic report only if we have one ( #6231 )
2018-08-02 08:01:17 -04:00
0b3d51a8bc
FEATURE: whitelist lang attribute
2018-08-02 16:53:08 +10:00
9499693baa
Layout works better with auto columns
2018-08-01 22:37:21 -04:00
60f62f6f36
FIX: improves report-show mobile UI ( #6229 )
2018-08-01 19:54:27 -04:00
859c98743f
FIX: removes ellipsis from activity-metrics report cells
2018-08-01 19:08:53 -04:00
8cbe3cbe26
this file shouldn’t have been comitted
2018-08-01 19:01:47 -04:00
9073e11943
FIX: improves number/percent support in reports
2018-08-01 18:40:59 -04:00
4a872823e7
Improvements to user drafts ( #6226 )
...
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels
* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
8147130412
Group icon misalignment
2018-08-01 17:30:17 -04:00
d678ef2653
group icon needs margin
2018-08-01 17:05:35 -04:00
04255d1dce
removing unneeded styles
2018-08-01 16:38:47 -04:00
f0bea4ae55
Improve PM participant list
2018-08-01 16:20:14 -04:00
4eef41ea1b
FIX: Error with debouncing mentions
2018-08-01 15:57:24 -04:00
2ec1aec2be
FIX: Clicking admin wrench in topic footer didn't hide post select box
2018-08-01 21:29:35 +02:00
1a0ffc5ace
FEATURE: Added method to get multiple values at once from PluginStore. ( #6225 )
2018-08-01 18:42:40 +02:00
f4ca105498
FIX: Moving posts to existing topic didn't update topic metadata
2018-08-01 18:05:43 +02:00
d7b463a03d
FIX: Remove unused import
2018-08-01 11:54:47 -04:00
7c950321d1
FIX: Allow non-english usernames in autocomplete
...
Also add support for username formatters
2018-08-01 11:53:20 -04:00
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
0b9437cee7
FIX: more resilient/consistent dashboard caching ( #6223 )
2018-08-01 09:45:50 -04:00
7c7dfa4e5e
FIX: wraps any query with the slow query guard ( #6222 )
2018-08-01 07:39:57 -04:00
8178444382
Make prettier happy
2018-08-01 15:13:54 +05:30
8556288397
DEV: Export Tag class to modify methods in plugin
2018-08-01 15:10:15 +05:30
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
5d421fb946
FIX: Try respecting charset in HTTP header of RSS feed
2018-08-01 10:41:20 +02:00
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
70ea153dce
Fix lint.
2018-08-01 12:23:36 +08:00
53adbf70f3
FIX: Nav item missing for plugins that don't include a custom filter.
2018-08-01 11:50:14 +08:00
5febe71baa
FIX: prevents crash if flagger doesn’t exist ( #6219 )
2018-07-31 23:48:54 -04:00
849f0d00f6
FEATURE: adds revision_count to moderators_activity ( #6218 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
919e8db686
FIX: Check for group name availability should skip reserved usernames.
2018-08-01 11:09:33 +08:00
129268ddc6
Highlighted titles too wide on mobile
2018-07-31 21:24:43 -04:00
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
0715aa18da
UI: uses tiny avatars for reports ( #6215 )
2018-07-31 18:57:00 -04:00
37252c1a5e
UI: improves dashboard table reports
...
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
4b166cccc1
FIX: Linting error
2018-07-31 14:19:45 -04:00
b6bb8df622
FIX: We loosened username restrictions some time ago
...
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
Kris
David Taylor
Joffrey JAFFEUX
Guo Xiang Tan
Neil Lalonde
Sam
Gerhard Schlager
Vinoth Kannan
Jeff Atwood
Bianca Nenciu
Osama Sayegh
Rishabh Nambiar
Régis Hanol
Arpit Jalan
Joshua Rosenfeld
Blake Erickson
Vinoth Kannan
Kyle Zhao
Guo Xiang Tan
Joe
Raul Tambre
Bianca Nenciu
Jeff Wong
James Kiesel
Misaka 0x4e21
Rafael dos Santos Silva
tshenry
Peter Borsa
Simon Cossar
Leo McArdle
Penar Musaraj
Robin Ward
Dan Ungureanu