Commit Graph

17876 Commits

Author SHA1 Message Date
Gerhard Schlager ddfd02ad36 FIX: Deleting backup failed after uploading backup 2018-08-31 13:50:32 +02:00
Gerhard Schlager 91b3f200f4 UX: Primary button didn't have hover effect anymore 2018-08-31 12:14:41 +02:00
Gerhard Schlager 5310b4841d UX: Show Rollback and Backup buttons on same line 2018-08-31 12:01:59 +02:00
Guo Xiang Tan 5a214a687c FIX: Exclude `UserAuthToken` and `UserAuthTokenLog` in user webhook. 2018-08-31 17:25:56 +08:00
Régis Hanol 6ada825a4d fix linting 2018-08-31 10:49:44 +02:00
Bianca Nenciu 931cffcebe FEATURE: Let users see their user auth tokens. (#6313) 2018-08-31 10:18:06 +02:00
Sam b3aab1770f FIX: set old last modified date for invalid avatars
In some cases Akami was holding tight to these invalid avatars,
to avoid this happening we explain the avatar image is ancient
then when a new upload is added it automatically is older than
this.
2018-08-31 17:07:31 +10:00
Sam e1975e293f FIX: when uploads are destroyed clear up avatar refs in user table
This also auto corrects twice daily when we ensure consistency
2018-08-31 14:46:42 +10:00
Arpit Jalan 6b9aeeea73 bump onebox version 2018-08-31 08:40:36 +05:30
Sam 9b7cab589a FIX: revert diacritic stripping
See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam
2018-08-31 11:46:55 +10:00
Joshua Rosenfeld f3afc0cf76 Add raw date to title attribute on old flags page (#6349) 2018-08-31 11:01:10 +10:00
Blake Erickson ae532f8548 FIX: return 422 for an invalid group name on category create 2018-08-30 14:28:55 -06:00
Joffrey JAFFEUX bb93179609
FEATURE: charts will now use tertiary color (#6342) 2018-08-30 14:56:11 +02:00
David Taylor 103509b9dd SECURITY: Prevent users from modifying custom fields 2018-08-30 12:59:36 +01:00
Guo Xiang Tan 0f812aa768 Make prettier happy. 2018-08-30 15:56:30 +08:00
Guo Xiang Tan 4f81d4cc8e Minor fixes to `Jobs::BulkInvite`. 2018-08-30 15:35:16 +08:00
Vinoth Kannan 092fb0c170
Merge pull request #6333 from vinothkannans/rich-text-pasting
FIX: Use tight list format for GDocs html to markdown
2018-08-30 12:14:50 +05:30
David Taylor f0abb4d09a FIX: Allow user actions to be saved even if the post has nil user
This issue made it impossible to delete users if they had flagged a post with nil user
2018-08-30 01:03:32 +01:00
Sam e6970151a6 FEATURE: allow specifying locale via SSO
Use:

locale
locale_force_update

To force user locale on users where SiteSetting.allow_user_locale is enabled

Note: If an invalid locale is specified no action will occur
2018-08-30 09:58:03 +10:00
Jeff Atwood 22110d3106 minor copyedit on pm a/r button 2018-08-29 16:51:38 -07:00
Bianca Nenciu 72ffabf619 UX: Improve email testing admin tool. (#6308) 2018-08-29 23:14:16 +02:00
Bianca Nenciu c1a5a7504e FIX: Reset email preferences controller. (#6316) 2018-08-29 23:10:56 +02:00
Vinoth Kannan 4c99acea1b FIX: Use tight list format for GDocs html to markdown 2018-08-29 16:21:31 +00:00
Kris 8ff83d174e
FIX: Changing tag name class to data attribute (#6326) 2018-08-29 10:49:19 -04:00
Kris 78089e3577 Removing unneeded background color 2018-08-29 08:58:28 -04:00
Gerhard Schlager b2cf725700 FIX: Don't try to send invite email when invite was deleted 2018-08-29 12:43:12 +02:00
Joffrey JAFFEUX 1281fb964e
FIX: prevents remove user btn to overflow parent (#6329) 2018-08-29 10:11:44 +02:00
Vinoth Kannan 26f17150e1
Merge pull request #6327 from vinothkannans/rich-text-pasting
FIX: Keep emojis and remove clicks count on html to markdown
2018-08-29 13:38:55 +05:30
Joffrey JAFFEUX ad34bdca09
UI: minor tweaks to new message participants list (#6328)
* Icon for button
* Display name when editing on mobile
* Always display name on mobile when less/or 4 participants involved
2018-08-29 10:07:49 +02:00
Vinoth Kannan fb35b0b3c3 FIX: Keep emojis and remove clicks count 2018-08-29 07:26:25 +00:00
Sam 44cf3cf975 FIX: queue heartbeats in readonly modes
If sidekiq is paused or Discourse is in readonly continue to queue
heartbeats

If we do not do that then a master process can end up reaping sidekiq
workers and causing various badness

This also impacts restore which can do weird stuff TM in cases like this
2018-08-29 12:36:59 +10:00
Neil Lalonde 7516f5159e FIX: /rules route showed error page 2018-08-28 20:40:37 -04:00
Kris feeaac81df FIX: Mobile admin menu iOS rendering bug 2018-08-28 16:39:20 -04:00
Kris 3a4a6cb41a alignment fix 2018-08-28 16:27:34 -04:00
Kris 7deb86ad8b A more subtle mobile lightbox hint 2018-08-28 15:25:54 -04:00
Sam 740308675b FEATURE: erode bounce score every time an email is sent
Introduces a hidden setting (default is 0.1) that erodes bounce score
every time we send an email. This means that erratic failures are less
painful cause system auto corrects
2018-08-28 17:02:12 +10:00
Kyle Zhao e25a6e085e FIX: drop title updates through RSS feeds
can create an update loop
2018-08-28 16:25:04 +10:00
Sam 9ab1fb7dfc FEATURE: correctly store width and height on uploads
Previously we used width and height for thumbnails, new code ensures

1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
 by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions

Also

- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
Neil Lalonde ebe7835316 FIX: links in rss feeds are sometimes wrong on subfolder installs 2018-08-27 18:05:15 -04:00
Vinoth Kannan 26e05933cd FIX: Use proper markdown syntax for image urls 2018-08-28 00:29:26 +05:30
Joffrey JAFFEUX b12cf08c57
minor css tweak 2018-08-27 16:38:57 +02:00
Joffrey JAFFEUX 4fdc27bab5
UI: improves participants list in messages (#6320) 2018-08-27 15:41:34 +02:00
Joffrey JAFFEUX c8ffe0fda3
FIX: term should be handled as text (#6321) 2018-08-27 11:58:46 +02:00
Guo Xiang Tan cf3b7ccae2
Merge pull request #6295 from nbianca/fix_mobile_images
UX: Show only the expand icon in lightboxes on mobile.
2018-08-27 13:07:55 +08:00
Guo Xiang Tan 53a6c31107
Merge pull request #6310 from nbianca/ux_ip_lookup
UX: Improve copying from IP lookup component.
2018-08-27 13:04:35 +08:00
Guo Xiang Tan 3584af4e51
Merge pull request #6314 from nbianca/groups_directory
UX: Do not show the groups directory if disabled.
2018-08-27 13:00:39 +08:00
Joe fb0b54f7f8
UX: Styles for user-cards should the same with badges on / off 2018-08-27 11:16:48 +08:00
Joe 1f4af5ab36
UX: Super short tags shouldn't display on same line as title 2018-08-27 10:35:15 +08:00
Sam 4205c528d0 FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages
These site settings are very hard to explain and only applicable for very
specific Discourse setups.

If an admin "enables staged users" which is used in support scenarios then
all staff can send "messages" directly to an "email".

The setting allows you to extend this to TL4 or any trust level.

Actual use case would be a support type setup with restricted staff. It is
quite rare so hiding this for now and re-evaluate keeping the setting in
2019
2018-08-27 11:38:22 +10:00
Raul Tambre 2271918be2 FEATURE: Use S3 dualstack endpoints
Allows S3 without a CDN to serve images from dualstack domains that also support ipv6
2018-08-27 11:22:46 +10:00
Bianca Nenciu 5ccf581e1e UX: Improve copying from IP lookup component.
- Removed trailing whitespaces caused by textarea.
- Clicking the Copy button will show "copied" for 2 seconds.
2018-08-26 22:20:24 +02:00
Bianca Nenciu 5be41faa8c UX: Do not show the groups directory if disabled.
Staff could still the groups directory before.
2018-08-26 00:21:16 +02:00
Kris 64c4171937 add no-text to PM bulk select button 2018-08-25 00:07:35 -04:00
Jeff Wong c3ba822489 remove debug 2018-08-24 16:46:55 -07:00
Jeff Wong 3743e90316 FIX: second factor input for username password is disabled when hidden. 2018-08-24 16:15:34 -07:00
Kris faf09bb8c8 Replacing default brown category color 2018-08-24 14:18:14 -04:00
Joffrey JAFFEUX 2dbd75d4d2
minor css tweaks on reports 2018-08-24 17:16:01 +02:00
Neil Lalonde 9bf4333491 FIX: redirect to wrong URL after account creation on subfolder install 2018-08-24 10:34:44 -04:00
Joffrey JAFFEUX 82dcc5cbfa
FEATURE: makes reports loadable in bulk (#6309) 2018-08-24 15:28:01 +02:00
James Kiesel a4001c1ea0 FEATURE: Pop revise modal on post edited notification (#6287)
* Add revision number to notification url

* Pop modal on route change

* Add semicolon

* Ensure modal pops even when navigating within a topic

* Ensure modal pops when visiting from other page

* Fix eslint errors

* Fix prettier errors

* Add callback for notification item click

* Remove stray revisionUrl function

* Rename to afterRouteComplete
2018-08-24 09:13:07 -04:00
Guo Xiang Tan 932195d828 DEV: Update test case for `TopicEmbed`. 2018-08-24 09:42:12 +08:00
Guo Xiang Tan 1ba24496ab
Merge pull request #6261 from xrav3nz/fix/topic-embed-import-updates
FIX: update TopicEmbed's title and user correctly
2018-08-24 09:32:03 +08:00
Osama Sayegh e0cc29d658 FEATURE: themes and components split
* FEATURE: themes and components split

* two seperate methods to switch theme type

* use strict equality operator
2018-08-24 11:30:00 +10:00
Sam ac11f8df52 correct regression searching with diacritics 2018-08-24 10:00:51 +10:00
Sam 29315b73c2 FIX: improve last_modified date returned for avatars
instead of hard coding a date:

1. For optimized images use the upload date when on s3
2. For not-found use 10 minutes ago to match the expiry
2018-08-24 09:36:11 +10:00
Régis Hanol c26de01399 Use NFKD normalization instead of NFD 2018-08-24 00:52:53 +02:00
Régis Hanol bc7b530b0a FIX: remove diacritics instead of transliterating 2018-08-24 00:38:44 +02:00
Régis Hanol f4ae53d52b Return immediately when there's no html to scrub 2018-08-23 18:00:07 +02:00
Régis Hanol 2fcf2b899e FIX: remove diacritics when tokenizing html for search 2018-08-23 17:13:52 +02:00
Gerhard Schlager 409ee66839 Add optional "ignore_case" parameter to posts:remap rake task 2018-08-23 14:49:17 +02:00
Arpit Jalan 7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
Arpit Jalan 1a7cd6648b UX: show full name on /latest page 2018-08-23 14:41:06 +05:30
Joffrey JAFFEUX 07e11a223c
FIX: prefills username for new message on first post (#6305) 2018-08-23 11:09:35 +02:00
Gerhard Schlager 3d176d9984 Add missing copy 2018-08-23 09:44:15 +02:00
Guo Xiang Tan 72ed6ae951 Raise an error if update fails. 2018-08-23 15:40:21 +08:00
Guo Xiang Tan bd66fbef7f FIX: Post time query filter not set correctly when loaded from params.
https://meta.discourse.org/t/before-and-after-are-not-implemented-right-in-search/92515
2018-08-23 14:06:28 +08:00
Osama Sayegh 2711f173dc FIX: don't allow inviting more than `max_allowed_message_recipients`
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows

* add specs for guardian

* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)

Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences

* groups take only 1 slot in PM

* just return if topic is a PM
2018-08-23 14:36:49 +10:00
James Kiesel b2ce33be26 FIX: tag intersection not populating (#6296)
* Fix for tag intersection not populating

* Fix prettier

* Add acceptance test for tags intersection
2018-08-23 14:22:47 +10:00
Guo Xiang Tan 36a7028f19 FEATURE: Clean up `PostReplyKey` records.
* Default retention of 90 days.
2018-08-23 10:40:02 +08:00
Bianca Nenciu 4436024563 UX: Show only the expand icon in lightboxes on mobile. 2018-08-22 19:21:42 +02:00
Joffrey JAFFEUX a48059fd8f
FIX: uses localized string for 429 in reports (#6302)
NGINX was retuning an html page instead of single string for some users. Seems safer to not risk showing anything from server anyways.
2018-08-22 18:13:29 +02:00
Joffrey JAFFEUX c08dea386b
FIX: better handling of no prev30Days (#6301) 2018-08-22 18:00:11 +02:00
Régis Hanol f01169d6ff FIX: don't send email when the post was deleted 2018-08-22 13:13:58 +02:00
Joffrey JAFFEUX 774e6bc795
FIX: handle rate limiting from nginx (#6300) 2018-08-22 13:10:57 +02:00
Joffrey JAFFEUX 87d443f070
FIX: counters were showing future instead of past (#6299) 2018-08-22 12:37:05 +02:00
Joffrey JAFFEUX 599cebf8ad
FIX: better message if request for report is rate limited (#6298) 2018-08-22 11:25:12 +02:00
Bianca Nenciu 758fae7f9f UX: Keyboard shortcuts will automatically select hovered post 2018-08-22 15:47:17 +10:00
James Kiesel cdea969c6a FEATURE: Make initial admins TL1
* Match register controller TL to rake admin:create
* Don't promote if trust_level > 1
2018-08-22 15:45:24 +10:00
Sam 5a6d1ee257 FIX: defer actions in a static method
This avoids capturing a huge closure and passing to defer
2018-08-22 14:36:56 +10:00
Sam 5d96809abd FIX: improve support for subfolder S3 CDN 2018-08-22 12:31:13 +10:00
Gerhard Schlager bed34b52b5 UX: Blue "Resend Activation Email" button in wizzard 2018-08-21 22:18:08 +02:00
Régis Hanol a00d368d0f remove empty line 2018-08-21 19:46:04 +02:00
Régis Hanol 61447a8046 UX: don't show the whisper toggle when replying to a whisper 2018-08-21 19:35:40 +02:00
Gerhard Schlager 17dc8f2490 UX: Wizard resends activation email when user exists 2018-08-21 19:13:41 +02:00
Régis Hanol 3e436e2daf FIX: doesn't translate group permission keys 2018-08-21 12:56:56 +02:00
Kyle Zhao baf413d527 FIX: update TopicEmbed's title and user correctly 2018-08-21 18:31:01 +08:00
Guo Xiang Tan 8bdf14834b PERF: Restrict number of skipped email log for `Jobs::UserEmail`. 2018-08-21 11:14:43 +08:00
Guo Xiang Tan 7c69fa8cfd PERF: Memoize `SkippedEmailLog.reason_types`. 2018-08-21 10:25:06 +08:00
Guo Xiang Tan 2c70d3f443 Take 2 on ba6f11c521. 2018-08-21 10:06:36 +08:00
Sam 2d96160192 FEATURE: improve API error reporting for invalid records 2018-08-21 11:54:34 +10:00
Kris 45cd141ed6 Need to clear subcategories 2018-08-20 21:07:07 -04:00
Gerhard Schlager 96d1ea03e7 Sorting is hard. This should really fix user profiles. 2018-08-20 18:56:21 +02:00
Gerhard Schlager 209ed105f9 FIX: User profiles didn't work when API keys exist 2018-08-20 18:21:40 +02:00
Bianca Nenciu dc5fddbfe6 FIX: Do not show an empty modal when an IP address is allowed or blocked. (#6265) 2018-08-20 17:37:30 +02:00
Bianca Nenciu 860c1c3dcd FEATURE: Automatically expire keys if not used for a configurable amount of time. (#6264) 2018-08-20 17:36:14 +02:00
Misaka 0x4e21 1d913d3204 UX: Allow admin to copy IP address details of a user. (#6270) 2018-08-20 17:29:20 +02:00
Gerhard Schlager 5ed582551a FIX: SpamRulesEnforcer should use default locale 2018-08-20 15:08:12 +02:00
Gerhard Schlager cc851af750 FIX: HTML lang attribute expects hyphen instead of underscore 2018-08-20 13:55:58 +02:00
Gerhard Schlager 14af90df5b UX: Stop putting usernames in edit reason when changing post owner 2018-08-20 12:28:04 +02:00
Guo Xiang Tan b4f92a05b3 FIX: Load more on groups page does not account for params.
https://meta.discourse.org/t/cant-scroll-through-list-of-users-groups-if-more-than-one-page/92259
2018-08-20 17:08:50 +08:00
Guo Xiang Tan 658b55c406 FIX: Search does not retrigger when context has changed. Take 2.
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-20 15:46:02 +08:00
Sam ce4b12ae59 FIX: if we have not target available do not redirect 2018-08-20 13:10:59 +10:00
Guo Xiang Tan 9c3ba98ef1 FIX: User can't save gravatar as profile picture after refresh.
https://meta.discourse.org/t/gravatar-issue-cant-save-changes/95076
2018-08-20 10:29:50 +08:00
Sam 8b5e42ea16 FIX: always test and coerce to image on upload
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.

We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
Bianca Nenciu 975a72ab7a FEATURE: Make links indexable. (#6285) 2018-08-20 10:39:19 +10:00
Kris a15a43605e Simplifying category page markup 2018-08-17 23:07:07 -04:00
David Taylor e7e8f4ef4c Add plugin API for handling uploads with specific file extensions 2018-08-17 16:08:47 +01:00
Joffrey JAFFEUX 37d4f27c44
FIX: quality/bugfix dashboard/reports pass (#6283) 2018-08-17 16:19:25 +02:00
Guo Xiang Tan 16c0ebe8a8 Fix the build. 2018-08-17 16:53:07 +08:00
Bianca Nenciu b69f72853f UX: Show static page title. (#6273) 2018-08-17 10:47:11 +02:00
Sam 9628c3cf97 FEATURE: automatically correct extension for bad uploads
This fixes with post thumbnails on the fly
2018-08-17 14:00:27 +10:00
Régis Hanol 93201d8dbe FIX: don't trigger 'flag_reviewed' when no flags were reviewed 2018-08-16 18:11:29 +02:00
Joffrey JAFFEUX 3fbf7b164d
FEATURE: emoji 11.0 "recently added" update (#6275)
Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list
2018-08-16 11:59:45 +02:00
Sam baa72d18f8 FIX: simplify so we ban all auth paths
previously plugins that have auth paths were not disallowed and robots
tend to call them
2018-08-16 19:16:47 +10:00
Sam f62073a22a correct regression uploading images 2018-08-16 18:49:08 +10:00
Sam 796164b58c FIX: automatically correct bad avatars on access
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
Kris 8e240af3ea FIX: z-index fix for tag input on mobile 2018-08-16 01:17:15 -04:00
Kris 8c46ecf7f3 UX: Improving tag topic list navigation consistency 2018-08-16 00:02:26 -04:00
Sam 1f17b84b63 FEATURE: more context for error reporting on jobs fails 2018-08-16 12:38:49 +10:00
Rafael dos Santos Silva c8b5e6baae FEATURE: Use `display: browser` in webmanifest for iOS devices
Since iOS doesn't have a back button and can have issues on log in.

See https://twitter.com/firt/status/1021477243909033984
2018-08-15 23:36:08 -03:00
Kris 7b412727bb Fixing HTML structure of tag filtered topic list 2018-08-15 19:45:37 -04:00
Sam 243fc9d0f9 FIX: refreshing auto groups when min_username_length is long 2018-08-15 16:59:56 +10:00
Sam 33b5cc6bbd FIX: Add gif to list of allowed decoders 2018-08-15 13:56:57 +10:00
Sam cf788582cc DEV: split optimize image failure warnings in logs 2018-08-15 13:27:24 +10:00
Misaka 0x4e21 d4fd19d49a UX: Replace Google search with Discourse search on not found page
* UX: Replace Google search with Discourse search on not found page.

* FIX: Update application_controller_spec.rb.
2018-08-15 11:53:04 +10:00
Régis Hanol 12bab65167 FIX: going from /categories to /latest on mobile might break infinite scrolling 2018-08-15 01:22:03 +02:00
Gerhard Schlager c358421ca5 FIX: Bulk updating category failed when topic title was too short 2018-08-14 16:37:52 +02:00
Joffrey JAFFEUX 7290765a62
FIX: uses touchstart/mousedown for selected tags (#6268)
It seems to be way more reliable on firefox and safari in the case of hot replaced content not using ember.
2018-08-14 16:16:13 +02:00
Régis Hanol de92913bf4 FIX: store the topic links using the cooked upload url 2018-08-14 12:23:32 +02:00
Sam ad5f502332 FIX: add a basic validator for topic params
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
Kyle Zhao 983dba37ce FIX: use BasicUserSerializer for user_badge.granted_by (#6266)
BasicUserSerializer contains enough information for the badges page,
while UserSerializer issues ~100 SQL queries on the fly when serializing
the field without preloading.
2018-08-14 08:11:14 +10:00
Neil Lalonde 71b65be6f6 SECURITY: prevent use of X-Forwarded-Host to perform XSS 2018-08-13 16:45:22 -04:00
Joe 075d80862f
UX: topic-timer modal style fixes 2018-08-13 14:04:20 +08:00
tshenry 03010571f5 Remove unnecessary code (#6262)
"border-bottom: none;" gets overridden a few lines below by "border-bottom: 1px solid $primary-low;" making it unnecessary.
2018-08-13 15:43:03 +10:00
Misaka 0x4e21 e26437f334 FEATURE: Do encodeURI on share links
Some Discourse-supported sharing platforms such as Twitter are unable to determine the end of a unicode URL. If you post a URL "https://example.org/t/测试/1" on Twitter, it will be a link of href="https://example.org/t/"

If the URL contains any unicode character (usually in the slug part) , it must be urlencoded with encodeURI(url) before being passed to source.generateUrl(link, title), or it will be a malformed URL in the sharing tweet.
2018-08-13 15:35:56 +10:00
Joe 7e68062a46
Topic meta-data flexbox fixes (#6263)
Topic meta-data flexbox fixes
2018-08-13 13:29:46 +08:00
Sam 83fd308963 FEATURE: group error message regarding image optimization failures 2018-08-13 14:48:25 +10:00
Guo Xiang Tan ba022234c6 Add onceoff job to fix incorrect upload extensions. 2018-08-13 10:44:08 +08:00
Peter Borsa a6820d8767 Add Hungarian locale (#6260) 2018-08-13 01:02:35 +02:00
Gerhard Schlager 6d813c2b52 FIX: Importers failed to import avatars 2018-08-12 22:02:17 +02:00
Gerhard Schlager 448e95b97d UX: Show anchor icon instead of text when topic bump is disabled 2018-08-11 21:51:13 +02:00
Kris a960a57c72 Improving category reorder modal layout 2018-08-10 22:09:46 -04:00
Kris e53983b53b Alignment fix 2018-08-10 14:00:06 -04:00
Gerhard Schlager b73950692b FIX: Parsing non-existent feed should not fail 2018-08-10 18:37:14 +02:00
Osama Sayegh 865cb3feb9
FIX: allow selecting site's default theme from preference 2018-08-10 14:12:02 +03:00
Sam 6f6b4ff988 regression: don't return from a block
also clean up some warnings (shadowed var, unused var)
2018-08-10 14:53:55 +10:00
Kris 0451dba27a Table margin adjustment 2018-08-09 21:24:26 -04:00
Simon Cossar 093c3510e6 Rework moderators activity query (#6230)
* Order rows in query

* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
Gerhard Schlager b9072e8292 FEATURE: Add "Reset Bump Date" action to topic admin wrench (#6246) 2018-08-10 10:51:03 +10:00
Misaka 0x4e21 6db623ef6b UX: Improve category filtering and include subcategories
* category_filtering
  1. report_top_referred_topics
  2. report_top_traffic_sources
  3. report_post_edit
* category_filtering with subcategory topics
  1. report_top_referred_topics
  2. report_top_traffic_sources
  3. report_post_edit
  4. report_posts
  5. report_topics
  6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
  1. report_posts
  2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
  1. `in_category_and_subcategories` in `topic_spec.rb`
  2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
Gerhard Schlager ef4b9f98c1 FEATURE: Allow admins to reply without topic bump 2018-08-10 10:48:30 +10:00
Kris 6ec92d5845 prettier 2018-08-09 20:45:47 -04:00
Kris 2e1049a75a Minor dashboard style adjustments 2018-08-09 20:43:18 -04:00
Simon Cossar 3cd4dc0f5f Allow users with group_locked_trust_level to be promoted to tl3 (#6249) 2018-08-10 10:42:23 +10:00
Joffrey JAFFEUX 6a2ca60b48
FIX: ember click event not reliably working on fx (#6256) 2018-08-09 22:41:35 +02:00
Kris 04658bb2f1 UX: prevent text from wrapping below notification icons 2018-08-09 12:04:34 -04:00
Neil Lalonde 2c4d7225d8 FIX: permalink redirects with subfolder 2018-08-09 11:05:27 -04:00
Neil Lalonde 701c5ae781 UX: admin permalink form can fit on one line 2018-08-09 11:05:27 -04:00
Joffrey JAFFEUX da1d520d4c
FIX: simplifies mini tag chooser events handling (#6252) 2018-08-09 14:23:28 +02:00
Joffrey JAFFEUX bfcf8ed61b
FIX: prevents focus of input on mobile (#6251) 2018-08-09 14:23:09 +02:00
Joffrey JAFFEUX 523acfcea4
FIX: checks on parent visibility instead of filter itself (#6250) 2018-08-09 10:45:53 +02:00
Sam 7aef604f7d regression, if there is not excerpt skip 2018-08-09 15:07:18 +10:00
Sam ed4c0f256e FIX: check permalinks for deleted topics
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
Neil Lalonde f7b4a2b3ba FIX: ensure URLs include subfolder in admin emails UI 2018-08-08 16:48:03 -04:00
Kris b53d3457c8 updating color scheme attribution 2018-08-08 16:01:21 -04:00
Kris cc96af07d1 Full-width markdown table on mobile 2018-08-08 15:51:11 -04:00
Neil Lalonde 35bef72d4e FIX: subfolder redirects to wrong URL if the subfolder appears in the slug 2018-08-08 13:41:29 -04:00
Guo Xiang Tan 94622b451a FIX: Search does not retrigger when context has changed.
https://meta.discourse.org/t/using-the-search-this-topic-check-box-blocks-search-on-other-pages/56832/6?u=tgxworld
2018-08-08 17:55:37 +08:00
David Taylor d3a9596d08 Remove unused import 2018-08-08 10:46:43 +01:00
David Taylor d4d5088324 FIX: Don't require device capabilities when calculating login methods 2018-08-08 10:37:25 +01:00
David Taylor 575d9e0b1a FIX: Include parameters in function call 2018-08-08 10:09:22 +01:00
Guo Xiang Tan ba6f11c521 PERF: Only log the first skipped email when user exceeds daily limit.
https://meta.discourse.org/t/cleaning-up-e-mail-logs/39132
2018-08-08 16:25:00 +08:00
Osama Sayegh 0d45826d22
fix theme previewing (#6245) 2018-08-08 10:58:45 +03:00
Osama Sayegh 0b7ed8ffaf FEATURE: backend support for user-selectable components
* FEATURE: backend support for user-selectable components

* fix problems with previewing default theme

* rename preview_key => preview_theme_id

* omit default theme from child themes dropdown and try a different fix

* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
Sam 3f6ad65aec FEATURE: include excerpt in HTML view for pinned topics 2018-08-08 11:15:49 +10:00
Neil Lalonde 4e6e4a83df FIX: subfolder digest emails have incorrect URLs 2018-08-07 16:38:17 -04:00
Kris 17d8fea796 Markdown tables should have vertical margin 2018-08-07 16:15:28 -04:00
Kris 48ecad53f2 additional hamburger alignment fix 2018-08-07 09:47:01 -04:00
Joffrey JAFFEUX 67ec81babf
FIX: fixes last backup/last_update dates (#6242) 2018-08-07 08:19:52 -04:00
David Taylor aa9a9a5a72 FIX: Include auth_providers for anonymous users when login_required 2018-08-07 09:24:16 +01:00
Guo Xiang Tan d5a7b818ba FIX: Move Jobs::CreateAvatarThumbnails to low priority queue. 2018-08-07 16:05:54 +08:00
Guo Xiang Tan 2b57239389 FIX: Upload's content is the only source of truth for the file type. 2018-08-07 13:15:00 +08:00
Sam 6797395bd0 FIX: staff should be allowed to agree and keep post 2018-08-07 10:05:43 +10:00
Joffrey JAFFEUX 8477501e83
FIX: imrpoves alert-error styles in counters reports (#6240) 2018-08-06 16:59:45 -04:00
Joffrey JAFFEUX 7f2f3b8b22
FIX: improves reports resilience (#6239)
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX c301111461
FIX: display select kit body if no choices (#6237) 2018-08-06 11:22:48 -04:00
Kris 74269ad585 FIX: hamburger menu category alignment 2018-08-06 11:11:29 -04:00
Leo McArdle 9b04921616 FIX: don't require auth providers to set full_screen_login_setting 2018-08-06 10:24:39 +01:00
David Taylor 812add18bd REFACTOR: Serve auth provider information in the site serializer.
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Guo Xiang Tan 4e11811321 FIX: `UserAvatar#update_gravatar!` does not update `User#uploaded_avatar`.
https://meta.discourse.org/t/missing-user-profile-pictures/93844/4
2018-08-06 13:29:44 +08:00
Osama Sayegh 18b396ad56 FEATURE: add link to see new commits when updates are available for themes (#6233)
* FEATURE: add link to see new commits when updates are available for themes

* shorten regexp
2018-08-06 15:29:15 +10:00
Joe cc77a285ee
UX: improves edit reason contrast in dark themes 2018-08-06 10:53:46 +08:00
Régis Hanol 0cd9e2acb9 fix build 2018-08-04 01:56:26 +02:00
Régis Hanol bf4d98e89d FIX: always store topic links using the upload url 2018-08-04 01:29:32 +02:00
Kris 84d822959a Reducing some specificity, color fix 2018-08-03 17:44:22 -04:00
Joffrey JAFFEUX 066010db7d
FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
Kris 072f5ce825 Increase ruby character size 2018-08-03 13:37:08 -04:00
Régis Hanol 535732bdc1 FIX: ensure the 'email_revoked' PM template is customizable 2018-08-03 17:10:20 +02:00
Sam 280c318c49 FEATURE: allow ruby tags in Markdown 2018-08-03 11:47:36 +10:00
Osama Sayegh 880462a41c FEATURE: display out of date themes on admin dashboard
* FEATURE: disaply out of date themes on admin dashboard

* Update copy
2018-08-03 09:53:48 +10:00
Neil Lalonde 864e279aaf FIX: wrong links to subcategories in top categories section of user summary 2018-08-02 17:38:42 -04:00
Joffrey JAFFEUX 1ca999fdb5
FIX: formats topic report only if we have one (#6231) 2018-08-02 08:01:17 -04:00
Sam 0b3d51a8bc FEATURE: whitelist lang attribute 2018-08-02 16:53:08 +10:00
Kris 9499693baa Layout works better with auto columns 2018-08-01 22:37:21 -04:00
Joffrey JAFFEUX 60f62f6f36
FIX: improves report-show mobile UI (#6229) 2018-08-01 19:54:27 -04:00
Joffrey JAFFEUX 859c98743f
FIX: removes ellipsis from activity-metrics report cells 2018-08-01 19:08:53 -04:00
Joffrey JAFFEUX 8cbe3cbe26
this file shouldn’t have been comitted 2018-08-01 19:01:47 -04:00
Joffrey JAFFEUX 9073e11943
FIX: improves number/percent support in reports 2018-08-01 18:40:59 -04:00
Penar Musaraj 4a872823e7 Improvements to user drafts (#6226)
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels

* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
Kris 8147130412 Group icon misalignment 2018-08-01 17:30:17 -04:00
Kris d678ef2653 group icon needs margin 2018-08-01 17:05:35 -04:00
Kris 04255d1dce removing unneeded styles 2018-08-01 16:38:47 -04:00
Kris f0bea4ae55 Improve PM participant list 2018-08-01 16:20:14 -04:00
Robin Ward 4eef41ea1b FIX: Error with debouncing mentions 2018-08-01 15:57:24 -04:00
Gerhard Schlager 2ec1aec2be FIX: Clicking admin wrench in topic footer didn't hide post select box 2018-08-01 21:29:35 +02:00
Dan Ungureanu 1a0ffc5ace FEATURE: Added method to get multiple values at once from PluginStore. (#6225) 2018-08-01 18:42:40 +02:00
Gerhard Schlager f4ca105498 FIX: Moving posts to existing topic didn't update topic metadata 2018-08-01 18:05:43 +02:00
Robin Ward d7b463a03d FIX: Remove unused import 2018-08-01 11:54:47 -04:00
Robin Ward 7c950321d1 FIX: Allow non-english usernames in autocomplete
Also add support for username formatters
2018-08-01 11:53:20 -04:00
Neil Lalonde b829452c75
Merge pull request #6209 from discourse/mini_scheduler
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
Joffrey JAFFEUX 0b9437cee7
FIX: more resilient/consistent dashboard caching (#6223) 2018-08-01 09:45:50 -04:00
Joffrey JAFFEUX 7c7dfa4e5e
FIX: wraps any query with the slow query guard (#6222) 2018-08-01 07:39:57 -04:00
Vinoth Kannan 8178444382 Make prettier happy 2018-08-01 15:13:54 +05:30
Vinoth Kannan 8556288397 DEV: Export Tag class to modify methods in plugin 2018-08-01 15:10:15 +05:30
Gerhard Schlager a115aae45f Use rchardet instead of charlock_holmes gem 2018-08-01 10:41:20 +02:00
Gerhard Schlager 5d421fb946 FIX: Try respecting charset in HTTP header of RSS feed 2018-08-01 10:41:20 +02:00
Gerhard Schlager ff942ed2f3 FIX: Try detecting encoding of RSS feed 2018-08-01 10:41:20 +02:00
Penar Musaraj 1f45215537 FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan 70ea153dce Fix lint. 2018-08-01 12:23:36 +08:00
Guo Xiang Tan 53adbf70f3 FIX: Nav item missing for plugins that don't include a custom filter. 2018-08-01 11:50:14 +08:00
Joffrey JAFFEUX 5febe71baa
FIX: prevents crash if flagger doesn’t exist (#6219) 2018-07-31 23:48:54 -04:00
Joffrey JAFFEUX 849f0d00f6
FEATURE: adds revision_count to moderators_activity (#6218)
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
Guo Xiang Tan 919e8db686 FIX: Check for group name availability should skip reserved usernames. 2018-08-01 11:09:33 +08:00
Kris 129268ddc6 Highlighted titles too wide on mobile 2018-07-31 21:24:43 -04:00
Joffrey JAFFEUX 2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217)
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX 0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX 37252c1a5e
UI: improves dashboard table reports
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Neil Lalonde 4ad7ce70ce REFACTOR: extract scheduler to the mini_scheduler gem 2018-07-31 17:12:55 -04:00
Robin Ward 4b166cccc1 FIX: Linting error 2018-07-31 14:19:45 -04:00
Robin Ward b6bb8df622 FIX: We loosened username restrictions some time ago
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
Vinoth Kannan ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Neil Lalonde fd29ecb91a UX: include a flag reason in the post-deleted-by-staff-because-of-flags message 2018-07-30 16:45:46 -04:00
Neil Lalonde c12a9279f6 post deleted notification regression because controller was agreeing with all flags too early 2018-07-30 16:45:46 -04:00
Vinoth Kannan c1e62808ed FIX: Top site categories are displayed in random order 2018-07-31 01:01:03 +05:30
Kris 7368dd8e7d Prevent activity-metrics stats from wrapping 2018-07-30 14:40:26 -04:00
Joffrey JAFFEUX c6fd506a15
fix eslint 2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX 2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus 2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX a327393651
fix 1.14.0 prettier offenses 2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX 536f88b95b Revert "DEV: prettier 1.14.0"
This reverts commit 1f899bec21.
2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX 1f899bec21
DEV: prettier 1.14.0 2018-07-30 11:09:08 -04:00
Vinoth Kannan c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
David Taylor 6566b2f11a FEATURE: Allow revoke and connect for Instagram logins 2018-07-30 14:38:53 +01:00
Joffrey JAFFEUX d494feaa32
FIX: should not be needed as we have itemprop='url' 2018-07-30 09:31:27 -04:00
Arpit Jalan dfcb2a0d42 FEATURE: include published_time in metadata 2018-07-30 17:09:56 +05:30
Vinoth Kannan 50df2d7241 FIX: Should not include regular categories in top_category_ids array 2018-07-30 16:06:36 +05:30
Maja Komel 04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan 176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:39:37 +05:30
Vinoth Kannan 249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Guo Xiang Tan 581cf62bcf UX: Allow emojis to be displayed in nav-item. 2018-07-30 18:02:34 +08:00
Guo Xiang Tan ef78268c01 Give `ExtraNavItem` more control over when it can be displayed. 2018-07-30 17:30:13 +08:00
Arpit Jalan ba64ebbf10 FIX: preserve whitespace between uploads when the process is complete 2018-07-30 14:49:33 +05:30
Vinoth Kannan 78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Guo Xiang Tan acde8d4323 Fix the build. 2018-07-30 15:07:03 +08:00
Guo Xiang Tan 96a0448c52 FIX: Add onceoff job to fix incorrect extension for gravatar uploads. 2018-07-30 14:44:02 +08:00
Guo Xiang Tan 87537b679c Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`. 2018-07-30 11:39:28 +08:00
Guo Xiang Tan b94633e844 FIX: `FileHelper` should prioritize response content-type.
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
Arpit Jalan fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Joe 3dbaaf0d74
UX: gives wizard language selector more room to expand 2018-07-28 11:51:53 +08:00
Kris 7a1a1eb4c0 improve header scaling with font size 2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX a8f1b07686
FIX: prevents exception when loading old dashboard (#6196) 2018-07-27 16:29:30 -04:00
Kris 3159c46613 Making dataless sections stand out less 2018-07-27 14:55:51 -04:00
Kris 60b2c3207e larger mobile topic list badges 2018-07-27 13:10:13 -04:00
David Taylor 5f1fd0019b FEATURE: Allow revoke and connect for GitHub logins 2018-07-27 17:18:53 +01:00
David Taylor 6296f63804 FEATURE: Revoke and connect for Yahoo logins 2018-07-27 16:20:47 +01:00
Vinoth Kannan a9c959e3e2 Make prettier happy 2018-07-27 20:39:44 +05:30
Vinoth Kannan bc501038cb FIX: Remove null value from categories list 2018-07-27 20:00:39 +05:30
Joe 85291e53f1
UX: more categories link alignment 2018-07-27 22:17:29 +08:00
David Taylor 9c72c00206 FEATURE: Revoke and reconnect for Twitter logins 2018-07-27 12:28:51 +01:00
Vinoth Kannan 5b4e13bfcc Make prettier happy 2018-07-27 13:20:21 +05:30
Vinoth Kannan c0f7d95bb8 Include subcategories in hamburger menu top categories 2018-07-27 13:05:18 +05:30
Vinoth Kannan dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX b7d1864d0a
FIX: simplify filters on admin-report component (#6193) 2018-07-27 01:22:00 -04:00
Guo Xiang Tan 6f9a91cbd5
Merge pull request #6175 from vinothkannans/post_approval_webhook
FEATURE: Webhook for post approval events
2018-07-27 10:50:49 +08:00
Guo Xiang Tan ccf76d45f2 FIX: Missing variable outside of `begin` block. 2018-07-27 08:19:11 +08:00
Joffrey JAFFEUX 262beed1cf
FIX: fixes regression with category filtering (#6190) 2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX 59684adc43
FIX: shows disk usage even if no backups taken (#6189) 2018-07-26 18:38:55 -04:00
Neil Lalonde 1708ff1808 UX: add a route /rules as an alias for /faq and /guidelines 2018-07-26 15:38:08 -04:00
Joffrey JAFFEUX 56ae826efb
UI: improves no data notice in reports (#6187) 2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX 330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
Kris 8d67b20d37 z-index fix 2018-07-26 12:11:40 -04:00
David Taylor 88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login 2018-07-26 11:11:16 +01:00
David Taylor 63e15aa41a Add missing semicolon 2018-07-26 10:30:10 +01:00
Maja Komel e8d82f48bc add maxlength attribute for 2FA input fields 2018-07-26 10:31:20 +02:00
Vinoth Kannan af5b88f8e2 Rename approval web hook event type to queued post 2018-07-26 10:29:38 +05:30
Kris 67b6539d98 rounder topic-list badges in iOS 2018-07-25 23:58:23 -04:00
Kris 998b7fb87a Rounder topic-list badges on mobile 2018-07-25 22:30:30 -04:00
Guo Xiang Tan f8b367cc9c Fix the build. 2018-07-26 10:17:51 +08:00
Kris c5e7c60a37 Fixing profile avatar flair poisition on mobile 2018-07-25 22:00:56 -04:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Guo Xiang Tan 30242972d3 Add spec for 4bf3bf6786. 2018-07-26 09:16:14 +08:00
Nick Shearer def2c977ce allow auth plugins to have a site setting for if they should be full screen vs popup window 2018-07-25 19:20:11 -05:00
Régis Hanol f94aeaf6cf SECURITY: force IM decoder based on file extension - part 3 2018-07-25 23:55:06 +02:00
Régis Hanol 800c57c6ab SECURITY: force IM decoder based on file extension - part 2 2018-07-25 23:08:02 +02:00
Régis Hanol 4bf3bf6786 SECURITY: force IM decoder based on file extension 2018-07-25 22:00:04 +02:00
Kris 0e84024958
Updating style of theme options in wizard (#6177) 2018-07-25 15:32:14 -04:00
Kris 3fd2571abc Fix typo in color scheme 2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Vinoth Kannan 5059dad8f0 FEATURE: Webhook for post approval events 2018-07-25 23:43:19 +05:30
Joffrey JAFFEUX 6ee1ea96ef
fixes tests (#6176) 2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX 01d1f850e9
FEATURE: uses category-chooser for report filtering (#6174) 2018-07-25 13:16:35 -04:00
Joffrey JAFFEUX fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills (#6173) 2018-07-25 11:45:29 -04:00
David Taylor 0d0d78841b
FIX: Remove `plugin.enabled?` checks at initialization time (#6166)
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
  - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
  - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.

Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.

I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
  - `post_custom_fields_whitelist`
  - `whitelist_staff_user_custom_field`
  - `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00
Joffrey JAFFEUX 796639a797
FIX: makes disk_space computation more resilient (#6172) 2018-07-25 11:04:01 -04:00
David Taylor fa399ce1c5 FEATURE: Add revoke and reconnect functionality for google logins 2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX 578c8e861b
FIX: refreshes disk_space on backup create/destroy (#6169) 2018-07-25 08:26:30 -04:00
Régis Hanol 637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Gerhard Schlager 9989c8179d FIX: Translation for default (light) color scheme was missing 2018-07-25 11:28:14 +02:00
Dan Ungureanu 44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Dan Ungureanu f540020d1d Add different trigger for the emoji popup of French users. (#6140) 2018-07-25 16:39:06 +10:00
Gerhard Schlager 1ac643d71c FIX: Email template for "Queued Posts Reminder" was not found 2018-07-24 17:26:52 +02:00
Régis Hanol 8ca25f5aed UX: open the change avatar modal when clicking the profile picture 2018-07-24 15:13:21 +02:00
Joffrey JAFFEUX 7a3c541077
UX: Preview multiple color schemes in wizard (#6151)
It was a dropdown to provide choices of color schemes,
and only one scheme could be shown.
With this commit, multiple color scheme previews can be displayed on
one page at the same time, making admins choose color schemes more
easily.

Theme preview windows are shrinked.

Imported default color schemes.

Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>
2018-07-24 09:00:20 -04:00
Gerhard Schlager c3b6811651 PERF: Split loading of posts to speed up user renames 2018-07-24 11:57:04 +02:00
Guo Xiang Tan fa19d3a53c
Merge pull request #6108 from discourse/transaction-sidekiq-fix
Fix notifications for topics moved between categories
2018-07-24 17:44:03 +08:00
David Taylor 20a21b1240 Move into MiniSQLMultisiteConnection, and add test for rollback 2018-07-24 09:41:55 +01:00
Guo Xiang Tan 98f84d1a4e Update annotations. 2018-07-24 15:49:55 +08:00
Guo Xiang Tan 7a2bf8e368 Fix invalid query syntax when `CategoryCustomField#value` is blank. 2018-07-24 14:48:27 +08:00
Guo Xiang Tan 663d78414b
Merge pull request #6104 from tgxworld/split_up_reply_key_from_email_logs
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 14:33:48 +08:00
Guo Xiang Tan fad9c2b971 PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table. 2018-07-24 13:51:53 +08:00
Guo Xiang Tan 5760873580 Fix linting. 2018-07-24 13:43:52 +08:00
Guo Xiang Tan ae8b0a517f PERF: Split skipped email logs into a seperate table. 2018-07-24 13:14:37 +08:00
Guo Xiang Tan 9b84e78fdf Update annotations. 2018-07-24 11:14:19 +08:00
Sam 95720e3873 lint files 2018-07-24 10:57:16 +10:00
Kyle Zhao c9d4288214 UX: auto fix order when reordering categories (#6149)
* set correct position number when moving up/down

* UX: drop 'fix order' and auto re-order subcategory

- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
Neil Lalonde f4b5eccad3 FIX: categories page crawler view had incorrect URLs 2018-07-23 14:54:41 -04:00
Joffrey JAFFEUX 568276fe40
FEATURE: allows tag editing on mobile (#6148) 2018-07-23 14:25:21 -04:00
Joffrey JAFFEUX 73d736c8c3
FIX: popup-menu instantly closing (#6147) 2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX 78419f677d
FIX: multiple select-kit fixes on mobile 2018-07-23 12:19:40 -04:00
David Taylor eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099)
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX 32062864d3
FIX: removes system from user to user report (#6144) 2018-07-23 10:33:12 -04:00