Guo Xiang Tan
58e52c0e4f
DEV: Use rails_failover gem for ActiveRecord and Redis failover handling
2020-06-15 15:47:07 +08:00
Arpit Jalan
6780d4d70c
FIX: process /invites/ route from server side only
2020-06-15 12:31:27 +05:30
Guo Xiang Tan
d8cd912769
DEV: Switch to db config to disable advisory locks.
2020-06-15 14:33:41 +08:00
Martin Brennan
35a157619a
FEATURE: Add "Now" as an option (default hidden) to the future date input selector ( #10047 )
...
Sometimes you need to schedule things from now onward. "Now" in this case is now + 1 minute. this option is hidden by default.
2020-06-15 14:06:03 +10:00
Guo Xiang Tan
0ff86b00cb
DEV: Upgrade Redis to 4.2.1.
2020-06-15 10:05:22 +08:00
Jarek Radosz
1303e89a72
DEV: Fix a composer state leak in tests
...
This is the one that made discourse-encrypt tests (and all subsequent tests) hang.
2020-06-15 01:44:41 +02:00
Gerhard Schlager
36a3675e0a
Update translations
2020-06-14 23:39:33 +02:00
dependabot-preview[bot]
14dc6f350e
Build(deps): Bump logster from 2.8.0 to 2.9.0 ( #10035 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/discourse/logster/releases )
- [Changelog](https://github.com/discourse/logster/blob/master/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-13 10:46:57 +03:00
Kris
7429512ced
FIX: Get correct right/left offset for topic progress bar on compose
2020-06-12 18:44:42 -04:00
Kris
16b41aa485
Save button alignment fixes for admin badge page
2020-06-12 17:15:59 -04:00
Kris
2adad96d05
Center align items in select kit headers
2020-06-12 17:07:50 -04:00
Kris
d0a7f15764
Usercard buttons on mobile should utilize full width
2020-06-12 16:24:25 -04:00
Bianca Nenciu
ff6811ceb8
Allow multiple groups which can vote when creating a poll ( #10015 )
...
* FEATURE: Allow multiple groups which can vote when creating a poll
* DEV: Fix select-kit deprecations
* DEV: Fix lint
2020-06-12 14:52:32 +03:00
Dan Ungureanu
111877db1f
FIX: Load I18n first in show_confirm_new_email page
2020-06-12 14:49:16 +03:00
Bianca Nenciu
60196cc192
FIX: Hide bootbox after a negative answer ( #10028 )
...
Starting to reply and then editing a post was not possible because of a
bootbox which kept showing up.
2020-06-12 13:48:45 +02:00
Joffrey JAFFEUX
4b793a1072
FIX: allows PM owner to remove any user if >= TL2 ( #10036 )
2020-06-12 12:54:28 +02:00
Sam Saffron
7211394e4d
FEATURE: include tags in unread/new messages
...
We need this information to maintain counts on tracked/watched
tags.
2020-06-12 16:20:30 +10:00
Guo Xiang Tan
c9964b95ce
DEV: Increase log level for `/srv/status` route.
...
This reduces the amount of noise in our logs.
2020-06-12 12:17:28 +08:00
Penar Musaraj
f57ecf22e0
UX: Send background color to iPad app too
...
Previously, we were only updating mobile devices.
2020-06-11 23:20:25 -04:00
Andrew Schleifer
b2c94cc8ea
FIX: do not migrate backups in the new prefix
2020-06-12 02:56:07 +00:00
Guo Xiang Tan
3aab98781a
Fix tests.
2020-06-12 10:22:22 +08:00
Guo Xiang Tan
2fbd4eb11f
DEV: Remove double query in `Group#remove_review_group`.
...
Probably a mistake during commit.
2020-06-12 10:14:45 +08:00
Guo Xiang Tan
78b5ab746c
DEV: No longer need to clear anon cache when toggling readonly mode.
2020-06-12 09:58:17 +08:00
Guo Xiang Tan
62ad473716
FIX: Preload readonly mode attribute seperately.
...
There are two problems I'm trying to tackle here.
1. The site json is cached for anonymous users so readonly mode can be
cached for up to 30 minutes which makes it confusing.
2. We've already checked for readonly mode in the controller so having
to check for readonly mode again in `SiteSerializer` is adding an extra
Redis query on every request.
2020-06-12 09:54:05 +08:00
Guo Xiang Tan
2e2dcb7d93
DEV: Disable better_errors by default.
...
It adds a somewhat unnecessary middleware before `ActionDispatch::DebugExceptions` and totally bypasses it. Apps that register exception interceptors with `ActionDispatch::DebugExceptions` would therefore stop working if better_errors is used.
2020-06-12 09:22:40 +08:00
Roman Rizzi
a4bfa35420
DEV: Pass the is_image flag when triggering the before_upload_creation event ( #10031 )
2020-06-11 11:06:48 -03:00
Jarek Radosz
3d55f2e3b7
FIX: Improvements and fixes to the image downsizing script ( #9950 )
...
Fixed bugs, added specs, extracted the upload downsizing code to a class, added support for non-S3 setups, changed it so that images aren't downloaded twice.
This code has been tested on production and successfully resized ~180k uploads.
Includes:
* DEV: Extract upload downsizing logic
* DEV: Add support for non-S3 uploads
* DEV: Process only images uploaded by users
* FIX: Incorrect usage of `count` and `exist?` typo
* DEV: Spec S3 image downsizing
* DEV: Avoid downloading images twice
* DEV: Update filesizes earlier in the process
* DEV: Return false on invalid upload
* FIX: Download images that currently above the limit (If the image size limit is decreased, then there was no way to resize those images that now fall outside the allowed size range)
* Update script/downsize_uploads.rb (Co-authored-by: Régis Hanol <regis@hanol.fr>)
2020-06-11 14:47:59 +02:00
Dan Ungureanu
b7e70850e4
FIX: Allow users to add emails which were deleted before
2020-06-11 14:54:11 +03:00
Bianca Nenciu
dd85d44dda
FIX: Show tag count for existing tags ( #9892 )
...
* FIX: Show tag count for existing tags
* Add test
2020-06-11 14:13:48 +03:00
David Taylor
45c399f0d7
DEV: Correct historical badge and user_badge index discrepancies ( #10017 )
...
Badge and user_badge tables were created using add_column index: true
When the migration was written, `index: true` was a no-op for non-reference columns
Since then, rails made it work 9a0d35e820
This migration adds the index to very old sites, so that we have a consistent state
2020-06-11 11:46:28 +01:00
David Taylor
c74f2b949f
DEV: Correct historical posts table schema discrepancies ( #10014 )
...
This is a no-op for modern installations. It only affects older sites.
Follow-up to f7d676dce1
This needs to be done in a transaction, because we need to drop and recreate the badge_posts view.
2020-06-11 11:45:46 +01:00
Joffrey JAFFEUX
6fa990f05d
FIX: prevents emoji in links to appear as large emojis ( #10027 )
2020-06-11 12:27:48 +02:00
Guo Xiang Tan
dc4071dfef
DEV: Use `Rails.logger` instead of logster for rails_failover callbacks
...
`Discourse.warn_exception` logs to logger by default but it means we
lose all the backtrace when the logs are written to the log file.
2020-06-11 17:24:32 +08:00
Guo Xiang Tan
b66f2187f1
DEV: Don't use logstash for unicorn if ENV is blank.
2020-06-11 15:58:18 +08:00
dependabot-preview[bot]
d47dc1e92d
DEV: Bump ffi from 1.13.0 to 1.13.1 ( #10006 )
...
Bumps [ffi](https://github.com/ffi/ffi ) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/ffi/ffi/releases )
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ffi/ffi/compare/1.13.0...1.13.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
very safe change, should not impact anything.
2020-06-11 17:49:36 +10:00
Guo Xiang Tan
2e8075bac3
FIX: Ignore Redis readonly errors in `RateLimiter#rollback!`.
...
This is similar to what we're doing in `RateLimiter#performed!`.
2020-06-11 15:13:11 +08:00
Sam Saffron
a26b490047
FIX: present correct new/unread counts when filtered by tag
...
Previously we would incorrectly ignore tags.
This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
2020-06-11 16:47:57 +10:00
Arpit Jalan
0061f758bd
Bump onebox version.
...
- temporary workaround to fetch Twitter OpenGraph data
2020-06-11 11:40:44 +05:30
Guo Xiang Tan
90dc6c8ce5
DEV: Fix deprecation warning when using `Redis#close` with redis namespace.
2020-06-11 14:09:19 +08:00
Guo Xiang Tan
1411b095eb
DEV: Rescue errors when runngin AR failover/fallback callbacks.
2020-06-11 13:02:42 +08:00
Guo Xiang Tan
34ee1f2e71
DEV: Fix undefined method in rails_failover initializer.
2020-06-11 12:30:01 +08:00
Guo Xiang Tan
e7af83e1fd
DEV: Run `apt-get update` before installing packages on CI.
...
```
E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/universe/libj/libjpeg-turbo/libjpeg-turbo-progs_1.5.2-0ubuntu5.18.04.3_amd64.deb 404 Not Found [IP: 52.177.174.250 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
```
2020-06-11 11:53:38 +08:00
Guo Xiang Tan
cbb4ea1ea8
DEV: Don't blow up request redis can't be reached during failover.
2020-06-11 11:41:06 +08:00
Guo Xiang Tan
531eca985e
DEV: Log error backtrace in `Discourse.warn_exception` without logster.
2020-06-11 10:49:46 +08:00
Kane York
5f3fd23fa8
DEV: Add stub flush_sw task to prevent rebuild errors ( #10021 )
2020-06-10 13:07:37 -07:00
romanrizzi
ac555610d9
DEV: Trigger an event before creating an upload
2020-06-10 16:30:53 -03:00
Mark VanLandingham
b8acb36532
DEV: Plugin outlet at top of user preference interface ( #10020 )
2020-06-10 13:36:50 -05:00
Blake Erickson
1ce6ff0a55
DEV: Include raw in post webhook serializer
...
This came in as a request on meta to include the raw field in the post
webhook serializer.
https://meta.discourse.org/t/-/49045/55?u=blake
Including this field can prevent needing to make a 2nd API request to
get the raw field of a post.
It would be handy down the road if we updated the webhook ui to specify
fields or arguments that you wanted to be included in the serialized
data, but most requests I've seen to update the serializers have been
valid requests that are good to add anyways, so I don't think we have
reached that point yet.
2020-06-10 11:56:39 -06:00
Neil Lalonde
81a265cecd
Version bump to v2.5.0.beta7
2020-06-10 13:38:18 -04:00
Dan Ungureanu
5bfe1ee4f1
FEATURE: Improve UX support for multiple email addresses ( #9691 )
2020-06-10 19:11:49 +03:00