493d437e79
Add RSpec 4 compatibility ( #17652 )
...
* Remove outdated option
04078317bahttps://github.com/rspec/rspec-core/pull/2803
* Use the non-globally exposed RSpec syntax, cont
https://github.com/rspec/rspec-core/pull/2803
* Comply to strict predicate matchers
See:
- https://github.com/rspec/rspec-expectations/pull/1195
- https://github.com/rspec/rspec-expectations/pull/1196
- https://github.com/rspec/rspec-expectations/pull/1277
2022-07-28 10:27:38 +08:00
fd1dc91eed
DEV: Don't cache watched words in test env ( #16731 )
...
The cache was causing state to leak between tests since the `WatchedWord` record in the DB would have been rolled back but `WordWatcher` still had the word in the cache.
2022-05-12 14:45:05 +08:00
3f0e767106
DEV: Use `FakeLogger` in RequestTracker specs ( #16640 )
...
`TestLogger` was responsible for some flaky specs runs:
```
Error during failsafe response: undefined method `debug' for #<TestLogger:0x0000556c4b942cf0 @warnings=1>
Did you mean? debugger
```
This commit also cleans up other uses of `FakeLogger`
2022-05-05 09:53:54 +08:00
c9dab6fd08
DEV: Automatically require 'rails_helper' in all specs ( #16077 )
...
It's very easy to forget to add `require 'rails_helper'` at the top of every core/plugin spec file, and omissions can cause some very confusing/sporadic errors.
By setting this flag in `.rspec`, we can remove the need for `require 'rails_helper'` entirely.
2022-03-01 17:50:50 +00:00
d4d3580761
PERF: perform all cached counting in background ( #15991 )
...
Previously cached counting made redis calls in main thread and performed
the flush in main thread.
This could lead to pathological states in extreme heavy load.
This refactor reduces load and cleans up the interface
2022-02-22 16:45:25 +00:00
9b5836aa1d
Add three reports ( #14338 )
...
* Add report top_users_by_received_likes
* Add report top_users_by_received_likes_from_inferior_trust_level
* Add report top_users_by_likes_received_from_a_variety_of_people
* Add test to report_top_users_by_received_likes
* add top_users_by_likes_received_from_a_variety_of_people report test
* add top_users_by_likes_received_from_inferior_trust_level report tests
2021-12-02 22:41:55 +05:30
e7b8e75583
FEATURE: Add post edits count to user activity ( #13495 )
2021-08-02 10:15:53 -04:00
4728962f7d
FIX: Don’t translate TrustLevel name when generating links ( #13588 )
...
We want to put the name of the trust level in to generated URLs, not the human-readable form.
i.e.:
`/admin/users/list/newuser`
rather than:
`/admin/users/list/new user`
2021-06-30 14:19:15 -04:00
c809f722f7
DEV: Remove unused comments from tests. ( #13241 )
...
Fabrication does not guarantee the ordering of records in anyway.
2021-06-02 15:33:15 +10:00
59097b207f
DEV: Correct typos and spelling mistakes ( #12812 )
...
Over the years we accrued many spelling mistakes in the code base.
This PR attempts to fix spelling mistakes and typos in all areas of the code that are extremely safe to change
- comments
- test descriptions
- other low risk areas
2021-05-21 11:43:47 +10:00
521934f163
FIX: Only cache reports with exceptions for 1 minute ( #11447 )
2020-12-09 10:54:41 -06:00
3a7ca97c36
FIX: Use include-subcategories filter in report export ( #10007 )
...
Some filters were renamed and the conversion of the filter names and arguments
was removed.
2020-06-10 18:57:39 +03:00
d01c336899
DEV: Clean up some Redis leaks in test env.
2020-05-18 17:27:37 +08:00
e733701887
FEATURE: Make report filters reusable ( #9444 )
...
This commit also adds 'include subcategories' report filter
2020-04-22 11:52:50 +03:00
20944e69e4
FEATURE: adds trust_level_growth report ( #8878 )
2020-02-06 19:44:30 +01:00
afff96ce54
DEV: Improved performance of report spec ( #8642 )
...
* FIX: bulk insert to create application requests
* FIX: bulk insert to create topics
* FIX: no need to create separate user for each topic, post etc.
* FIX: Another bulk_insert of ApplicationRequests
* FIX: dont create user and topic instances when not neccessary
* FIX: merge examples with expensive setup into one example
2020-01-06 17:17:07 +11:00
4ae8065f2c
DEV: Default to skipping creating a topic when fabricating categories ( #7976 )
...
This speeds up the test suite by 9%
2019-08-06 11:26:54 +01:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
1f40258d5c
fix spec ( #7500 )
2019-05-07 19:20:56 +02:00
4ea21fa2d0
DEV: use #frozen_string_literal: true on all spec
...
This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.
Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction
2019-04-30 10:27:42 +10:00
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
41563ba6b2
FIX: flaky test in reports ( #7255 )
...
* FIX: flaky test in reports
2019-03-26 13:23:57 +00:00
605530a77f
FEATURE: Include muted users count within the ignored users report ( #7230 )
2019-03-21 14:31:45 +01:00
28384ba62c
FEATURE: Add `Top Ignored Users` report ( #7153 )
...
* FEATURE: Add `Top Ignored Users` report
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ), and also part of [this PR](https://github.com/discourse/discourse/pull/7144 ).
We want to send a System Message daily when a specific count threshold for an ignored is reached. To make this system message informative, we want to link to a report for the Top Ignored Users too.
2019-03-12 16:01:58 +00:00
c5e952839a
FIX: prevents other tests from leaking modified theme color ( #7051 )
2019-02-21 15:12:20 +01:00
c23411cc69
FIX: Heisentest - suspicious logins report was not ordered by date
...
The specs needed an order even though none was supplied.
2019-02-12 13:17:29 -05:00
72b5ab0454
Don't wrap exceptions in test mode unless specifically requested.
...
This helps debugging reports with invalid SQL, which would otherwise
return no results instead of a useful error message while running
tests.
2019-02-08 11:26:26 -05:00
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
a123aafdad
Fix random build error
...
Follow-up to b95165b838
2019-01-21 22:00:45 +01:00
b95165b838
FEATURE: adds a new chart report to track pageviews ( #6913 )
2019-01-21 15:17:04 +01:00
95f9a369a5
FIX: ensures visits reports are correcttly differencing mobile/all ( #6905 )
2019-01-18 17:24:18 +01:00
f1269fa807
FEATURE: Add `Top Uploads` report ( #6825 )
...
Co-Authored-By: I am very Pro-Grammer. <khalilovcmded@users.noreply.github.com>
2018-12-28 20:48:54 +01:00
f637286db5
UX: improves flags-status report ( #6773 )
...
- link to post
- cover more post action types
2018-12-26 10:29:33 +01:00
341a6bd78a
REFACTOR: Calculate CTR in SearchLog model and hide unique column ( #6791 )
2018-12-18 19:13:46 +05:30
03014b0d05
FEATURE: adds security tab to dashboard ( #6768 )
...
This commit also includes the new staff_logins report
2018-12-14 13:47:59 +01:00
0cb33d2b52
UX: Rename Most Disagreed Flaggers report to "User Flagging Ratio"
2018-11-12 16:23:37 -05:00
23423ba112
correct spec and error reporting
...
previous commit misused warn_exception which caused a spec to fail
2018-10-31 13:38:05 +11:00
e0ccd36dbe
FEATURE: Suspicious logins report. ( #6544 )
2018-10-30 22:51:58 +00:00
b2585524a9
FEATURE: adds a most disagreed flaggers report
2018-10-26 15:59:04 +02:00
f26804394a
DEV: Remove the use of stubs on `Rails.logger` in our test suite.
2018-10-10 09:34:50 +08:00
a515ba8612
FIX: corrects typo and adds a spec for likes report ( #6439 )
...
* FIX: corrects typo and adds a spec for likes report
* save!
2018-10-02 02:27:43 -07:00
a6502ce879
FIX: ensures errors in report initialization fail nicely ( #6392 )
2018-09-13 17:36:55 +02:00
2b2612d0f5
correct flaky spec
...
after(:all) and before(:all) are to be avoided, state can leak
2018-08-10 16:08:07 +10:00
093c3510e6
Rework moderators activity query ( #6230 )
...
* Order rows in query
* Don't increment revisions when moderator revises their own post
2018-08-10 10:51:31 +10:00
6db623ef6b
UX: Improve category filtering and include subcategories
...
* category_filtering
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
* category_filtering with subcategory topics
1. report_top_referred_topics
2. report_top_traffic_sources
3. report_post_edit
4. report_posts
5. report_topics
6. report_topics_with_no_response
* category_filtering tests (without subcategory topics)
1. report_posts
2. report_topics_with_no_response
* subcategory topics tests `in_category_and_subcategories` in `topic_spec.rb`
1. `in_category_and_subcategories` in `topic_spec.rb`
2. topics, posts, flags and topics_with_no_response in `report_spec.rb`
2018-08-10 10:50:05 +10:00
849f0d00f6
FEATURE: adds revision_count to moderators_activity ( #6218 )
...
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-31 23:40:45 -04:00
2b2a506a7b
FIX: makes dashboard more resilient to errors ( #6217 )
...
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
8299fe0947
fix report spec ( #6214 )
2018-07-31 18:15:14 -04:00
313cd9940d
starts refactoring report spec
2018-07-26 19:24:18 -04:00
Phil Pirozhkov
Alan Guo Xiang Tan
Jarek Radosz
David Taylor
Sam
Michelle Bueno Saquetim Vendrame
Jean
jbrw
Josh Soref
Mark VanLandingham
Dan Ungureanu
Joffrey JAFFEUX
Krzysztof Kotlarek
Daniel Waterworth
Bianca Nenciu
Robin Ward
Tarek Khalil
Gerhard Schlager
Vinoth Kannan
Guo Xiang Tan
Simon Cossar
Misaka 0x4e21