5e29ae3ef5
FEATURE: Warning when component is added and not assigned ( #8482 )
...
When a component is installed and not assigned to any theme and the user is changing page, we should display a warning.
If the user decides to skip warning or come back later, a warning should not be shown anymore.
Also, when the user clicks "delete" button right after installation, warning about forgotten themes should not be shown.
2019-12-10 08:43:26 +11:00
413a49fe06
Build(deps-dev): Bump rspec-html-matchers from 0.9.1 to 0.9.2 ( #8494 )
...
Bumps [rspec-html-matchers](https://github.com/kucaahbe/rspec-html-matchers ) from 0.9.1 to 0.9.2.
- [Release notes](https://github.com/kucaahbe/rspec-html-matchers/releases )
- [Changelog](https://github.com/kucaahbe/rspec-html-matchers/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kucaahbe/rspec-html-matchers/compare/v0.9.1...v0.9.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 12:22:55 -08:00
866b634f22
Build(deps): Bump webpush from 0.3.8 to 1.0.0 ( #8491 )
...
Bumps [webpush](https://github.com/zaru/webpush ) from 0.3.8 to 1.0.0.
- [Release notes](https://github.com/zaru/webpush/releases )
- [Changelog](https://github.com/zaru/webpush/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zaru/webpush/compare/v0.3.8...v1.0.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 12:21:49 -08:00
6dd1d63671
Build(deps): Bump sassc from 2.0.1 to 2.2.1 ( #8493 )
...
Bumps [sassc](https://github.com/sass/sassc-ruby ) from 2.0.1 to 2.2.1.
- [Release notes](https://github.com/sass/sassc-ruby/releases )
- [Changelog](https://github.com/sass/sassc-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sass/sassc-ruby/compare/v2.0.1...v2.2.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 12:19:39 -08:00
bf847e680a
Build(deps-dev): Bump uglifier from 4.1.20 to 4.2.0 ( #8489 )
...
Bumps [uglifier](https://github.com/lautis/uglifier ) from 4.1.20 to 4.2.0.
- [Release notes](https://github.com/lautis/uglifier/releases )
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v4.1.20...v4.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 12:16:03 -08:00
16de46f8d4
Build(deps): Bump omniauth-google-oauth2 from 0.7.0 to 0.8.0 ( #8488 )
...
Bumps [omniauth-google-oauth2](https://github.com/zquestz/omniauth-google-oauth2 ) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/zquestz/omniauth-google-oauth2/releases )
- [Changelog](https://github.com/zquestz/omniauth-google-oauth2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zquestz/omniauth-google-oauth2/compare/v0.7.0...v0.8.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 12:13:07 -08:00
9be3945c91
Build(deps-dev): Bump rspec from 3.8.0 to 3.9.0 ( #8487 )
...
Bumps [rspec](https://github.com/rspec/rspec ) from 3.8.0 to 3.9.0.
- [Release notes](https://github.com/rspec/rspec/releases )
- [Commits](https://github.com/rspec/rspec/compare/v3.8.0...v3.9.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 11:34:30 -08:00
3092cdc2bd
Build(deps-dev): Bump simplecov from 0.16.1 to 0.17.1 ( #8486 )
...
Bumps [simplecov](https://github.com/colszowka/simplecov ) from 0.16.1 to 0.17.1.
- [Release notes](https://github.com/colszowka/simplecov/releases )
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md )
- [Commits](https://github.com/colszowka/simplecov/compare/v0.16.1...v0.17.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 11:32:25 -08:00
41f4159cc7
Build(deps): Bump multi_json from 1.13.1 to 1.14.1 ( #8485 )
...
Bumps [multi_json](https://github.com/intridea/multi_json ) from 1.13.1 to 1.14.1.
- [Release notes](https://github.com/intridea/multi_json/releases )
- [Changelog](https://github.com/intridea/multi_json/blob/master/CHANGELOG.md )
- [Commits](https://github.com/intridea/multi_json/compare/v1.13.1...v1.14.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 11:30:30 -08:00
14cb386f1e
FEATURE: Featured topic for user profile & card ( #8461 )
2019-12-09 11:15:47 -08:00
b5236591e9
FIX: Don't try to create an empty tag when updating a topic ( #8481 )
...
Fixes an issue where updates to the first post in a topic would be visible only for staff.
Before, because the empty tag would find its way to `PostRevisor`, `TopicsController#update` would create a hidden revision, and later `PostsController#update` would only update that revision.
After this change, `TopicsController` doesn't create a revision at all (unless necessary), so `PostsController` can create it (and correctly decide whether the revision should be hidden or not).
2019-12-09 19:55:08 +01:00
34ccd9ecbb
DEV: Export imageNameFromFileName
2019-12-09 18:19:55 +02:00
78d67f34f9
FIX: default draft key in openComposerWithTopicParams ( #8496 )
2019-12-09 07:53:05 -08:00
aa24be1a9a
DEV: Extend plugin API for uploads ( #8440 )
...
* DEV: Add API to alter uploads Markdown
* DEV: Extract data attributes from image / download Markdown
For example '[test|attachment|hello=world]' will generate an 'a' element
with a data attribute: 'data-hello=world'.
This commit also makes MarkdownIt to transform '|attachment' into
'class="attachment"'. This transformation used to be a part of the
process which resolves short URLs (i.e. upload://).
* DEV: Export imageNameFromFileName
2019-12-09 16:20:03 +02:00
ebe6fa95be
FIX: Optimize images in Onebox ( #8471 )
...
This commit ensures that images in Onebox are being optimized, but not
converted to lightbox too.
2019-12-09 15:39:25 +02:00
f62b8990ac
FIX: Do not autocomplete categories or emojis in code blocks ( #8459 )
...
This reapplies commit b643526d9af65c453555
2019-12-09 15:07:15 +02:00
192ada0067
UX: Remove 'show more' from upload modals ( #8470 )
2019-12-09 12:57:43 +02:00
276fb7f46f
DEV: Bump parallel_tests from 2.28.0 to 2.29.2 ( #8484 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 2.28.0 to 2.29.2.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.28.0...v2.29.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 10:46:01 +00:00
510047c5df
Build(deps): Bump ruby-openid from 2.7.0 to 2.9.2 ( #8476 )
...
Bumps [ruby-openid](https://github.com/openid/ruby-openid ) from 2.7.0 to 2.9.2.
- [Release notes](https://github.com/openid/ruby-openid/releases )
- [Changelog](https://github.com/openid/ruby-openid/blob/master/CHANGELOG.md )
- [Commits](https://github.com/openid/ruby-openid/compare/v2.7.0...v2.9.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-12-09 10:40:50 +00:00
e89fa7202d
UX: Removes avatar animation for mobile-user cards ( #8483 )
2019-12-09 18:19:37 +08:00
ed6d3b493c
DEV: update dependencies
...
This updates some low risk dependencies. Mostly minor changes.
Public suffix now requires Ruby 2.3 and up which is not a problem for us.
2019-12-09 19:20:45 +11:00
494fe335d3
DEV: allow handling crawler reqs with no user agent
...
Followup to e440ec25
2019-12-09 18:40:10 +11:00
e440ec2519
FIX: crawler requests not tracked for non UTF-8 user agents
...
Non UTF-8 user_agent requests were bypassing logging due to PG always
wanting UTF-8 strings.
This adds some conversion to ensure we are always dealing with UTF-8
2019-12-09 17:43:51 +11:00
9b30922109
Build(deps): Bump rotp from 3.3.1 to 5.1.0 ( #8477 )
...
* Build(deps): Bump rotp from 3.3.1 to 5.1.0
Bumps [rotp](https://github.com/mdp/rotp ) from 3.3.1 to 5.1.0.
- [Release notes](https://github.com/mdp/rotp/releases )
- [Changelog](https://github.com/mdp/rotp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mdp/rotp/compare/v3.3.1...v5.1.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Fix breaking ROTP changes
2019-12-09 14:29:48 +10:00
5cef71e885
DEV: remove uneeded distinct from relation
...
No need to call `.distinct` when a unique index already exists.
2019-12-09 14:24:38 +11:00
fca727fd92
DEV: Bump tilt from 2.0.9 to 2.0.10 ( #8479 )
...
Minor update, removes a Ruby 2.7 deprecation.
2019-12-09 14:22:55 +11:00
c853051edb
DEV: Bump mustache from 1.1.0 to 1.1.1 ( #8478 )
...
Minor update, removes one warning which we have not seen yet.
2019-12-09 14:21:55 +11:00
067c4a7c10
DEV: Fix CookedPostProcessor specs
...
Broken in #8480
2019-12-09 03:16:25 +01:00
7aa3233bcb
DEV: Bump puma from 3.12.2 to 4.3.1 ( #8475 )
...
The downside here is that we are now going to require nio4r which requires some native code.
It is reasonably low risk though cause puma is very well tested. We use puma mostly in test environments, not in production.
2019-12-09 12:51:41 +11:00
d198e824ce
DEV: Bump fastimage from 2.1.5 to 2.1.7
...
This library is used to detect size of images, upgrading a minor version here should be low risk, we have integration tests to detect issues.
2019-12-09 12:49:53 +11:00
02ca6fa6c8
DEV: See if the store is external before checking disk space ( #8480 )
...
`available_disk_space` calls `df` which exits with an error if the `uploads` path doesn't exist. That's often the case when the `Discourse.store.external?` is true.
By doing the `external?` check first the `disable_if_low_on_disk_space` does less work and doesn't output any errors to the console.
2019-12-09 12:48:45 +11:00
e7bd288d7b
FIX: Skip validation on enforcing second factor change if the value is "no"
...
Without this, this site setting breaks plugin tests if local logins are
disabled in the plugin.
2019-12-06 16:42:15 -08:00
da66950cf5
DEV: Remove buffered rendering from backup upload progress
...
This is another refactoring in the multi-step process to remove all uses
of our custom Render Buffer.
Previous commit: 54e4559aea
2019-12-06 17:11:25 -07:00
d0e191a9d5
REFACTOR: changes from tag synonym feedback
2019-12-06 15:42:22 -05:00
68124caae2
FIX: Avoid unpinning composer on iOS when invoking emojis
...
Specifically when invoking emoji dropdown using a colon and pressing Return.
2019-12-06 14:08:59 -05:00
78969d7719
DEV: Support custom log level in dev
...
See https://guides.rubyonrails.org/debugging_rails_applications.html#log-levels
Can be used to reduce noise when running "bundle exec rails server" in dev.
Setting DISCOURSE_DEV_LOG_LEVEL="warn" will make for easier puts debugging with unicorn.
2019-12-06 10:57:10 -05:00
e51091f199
REFACTOR: do `X-Frame-Options` header removal in application controller.
...
Co-authored-by: Sam <sam.saffron@gmail.com>
Previous commit: f7084a4339
2019-12-06 18:25:32 +05:30
c88797bf0e
FIX: Ignore DMARC for emails sent to mailing list mirror
2019-12-06 13:29:39 +01:00
8a6421565e
DEV: upgrade low risk gems
...
This updates a bunch of gems that have very low risk of breaking anything
or are mostly used in dev. Overall our goal is to be on latest gems with
latest bug fixes so this is us working in that direction.
2019-12-06 17:12:43 +11:00
6617015bb5
DEV: Remove commented out code
...
Forgot to remove this.
Follow up to: 54e4559aea
2019-12-05 20:32:27 -07:00
54e4559aea
DEV: Remove buffered rendering from topic timers
...
This is another refactoring in the multi-step process to remove all uses
of our custom Render Buffer.
Previous commit: f269e45978
2019-12-05 20:28:27 -07:00
cc92aa9e71
SECURITY: Bump puma from 3.12.1 to 3.12.2 ( #8464 )
...
Bumps [puma](https://github.com/puma/puma ) from 3.12.1 to 3.12.2.
- [Release notes](https://github.com/puma/puma/releases )
- [Changelog](https://github.com/puma/puma/blob/master/History.md )
- [Commits](https://github.com/puma/puma/compare/v3.12.1...v3.12.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2019-12-06 14:09:29 +11:00
a06fccae1b
DEV: update dependencies and add notes about exceptions
...
Previously it was unclear why certain gems are being held back cause Gemfile
had no comment explaining it.
I tried to add some explanation from memory and remove some exceptions that
seemed to be superfluous.
This upgrades shoulda to latest, it appears to work once a couple of assertions
are removed
Also update http accept language used to auto detect language from http header
this is tested
Zeitwerk small update seems fine
2019-12-06 13:00:28 +11:00
e4881290be
FIX: Image file names with dots were showing incorrectly in composer markdown ( #8465 )
...
When uploading an image file with dots in the filename we were splitting the string on dots and getting the last of the split items as the extension-less filename. However this did not work with filenames that have dots. We now just remove the extension using substr.
2019-12-06 10:58:47 +10:00
da2b0b2882
UX: remove the double-encoding of user titles.
...
`{{}}` in handlebars are already escaping the HTML elements.
2019-12-06 04:07:47 +05:30
f7084a4339
FEATURE: add site setting to remove `X-Frame-Options` header.
2019-12-06 03:15:09 +05:30
00985559e4
FIX: Login page that redirects to preferences was broken
2019-12-05 22:36:11 +01:00
86186de1e3
FIX: Redirect to /login-preferences didn't work for subfolders
2019-12-05 22:34:44 +01:00
895d5cb592
FIX: Anonymous cache regression
2019-12-05 15:07:48 -05:00
dbee72e92b
FIX: Export poll UI should only show for admins
2019-12-05 17:03:06 -03:00
Krzysztof Kotlarek
dependabot-preview[bot]
Mark VanLandingham
Jarek Radosz
Dan Ungureanu
Joe
Sam Saffron
jwjwyoung
Jeff Wong
Blake Erickson
Neil Lalonde
Penar Musaraj
Vinoth Kannan
Gerhard Schlager
dependabot[bot]
Martin Brennan
Robin Ward
Rafael dos Santos Silva