Commit Graph

28952 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 65a68e4d4d
uses pr instead of git to check big prs 2018-07-26 10:25:40 -04:00
Maja Komel a89dd51cae DEV: migrate acceptance tests to async/await 2018-07-26 12:51:16 +02:00
David Taylor 88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login 2018-07-26 11:11:16 +01:00
David Taylor 63e15aa41a Add missing semicolon 2018-07-26 10:30:10 +01:00
Maja Komel e8d82f48bc add maxlength attribute for 2FA input fields 2018-07-26 10:31:20 +02:00
Kris 67b6539d98 rounder topic-list badges in iOS 2018-07-25 23:58:23 -04:00
Kris 998b7fb87a Rounder topic-list badges on mobile 2018-07-25 22:30:30 -04:00
Guo Xiang Tan f8b367cc9c Fix the build. 2018-07-26 10:17:51 +08:00
Kris c5e7c60a37 Fixing profile avatar flair poisition on mobile 2018-07-25 22:00:56 -04:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Guo Xiang Tan 9ccdc0da76
Merge pull request #6179 from chancancode/fix-osx-docs
Fix OSX docs
2018-07-26 09:26:48 +08:00
Guo Xiang Tan 30242972d3 Add spec for 4bf3bf6786. 2018-07-26 09:16:14 +08:00
Nick Shearer def2c977ce allow auth plugins to have a site setting for if they should be full screen vs popup window 2018-07-25 19:20:11 -05:00
Régis Hanol f94aeaf6cf SECURITY: force IM decoder based on file extension - part 3 2018-07-25 23:55:06 +02:00
Godfrey Chan 5affdcbd59 Bump Ruby version in some docs 2018-07-25 14:38:10 -07:00
Godfrey Chan 6b5c77cf83 Revert "install imagemagick@6 for OSX native development (#5411)"
This reverts commit 0207b7ca58.

ImageMagick 7 is now supported (and expected by the test fixtures).
See 1d74cca.
2018-07-25 14:17:00 -07:00
Régis Hanol 800c57c6ab SECURITY: force IM decoder based on file extension - part 2 2018-07-25 23:08:02 +02:00
Régis Hanol 4bf3bf6786 SECURITY: force IM decoder based on file extension 2018-07-25 22:00:04 +02:00
Kris 0e84024958
Updating style of theme options in wizard (#6177) 2018-07-25 15:32:14 -04:00
Kris 3fd2571abc Fix typo in color scheme 2018-07-25 15:12:01 -04:00
Joffrey JAFFEUX 06663f69f0
update big pr copy 2018-07-25 14:36:09 -04:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Joffrey JAFFEUX 6ee1ea96ef
fixes tests (#6176) 2018-07-25 14:02:21 -04:00
Jeff Atwood 269baf90cb copyedit on flagged post removal 2018-07-25 10:45:57 -07:00
Joffrey JAFFEUX 01d1f850e9
FEATURE: uses category-chooser for report filtering (#6174) 2018-07-25 13:16:35 -04:00
Joffrey JAFFEUX fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills (#6173) 2018-07-25 11:45:29 -04:00
David Taylor 0d0d78841b
FIX: Remove `plugin.enabled?` checks at initialization time (#6166)
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
  - An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
  - In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.

Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.

I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
  - `post_custom_fields_whitelist`
  - `whitelist_staff_user_custom_field`
  - `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00
David Taylor f38942d121 FIX: Destroy session between omniauth callbacks controller tests 2018-07-25 16:33:42 +01:00
Joffrey JAFFEUX 796639a797
FIX: makes disk_space computation more resilient (#6172) 2018-07-25 11:04:01 -04:00
David Taylor fa399ce1c5 FEATURE: Add revoke and reconnect functionality for google logins 2018-07-25 16:03:14 +01:00
Joffrey JAFFEUX 578c8e861b
FIX: refreshes disk_space on backup create/destroy (#6169) 2018-07-25 08:26:30 -04:00
David Taylor 776fd0de66 FIX: Filter open-id logins by identifier 2018-07-25 11:47:09 +01:00
Régis Hanol 637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Gerhard Schlager 84d14fd8a0 FIX: Don't rely on setting data type read from database 2018-07-25 11:40:59 +02:00
Gerhard Schlager 9989c8179d FIX: Translation for default (light) color scheme was missing 2018-07-25 11:28:14 +02:00
Vinoth Kannan 8209555497
Merge pull request #6170 from vinothkannans/disable-bootstrap
Disable bootstrap mode before start importing
2018-07-25 12:45:46 +05:30
Dan Ungureanu 44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Vinoth Kannan 1390eb2957 Disable bootstrap mode before start importing 2018-07-25 12:12:26 +05:30
Dan Ungureanu f540020d1d Add different trigger for the emoji popup of French users. (#6140) 2018-07-25 16:39:06 +10:00
Neil Lalonde 417bcf7d2e add checks for staff and system user before sending flags_agreed_and_post_deleted message 2018-07-24 19:25:11 -04:00
Joffrey JAFFEUX 9516d3de4b
removes rubocop from dangerfile for now (#6168)
This will be re-enabled once I can reproduce and fix errors using travis local docker build.
2018-07-24 18:10:02 -04:00
Joffrey JAFFEUX 29e612e86a
forces rubocop install in travis (#6167) 2018-07-24 17:51:53 -04:00
Maja Komel 3a52c2fa64 DEV: migrate widgets tests to async/await 2018-07-24 23:22:03 +02:00
Neil Lalonde fe39cdc90a FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author 2018-07-24 17:17:56 -04:00
Joffrey JAFFEUX e4480ad0d2
try to require test gemfile in Dangerfile (#6165) 2018-07-24 17:07:08 -04:00
Maja Komel d16a2c776a DEV: migrate components tests to async/await 2018-07-24 22:41:14 +02:00
Joffrey JAFFEUX c0992a4d31
makes danger usable for bundler with --deployment (#6164) 2018-07-24 15:11:23 -04:00
Joffrey JAFFEUX 9b455bebc7
do not check plugins in danger for now (#6163) 2018-07-24 13:35:47 -04:00
Joffrey JAFFEUX e8b9bd7d9b
improves danger formatting (#6162) 2018-07-24 13:10:54 -04:00
Robin Ward 7058205f70 FIX: Broken specs 2018-07-24 12:00:34 -04:00