65b1381575
DEV: Fix a constant redefinition warning ( #20842 )
2023-03-27 13:34:25 +02:00
142ef6088c
Build(deps): Bump @uppy/aws-s3 in /app/assets/javascripts ( #20033 )
...
Bumps [@uppy/aws-s3](https://github.com/transloadit/uppy ) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/transloadit/uppy/releases )
- [Changelog](https://github.com/transloadit/uppy/blob/main/CHANGELOG.md )
- [Commits](https://github.com/transloadit/uppy/compare/@uppy/aws-s3@3.0.4...@uppy/aws-s3@3.0.5 )
---
updated-dependencies:
- dependency-name: "@uppy/aws-s3"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:50:56 +02:00
dd0c9a96b9
Build(deps): Bump @popperjs/core in /app/assets/javascripts ( #20831 )
...
Bumps [@popperjs/core](https://github.com/popperjs/popper-core ) from 2.11.6 to 2.11.7.
- [Release notes](https://github.com/popperjs/popper-core/releases )
- [Commits](https://github.com/popperjs/popper-core/compare/v2.11.6...v2.11.7 )
---
updated-dependencies:
- dependency-name: "@popperjs/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:52:53 +02:00
f56a6a1c28
Build(deps): Bump sinon from 15.0.2 to 15.0.3 in /app/assets/javascripts ( #20829 )
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 15.0.2 to 15.0.3.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v15.0.2...v15.0.3 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:51:33 +02:00
e7ef5afb1b
Build(deps): Bump sass from 1.59.3 to 1.60.0 in /app/assets/javascripts ( #20830 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.59.3 to 1.60.0.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.59.3...1.60.0 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:55 +02:00
30417b7f18
Build(deps): Bump terser in /app/assets/javascripts ( #20832 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.6 to 5.16.8.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.6...v5.16.8 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 11:50:06 +02:00
4624cca00f
DEV: Fix `TopcisFilter#filter_tags` not working for a single tag ( #20840 )
...
Follow-up to dd88fdeabc
2023-03-27 16:58:40 +08:00
392cea5852
DEV: Only show plugin tab for admin ( #20841 )
...
As part of another regression, we realized that the plugins tab is visible to moderators, but they cannot interact with anything inside without triggering authorization errors.
This change hides the plugin tab for non-admin users.
2023-03-27 16:08:16 +08:00
dd88fdeabc
DEV: Introduce `TopicsFilter#filter_tags` method ( #20839 )
...
This change sets the ground work for allowing us to filter topics list
by tags in the following ways:
1. Filter for topics that matches all tags in a given set of tags
2. Filter for topics that matches any tags in a given set of tags
3. Exclude topics that matches all tags in a given set of tags
4. Exclude topics that matches any tags in a given set of tags
2023-03-27 14:16:53 +08:00
e0cf2849fd
FIX: admin always see configure default sidebar categories ( #20836 )
...
When an admin removes all the categories from their personal sidebar configuration, the section should remain visible to them with the “Configure default categories” prompt.
Similar solution for tags.
/t/95036
2023-03-27 15:46:39 +11:00
1edf7d1b72
Build(deps): Bump tzinfo-data from 1.2022.7 to 1.2023.2 ( #20826 )
...
Bumps [tzinfo-data](https://github.com/tzinfo/tzinfo-data ) from 1.2022.7 to 1.2023.2.
- [Release notes](https://github.com/tzinfo/tzinfo-data/releases )
- [Commits](https://github.com/tzinfo/tzinfo-data/compare/v1.2022.7...v1.2023.2 )
---
updated-dependencies:
- dependency-name: tzinfo-data
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:30:17 +08:00
91c7acc460
Build(deps): Bump sass-embedded from 1.59.3 to 1.60.0 ( #20827 )
...
Bumps [sass-embedded](https://github.com/ntkme/sass-embedded-host-ruby ) from 1.59.3 to 1.60.0.
- [Release notes](https://github.com/ntkme/sass-embedded-host-ruby/releases )
- [Commits](https://github.com/ntkme/sass-embedded-host-ruby/compare/v1.59.3...v1.60.0 )
---
updated-dependencies:
- dependency-name: sass-embedded
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:30:00 +08:00
018fd90cf3
Build(deps-dev): Bump selenium-webdriver from 4.8.1 to 4.8.2 ( #20824 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:29:25 +08:00
41d9b85bf7
Build(deps): Bump connection_pool from 2.3.0 to 2.4.0 ( #20828 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 12:27:48 +08:00
e0155b6955
DEV: Introduce dedicated controller and route for `discovery.filter` ( #20837 )
...
Instead of being tied to the old implementation and constraints, a
dedicated route and controller for the `discovery.filter` app route will
allow us to iterate on changes much faster.
2023-03-27 10:08:11 +08:00
9c36a49668
Build(deps): Bump rubocop-ast from 1.27.0 to 1.28.0 ( #20825 )
...
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast ) from 1.27.0 to 1.28.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases )
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.27.0...v1.28.0 )
---
updated-dependencies:
- dependency-name: rubocop-ast
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:03:28 +11:00
4047073292
FIX: display validation under custom sidebar fields ( #20772 )
...
Before, incorrectly filled fields were marked with red border. Now, additional information under the field is displayed to notify the user what is incorrect.
/t/93696
2023-03-27 13:03:16 +11:00
db3d30af3a
DEV: Skip system tests timing out on CI ( #20835 )
2023-03-27 08:22:37 +08:00
56fbdde0e5
FIX: Broken `?status=(listed|unlisted)` query param support ( #20834 )
...
In 66c5054
2023-03-27 07:30:19 +08:00
c66323f964
UX: Make table wrapper popup button icon only ( #20820 )
2023-03-24 13:23:05 -07:00
e47af9bb72
FIX: Check for staff without triggering anonymous user error ( #20819 )
...
Followup to 142d2ab65e
2023-03-24 19:11:57 +00:00
ef0016cdba
DEV: Drop our mail gem fork ( #20805 )
...
Didn't happen in https://github.com/discourse/discourse/pull/16622 but now that the official release is fixed - let's do this :P
2023-03-24 20:10:28 +01:00
83db0bf41a
FIX: Post height issues with Expand Table button ( #18810 )
2023-03-24 11:55:49 -07:00
0728fa055b
DEV: Make theme cache work like other caches ( #20813 )
2023-03-24 12:37:16 -05:00
7e23e6c1e8
DEV: Make banner cache work like other caches ( #20811 )
2023-03-24 12:36:55 -05:00
88004873ec
A11Y: usernames aren't a meaningful heading ( #20623 )
2023-03-24 13:22:22 -04:00
19b0dbe59d
UX: Show titles on site settings navigation menu items ( #20794 )
...
In some languages, labels on the site settings navigation menu
get truncated. This adds titles to menu items, so users can see
untruncated labels on hover.
2023-03-24 20:46:10 +04:00
bc8ab33708
DEV: Disable test to see if this is what's causing ci failures ( #20809 )
2023-03-24 11:15:30 -05:00
fc3c737a7f
UX: Restore reviewable counts on hamburger for legacy navigation ( #20807 )
...
Previously we disabled the hamburger reviewable count badge when the redesigned user menu was enabled. This commit updates the logic so that the hamburger reviewable count is tied the legacy navigation mode instead. This ensures that there is always a persistent reviewable count visible. (in the non-legacy navigation modes, the total reviewable count is shown in the sidebar)
2023-03-24 14:34:32 +00:00
9b41700f87
DEV: Use component class instead of string in user-menu API ( #20806 )
...
In the future we'll be looking at things like tree-shaking and code-splitting. Using 'magic strings' to resolve components is not compatible with those techniques. It makes sense to switch to a more modern pattern now, before the new user-tab API is used too widely.
This commit is backwards-compatible. API consumers which pass a string will see a deprecation message asking them to pass a component class instead.
This commit also turns some unneeded getters into simple class properties (no need to use a getter when it just returns a constant).
2023-03-24 14:26:30 +00:00
142d2ab65e
FEATURE: Move bootstrap mode indicator to header ( #20663 )
...
The information about bootstrap mode has been moved from the notice to
the README topic for admins.
2023-03-24 15:59:03 +02:00
a39a7028ab
DEV: Remove server-side-only entry for /upgrade ( #20804 )
...
After the docker_manager upgrade (https://github.com/discourse/docker_manager/pull/167 ) this is no longer needed.
2023-03-24 13:11:25 +01:00
75cd3821c6
Build(deps): Bump webpack in /app/assets/javascripts ( #20798 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.76.2 to 5.76.3.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.76.2...v5.76.3 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-24 13:10:34 +01:00
d533f316e8
UX: Fix mobile grippie being hidden ( #20803 )
2023-03-24 07:04:09 -05:00
55ef4d9a98
FIX: Make sure marking channels read propagates to all tabs ( #20802 )
...
Instead of just marking the state read in JS for each channel
after the AJAX call, we can instead just rely on the MessageBus
user-tracking-state chat channel, and publish the state to all
the channels affected in MarkAllUserChannelsRead. This will make
it so the blue dots for the channels are cleared across all tabs.
2023-03-24 10:12:35 +01:00
d2617c4904
UX: Allow opening user-menu tabs in new tab/window ( #20792 )
...
This commit turns the new user menu tabs into `<a href` elements. This means that the tab's associated URL is shown on mouseover, and also allows the browser to handle navigation when a modifier key is pressed (e.g. ctrl, shift, mod).
2023-03-24 08:18:23 +00:00
ed6f7b1e6d
FIX: use correct validation method name for `default_categories_normal`. ( #20801 )
...
When we renamed the `default_categories_regular` to `default_categories_normal` we missed a site setting validation method. It allowed the duplicate category ids in `default_categories_normal` site setting and caused the problem in user registration process.
5176c689e9
2023-03-24 11:40:37 +05:30
7c6a8f1c74
DEV: Refactor `TopicQuery#default_results` to improve readability ( #20800 )
...
This commit breaks down the code in TopicQuery#default_results into
smaller private methods to improve readability.
2023-03-24 11:17:55 +08:00
4929288bdd
FIX: delay custom section reorder ( #20799 )
...
Reorder should start after 300ms.
In addition, pointer events should be blocked to not open link after reorder is finished.
2023-03-24 13:58:05 +11:00
97f8f88cfe
FIX: ACL for OptimizedImage was using wrong path on multisite ( #20784 )
...
When setting the ACL for optimized images after setting the
ACL for the linked upload (e.g. via the SyncACLForUploads job),
we were using the optimized image path as the S3 key. This worked
for single sites, however it would fail silently for multisite
sites since the path would be incorrect, because the Discourse.store.upload_path
was not included.
For example, something like this:
somecluster1/optimized/2X/1/3478534853498753984_2_1380x300.png
Instead of:
somecluster1/uploads/somesite1/2X/1/3478534853498753984_2_1380x300.png
The silent failure is still intentional, since we don't want to
break other things because of ACL updates, but now we will update
the ACL correctly for optimized images on multisite sites.
2023-03-24 10:16:53 +10:00
a6166c5b32
Build(deps): Bump @glimmer/syntax in /app/assets/javascripts ( #20797 )
...
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm ) from 0.84.2 to 0.84.3.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases )
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/master/CHANGELOG.md )
- [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.84.2...v0.84.3 )
---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-23 23:20:33 +01:00
c8cae7b7de
Build(deps-dev): Bump test-prof from 1.2.0 to 1.2.1 ( #20796 )
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.2.0...v1.2.1 )
---
updated-dependencies:
- dependency-name: test-prof
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-23 23:18:49 +01:00
52999d1422
DEV: Show which system tests are being executed in CI ( #20795 )
...
... to see if it's always the same test causing timeouts
2023-03-23 15:12:14 -05:00
ebada4a6b0
DEV: More specific API to including extra associations in CategoryList ( #20790 )
2023-03-23 12:39:38 -05:00
fe127b166d
DEV: Add `{{yield}}` to user-stream-item for plugins/themes ( #20791 )
...
This means that plugins/themes can re-use the core component and also introduce their own footer
2023-03-23 15:32:00 +00:00
5238e96377
FIX: Avoid double-encoding featured topic title in user profile ( #20740 )
2023-03-23 13:36:37 +00:00
bee61d4faf
DEV: Convert composer controller to native class syntax ( #20723 )
...
Actions are moved from actions: {} to top-level functions with @action decorator. Previously we had a save() action and a top-level function of the same name, so this commit renames the action to avoid a clash.
2023-03-23 13:36:03 +00:00
b81767c1b1
SECURITY: Limit URL length for theme remote ( #20787 )
2023-03-23 12:01:04 +00:00
165a3217c8
Revert "FIX: delay custom section reorder ( #20781 )" ( #20786 )
...
This reverts commit 4fe79ccc79
2023-03-23 11:27:12 +01:00
67913e59e0
FIX: relies only on message bus to set tracking state ( #20785 )
...
This manual set was happening only after the request so was not much faster than just waiting on message bus update. It's not by itself changing any behavior or fixing any bug but it makes reasoning about the whole state easier as it happens in only one central place.
2023-03-23 11:11:13 +01:00
Jarek Radosz
dependabot[bot]
Alan Guo Xiang Tan
Ted Johansson
Krzysztof Kotlarek
Keegan George
David Taylor
Daniel Waterworth
Kris
Andrei Prigorshnev
Bianca Nenciu
Jordan Vidrine
Martin Brennan
Vinoth Kannan
Mark VanLandingham
Joffrey JAFFEUX