Commit Graph

2814 Commits

Author SHA1 Message Date
Osama Sayegh 98201ecc24
DEV: {{user-selector}} replacement ()
This PR is the first step towards replacing our `{{user-selector}}` and eventually deprecating and removing it from our codebase. Some of `{{user-selector}}` problems are:

1. It's called `{{user-selector}}`, but in reality in can also select groups and emails.
2. It's an Ember component, yet it doesn't have a handlebars template and uses jQuery to render itself and modify the DOM. An example of this problem is when you want to clear the selected users programmatically, see [this](6c155dba77/app/assets/javascripts/discourse/app/components/user-selector.js (L179-L185)).
3. We now have select kit which does very similar things but a lot better.

This PR introduces `{{email-group-user-chooser}}` which is meant to replace `{{user-selector}}`. It extends select kit and has the same features that `{{user-selector}}` has. `{{user-selector}}` is still used in a few places in core, but they'll all be replaced with the new component in a separate commit. 

Once `{{user-selector}}` is not used anywhere in core, it'll be deprecated and then removed after the 2.7 release.
2021-02-01 13:07:11 +03:00
awesomerobot 2f2dd94217 left align popup-menu button text 2021-02-01 10:30:52 +08:00
Martin Brennan 3e3f3f7b7e
DEV: Add time shortcut picker component and libs and refactor bookmark modal controller into component which uses time shortcut picker ()
This PR moves all of the time picking functionality from the bookmark modal and controller into a reusable time-shortcut-picker component, which will be used for the topic timer UI revamp. All of the utility JS for getting dates like tomorrow/next week/next month etc. have also been moved into a separate utility lib.

The time-shortcut-picker has a couple of options that can be passed in:

* prefilledDatetime - The date and time to parse and prefill into the custom date and time section, useful for editing interfaces.
* onTimeSelected (callback) - Called when one of the time shortcuts is clicked, and passes the type of the shortcut (e.g. tomorrow) and the datetime selected.
* additionalOptionsToShow - An array of option ids to show (by default `later_today` and `later_this_week` are hidden)
* hiddenOptions - An array of option ids to hide
* customOptions - An array of custom options to display (e.g. the option to select a post date for the bookmarks modal). The options should have the below properties:
    * id
    * icon
    * label (I18n key)
    * time (moment datetime object)
    * timeFormatted
    * hidden

The other major work in this PR is moving all of the bookmark functionality out of the bookmark modal controller and into its own component, where it makes more sense to be able to access elements on the page via `document`. Tests have been added to accompany this move, and existing acceptance tests for bookmark are all passing.
2021-02-01 09:03:41 +10:00
Kris 363170513e
UX: Allow some overflow in composer preview () 2021-01-29 20:28:56 -05:00
Kris 598c7d2fcb
fix topic entrance button layout () 2021-01-28 15:44:01 -05:00
Kris 9ae067164d
ensure topic footer buttons are the same height ()
follow-up to f1d5d2b
2021-01-27 21:40:45 -05:00
Kris d3febe5e86
Fix post edit icon color () 2021-01-27 20:38:15 -05:00
Kris f1d5d2b134
REFACTOR: Convert buttons to flexbox () 2021-01-27 16:17:08 -05:00
Penar Musaraj 4228c7e7d1
UX: Small tweak to category delete warning () 2021-01-26 09:43:47 -05:00
Kris 37f7f30640
edit button fix, follow up to 6f13d2b () 2021-01-22 20:31:01 -05:00
Roman Rizzi 6d30e01d1c
A11Y: Structure user menu as tabs. ()
* A11Y: Structure user menu as tabs.

Although the user menu content has the appearance of tabs and relies on the functionality of tabs to make sense in terms of content and focus order, it is not marked up correctly as tabs and tab panels. See [WAI-ARIA Authoring Practices 1.1](https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel) and the [example](https://www.w3.org/TR/wai-aria-practices-1.1/examples/tabs/tabs-2/tabs.html) for details.

* Make plugin api backwards compatible
2021-01-22 19:05:14 -03:00
Joffrey JAFFEUX 6f13d2b039
A11Y: makes post-edits-indicator a button instead of a link () 2021-01-22 17:09:39 +01:00
Penar Musaraj 4f01ca87e3
FEATURE: Add new features section in admin dashboard () 2021-01-22 10:09:02 -05:00
Gerhard Schlager 71656d2c37
UX: Makes the theme editor display placeholder correctly for RTL languages ()
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-he#53834
2021-01-22 16:03:43 +01:00
Arpit Jalan 15b5bd4e14
UX: show onebox error preview image as favicon () 2021-01-22 20:05:28 +05:30
Joffrey JAFFEUX 314e7be2b1
A11Y: improves search-in-options filter accessibility () 2021-01-22 14:39:16 +01:00
Joffrey JAFFEUX 7521cb51c4
A11y: makes advanced search and html heading () 2021-01-22 14:35:17 +01:00
Arpit Jalan e81d93cf26
UX: specify width and height for onebox preview error image () 2021-01-22 19:02:23 +05:30
Roman Rizzi 48f06e56f2
A11Y: Improve the quick access menu accessibility. ()
- The icon for the “view all” controls in the panels have no accessible alternative.
- Because the “Log Out” and "Do Not Disturb" elements in the preferences tab are an <a> element without an href attribute, it is not keyboard focusable and therefore not keyboard focusable. Use a button element instead.
2021-01-20 14:50:36 -03:00
Mark VanLandingham 1a7922bea2
FEATURE: Create notification schedule to automatically set do not disturb time ()
This adds a new table UserNotificationSchedules which stores monday-friday start and ends times that each user would like to receive notifications (with a Boolean enabled to remove the use of the schedule). There is then a background job that runs every day and creates do_not_disturb_timings for each user with an enabled notification schedule. The job schedules timings 2 days in advance. The job is designed so that it can be run at any point in time, and it will not create duplicate records.

When a users saves their notification schedule, the schedule processing service will run and schedule do_not_disturb_timings. If the user should be in DND due to their schedule, the user will immediately be put in DND (message bus publishes this state).

The UI for a user's notification schedule is in user -> preferences -> notifications. By default every day is 8am - 5pm when first enabled.
2021-01-20 10:31:52 -06:00
Joffrey JAFFEUX 54a01701d7
DEV: makes user-stream an unordered list ()
Note, ideally we would drop tagName usage, but I think it's safer to do it in a separate PR in few weeks.
2021-01-20 15:57:38 +01:00
Bianca Nenciu 3d7bb15be8
FIX: Always show overriden colors filter () 2021-01-20 10:40:05 +02:00
Krzysztof Kotlarek 8b10fc2f8c
FIX: remove rendering UX from ember models ()
Fix for `admin-user.js` and `backup.js` models.
2021-01-20 16:04:21 +11:00
Penar Musaraj 670b438ca5
UX: Use uniform style for tag counts () 2021-01-18 15:11:23 -05:00
Roman Rizzi ea8b5c18db
UX: Text customization for different languages. ()
Admins can now edit translations in different languages without having to change their locale. We display a warning when there's a fallback language set.
2021-01-18 14:53:45 -03:00
Mark VanLandingham 23059297b5
UX: Ellipsis hamburger menu link text when overflowing () 2021-01-14 18:25:19 -05:00
Kris 2f84ab6e0a
UX: add space between links and text in labels () 2021-01-11 13:35:41 -05:00
Osama Sayegh 2e3b3ec2de
FEATURE: Warn admins when installing a theme that's already installed ()
Installing multiple copies of the same theme/component is possible, but you rarely need to actually have multiple copies installed. We've seen many times new admins installing duplicates of components because they were unaware it was already installed. This PR makes the theme installer modal loop through the existing themes when you click on 'install', and if there is a theme with a URL that matches the URL you entered, a warning will show up and you will need to click 'install' again to proceed.
2021-01-07 21:03:35 +03:00
Kris d15159dff7
UX: Refactor topic list nav () 2021-01-06 16:15:28 -05:00
Kris 5b77c6a5d8
UX: Allow quick access profile content to scroll () 2021-01-06 15:32:20 -03:00
Penar Musaraj 5f846531a5
DEV: Cleanup variables/mixins SCSS imports ()
Prepends variables.scss and mixins.scss globally for all assets. With
one notable exception, theme fields, which will be addressed in a
separate PR.
2021-01-05 14:05:34 -05:00
Mark VanLandingham 836cbfe7ae
UX: Move do not disturb to profile panel () 2020-12-31 08:39:06 -06:00
Penar Musaraj 303f229e98
DEV: Use indexes when importing SCSS from a folder ()
By default, SCSS does not support globbing. This removes our magic and uses index files to import all files in a folder.
2020-12-30 15:29:10 -05:00
Mark VanLandingham 649ed24bb4
FEATURE: Do not disturb () 2020-12-18 09:03:51 -06:00
Sam 4558d91bbb
UX: adjust default menu width ()
The notification panel gets resized and the JS uses maxWidth of 320.

This tends to fight with the CSS causing notifications to "jump" a bit when a new one lands.
2020-12-18 14:50:50 +11:00
Penar Musaraj d1058f4e4c
UX: Blend header colors () 2020-12-16 09:38:51 -05:00
Arpit Jalan 1e7d6ebb0f
DEV: no need to iterate through each tag for rendering ()
This commit allows discourse-assign plugin to show assigned user next to
tags.
2020-12-16 18:40:58 +05:30
Kris d870c80516
UX: Don't wrap menu text under icon () 2020-12-16 16:43:47 +11:00
Kris f450ab6b5d
UX: Make theme install modal more responsive ()
* UX: Make theme install modal more responsive

* chrome fix
2020-12-16 16:41:36 +11:00
Kris 407591719c
UX: When input placeholders are too long, truncate with ellipsis () 2020-12-16 16:40:30 +11:00
Kris 7588910ee6
UX: remove timeline from print view, fix header in crawler view () 2020-12-15 16:12:46 -05:00
Kris e02c47c4f3
UX: Show required indication consistently on signup () 2020-12-14 16:35:32 -05:00
Kris ae114a6ee8
Revert "UX: When requiring user fields at signup, also mark default fields as required ()" ()
This reverts commit 3ef60686ed.
2020-12-11 12:09:56 -05:00
Penar Musaraj 8940e0f163
DEV: Fix position of filtered replies notice on DiscourseHub () 2020-12-10 13:25:09 -05:00
Penar Musaraj adda53c462
FEATURE: Optional filtered replies view ()
See PR for details
2020-12-10 12:02:07 -05:00
Jordan Vidrine 0116897ac9
UI: Category Onebox styling changes ()
This commit adjusts the category one box styling to be more in line with the discourse categories UI.
2020-12-09 11:36:05 -06:00
Arpit Jalan f62ea77666
Revert "DEV: no need to iterate through each tag for rendering" ()
This reverts commit a19a3adf9e.

Need to look into failing tests.
2020-12-08 20:35:46 +05:30
Arpit Jalan a19a3adf9e
DEV: no need to iterate through each tag for rendering ()
This commit allows discourse-assign plugin to show assigned user next
to tags.
2020-12-08 18:41:26 +05:30
Joffrey JAFFEUX daefa3d25a
UX: makes sk components full width on users admin page () 2020-12-08 11:18:02 +11:00
Joe 5ab6ef9765
FEATURE: Adds back button to theme editor () 2020-12-08 10:54:44 +11:00