793f933b6b
FIX: Move check to right serializer.
2017-09-12 17:52:13 +08:00
d3a409456f
PERF: Bypass AR and execute SQL directly.
2017-09-12 17:52:13 +08:00
c06c88b479
cleaner title attribute for select-box
2017-09-12 01:36:58 +02:00
18114c7bdb
Revert "FIX: pinned-button sometimes not shown when unpinned is null"
...
This reverts commit 01f0b56331
2017-09-12 01:03:16 +02:00
b875d17e1f
fix linter error
2017-09-11 23:51:42 +02:00
2c284874b4
FIX: icon showing as null
2017-09-11 22:47:47 +02:00
01f0b56331
FIX: pinned-button sometimes not shown when unpinned is null
2017-09-11 20:04:07 +02:00
90dd1609eb
FIX: memoization in PostAnalyzer.raw_mentions ( #5172 )
...
Due to a missing 's' when assigning the computed value to @raw_mentions, the raw_mentions function in PostAnalyzer would never retrieve a memoized value.
2017-09-11 20:01:24 +02:00
d7d9923b8e
FIX: display email validation error messages
2017-09-11 13:22:14 -04:00
e924920bec
uses select-box for pinned-button
...
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
f1639bf4f5
make eslint happy
2017-09-11 16:49:09 +02:00
5a51953c8e
UX: '.visited' wasn't applied in categories view and suggested topics
2017-09-11 16:42:51 +02:00
81e576ae37
FIX: Missing color on queued posts dropdown
2017-09-11 09:47:16 -04:00
2708243584
FIX: makes sure the select-box doesn’t go over header
2017-09-11 11:23:46 +02:00
b2dcb51e48
adds missing spacing around links in reason text
2017-09-11 10:42:53 +02:00
7f9220a2cd
minor select-box fixes
...
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
cf624bead0
FIX: cross browser issues on safari and edge
2017-09-10 22:25:31 +02:00
6d6fe7b3a9
adds more specificity to .dropdown-select-box
2017-09-10 20:57:34 +02:00
238557883f
FIX: queued posts had a red background
2017-09-10 14:26:55 -04:00
87b4615eee
FIX: Bookmark icon was not coloured on mobile
2017-09-10 14:14:52 -04:00
8e7e43a2d0
FIX: Duplicate class name
2017-09-10 14:09:29 -04:00
4b558638c8
FEATURE: improves keyboard handling of select-box
...
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
a11eec47bb
FIX: display localised title when using notifications-button
2017-09-10 11:38:52 +02:00
bba26e48a0
FIX: positioning issues with notifications-button
2017-09-10 11:36:57 +02:00
1f8695b16a
fix broken build
2017-09-09 20:58:37 +02:00
950b9e9eaf
FIX: keeps as much as possible the same api for select-box components
2017-09-09 20:29:07 +02:00
e6d3bbfa1d
FIX: Categories admin menu was missing
2017-09-09 09:21:43 -04:00
8c3f7d9bbc
FIX: select-box width was incorrect on mobile
2017-09-09 02:41:31 +02:00
753bf72921
FIX: adds correct spacing between footer buttons
2017-09-09 02:28:51 +02:00
253672f3fa
makes notification-options design more compliant with existing design
2017-09-09 01:53:10 +02:00
ab700d86ba
lighter icon color for categories-admin-actions
2017-09-09 01:52:36 +02:00
a9aa11d7c4
use d-icon names
2017-09-09 01:48:03 +02:00
5b9819f4ed
minor fixes to select-box
2017-09-09 00:49:33 +02:00
1def49cf6c
SECURITY: Only publish PM reply messagebus notifications to allowed users
2017-09-08 14:12:15 -07:00
1d52231f42
FIX: css regression on category-dropdown-button
2017-09-08 21:28:28 +02:00
cf6fb7622e
Replaces all notification-options like dropdowns with select-box
2017-09-08 20:47:39 +02:00
f13776e550
UX: Move `.visited` to entire row, not just the link to a topic
2017-09-08 13:54:41 -04:00
b7ac33464f
Reduce number of Redis calls.
2017-09-08 20:12:53 +08:00
661ae38a03
FIX: makes sure we only autocomplete valid emoji tones
2017-09-08 09:42:13 +02:00
6d35b62238
add image type attribute to icon link tag
2017-09-08 12:48:30 +05:30
5d4221fbe1
PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
164a388dcc
Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
...
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
f6fb94d31f
UX: Flags lost their red color on dropdown
2017-09-07 16:22:31 -04:00
e183600563
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-07 21:02:41 +01:00
a9737e2813
Merge pull request #5133 from guoyunhe/patch-1
...
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
d2d1c29f48
FIX: topic-notifications was taking too much space on mobile
2017-09-07 20:13:32 +02:00
3c0a9d4d19
FIX: topic-notifications taking too much space in timeline
2017-09-07 19:55:56 +02:00
5054065e81
FIX: broken spec
2017-09-07 19:18:27 +02:00
afc075d93b
UX: Convert bookmark icon from CSS to a proper icon using our helper
2017-09-07 11:41:19 -04:00
0ba789de17
Allow for customization of header dropdown icons
2017-09-07 11:18:59 -04:00
Guo Xiang Tan
Joffrey JAFFEUX
Darren Lee
Neil Lalonde
Régis Hanol
Robin Ward
David Taylor
Arpit Jalan
Leo McArdle