Commit Graph

14876 Commits

Author SHA1 Message Date
Guo Xiang Tan d3a409456f PERF: Bypass AR and execute SQL directly. 2017-09-12 17:52:13 +08:00
Joffrey JAFFEUX c06c88b479 cleaner title attribute for select-box 2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX 18114c7bdb Revert "FIX: pinned-button sometimes not shown when unpinned is null"
This reverts commit 01f0b56331.
2017-09-12 01:03:16 +02:00
Joffrey JAFFEUX b875d17e1f fix linter error 2017-09-11 23:51:42 +02:00
Joffrey JAFFEUX 2c284874b4 FIX: icon showing as null 2017-09-11 22:47:47 +02:00
Joffrey JAFFEUX 01f0b56331 FIX: pinned-button sometimes not shown when unpinned is null 2017-09-11 20:04:07 +02:00
Darren Lee 90dd1609eb FIX: memoization in PostAnalyzer.raw_mentions (#5172)
Due to a missing 's' when assigning the computed value to @raw_mentions, the raw_mentions function in PostAnalyzer would never retrieve a memoized value.
2017-09-11 20:01:24 +02:00
Neil Lalonde d7d9923b8e FIX: display email validation error messages 2017-09-11 13:22:14 -04:00
Joffrey JAFFEUX e924920bec uses select-box for pinned-button
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
Régis Hanol f1639bf4f5 make eslint happy 2017-09-11 16:49:09 +02:00
Régis Hanol 5a51953c8e UX: '.visited' wasn't applied in categories view and suggested topics 2017-09-11 16:42:51 +02:00
Robin Ward 81e576ae37 FIX: Missing color on queued posts dropdown 2017-09-11 09:47:16 -04:00
Joffrey JAFFEUX 2708243584 FIX: makes sure the select-box doesn’t go over header 2017-09-11 11:23:46 +02:00
Joffrey JAFFEUX b2dcb51e48 adds missing spacing around links in reason text 2017-09-11 10:42:53 +02:00
Joffrey JAFFEUX 7f9220a2cd minor select-box fixes
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX cf624bead0 FIX: cross browser issues on safari and edge 2017-09-10 22:25:31 +02:00
Joffrey JAFFEUX 6d6fe7b3a9 adds more specificity to .dropdown-select-box 2017-09-10 20:57:34 +02:00
Robin Ward 238557883f FIX: queued posts had a red background 2017-09-10 14:26:55 -04:00
Robin Ward 87b4615eee FIX: Bookmark icon was not coloured on mobile 2017-09-10 14:14:52 -04:00
Robin Ward 8e7e43a2d0 FIX: Duplicate class name 2017-09-10 14:09:29 -04:00
Joffrey JAFFEUX 4b558638c8 FEATURE: improves keyboard handling of select-box
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX a11eec47bb FIX: display localised title when using notifications-button 2017-09-10 11:38:52 +02:00
Joffrey JAFFEUX bba26e48a0 FIX: positioning issues with notifications-button 2017-09-10 11:36:57 +02:00
Joffrey JAFFEUX 1f8695b16a fix broken build 2017-09-09 20:58:37 +02:00
Joffrey JAFFEUX 950b9e9eaf FIX: keeps as much as possible the same api for select-box components 2017-09-09 20:29:07 +02:00
Robin Ward e6d3bbfa1d FIX: Categories admin menu was missing 2017-09-09 09:21:43 -04:00
Joffrey JAFFEUX 8c3f7d9bbc FIX: select-box width was incorrect on mobile 2017-09-09 02:41:31 +02:00
Joffrey JAFFEUX 753bf72921 FIX: adds correct spacing between footer buttons 2017-09-09 02:28:51 +02:00
Joffrey JAFFEUX 253672f3fa makes notification-options design more compliant with existing design 2017-09-09 01:53:10 +02:00
Joffrey JAFFEUX ab700d86ba lighter icon color for categories-admin-actions 2017-09-09 01:52:36 +02:00
Joffrey JAFFEUX a9aa11d7c4 use d-icon names 2017-09-09 01:48:03 +02:00
Joffrey JAFFEUX 5b9819f4ed minor fixes to select-box 2017-09-09 00:49:33 +02:00
David Taylor 1def49cf6c SECURITY: Only publish PM reply messagebus notifications to allowed users 2017-09-08 14:12:15 -07:00
Joffrey JAFFEUX 1d52231f42 FIX: css regression on category-dropdown-button 2017-09-08 21:28:28 +02:00
Joffrey JAFFEUX cf6fb7622e Replaces all notification-options like dropdowns with select-box 2017-09-08 20:47:39 +02:00
Robin Ward f13776e550 UX: Move `.visited` to entire row, not just the link to a topic 2017-09-08 13:54:41 -04:00
Guo Xiang Tan b7ac33464f Reduce number of Redis calls. 2017-09-08 20:12:53 +08:00
Joffrey JAFFEUX 661ae38a03 FIX: makes sure we only autocomplete valid emoji tones 2017-09-08 09:42:13 +02:00
Arpit Jalan 6d35b62238 add image type attribute to icon link tag 2017-09-08 12:48:30 +05:30
Guo Xiang Tan 5d4221fbe1 PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
Before

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 19
  75: 19
  90: 21
  99: 27
topic:
  50: 56
  75: 62
  90: 64
  99: 99
timings:
  load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```

After

```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
  50: 18
  75: 18
  90: 20
  99: 28
topic:
  50: 41
  75: 42
  90: 46
  99: 49
timings:
  load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
Arpit Jalan 164a388dcc Merge pull request #5120 from LeoMcA/new-topic-redirect-loop
FIX: redirect loop for new users visiting /new-topic using full screen login
2017-09-08 08:53:24 +05:30
Robin Ward f6fb94d31f UX: Flags lost their red color on dropdown 2017-09-07 16:22:31 -04:00
Leo McArdle e183600563 FIX: redirect loop for new users visiting /new-topic using full screen login 2017-09-07 21:02:41 +01:00
Arpit Jalan a9737e2813 Merge pull request #5133 from guoyunhe/patch-1
bbcode find close tag loop end condition
2017-09-08 00:04:30 +05:30
Joffrey JAFFEUX d2d1c29f48 FIX: topic-notifications was taking too much space on mobile 2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX 3c0a9d4d19 FIX: topic-notifications taking too much space in timeline 2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX 5054065e81 FIX: broken spec 2017-09-07 19:18:27 +02:00
Robin Ward afc075d93b UX: Convert bookmark icon from CSS to a proper icon using our helper 2017-09-07 11:41:19 -04:00
Robin Ward 0ba789de17 Allow for customization of header dropdown icons 2017-09-07 11:18:59 -04:00
Robin Ward 8e88bf019f Add `span` to various labels so they can be targetted 2017-09-07 11:10:11 -04:00
Joffrey JAFFEUX 70d0e175a2 FIX: default select-box-row should be aligned vertically 2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX 0374dc1a0e FIX: keys were incorrectly set to category 2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX 633d2fde45 removes select-box minWidth property
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX ca58a8228c minor css fixes on select-box 2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX d04aa5c7af FIX: component height computation was wrong 2017-09-07 16:55:36 +02:00
Leo McArdle 0ce9098339 add admin-user-details plugin outlet (#5141) 2017-09-07 16:17:27 +02:00
David Taylor 7d350d0d75 Revert plugin js changes (#5139)
* Revert "Add disabled_plugins to preloadstore for login_required anonymous users (#5134)"

This reverts commit b840170f8d.

* Revert "Do not load javascripts for disabled plugins (#5103)"

This reverts commit a14ab48829.
2017-09-07 15:15:29 +02:00
Joffrey JAFFEUX dd27c0c80e FIX: supports emojis in pinned topic excerpt 2017-09-07 11:06:04 +02:00
Guo Xiang Tan 4d840d10db PERF: Reduce number of Redis hits per requests. 2017-09-07 13:34:27 +08:00
Robin Ward a1957b7723 FIX: Stop moving notifications on large screens 2017-09-06 17:35:35 -04:00
Régis Hanol 8a935a4b5f FEATURE: new badges when visiting the forum for 10, 100 and 365 consecutive days 2017-09-06 22:35:08 +02:00
Joffrey JAFFEUX 0fca5ed533 FIX: stricter check on presence of notification_level_change
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
Robin Ward 825452df76 Refactor header CSS for composability 2017-09-06 11:34:10 -04:00
Robin Ward 777f024b8c Clean up weird indentation 2017-09-06 11:34:10 -04:00
Joffrey JAFFEUX ccf5005feb FEATURE: uses select-box for topic-notifications-button component
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
David Taylor b840170f8d Add disabled_plugins to preloadstore for login_required anonymous users (#5134) 2017-09-06 12:18:58 +02:00
David Taylor a14ab48829 Do not load javascripts for disabled plugins (#5103)
* Do not load javascript for disabled plugins

* Appease rubocop
2017-09-06 10:06:47 +02:00
Guo Yunhe 7d29ccf207 bbcode find close tag loop end condition
Only break loop when close tag has been found. Otherwise, keep searching until the end of string.
2017-09-06 09:13:57 +03:00
Guo Xiang Tan 8463b676df Revert "Activate mini-profiler when in profiling env."
This reverts commit d61109388c.
2017-09-06 11:26:03 +08:00
Guo Xiang Tan d61109388c Activate mini-profiler when in profiling env. 2017-09-06 11:19:20 +08:00
Guo Xiang Tan 672b7cb9a5 Require missing dependency. 2017-09-05 09:39:56 +08:00
Guo Xiang Tan 7786c6c6f2 Remove duplicated scope. 2017-09-05 09:15:06 +08:00
Robin Ward 51ffbf1c1f FIX: Remove duplicate event typo 2017-09-04 15:39:58 -04:00
minusfive fd91e53e68 Cleaned, de-duplicated/DRYed and organized discourse.css (common, mobile and desktop) 2017-09-04 10:56:28 -07:00
Robin Ward db929e58fc FIX: Don't allow staff to approve users with unverified emails 2017-09-04 12:55:39 -04:00
Robin Ward be1cce503c FIX: Don't bind events in `defaultState` 2017-09-04 11:48:36 -04:00
Joffrey JAFFEUX afe6f46b03 merges after_save 2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX caedefd675 FIX: correctly resets user_themes template
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Arpit Jalan 3b7128102c FIX: disable follow in topic summary links
https://meta.discourse.org/t/links-in-popular-links-appear-without-nofollow/68974
2017-09-04 16:21:12 +05:30
Guo Xiang Tan 5c1143cd55 Add missing test case for `PostController#timings`. 2017-09-04 16:36:02 +08:00
Arpit Jalan ebbdd4fe0f FIX: error when rebaking posts 2017-09-02 22:22:29 +05:30
Robin Ward dfe347fb1d FIX: Wizard tests don't need `Discourse` defined 2017-09-01 12:26:42 -04:00
Robin Ward c6ff387ce9 Use more semantic names for various tracking icons
This way they can be replaced by plugins without conflicting with other
icons. For example `circle` is used in some places that doesn't
represent `tracking`.
2017-09-01 12:14:58 -04:00
Sam Saffron 46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Robin Ward cb56dcdf2e FIX: Use proper `iconNode` when compiling virtual dom templates 2017-09-01 11:20:33 -04:00
Vinoth Kannan 0fb7831749 FEATURE: Add placeholders to broken and large image files (#5113) 2017-09-01 10:26:13 -04:00
Sam Saffron e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
minusfive b3b6eeff97 Ensure css applies to .user-main > .about icons regardless of tag 2017-09-01 06:32:27 -07:00
minusfive 611d62e4a5 Cleanup, deduplicate, debug user css, separated user-info component css 2017-09-01 06:32:27 -07:00
Robin Ward dffb1fc4ee FEATURE: Use Glimmer compiler for widget templates
Widgets can now specify a template which is precompiled using Glimmer's
AST and then converted into our virtual dom code.

Example:

```javascript
createWidget('post-link-arrow', {
  template: hbs`
    {{#if attrs.above}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_up"}}>
        {{fa-icon "arrow-up"}}
      </a>
    {{else}}
      <a class="post-info arrow" title={{i18n "topic.jump_reply_down"}}>
        {{fa-icon "arrow-down"}}
      </a>
    {{/if}}
  `,

  click() {
    DiscourseURL.routeTo(this.attrs.shareUrl);
  }
});
```
2017-09-01 09:28:16 -04:00
Arpit Jalan 66f2925348 SECURITY: do not include links from whispers in topic summary map
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
Robin Ward ef0f346eec Add custom style for header buttons 2017-08-31 12:10:54 -04:00
Joffrey JAFFEUX 56468582ee FIX: visual regressions on title-wrapper 2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX 0957ac9ee2 FIX: minor css tweaks to title-wrapper 2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX 84e992363c FIX: use maximum z-index for select-box when expanded 2017-08-31 00:55:05 +02:00
Robin Ward 75b2aa2edd Better support for inline modals 2017-08-30 17:52:49 -04:00
Robin Ward a48abc6556 Tweaks for better modal distinction between fixed/inline 2017-08-30 17:38:49 -04:00
Robin Ward 6361618188 `fixed-modal` is a better name 2017-08-30 15:52:29 -04:00
Robin Ward 3d95bac3fb Migrate away from `#discourse-modal` to `.d-modal` 2017-08-30 15:29:51 -04:00
Robin Ward 8fcd5af5b1 UX: Use a template for the `d-modal` component 2017-08-30 15:20:49 -04:00
Robin Ward 64bb0f9f05 Add a class to target the sugested topics message 2017-08-30 13:50:39 -04:00
Robin Ward 3aed047b7e UX: Add another div to aid in styling via flexbox 2017-08-30 13:43:56 -04:00
minusfive 5fd4970602 Cleanup nav-stacked .active state styles, remove unnecessary nesting 2017-08-30 09:14:56 -07:00
minusfive 8781c6bfcb Removed unnecessary outer link-tos from admin/settings|watched-words navs 2017-08-30 09:14:56 -07:00
Joffrey JAFFEUX 746c5927e1 Replaces remaining {{category-chooser}} by {{category-select-box}}
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues

Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Guo Xiang Tan 0a53c589c4 Fix linting. 2017-08-30 15:36:45 +08:00
Sam 9a861c1b43 Correct previous commit
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam 5cdb486332 UX: large topic creation area on mobile
This refines the iOS hack and allows for height 100%
on the composer

Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam c705159d22 Remove email column from user table 2017-08-29 11:50:56 -04:00
Sam b3fd091379 annotate stuff 2017-08-29 10:48:22 -04:00
Joffrey JAFFEUX 98c6c7e35a FIX: css regression on select-box 2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX cb4f690937 uses new select-box for quick topic edit 2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX dcc5f93344 FIX: disable highlighting when no value set on select-box 2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX 21c4e38eec clean select-box css 2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX f101fec19c FIX: improves uncategorized support for category-select-box 2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX 861dbe3b51 select-box refactoring
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joshua Rosenfeld e3e6fd6ea0 FIX: Only show topic timer to staff 2017-08-28 23:49:30 -04:00
Sam 50203794e6 FIX: staged users should get emails on must_approve_users sites 2017-08-28 17:32:07 -04:00
Sam 41e7bdff38 FIX: don't refresh notifications in a tight loop 2017-08-28 16:52:00 -04:00
Sam 9f0f086b3e FEATURE: allow API to mark accounts as approved on creation 2017-08-28 15:36:46 -04:00
Bianca Nenciu fa69e0dd77 Improved metadata for tags. (#5067) 2017-08-28 13:11:34 -04:00
Leo McArdle fd2cd63b08 FIX: make /new-topic redirect survive full screen login (#5105) 2017-08-28 12:40:31 -04:00
Bianca Nenciu 6bc74ceb50 Split alias levels in mentionable and messageable levels. (#5065)
* Split alias levels in mentionable and messageable levels.

* Fixed some tests.

* Set messageable level to everyone by default.

* By defaults, groups are not mentionable or messageable.

* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
David Taylor ce2250d7aa Add avatar-flair plugin outlet for user card (#5104) 2017-08-28 12:26:42 -04:00
minusfive d70ecf1c53 Simplify user-nav styles to facilitate theming 2017-08-28 09:24:41 -07:00
Bianca Nenciu bb3a5910d7 Support for sending PMs to email addresses (#4988)
* Added support for sending PMs to email addresses.

* Made changes after review.

* Added settings validator.

* Fixed tests.
2017-08-28 12:07:30 -04:00
Joffrey JAFFEUX b83c0747d9 FIX: select-box improvments
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Arpit Jalan be972912cb FIX: do not show full name field when accepting invite if full names are disabled
https://meta.discourse.org/t/require-password-for-trusted-user-invites/13750/58?u=techapj
2017-08-27 12:15:32 +05:30
Robin Ward a77ede05e2 FIX: Don't re-render if you find composer messages after destroying 2017-08-26 00:41:24 -04:00
Robin Ward b93f491035 Add option for button type under posts 2017-08-26 00:00:52 -04:00
Robin Ward 27b10a709b Revert "FIX: Un-revert the btn class added to the topic post menu"
This reverts commit aa07d23caa.
2017-08-25 23:50:00 -04:00
Joffrey JAFFEUX 5d12db1fb5 FIX: html not showing in select-box header 2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX 918f5045b4 FEATURE: display subcategories when filtering on parent name 2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX 2efb39289c FIX: select-box fragile specs 2017-08-26 01:24:17 +02:00
Robin Ward aa07d23caa FIX: Un-revert the btn class added to the topic post menu 2017-08-25 17:08:34 -04:00
Joffrey JAFFEUX 296ea6c7b1 FIX: castInteger on initial value 2017-08-25 22:41:35 +02:00
Robin Ward 7f16323ba4 REVERT: btn class looked ugly, let's revert for now 2017-08-25 16:06:56 -04:00
Neil Lalonde 398604ac71 FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users 2017-08-25 15:20:06 -04:00
minusfive d911d3ff6e Namespaced Sass color brightness function to avoid conflict w/CSS filter 2017-08-25 11:10:11 -07:00
Joffrey JAFFEUX 14f06c2740 select-box minor fixes 2017-08-25 19:56:57 +02:00
Robin Ward 075cc1a8bb FIX: some button classes 2017-08-25 13:44:28 -04:00
Robin Ward 493fd707f8 UX: Add missing `btn` class to `flat-button` 2017-08-25 13:16:18 -04:00
Robin Ward 4e9c4f0768 Add option to collapse buttons in post menu 2017-08-25 13:11:53 -04:00
Robin Ward 324b02a830 Add option to move the poster name in with the avatar 2017-08-25 13:11:53 -04:00
Neil Lalonde ea969d1ed0 FEATURE: add Thai language 2017-08-25 12:33:09 -04:00
Neil Lalonde 2c56f8df7c FEATURE: show tags in search results 2017-08-25 11:52:59 -04:00
minusfive cdcc5d6174 Extracted/DRYed user-stream-item component CSS from user.css into own files
- Renamed 'stream-item' component to 'user-stream-item'
- Replaced generic 'item' class with clearer 'user-stream-item' class
- Retained 'item' class for backward compatibility, marked as 'DEPRECATED'
- Extracted CSS pertaining 'user-stream-item' component to component CSS files
- Removed unnecessary duplication from 'user-stream-item' CSS
- Removed unnecessary nesting from 'user-stream-item' CSS
2017-08-25 08:38:27 -07:00
Joffrey JAFFEUX bbd428fb94 FIX: more consistent filter from keyboard on select-box 2017-08-25 01:48:32 +02:00
minusfive 8a06d3d312 Fix + remove unnecessary indentation, dead code, cleanup user.css 2017-08-24 14:46:01 -07:00
Jeff Atwood c8ce3c6dee make composer edu panel close button more visible 2017-08-24 13:49:33 -07:00
minusfive 512858c2e7 Removed no-longer-used styles from group.scss 2017-08-24 10:07:36 -07:00
minusfive c01dc26ea6 Add no-content message for user/activity/replies, fix no-content display 2017-08-24 09:51:39 -07:00
Joffrey JAFFEUX f3388043db FIX: avoids select-box being over composer popup 2017-08-24 18:49:35 +02:00
minusfive cdf0fefe8c Removed icons + no-glyph classes from /user sub-navs, normalized indentation 2017-08-24 09:41:27 -07:00
Joffrey JAFFEUX 39a89419b6 uses select-box for theme selection on user profile 2017-08-24 18:33:01 +02:00
Joffrey JAFFEUX d05df4a337 FIX: better headerText handling on select-box 2017-08-24 18:31:33 +02:00
Robin Ward a6251f717b Convert user card buttons to `{{d-button}}` components 2017-08-24 12:23:08 -04:00
Joffrey JAFFEUX 9c446fcb4d FIX: modify select-box orientation when composer resizes 2017-08-24 17:14:55 +02:00
Joffrey JAFFEUX 21d6c7f6b3 FIX: duplicated categories in select-box 2017-08-24 16:54:10 +02:00
Joffrey JAFFEUX d52048ad34 Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
This reverts commit 1d90f6016a.
2017-08-24 16:04:47 +02:00
Guo Xiang Tan 0531ef2e20 Fix calling `exists?` on Arrays. 2017-08-24 09:56:07 +09:00
Guo Xiang Tan 4b4169c8fd Merge pull request #5053 from fantasticfears/session-controller
Spec for local auth check
2017-08-24 09:42:54 +09:00
Guo Xiang Tan 91d3929f52 Merge pull request #5078 from lelelelemon/master
change count>0 to exists
2017-08-24 09:24:42 +09:00
Guo Xiang Tan 027b999828 Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
junwen yang 8124f26a6e change count>0 to exists 2017-08-23 22:54:51 +00:00
minusfive 38eef177d4 Cleanup & debug .nav-stacked styles 2017-08-23 13:58:41 -07:00
Robin Ward 950c9e50ac Add wrapper div to aid in styling 2017-08-23 14:47:09 -04:00
Sam f766ea4257 Correct short url decoding for sha1s leading with zero
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Joffrey JAFFEUX 1d90f6016a Revert "FEATURE: improves select-box to support category selection on new topic"
This reverts commit 7b4e302677.
2017-08-23 16:33:03 +02:00
Leo McArdle 3986367f3f update pr based on review 2017-08-23 14:55:34 +01:00
Joffrey JAFFEUX 7b4e302677 FEATURE: improves select-box to support category selection on new topic 2017-08-23 15:08:19 +02:00
Sam 8dfb1be4d1 FEATURE: unlisted *only* means not listed in topic lists
Remove security by obscurity feature that tries for exact slug match

If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Neil Lalonde 224796a7d4 FIX: wrongs counts on tags with deleted topics 2017-08-22 16:55:05 -04:00
Sam d7a2584c6e FEATURE: image uploads now have short urls
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
Robin Ward 605653a369 Add classes to small action buttons 2017-08-22 14:49:14 -04:00
Robin Ward cbe17be40e Remove unused small action component 2017-08-22 14:39:57 -04:00
Robin Ward 7e8766cee8 UX: Move buttons into the nav section of the topic map 2017-08-22 14:20:18 -04:00
Joffrey JAFFEUX a3e9819158 FEATURE: allows to disable automaticPositioning of emoji-picker (#5074)
Usage:
{{emoji-picker automaticPositioning=false}}
2017-08-22 19:41:02 +02:00
Sam ce8030716f FIX: broken badge show page 2017-08-22 13:28:02 -04:00
Sam bcf7dc38c2 FEATURE: server side support for upload:// markdown
This allows uploads to be specified using short sha1 hash instead of full
URL

Client side change is pending
2017-08-22 11:46:23 -04:00
Leo McArdle be1df3ba75 FIX: transfer posts by duplicated staged users to original 2017-08-22 09:58:51 +01:00
Arpit Jalan b00747fd49 FIX: do not create topic link reflection for unlisted topics 2017-08-22 14:28:01 +05:30
Guo Xiang Tan 29a9e0c4d2 Fix the build. 2017-08-22 15:52:24 +09:00
Guo Xiang Tan bc3e43b496 FIX: Topic timers being incorrectly `trashed!`.
https://meta.discourse.org/t/temporary-timed-closure-of-topic-not-re-opening-topic/67877
2017-08-22 15:23:09 +09:00
Guo Xiang Tan 87994a86ce FIX: Don't set topic timer for close topics when changing category.
https://meta.discourse.org/t/moving-a-topic-after-closure-reopens-topic/67659/4
2017-08-22 12:54:34 +09:00
Robin Ward 3a3dca32a3 FIX: Move before post count outlet inside the link 2017-08-21 20:40:35 -04:00
Robin Ward 8bd7cfedfd Convert suggested topics to a component 2017-08-21 17:03:38 -04:00
Sam 2f0c6c99e0 FIX: ip lookup not working
Also add a powered by line so it is clear this makes an external service call
2017-08-21 14:18:49 -04:00
Joffrey JAFFEUX c264348fcb FIX: avoids user-selector having no width 2017-08-21 18:55:44 +02:00
Guo Xiang Tan 93fe76fc02 Make eslint happy. 2017-08-21 21:56:22 +09:00
Kyle Zhao 1a32de722b last attempt at fixing user page layout
drop the width setting on the right column *completely* so it can
 adjust on it own

https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181
2017-08-18 17:28:50 -04:00
Sam 5c80d4bcdd UX: move close button to bottom and add esc hint. 2017-08-18 15:40:34 -04:00
Bianca Nenciu e976b98efc Show the select badge button only once. (#5064) 2017-08-18 14:00:20 -04:00
minusfive 77469cfb88 Unnest top level selectors from body 2017-08-18 13:00:26 -04:00
Robin Ward 286bc7db33 Revert "fixes overflowing div width on user activity page"
This reverts commit 375153ce57.
2017-08-18 10:43:42 -04:00
Jeff Atwood d84f105288 Merge pull request #5060 from xrav3nz/fix-user-activity-word-wrap-take-2
fixes overflowing div width on user activity page
2017-08-17 22:48:52 -07:00
Kyle Zhao 375153ce57 fixes overflowing div width on user activity page
detailed explanation: https://meta.discourse.org/t/long-words-not-wrapping-in-user-activity-page/68181/8?u=xrav3nz
2017-08-18 01:01:09 -04:00
Bianca Nenciu ac8bc04ad7 Set user title from the badge view (#5049)
* title info under notification

* create badge-title as component

* display available titles, close button

* remove visual feedback when grant new badge

* Made changes after review.

* Some minor fixes.
2017-08-17 16:32:37 -04:00
Sam c2a6616035 Correct erratic spec failure 2017-08-17 15:26:31 -04:00
Sam 0c4527323e FIX: queues posts broken for multiple posts 2017-08-17 14:47:09 -04:00
Robin Ward 4b0dcd64eb FIX: Footer message was missing the class 2017-08-17 14:40:14 -04:00
Sam 9246bc3400 support up button from first result 2017-08-17 13:32:30 -04:00
Sam 889b99552a FEATURE: allow ctrl+shift+s to open search 2017-08-17 12:57:08 -04:00
Sam dc4d5677eb FEATURE: use `a` when search result is focused to add to composer 2017-08-17 12:39:43 -04:00
Jen d29fc781fb trigger for other backup choices 2017-08-17 10:34:24 -04:00
Jen b5823a3b03 add event for other backup choices 2017-08-17 10:34:24 -04:00
Mudasir Raza 84c83afd35 Allow optional import_mode param for posts in api (#4952) 2017-08-17 07:53:04 -04:00
Kyle Zhao 43e2c91845 fixes word wrap issue on user activity page (#5056)
By default, the width of a table and its cells are adjusted to fit
the content. Thus, longer words are not wrapped and lead to a
wider width.
2017-08-17 08:52:50 +02:00
Régis Hanol 629810bd07 FIX: when registering custom_field types, ensure we're casting them before checking for equality 2017-08-16 23:04:40 +02:00
Sam 304379d436 FEATURE: up/down arrow will highlight search result
Then you can use enter to visit result.
2017-08-16 14:14:55 -04:00
Robin Ward b78958fbfc Silence CSS logging in development - it's way too noisy 2017-08-16 10:59:56 -04:00
Sam c68999e128 annotate models
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
Sam Saffron 56f7b4e01e PERF: reindex search data without loading large post counts 2017-08-16 08:18:59 -04:00
Erick Guan 6e59149a77 FIX: rebuild index when engine replaced (#5021) 2017-08-16 07:38:34 -04:00
Erick Guan c7a101476e Spec for local auth check 2017-08-16 11:01:00 +02:00
Guo Xiang Tan b77aa29e71 Merge pull request #5013 from LeoMcA/alternate-emails-phase-1.5
FIX: add additional email to tests and clean up resulting mess
2017-08-16 16:19:28 +09:00
Guo Xiang Tan ed851dbfff FIX: Avoid publishing a gigantic payload.
* Certain sites have way too many categories.
2017-08-16 11:38:30 +09:00
jomaxro 1219ae685b Add specific class to site description on /about 2017-08-15 19:48:57 -04:00
Joffrey JAFFEUX cad6107624 refactors select-box
Note: this commit also now uses select-box for mobile topics controls
2017-08-16 00:41:56 +02:00
Neil Lalonde d506e577a5 FEATURE: if full search returns no results, show google search form 2017-08-15 16:46:41 -04:00
Robin Ward 4085c40e50 Minor CSS changes 2017-08-15 13:17:25 -04:00
Kyle Zhao c3249f6e93 FEATURE: add full editing access to queued posts (#5047)
For pending new topics: the body of the post, title, categories
and the tags are editable.

For pending new replies: only the body is applicable and thus
editable

DISCUSSION: https://meta.discourse.org/t/66754
2017-08-15 12:44:05 -04:00
Erick Guan 1146772deb Fix: unlinked topic search model (#5044) 2017-08-15 11:46:57 -04:00
Neil Lalonde 130ae2cd4b FEATURE: add Latvian language 2017-08-15 11:40:00 -04:00
Arpit Jalan b354099252 FEATURE: add custom open graph tag for ignoring canonical url 2017-08-15 19:24:20 +05:30
Sam 6002f2ca4a FIX: not splitting words correctly for search tokenizer 2017-08-14 16:19:39 -04:00
Neil Lalonde 94d8f6d734 FIX: digest emails should not include posts that are still in the edit grace period 2017-08-14 12:47:33 -04:00
Robin Ward e568be04e8 Refactor footer message to use a component 2017-08-13 16:06:26 -04:00
Robin Ward f4839da047 More consistent container class names for styling 2017-08-13 15:49:57 -04:00
Arpit Jalan de642e0b0e Merge pull request #5042 from davidtaylorhq/login-required-404
SECURITY: Do not show latest/top topics on 404 for login_required sites
2017-08-13 23:36:24 +05:30
Robin Ward 0c2d20a523 Split out `latest-topic-list-contents` component 2017-08-13 13:19:27 -04:00
Robin Ward 8ccde140e5 Convert latest-topic-list to components and remove nested tables 2017-08-13 12:45:26 -04:00
David Taylor 37300d6777 SECURITY: Do not show latest/top topics on 404 for login_required sites 2017-08-13 19:02:44 +03:00
Joffrey JAFFEUX 9e475860e0 theme color select-box should be filterable 2017-08-13 14:53:07 +02:00
Joffrey JAFFEUX 482924b161 FEATURE: initial implementation of an ember native select 2017-08-13 14:34:50 +02:00
Bianca Nenciu 7213e02dee FIX: Scroll position is tracked on search page 2017-08-13 14:24:29 +02:00
Régis Hanol 75e4f7f896 Shorten some very long lines
Prevent warnings from already defined constants when reloading
2017-08-12 04:18:04 +02:00
Régis Hanol c2061aae3d Add new 'post_moved' event 2017-08-12 04:12:09 +02:00
Régis Hanol 4f09a5a7a5 Add 'Post.permitted_create_params' to allow plugins to add new params when creating a post 2017-08-12 04:10:45 +02:00
Régis Hanol 962db8c759 Add 'beforeCreate' hook in rest model 2017-08-12 04:08:40 +02:00
Régis Hanol 13e9d2867a Add current user's primary group name class to the composer body 2017-08-12 04:06:23 +02:00
Régis Hanol 19b7658dc3 Add 'primary_group_name' to CurrentUserSerializer 2017-08-12 04:05:16 +02:00
Neil Lalonde 9813f9f0f8 FIX: more cases of case sensitive group membership in sso 2017-08-11 18:09:29 -04:00
Robin Ward c2016e2bc6 Revert "Fix up some markup to making styling latest categories easier"
This reverts commit 2589b59f39.
2017-08-11 17:08:58 -04:00
Robin Ward 2589b59f39 Fix up some markup to making styling latest categories easier 2017-08-11 16:49:15 -04:00
Arpit Jalan 51f9c23e48 UX: add a divider line between regular user fields and custom user fields
https://meta.discourse.org/t/differentiate-user-fields-on-signup-form-better/66427/2?u=techapj
2017-08-11 17:46:40 +05:30
Bianca Nenciu 117417848e Remove like on change of ownership. (#5038) 2017-08-11 09:55:00 +02:00
Guo Xiang Tan f2539a86d0 Merge pull request #5036 from tgxworld/another_pass_at_removing_duplicated_users
FIX: Staged users were incorrectly created multiple times with same e…
2017-08-11 12:30:28 +09:00
Neil Lalonde 15a74d6d3e FIX: don't enforce newuser_spam_host_threshold on private messages 2017-08-10 17:19:08 -04:00
Robin Ward e6398bac21 Accept no arguments for `NavItem` options 2017-08-10 15:16:52 -04:00
Neil Lalonde 3c538270e4 UX: placeholder text in watched word input field 2017-08-10 11:25:17 -04:00
Régis Hanol 05a74d2534 FIX: navigation item counters weren't updating properly 2017-08-10 12:22:15 +02:00
Guo Xiang Tan 793eccf6c5 FIX: Staged users were incorrectly created multiple times with same email. 2017-08-10 18:56:15 +09:00
Guo Xiang Tan b84e87dedd FIX: Don't raise an error if URL timesout. 2017-08-10 12:58:56 +09:00
Guo Xiang Tan a849959915 Fix missing parameter. 2017-08-10 11:15:51 +09:00
Guo Xiang Tan b404a4b97c Merge pull request #5034 from tgxworld/fix_staged_primary_email
FIX: Staged users are still missing primary email.
2017-08-10 10:30:51 +09:00
Robin Ward c3051b89c0 Allow explicit hover and active buttons 2017-08-09 16:39:43 -04:00
Neil Lalonde ca1609c821 FIX: user directory didn't update stats of users with no recent activity 2017-08-09 15:57:42 -04:00
Robin Ward 53e6ccf17b Allow reloading of translation keys for plugins in development mode 2017-08-09 13:58:20 -04:00
Neil Lalonde 197944edaa UX: when staff change their email address, show a message saying an email has been sent to their current address, not their new one 2017-08-09 13:43:01 -04:00
Robin Ward 5ba3a2bd9d Allow route maps to access `site` easily 2017-08-09 11:49:18 -04:00
Guo Xiang Tan 705f75dd8c Merge pull request #5032 from xrav3nz/ux-hide-options-in-adv-search
UX: exclude irrelevant search filters for anonymous users
2017-08-09 18:21:44 +09:00
Guo Xiang Tan 90d7dd1f05 FIX: Ensure that post action moderation post uses the site's default locale.
https://meta.discourse.org/t/a-post-in-looking-for-someone-to-customize-discourse-to-create-a-forum-site-requires-staff-attention/67468/5?u=tgxworld
2017-08-09 18:20:20 +09:00
Arpit Jalan e993d53260 FIX: handle missing parent category when exporting user archive
https://meta.discourse.org/t/download-my-posts-failed/67613?u=techapj
2017-08-09 14:37:21 +05:30
Arpit Jalan bf2c35aa99 FEATURE: add RSS feed for badge pages 2017-08-09 13:43:49 +05:30
Guo Xiang Tan 49c6959dfc Adjust width for membership request input field. 2017-08-09 16:05:20 +09:00
Guo Xiang Tan 898c6ba037 Merge pull request #5033 from tgxworld/reason_when_requesting_to_join_a_group
FEATURE: Force user to enter reason when requesting for group members…
2017-08-09 15:54:21 +09:00
Guo Xiang Tan a9613163b5 FEATURE: Force user to enter reason when requesting for group membership. 2017-08-09 15:45:28 +09:00
Guo Xiang Tan 0bc690ed11 FIX: Staged users are still missing primary email. 2017-08-09 12:03:49 +09:00
Neil Lalonde c4b49fbabe send args to user-preferences-nav plugin outlet 2017-08-08 17:30:10 -04:00
Kyle Zhao cea2a9fe53 UX: exclude irrelevant search filters for anonymous users
On the advanced search page, filters like "I've read", "I'm watch
-ing", etc, are irrelevant to anonymous users and should be hidden
2017-08-08 15:25:40 -04:00
Régis Hanol 15fa27a1ff Add warning when using the 'modifyClass' plugin API after it's been cached in the container 2017-08-08 20:07:35 +02:00
Arpit Jalan e36a20660d FIX: handle topics without excerpt for meta description tag 2017-08-08 22:17:05 +05:30
Régis Hanol d182f0f2d1 Add support for preloaded custom_fields on Group 2017-08-08 15:45:27 +02:00
Régis Hanol 76a217c4bc add support for classNames binding in Navigation Item 2017-08-08 15:44:31 +02:00
Robin Ward 6ecb7cdff4 UX: Support for `none` style of category badge 2017-08-07 12:49:19 -04:00
Régis Hanol 4bfb049054 Add new 'group-edit' plugin outlet 2017-08-07 18:16:54 +02:00
Régis Hanol 770efee25f Add support for disabled attribute to the d-checkbox component 2017-08-07 18:16:43 +02:00
Robin Ward 2e4b3e9b06 Don't include all html builders on client and server side 2017-08-07 11:29:35 -04:00
Régis Hanol 4c306f9f49 New 'topic:current-post-changed' application event 2017-08-07 15:56:08 +02:00
Régis Hanol 125cc356f3 FIX: don't break the site when adding a navigation item without a 'name' field 2017-08-07 10:45:35 +02:00
Régis Hanol ce7d97a9a8 move title computed property back to nav-item so it can be overriden in a plugin 2017-08-07 09:53:03 +02:00
Guo Xiang Tan f496302c2c `order` scope is ignored when using `find_each`. 2017-08-07 11:46:18 +09:00
Guo Xiang Tan 3f24ed2b3e Can't revert due to incompatibility of new site setting types.
Revert "Revert "FEATURE: Site settings defaults per locale""

This reverts commit 439fe8ba24.
2017-08-07 10:43:09 +09:00
Guo Xiang Tan 439fe8ba24 Revert "FEATURE: Site settings defaults per locale"
This reverts commit 468a8fcd20.
2017-08-07 10:31:50 +09:00
Régis Hanol 4b53fe3cc7 new 'addNavigationBarItem' plugin api 2017-08-05 02:23:35 +02:00
Régis Hanol e958500735 extract 'timeline-controls' and 'timeline-footer-controls' widgets 2017-08-05 01:22:01 +02:00
Leo McArdle a7b7fe335f FIX: allow an admin to click on blank errors (#5027)
* FIX: allow an admin to click on blank errors

* i18nlize strings

* what would a rails master do?
2017-08-04 20:04:26 +02:00
Robin Ward a3ef814245 UX: Show proper HTML for category preview in site settings 2017-08-04 13:56:27 -04:00
Robin Ward 58d452fc41 FIX: Site setting previews were not rendering 2017-08-04 13:48:02 -04:00
Régis Hanol 3c0de22bf0 FIX: wasn't able to remove a user's primary group 2017-08-04 18:13:20 +02:00
Régis Hanol 519b70ea46 FIX: always trigger the ':user_updated' event
We don't always use the UserUpdated class to update a user's record
2017-08-04 18:12:10 +02:00
Régis Hanol c26ba890bd prevent N+1 when loading custom emojis 2017-08-04 17:04:59 +02:00
Leo McArdle 99527af38a FIX: show rejected emails with unrecognized errors (#5026)
Although 407a23663d will send rejection
messages for unrecognized errors, sometimes processing the email will
raise an error which has a blank message.

This commit:

1. Shows rejected emails which have already been processed and contain
   a blank error in /admin/email/rejected

2. Replaces new blank error messages with the error type
2017-08-04 16:20:44 +02:00
Guo Xiang Tan 40fc6c429a Merge pull request #5018 from discourse/wekbit-embedded-referer
FIX: First load of embed comments would always fail on WebKit
2017-08-04 14:12:26 +09:00
Robin Ward 2589b17cb7 Add wrapper divs with classes to the topic footer button area 2017-08-03 15:59:26 -04:00
Robin Ward 82230a1830 Support forcing badge styles 2017-08-03 14:55:36 -04:00
Arpit Jalan 2d95b9dfbf FIX: prevent Cloudflare from obfuscating emails
https://support.cloudflare.com/hc/en-us/articles/200170016-What-is-Email-Address-Obfuscation-
2017-08-03 15:06:13 +05:30
Guo Xiang Tan a47e297508 Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis
Fix Redis command errors when trying to start app with a readonly Redis.
2017-08-03 06:34:36 +09:00
Robin Ward edc7fae0b0 FIX: The ellipsis should be a `flat-button` 2017-08-02 17:30:40 -04:00