Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
43,700 Commits 244 Branches 502 Tags 901 MiB
Commit Graph

43700 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 828e75c2f3
DEV: minor choose topic refactoring (#15233) 
* DEV: minor choose topic refactoring

- prevents category to be clickable to make clicking topics easier
- drops jQuery
- uses @action
- uses ? operator where possible
- drops un-needed next/schedule usage

* uses topic-status component and prevents pinned icon to be focusable

* Update app/assets/javascripts/discourse/app/templates/components/choose-topic.hbs

Co-authored-by: Jarek Radosz <jradosz@gmail.com>

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
 2021-12-09 14:08:21 +11:00
Alan Guo Xiang Tan 4d1c84f15f
UX: Make toggling to filtered replies mode less jumpy. (#15240) 
Previously we would jump to the first two replies but it made the
transition very jumpy depending on how long the post being selected is.
 2021-12-09 10:03:22 +08:00
Alan Guo Xiang Tan e668b3dc71
DEV: Remove unnecessary element. (#15225) 
This was added 6 years ago in d1e85bdd8b
and I can't see how this is useful for any customizations at all.
 2021-12-09 08:40:23 +08:00
Alan Guo Xiang Tan ae88b52370
DEV: Fix position of avatar flair to be based on the actual avatar. (#15226) 
Previously, it was based on the container of the avatar. However, the
container of the avatar can be extended to contain more than just the
avatar itself. This resulted in the positioning of the avatar flair to
be off.
 2021-12-09 08:38:39 +08:00
dependabot[bot] dea56ed953
Build(deps): Bump parser from 3.0.3.1 to 3.0.3.2 (#15239) 
Bumps [parser](https://github.com/whitequark/parser) from 3.0.3.1 to 3.0.3.2.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v3.0.3.1...v3.0.3.2)

---
updated-dependencies:
- dependency-name: parser
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-12-09 08:37:42 +08:00
Jeff Wong 51abcd7524
DEV: add app event for user-card:after-show (#15227) 
Adds user-card:after-show event for when a usercard is fully loaded and shown.
 2021-12-08 15:23:39 -08:00
Daniel Waterworth 3b0d46c659
FIX: make tests work with higher starting upload id (#15237) 2021-12-08 13:13:59 -06:00
Osama Sayegh aec9ce9819
A11Y: Move focus to highlighted post when visiting a topic (#15236) 
Meta topic: https://meta.discourse.org/t/discourse-with-a-screen-reader/178105/87?u=osama.
 2021-12-08 21:33:15 +03:00
Andrei Prigorshnev 4e8983036a
DEV: do not return no_result_help from the server (#15220) 
We don't need it anymore. Actually, I removed using of it on the client side a long time ago, when I was working on improving blank page syndrome on user activity pages (see https://github.com/discourse/discourse/pull/14311).

This PR also removes some old resource strings that we don't use anymore. We have new strings for blank pages.
 2021-12-08 21:46:54 +04:00
David Taylor a6230b8138
UX: Improve composer presence-display positioning (#15235) 
Previously the discourse-presence plugin was using a `position: absolute` hack to display the 'replying...' users in the top right of the composer. This commit adds a more suitable plugin outlet, and updates the discourse-presence styling so it slots into the flex-box layout at the top of the composer
 2021-12-08 16:18:49 +00:00
Dan Ungureanu d8fe0f4199
FEATURE: Restrict link invites to email domain (#15211) 
Allow multiple emails to redeem a link invite only if the email domain
name matches the one specified in the link invite.
 2021-12-08 17:06:57 +02:00
Joffrey JAFFEUX e1b4e2e034
DEV: removes jquery usage from add-category-tag-classes (#15232) 
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
 2021-12-08 14:32:27 +01:00
Bianca Nenciu b1c11d5787
FIX: Select correct topic draft for user (#15234) 
The old query could return multiple rows.
 2021-12-08 15:23:44 +02:00
Bianca Nenciu 049bc33838
FIX: Update has_topic_draft when draft is updated (#15219) 
Current user state regarding the new topic draft was not updated when
the draft was created or destroyed.
 2021-12-08 14:40:35 +02:00
Joffrey JAFFEUX a144f49ec2
UX: scroll row to top of container in select-kit (#15230) 2021-12-08 12:22:18 +01:00
David Taylor f799b8bfb1
FIX: Ensure MessageIdService can handle hostname changes and multisite (#15231) 2021-12-08 11:17:20 +00:00
Loïc Guitaut 74387e83b6 DEV: Stop polluting all Ruby classes 
The `ReviewableScore` model was defining class methods on `self.class`
from a singleton context so instead of defining methods on
`ReviewableScore` it was defining them on `Class`, so basically on every
existing class.

This patch resolves this issue. Using `enum` from `ActiveRecord` in the
future will avoid this kind of problems.
 2021-12-08 11:32:25 +01:00
dependabot[bot] 3c5b1faab4
Build(deps): Bump raindrops from 0.19.2 to 0.20.0 (#15222) 
Bumps [raindrops](https://yhbt.net/raindrops/) from 0.19.2 to 0.20.0.

---
updated-dependencies:
- dependency-name: raindrops
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-12-08 01:42:57 +01:00
dependabot[bot] a22ee35d6c
Build(deps-dev): Bump fabrication from 2.22.0 to 2.23.0 (#15223) 
Bumps [fabrication](https://github.com/paulelliott/fabrication) from 2.22.0 to 2.23.0.
- [Release notes](https://github.com/paulelliott/fabrication/releases)
- [Changelog](https://github.com/paulelliott/fabrication/blob/master/Changelog.markdown)
- [Commits](https://github.com/paulelliott/fabrication/commits)

---
updated-dependencies:
- dependency-name: fabrication
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-12-08 01:42:17 +01:00
dependabot[bot] 21d5918d51
Build(deps): Bump excon from 0.88.0 to 0.89.0 (#15224) 
Bumps [excon](https://github.com/excon/excon) from 0.88.0 to 0.89.0.
- [Release notes](https://github.com/excon/excon/releases)
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt)
- [Commits](https://github.com/excon/excon/compare/v0.88.0...v0.89.0)

---
updated-dependencies:
- dependency-name: excon
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-12-08 01:41:12 +01:00
Jarek Radosz 301d5657fe
FIX: --header-offset didn't account for overscroll (#15221) 
Fixes miniprofiler badge sliding away from the header when you rubber-band overscroll on the top of the page (in Safari)
 2021-12-08 01:40:49 +01:00
Martin Brennan f26b8b448d
FIX: References header leading to broken email threading (#15206) 
Since 3b13f1146b the email threading
in mail clients has been broken, because the random suffix meant
that the References header would always be different for non-group
SMTP email notifications sent out.

This commit fixes the issue by always using the "canonical" topic
reference ID inside the References header in the format:

topic/TOPIC_ID@HOST

Which was the old format. We also add the References header to
notifications sent for the first post arriving, so the threading
works for subsequent emails. The Message-ID header is still random
as per the previous change.
 2021-12-08 08:14:48 +10:00
Mark VanLandingham a7fdcb921a
DEV: Sniff isPwa for capabilities (#15218) 2021-12-07 15:35:06 -06:00
David Taylor f3d480dacb
DEV: Allow PresenceChannel to specify custom activity thresholds (#15217) 
This allows consumers to vary the parameters on a per-channel basis. e.g. if you wanted a channel to consider someone 'away' after 10 minutes, and another channel to consider someone 'away' after 1 minute, that is now possible.
 2021-12-07 20:57:57 +00:00
Daniel Waterworth 6cae6aadf4
FIX: Make thumbnail tests start with a clean slate (#15216) 
* FIX: Make thumbnail tests start with a clean slate

Unfortunately, this exposes the fact that they don't actually work.
Marking as pending for now.
 2021-12-07 13:07:45 -06:00
Andrei Prigorshnev 77cca39c2d
DEV: dry up omni_auth_callback_controller_spec (#15213) 2021-12-07 23:06:44 +04:00
Daniel Waterworth 8371c96b7e
PERF: Speed up tests (#15214) 2021-12-07 12:45:58 -06:00
Daniel Waterworth 95c75d3f4f
DEV: Set uploads_id_seq starting point before tests (#15215) 
Some tests don't pass when this is elevated. They should be fixed,
since, at some point, we may create enough uploads during tests that
they fail naturally.
 2021-12-07 12:26:35 -06:00
Jarek Radosz 6e8df3d66b
DEV: Deprecate `registerOption()` (#15209) 
It's been a no-op for 5 years now.
 2021-12-07 18:33:45 +01:00
Penar Musaraj 03b0c9f267
A11Y: Remove dupe label on signup confirm field (#15212) 2021-12-07 11:40:00 -05:00
Discourse Translator Bot 3fec579ede
Update translations (#15210) 2021-12-07 16:19:44 +01:00
Loïc Guitaut d0888c190e FIX: Display pending posts in a moderated category 
Currently we display pending posts in topics (both for author and staff
members) but the feature is only enabled when there’s an enabled global site
setting related to moderation.

This patch allows to have the same behavior for a site where there’s
nothing enabled globally but where a moderated category exists. So when
browsing a topic of a moderated category, the presence of pending posts
will be checked whereas nothing will happen in a normal category.
 2021-12-07 10:14:45 +01:00
Krzysztof Kotlarek 412a6c0e8c
FIX: edit tag test (#15207) 
Broken with PR https://github.com/discourse/discourse/pull/15149
 2021-12-07 07:24:55 +01:00
Krzysztof Kotlarek a616bc296a
FIX: tag transition only if tag name changed (#15149) 
We need to change path only if tag name is changed. If a description is added, we don't need to reload.
 2021-12-07 05:44:55 +01:00
Dan Ungureanu 9a6ec1d0c6 PERF: Add index on email_tokens.token_hash 2021-12-07 10:17:45 +08:00
Alan Guo Xiang Tan 4e67297a7c FIX: Missing allowed urls when displaying granualar API key scopes. 
Follow-up to 3791fbd919
 2021-12-07 10:17:17 +08:00
Alan Guo Xiang Tan 44588255fc FEATURE: Introduce API scopes for badges. 2021-12-07 10:17:17 +08:00
Andrei Prigorshnev f3508065a3
FIX: auth incorrectly handles duplicate usernames (#15197) 2021-12-06 20:49:04 +04:00
Penar Musaraj bf18145e70
UX: Fix flair dropdown styling in user account (#15201) 2021-12-06 11:28:10 -05:00
Roman Rizzi 43903f8dfe
FIX: Updating a consolidated notification should bump it to the top. (#15199) 
In the future, it would be better to have a consolidated_at timestamp instead of updating created_at.
 2021-12-06 12:31:44 -03:00
Daniel Waterworth 3ebce550fe
DEV: Make add_api_parameter_route parameter deprecations errors (#15198) 
Since we said we would remove support in 2.7, this is overdue.
 2021-12-06 09:10:14 -06:00
Andrei Prigorshnev 10cc082560
FIX: when using external auth disallowed characters weren't removed from username (#15185) 2021-12-06 15:06:35 +04:00
David Taylor 0b364140ec
DEV: Add :before_email_login event for plugins (#15187) 2021-12-06 09:38:37 +08:00
Andrei Prigorshnev ce074d118e
DEV: drop unused method (#15190) 
There are no usages in Core and plugins.
The last usage was removed in https://github.com/discourse/discourse/pull/9369.
 2021-12-06 09:37:54 +08:00
Jarek Radosz 28bf9599f5
FEATURE: Pre-setting user locale via bulk invite (#15195) 2021-12-06 02:08:21 +01:00
Jarek Radosz 4bb91754ad
FIX: Make user themes sort order case insensitive (#15193) 
That's the order they appear in a dropdown in user preferences.
 2021-12-06 01:55:34 +01:00
Martin Brennan 3b13f1146b
FIX: Add random suffix to outbound Message-ID for email (#15179) 
Currently the Message-IDs we send out for outbound email
are not unique; for a post they look like:

topic/TOPIC_ID/POST_ID@HOST

And for a topic they look like:

topic/TOPIC_ID@HOST

This commit changes the outbound Message-IDs to also have
a random suffix before the host, so the new format is
like this:

topic/TOPIC_ID/POST_ID.RANDOM_SUFFIX@HOST

Or:

topic/TOPIC_ID.RANDOM_SUFFIX@HOST

This should help with email deliverability. This change
is backwards-compatible, the old Message-ID format will
still be recognized in the mail receiver flow, so people
will still be able to reply using Message-IDs, In-Reply-To,
and References headers that have already been sent.

This commit also refactors Message-ID related logic
to a central location, and adds judicious amounts of
tests and documentation.
 2021-12-06 10:34:39 +10:00
dependabot[bot] 11d1c520ff
Build(deps): Bump regexp_parser from 2.1.1 to 2.2.0 (#15194) 
Bumps [regexp_parser](https://github.com/ammar/regexp_parser) from 2.1.1 to 2.2.0.
- [Release notes](https://github.com/ammar/regexp_parser/releases)
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.1.1...v2.2.0)

---
updated-dependencies:
- dependency-name: regexp_parser
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-12-05 22:24:35 +01:00
David Taylor 972d7cb1d6
DEV: Fix mini-profiler location for custom (or missing) d-headers (#15192) 2021-12-04 23:33:07 +00:00
Jarek Radosz d3912075b6
FIX: PWA badges were not updating (#15191) 
That regressed in #7714, over two years ago. :P
 2021-12-05 00:15:51 +01:00