Penar Musaraj
b690fc3d98
FEATURE: Add new group visibility option for "logged on users" ( #7814 )
...
Groups can now be marked as visible to "logged on users". All automatic groups (except `everyone`) are now visible to "logged on users", previously they were marked as public but suppressed in the group page for non-staff.
2019-07-08 15:09:50 -04:00
Arpit Jalan
bb8cf81089
Bump onebox version.
...
- better placeholders for audio/video/trello/typeform oneboxes
- added CSS for audio/video/trello/typeform onebox placeholders
2019-07-08 21:40:33 +05:30
Joe
e49b5fa30c
UX: expand-post button alignment fix ( #7865 )
2019-07-08 14:36:15 +08:00
Arpit Jalan
2cd4e95d82
FIX: show category name in title for crawler view
...
Show category name in title for crawler view despite presence of `short_site_description`.
Bug reported here: https://meta.discourse.org/t/short-site-description-break-category-title-for-crawler-or-its-the-expected-behavior/122109/
2019-07-08 11:42:39 +05:30
Robin Ward
3132a9007b
FIX: Use correct timezone for manual SQL
2019-07-06 15:14:07 -04:00
Robin Ward
a075fd46fd
FIX: Don't use exceptions to catch conflicts
...
If a database exception is raised ActiveRecord will always rollback
even if caught.
Instead we build the query in manual SQL and DO NOTHING when there's a
conflict. If we detect nothing was done, perform an update.
2019-07-06 14:43:56 -04:00
Kris
a9982b5aa2
UX: Make default site logo height an even 40px
2019-07-05 23:46:43 -04:00
Robin Ward
de6edf9e4e
FIX: Back button would go to previous topic instead of list
...
See related topic:
https://meta.discourse.org/t/back-button-history-not-properly-working/122183
The issue here is the transition was not completing properly which meant
if you backed out of a topic quickly and entered a new one, hitting back
in the second topic would sometimes take you to the previous one instead
of back to the topic list.
2019-07-05 15:53:14 -04:00
Robin Ward
66214eee85
SECURITY: Strip HTML from invite emails
...
We also strip new lines from the emails because it ruins the markdown
formatting which expects a one line message.
2019-07-05 14:57:11 -04:00
Régis Hanol
155cad8b85
FIX: only add image size when with & height are in pixels
2019-07-05 20:34:11 +02:00
Kris
589351d996
UX: Give badge icons width to accommodate for dimensionless SVGs
2019-07-05 12:37:18 -04:00
Penar Musaraj
7c130990e9
FIX: IE grid layout issue on user's own activity page
2019-07-05 12:05:58 -04:00
Arpit Jalan
5494e17c71
UX: improve twitter status onebox with line breaks
2019-07-05 20:37:08 +05:30
Arpit Jalan
5bc1fd23b0
Bump onebox version.
...
- update HTML for twitter quoted onebox
- updated CSS for twitter quoted onebox
2019-07-05 19:35:36 +05:30
Arpit Jalan
bd084b2147
FIX: do not show invite button if local logins are disabled
2019-07-05 15:16:20 +05:30
Joffrey JAFFEUX
f140c4d499
FIX: ensures routing to / with query string works ( #7859 )
2019-07-05 09:40:19 +02:00
Vinoth Kannan
1bb258ab49
DEV: use upload short-url in html to markdown conversion if 'base62-sha1' data attr available.
2019-07-05 10:06:41 +05:30
Ralph Rooding
1318e0b288
FEATURE: Rake themes installer ( #7848 )
...
* Delete remote_theme when deleting the theme
* Install themes and theme components through rake
* Removed unnecessary test
2019-07-04 14:33:05 -04:00
Robin Ward
72bac61c90
FIX: Upsert a custom field if a unique constraint fails
2019-07-04 13:26:25 -04:00
Penar Musaraj
c78634284c
UI: when in a different topic context, allow dismissing draft without destroying it
...
This changes the label and behaviour of the "No, keep" button in the confirmation modal when user cancels a draft while on a different topic. The new button label is "No, save draft", and when clicked, the composer will be dismissed without destroying the draft.
2019-07-04 11:45:57 -04:00
Penar Musaraj
03805e5a76
FIX: Ensure lightbox image download has correct content disposition in S3 ( #7845 )
2019-07-04 11:32:51 -04:00
Mario Santos
c5625b70f1
FIX: Prevent emoji-picker from not showing ( #7856 )
...
If an external plugin inserts an element with class "emoji-picker", something probable if they extend EmojiPicker, it could cause troubles as css is added depending on the emoji-picker height. Just by adding a class of a parent <div> as could be d-editor, we prevent this from happening.
2019-07-04 11:46:21 +02:00
Gerhard Schlager
a5e80079d6
FEATURE: Add Belarusian language
2019-07-04 11:37:37 +02:00
David Taylor
2063d20e9a
Revert "DEV: Let OmniAuth strategies return auth result. ( #7833 )"
...
This reverts commit dc5eb76551
.
It is better to keep any custom redirect logic within omniauth, without relying on the app
2019-07-04 10:06:18 +01:00
Joffrey JAFFEUX
71bf9ec1b2
FEATURE: opt-in guidance on topics for users without access ( #7852 )
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-07-04 10:12:39 +02:00
David Taylor
5fdf228db6
FIX: Respect the full_screen_login parameter from plugin auth providers ( #7855 )
...
This behavior was regressed in 427979e7e5
2019-07-04 09:06:29 +01:00
Arpit Jalan
1708be4f27
FEATURE: support query params when redirecting to internal link on login ( #7829 )
2019-07-04 11:11:43 +05:30
David Taylor
0f813fc7c7
DEV: Remove reference to non-existent `letter_proxy` route
...
This was introduced in f04471e422
, but never actually used
2019-07-03 23:48:32 +01:00
Bianca Nenciu
459932f4e2
FIX: Use title attribute for notification items. ( #7840 )
2019-07-03 10:48:13 -04:00
Julian Calvento
f3c9dbcf20
UX: Add styling for quoted tweets ( #7832 )
2019-07-03 10:34:46 -04:00
romanrizzi
9ca1bbe900
Revert "FIX: remove misplaced save button"
...
This reverts commit 4f468ef210
.
2019-07-03 10:56:08 -03:00
Joffrey JAFFEUX
f9f1df7611
DEV: prevents reports key to be time dependant when testing ( #7850 )
2019-07-03 15:43:01 +02:00
romanrizzi
4f468ef210
FIX: remove misplaced save button
2019-07-03 10:39:01 -03:00
Bianca Nenciu
bfdf740a05
FIX: Show 'Export' button for all tabular reports. ( #7838 )
2019-07-03 14:47:36 +02:00
OsamaSayegh
426c8045de
FIX: logs for enabling/disabling components should show up in the staff actions logs
2019-07-03 12:33:25 +00:00
Osama Sayegh
3d64532273
FEATURE: allow disabling theme components ( #7812 )
...
This allows you to temporarily disable components without having to remove them from a theme.
This feature is very handy when doing quick fix engineering.
2019-07-03 18:18:11 +10:00
Joffrey JAFFEUX
ecf0215ee7
DEV: resets page tracking state between tests ( #7847 )
2019-07-03 10:08:05 +02:00
Joffrey JAFFEUX
9ee2c121c1
FIX: ensures emoji helper is working with custom emojis ( #7843 )
2019-07-03 09:23:40 +02:00
Joffrey JAFFEUX
0733ed3a2b
FIX: ensures /t/TOPIC_ID/POST_NUMBER is correctly routing ( #7841 )
2019-07-03 09:23:23 +02:00
Penar Musaraj
6e3e0685fb
DEV: add useBlockMode option for toolbar button text selection
...
Allows buttons to switch selection to block mode if needed.
2019-07-02 18:02:40 -04:00
Rafael dos Santos Silva
c422520b4a
FEATURE: Add CSS classes to associated accounts rows
2019-07-02 16:56:15 -03:00
Joffrey JAFFEUX
72441e2c7c
FIX: page starts at 1 ( #7844 )
2019-07-02 17:26:23 +02:00
romanrizzi
8404921b91
FIX: Remove misplaced outlet
2019-07-02 11:26:40 -03:00
Arpit Jalan
ccb3ba509d
FIX: creating new badge is failing on empty SQL query ( #7837 )
2019-07-02 15:12:53 +05:30
Joffrey JAFFEUX
1b45096aa5
UX: improves styling of similar topics results in composer ( #7839 )
2019-07-02 11:26:43 +02:00
Penar Musaraj
fca2f0f212
FIX: Only show remove timer button to users with permission to do so
2019-07-01 22:17:02 -04:00
Osama Sayegh
f1c67729de
Different fix ( #7815 )
2019-07-02 11:53:16 +10:00
Sam Saffron
4dcc5f16f1
FEATURE: when under extreme load disable search
...
The global setting disable_search_queue_threshold
(DISCOURSE_DISABLE_SEARCH_QUEUE_THRESHOLD) which default to 1 second was
added.
This protection ensures that when the application is unable to keep up with
requests it will simply turn off search till it is not backed up.
To disable this protection set this to 0.
2019-07-02 11:22:01 +10:00
Dan Ungureanu
dc5eb76551
DEV: Let OmniAuth strategies return auth result. ( #7833 )
2019-07-01 13:13:11 -03:00
Arpit Jalan
f56d86a852
FIX: use normal title instead of fancy title for prefilled composer
2019-07-01 17:55:24 +05:30
Joffrey JAFFEUX
7b52a110b8
DEV: removes DOMTokenList polyfill ( #7831 )
...
Creates more issues than it solves especially on IOS, I dont trust it anymore. Will reconsider if this is an issue in the future.
2019-07-01 14:08:38 +02:00
Gerhard Schlager
d513c28e3b
FIX: Don't send notification email when user isn't allowed to see topic
2019-07-01 14:03:03 +02:00
Arpit Jalan
997250586c
FEATURE: prefill title for direct messages from topic
...
https://meta.discourse.org/t/default-re-title-title-for-direct-messages-from-topic/121413
2019-07-01 17:14:08 +05:30
Joffrey JAFFEUX
af58049eeb
UX: puts tags and categories on same line in search-menu-results ( #7830 )
2019-07-01 13:11:43 +02:00
Joffrey JAFFEUX
384f5cea05
FIX: ensures static pages are using absolute path ( #7828 )
2019-07-01 11:25:45 +02:00
Joffrey JAFFEUX
11ae5c78db
FEATURE: adds infite scroll on admin users list page ( #7821 )
2019-07-01 11:00:06 +02:00
Bianca Nenciu
4f97f85178
DEV: Fix lint. ( #7824 )
2019-06-28 20:24:09 +02:00
Kris
aa9b9e1930
UX: improved mobile positioning of topic timer remove button
2019-06-28 14:09:42 -04:00
Joffrey JAFFEUX
5bab4f8007
UX: gives each info its own line in search-menu-results ( #7825 )
2019-06-28 11:14:38 +02:00
Joffrey JAFFEUX
61438c825a
fix prettier ( #7823 )
2019-06-28 09:36:38 +02:00
Bianca Nenciu
b2eb0f4ad6
FEATURE: Export any type of report supporting table mode. ( #7662 )
2019-06-28 08:50:31 +02:00
Kris
82f2af8a0d
UX: Move link to show tracked topics, simplify translation
2019-06-27 21:36:24 -04:00
Penar Musaraj
27387b0859
Do not collapse quote notifications
...
This prevents an issue where edits to a post with a quote would trigger push notifications indefinitely.
2019-06-27 18:20:43 -04:00
Ralph Rooding
4ba35472e6
Don't check for second factor when switching to anonymous account ( #7803 )
2019-06-27 15:01:26 -07:00
Joffrey JAFFEUX
a61147d838
FEATURE: displays tags in search menu results when enabled ( #7819 )
2019-06-27 19:26:14 +02:00
Robin Ward
ed936bcb01
FIX: Fix a navigation bug
...
To reproduce:
1. Visit a url in a new tab such as `/latest?order=views`
2. Click a topic link
3. Click the back button
Before this patch, you would not be sent back to the latest list.
Now, I am somewhat hesitant to delete code like this, but the [original
commit](b2b7f4d905
)
explains a situation that I cannot reproduce with the code missing.
I cannot seem to keep the filters as sticky even if I try. At the very
least this is better to commit right now than the currently known broken
situation.
2019-06-27 09:06:10 -04:00
Gerhard Schlager
fe870a1e54
DEV: Respond with error 400 to uploads requested via XHR
...
follow-up to 13f38055
2019-06-27 11:15:35 +02:00
Sam Saffron
8f7a387aa7
FEATURE: add support for tag group search
...
The behaviour of #TERM in search has been amended
1. We try category or subcategory slugs
2. We try tags
3. We try tag-groups
The term `hello #my-group` will search for all posts tagged with any of
the tags in the tag group `My Group`
Future work may be introducing a slug cache here or caching it in the table
but the assumption is that the number of tag groups will not be huge
2019-06-27 17:53:26 +10:00
Arpit Jalan
9a2eb5c8cb
UX: change icon for video placeholder
2019-06-27 12:27:14 +05:30
Sam Saffron
5bc5c02af6
FIX: mark topics in sub categories as unread when dismissing parent
...
Previously we would only dismiss the parent category and leave the
child categories unread
2019-06-27 13:26:48 +10:00
Jeff Wong
88ef5e55fe
FEATURE: add ability to have multiple totp factors ( #7626 )
...
Adds a second factor landing page that centralizes a user's second factor configuration.
This contains both TOTP and Backup, and also allows multiple TOTP tokens to be registered and organized by a name. Access to this page is authenticated via password, and cached for 30 minutes via a secure session.
2019-06-26 16:58:06 -07:00
Osama Sayegh
50e4ecc77e
UX: hide post is unread tooltip after the post is read ( #7813 )
...
Note we can't use `display: none` here because it doesn't work with
animations.
2019-06-26 22:39:57 +03:00
Arpit Jalan
a3bcb8e887
UX: make onebox video placeholder icon grey
2019-06-26 23:40:36 +05:30
Arpit Jalan
168a38dc29
Bump onebox version.
...
- better Twitch placeholder
- CSS for said placeholder
2019-06-26 23:22:29 +05:30
Robin Ward
817661aed9
UX: Require a confirmation if approving a post in a closed topic
2019-06-26 12:21:49 -04:00
Robin Ward
14a64e7c4c
Move "Hide Post" option up to the top on the review interface
...
If you agree with the post you are likely to want to hide it.
2019-06-26 11:35:59 -04:00
Robin Ward
eedec7d79b
FIX: Only include pending/agreed scores in the total score
...
This should prevent posts from being hidden if a previous flag was
rejected and a new one was added.
2019-06-26 11:21:35 -04:00
Joffrey JAFFEUX
c63268467e
DEV: prettier 1.18.2 ( #7810 )
2019-06-26 17:09:52 +02:00
Penar Musaraj
76307611dc
UX: new inline button to remove a topic timer ( #7790 )
2019-06-26 11:08:53 -04:00
Gerhard Schlager
13f38055ac
SECURITY: XSS in routes
...
Co-authored-by: Guo Xiang Tan <tgx_world@hotmail.com>
Co-authored-by: David Taylor <david@taylorhq.com>
2019-06-26 16:34:15 +02:00
Joffrey JAFFEUX
56b76f31dc
fix prettier linting ( #7809 )
2019-06-26 15:26:02 +02:00
Joffrey JAFFEUX
dfde59f631
FIX: provides an emoji helper to replace codes by images ( #7802 )
2019-06-26 15:11:04 +02:00
Daniel Waterworth
65a6e2c860
Change Widget#attach signature
...
Take a fallback option instead of a list of names
2019-06-26 09:01:25 -04:00
Daniel Waterworth
37b8f5d989
Use dasherize instead of replace
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d025e188e8
Make the linter happy
2019-06-26 09:01:25 -04:00
Daniel Waterworth
70e27641eb
Pass data to description to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
8c349101c5
Pass data to text method to prevent duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
86d5208b31
Pass data to url method to avoid duplication
2019-06-26 09:01:25 -04:00
Daniel Waterworth
ac6f7b3625
Remove notificationType argument from text
2019-06-26 09:01:25 -04:00
Daniel Waterworth
a3254b8446
Pull invitee accepted notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7c52ba1431
Pull liked consolidated notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
42143a874e
Pull custom notification behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
305562bf66
Pull title logic into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
d83147d137
Rename "title" variable to more apt "description"
2019-06-26 09:01:25 -04:00
Daniel Waterworth
02deaa4bc6
Pull icon choosing into its own method
2019-06-26 09:01:25 -04:00
Daniel Waterworth
36d7abed0b
Pull group message summary behaviour into its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
396e13aaa7
Pull liked notification behaviour in its own class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
bd062fcbef
Export DefaultNotificationItem
2019-06-26 09:01:25 -04:00
Daniel Waterworth
04a75b1cb3
Change the way notification items are created
...
Look for the specialised version first, before falling back to the
default. This allows the behaviour to be customised based on the type of
notification.
2019-06-26 09:01:25 -04:00
Daniel Waterworth
cdf0cd3ecd
`createWidgetFrom` creates a new widget with an arbitrary base class
2019-06-26 09:01:25 -04:00
Daniel Waterworth
01a7fd4225
Make `attach` optionally take a list of widget names to try
2019-06-26 09:01:25 -04:00
Daniel Waterworth
41129f933d
Rename notification-item to default-notification-item
2019-06-26 09:01:25 -04:00
Daniel Waterworth
7e70db3fb7
s/notName/notificationName/g
2019-06-26 09:01:25 -04:00
Joffrey JAFFEUX
7c9d62c280
FIX: prevents failure when TL was mutated on internal object ( #7808 )
2019-06-26 14:51:45 +02:00
Joffrey JAFFEUX
01de7e1444
FIX: calling action with a string is deprecated ( #7807 )
2019-06-26 12:42:46 +02:00
Joffrey JAFFEUX
e64544ae44
icon s/trash/trash-alt ( #7806 )
2019-06-26 12:31:49 +02:00
Joffrey JAFFEUX
ea2a9bc4fc
FIX: closes search-menu on escape ( #7804 )
2019-06-26 11:53:39 +02:00
Arpit Jalan
2af4002817
Bump onebox version.
...
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
Sam Saffron
333b5a19b2
FIX: do not include uncategorized_category_id in `topic_create_allowed` if posting in uncategorized is disabled
...
Previously users were still allowed to create topic via API even if
uncategorized was disabled.
Not 100% happy with all this special casing, but I guess we have to do
something.
This also splits up a mega spec now that we have fab! into a more easy to
understand structure (I hope)
2019-06-26 17:41:07 +10:00
Osama Sayegh
2eece2c41b
UX: add shortcut for deferring topics ( #7798 )
2019-06-25 07:20:55 +03:00
David Taylor
afb5ec811d
FIX: Don't use DistributedCache to store redis readonly state
...
This can cause unbound CPU usage in some cases, and excessive logging in other cases. This commit moves redis readonly information into the local process, but maintains the DistributedCache for postgres readonly state.
2019-06-25 11:20:34 +08:00
Sam Saffron
f3e4e6941c
DEV: Correct batch setting of categories
...
followup to #bc03c509
There were 2 problems
1. VALUES was not properly getting multiple results ... we need (1),(2),(3)
not (1,2,3)
2. changes was mistakenly lazy evaluated eg `changed ||=` which meant some
queries were not running
2019-06-25 13:05:43 +10:00
Daniel Waterworth
bc03c509ab
FIX: CategoryUser#batch_set ( #7787 )
...
* Remove unused method
* Prefabricate user in category_user_spec.rb
* FIX: Remove notification_level from category_users unique indexes
* FIX: CategoryUser#batch_set wasn't updating pre-existing records
* Improve tests for CategoryUser#batch_set
* FIX: changed was being reported incorrectly
* DEV: Rewrote query to do a bulk insert
* DEV: remove unnecessary parentheses
2019-06-25 12:13:27 +10:00
Jeff Wong
6de254f642
FIX: iterate when clearing watched words cache
2019-06-24 17:17:56 -07:00
Vinoth Kannan
b1ca64487a
FIX: multisite upload urls must have either db name or the word 'short-url'.
2019-06-25 01:19:58 +05:30
Kris
9e54e0141e
FIX: mobile overflow for tall fixed modals
2019-06-24 12:24:13 -04:00
Joffrey JAFFEUX
c1ca942a77
REFACTOR: removes self pattern from safari-hacks lib ( #7795 )
2019-06-24 11:12:06 +02:00
Joffrey JAFFEUX
e064db35d9
REFACTOR: removes self pattern from eyeline lib ( #7796 )
2019-06-24 10:58:59 +02:00
Joffrey JAFFEUX
cea3a027f3
FIX: category-chooser search should be scoped to category ( #7794 )
2019-06-24 10:45:30 +02:00
Joffrey JAFFEUX
7cabc47945
UX: improves change-timestamp modal datepicker ( #7771 )
2019-06-24 10:24:54 +02:00
Dan Ungureanu
ee8669d778
FIX: Ensure :after_auth event is triggered. ( #7791 )
2019-06-21 21:57:49 +03:00
Robin Ward
02f6db4e59
FIX: Back button shenanigans when redirecting from `index` routes
...
This is a problem that has long plagued Discourse. The root issue here
is that we have to implement our own link click handler, because
Discourse allows users to create HTML blobs of content with links, and
when those links are clicked they must be handled by the Ember router.
This always involved a certain amount of use of private Ember APIs which
of course evolved over time.
The API has more or less stabilized in the last two years, however we
have hacks in our URLs to handle a dynamic root path, depending on how
forums have set up their filters and in what order.
This patch adds a special case for the root path so we needn't update
the URL ourselves otherwise, which preserves the back button on index
routes. The update call would otherwise insert an extra history event if
a route redirected on transition, breaking the back button.
2019-06-21 14:42:01 -04:00
Penar Musaraj
e51de4cc25
FEATURE: Add endpoint to individually update a theme setting ( #7789 )
...
- also adds a new staff action type called "change theme setting" for easier logging of staff changes to theme settings
2019-06-21 13:49:14 -04:00
Arpit Jalan
2738d11f60
UX: show like icon on archived posts ( #7775 )
2019-06-21 20:47:32 +05:30
Joffrey JAFFEUX
1cbe2dd2ce
DEV: adds polyfill to fully support DOMTokenList in IE ( #7765 )
2019-06-21 09:59:28 +02:00
Guo Xiang Tan
7c86f16aa3
FIX: Support carriage return in `InlineUploads`.
...
Follow up to 8deaef3872
.
2019-06-21 14:07:06 +08:00
Guo Xiang Tan
8deaef3872
FIX: Don't replace img tags within anchor tags with markdown format.
...
Follow up to 9a25b0d614
.
2019-06-21 12:32:02 +08:00
Guo Xiang Tan
9a25b0d614
FIX: Edge case with anchor tag in `InlineUploads`.
2019-06-21 09:55:56 +08:00
Robin Ward
fc026e12a5
FIX: Some toolbar operations weren't triggering the `change` event
...
This would mean that some simple edits to queued posts did not get
saved.
2019-06-20 13:35:12 -04:00
Penar Musaraj
0e26c57afa
FIX: Do not refresh all settings on save for all settings, limit to only a few
...
- Followup to 0e303c7f5d
- Automatically reloads site settings after saving only for the logo, logo_small and large_icon settings.
2019-06-20 10:57:31 -04:00
Vinoth Kannan
56b7777705
FIX: 'status' param change not filtering the topics in tag route.
...
Use existing 'filterQueryParams' helper method to set 'queryParams' value for tag route.
2019-06-20 17:27:32 +05:30
Guo Xiang Tan
53efb7bd24
FIX: BBcode edge case for `InlineUploads`.
2019-06-20 11:47:51 +08:00
Penar Musaraj
f096c994de
FIX: use correct name for selectable_avatars_enabled site setting
2019-06-19 13:18:16 -04:00
Guo Xiang Tan
34f382b758
FIX: `InlineUploads` should replace attachment links with markdown text.
2019-06-19 11:15:02 +08:00
Guo Xiang Tan
73a45048a0
FIX: `Upload#short_url` generates incorrect URL when extension is `nil`.
2019-06-19 09:10:50 +08:00
Robin Ward
6fec4982d9
FIX: Couldn't modify a widget that wasn't in the registry
2019-06-18 12:28:18 -04:00
Sam Saffron
03ba1d49fb
DEV: lint file
...
We no longer need that isAppleDevice require
2019-06-18 17:12:55 +10:00
Maja Komel
506de13896
FIX: remove temporary hack for fixed iOS bug ( #7773 )
...
A bug where input focus is displaced on modals was fixed in iOS 11.3 update. This hack was causing problems on topic page since hiding main-outlet results in lost read position after opening and closing a modal.
2019-06-18 16:25:29 +10:00
Jeff Wong
893b50031d
replace subfolder on cdn url conversion between general cdn and s3 ( #7764 )
...
When both a cdn URL and an s3 cdn URL defined, subfolder paths were leaking
through to the s3 cdn URL. If we are replacing the cdn url with the s3_cdn url,
we also need to make sure that the subpath is removed as well, as it appears in
the original cdn url.
The test should give a fairly good gist of the situations - in subfolder
situations where s3_cdn and a cdn is defined:
`asset_path` returns the asset with a subfolder, in the form `{cdn_url}/{subfolder}/{asset_path}`
Currently this is being replaced to `{s3_cdn_url}/{subfolder}/{asset_path}`
I am proposing we change this to: `{s3_cdn_url}/{asset_path}` as it seems like
for s3_cdn urls we should not be carrying around app subfolder pathing anywhere
we are looking up s3 paths.
2019-06-17 11:51:17 -07:00
David Taylor
e6e47f2fb2
SECURITY: Add confirmation screen when logging in via user-api OTP
2019-06-17 16:18:44 +01:00
David Taylor
52387be4a4
SECURITY: Add confirmation screen when logging in via email link
2019-06-17 16:18:37 +01:00
David Taylor
5f6f707080
Revert "Merge pull request from GHSA-hv9p-jfm4-gpr9"
...
This reverts commit b8340c6c8e
.
2019-06-17 16:17:10 +01:00
David Taylor
b8340c6c8e
Merge pull request from GHSA-hv9p-jfm4-gpr9
...
* SECURITY: Add confirmation screen when logging in via email link
* SECURITY: Add confirmation screen when logging in via user-api OTP
* FIX: Correct translation key in session controller specs
* FIX: Use .email-login class for page
2019-06-17 15:59:41 +01:00
Arpit Jalan
863d8014d0
FIX: respond with 400 error on invalid redirect param
2019-06-17 16:44:30 +05:30
Arpit Jalan
102be5a9e3
DEV: optimize fix for sub-categories not getting pre-filled.
2019-06-17 13:28:08 +05:30
tshenry
c909033f2b
Add plugin outlets to login/create-account modals ( #7770 )
2019-06-17 16:22:00 +10:00
Sam Saffron
704c579550
FIX: do not allow unbound membership lookups
...
Previously we would allow looking up membership limits in an unbound way
via the API, this introduces an upper limit of 1000 per page.
2019-06-17 15:32:06 +10:00
Sam Saffron
fe4f0a4369
FIX: staged users should not be included in TL groups
...
staged users should not be included in any automatic groups cause for all
purposes they do not exist.
2019-06-17 15:10:47 +10:00
Arpit Jalan
48b9e0d749
FIX: sub-categories was not getting selected for pre-filled topics
2019-06-15 13:46:15 +05:30
Kris
9cb656250d
FIX: Allow tall tables to scroll vertically on iOS
2019-06-14 14:26:59 -04:00