6fa836d781
FIX: prevent popup when thread count request fails ( #25308 )
...
On the rare occasions that an ajax request for thread count fails, we should fail silently without alerting the user.
2024-01-18 16:28:23 +08:00
fb087b7ff6
DEV: Convert min_trust_to_post_links to groups ( #25298 )
...
We're changing the implementation of trust levels to use groups. Part of this is to have site settings that reference trust levels use groups instead. It converts the min_trust_to_post_links site setting to post_links_allowed_groups.
This isn't used by any of our plugins or themes, so very little fallout.
2024-01-18 14:08:40 +08:00
20c5f7aef8
PERF: Avoid loading the whole record when we only need id ( #25301 )
2024-01-18 08:50:26 +08:00
26698ff52a
Build(deps): Bump terser from 5.26.0 to 5.27.0 in /app/assets/javascripts ( #25306 )
...
* Build(deps): Bump terser in /app/assets/javascripts
Bumps [terser](https://github.com/terser/terser ) from 5.26.0 to 5.27.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.26.0...v5.27.0 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-18 01:14:30 +01:00
89eae4c6e3
DEV: add anonymousOnly opt to registerTopicFooterButton ( #25293 )
...
Adds support to `anonymousOnly` as an option when using `registerTopicFooterButton`, rendering the buttons accordingly.
2024-01-17 21:10:42 -03:00
e3f0c8682a
Build(deps-dev): Bump rubocop from 1.60.0 to 1.60.1 ( #25305 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.60.0 to 1.60.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.60.0...v1.60.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-17 22:26:40 +01:00
1a8cf92be1
DEV: Update `reply_to_user_id` after bulk imports ( #25289 )
2024-01-17 20:47:01 +01:00
6a205ea0a5
DEV: Replace lazy_load_categories site setting ( #25302 )
...
The site setting has been removed in a previous commit abad38c
2024-01-17 21:44:48 +02:00
abad38c2e7
DEV: Make lazy_load_categories setting use groups ( #25282 )
...
This allows certain users to test the new feature and avoid disruptions
in other's workflows.
2024-01-17 20:26:51 +02:00
719956f255
FIX: Allow staff to change group members visibility level for automatic groups ( #25281 )
2024-01-17 12:54:52 -05:00
4cfc0e231a
DEV: Change categories#index loading strategy ( #25232 )
...
The old strategy used to load 25 categories at a time, including the
subcategories. The new strategy loads 20 parent categories and at most
5 subcategories for each parent category, for a maximum of 120
categories in total.
2024-01-17 17:18:01 +02:00
ec1905cf6f
FIX: "Action Logs" button on user admin page ( #25300 )
...
The `transitionToRoute` API was removed in Ember 5 in favour of the route service
2024-01-17 13:49:59 +00:00
f2e669a008
DEV: add system test for topic map ( #25242 )
...
* DEV: add system test for topic map
2024-01-17 19:25:18 +08:00
62f423da15
DEV: Redesign chat mentions ( #24752 )
...
At the moment, when someone is mentioning a group, or using here or
all mention, we create a chat_mention record per user. What we want
instead is to have special kinds of mentions, so we can create only one
chat_mention record in such cases. This PR implements that.
Note, that such mentions will still have N related notifications, one
notification per a user. We don't expect we'll have performance
problems on the notifications side, but if at some point we do, we
should be able to solve them on the side of notifications
(notifications are handled in jobs, also some little delays with
the notifications are acceptable, so we can make sure notifications
are properly queued, and that processing of every notification is
fast enough to make delays small enough).
The preparation work for this PR was done in fbd24fa
2024-01-17 15:24:01 +04:00
6876c52857
FIX: set channels tab as default on mobile chat footer ( #25296 )
...
This change moves the "Channels" tab to first position in the chat footer nav, and loads it as the default page when opening chat for the first time on mobile.
2024-01-17 17:12:55 +08:00
c91bd3ca07
UX: hide draft post notice on mobile chat ( #25297 )
2024-01-17 16:45:25 +08:00
df8bb947b2
FEATURE: improvements to hot algorithm ( #25295 )
...
- Decrease gravity, we come in too hot prioritizing too many new topics
- Remove all muted topics / categories and tags from the hot list
- Punish topics with zero likes in algorithm
2024-01-17 16:12:03 +11:00
54e6c1d823
DEV: Allow test-prof to be disabled completely with `PREFABRICATION` env ( #25294 )
...
Why this change?
We have been looking into a flaky system tests in one of our plugins
where the DB transaction flow can be messed up from time to time. Our
debugging effort is complicated by that fact that `test-prof` starts a
DB transaction in a `before(:all)` block which makes it hard to properly
log information. By allowing test-prof to be disabled completely, we
believe it will make it easier for us to isolate the problem we are
investigating.
What does this change do?
1. Avoid loading test-prof files if `PREFABRICATION` env has been set to
`0`.
2. Set `PREFABRICATION=0` for plugin system tests in Github actions
2024-01-17 11:00:32 +08:00
ebd3971533
FEATURE: experiment with hot sort order ( #25274 )
...
This introduces a new experimental hot sort ordering.
It attempts to float top conversations by first prioritizing a topics with lots of recent activity (likes and users responding)
The schedule that updates hot topics is disabled unless the hidden site setting: `experimental_hot_topics` is enabled.
You can control "decay" with `hot_topic_gravity` and `recency` with `hot_topics_recent_days`
Data is stored in the new `topic_hot_scores` table and you can check it out on the `/hot` route once
enabled.
---------
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2024-01-17 13:01:04 +11:00
1a752148a9
Build(deps-dev): Bump imports-loader from 4.0.1 to 5.0.0 in /app/assets/javascripts ( #25288 )
...
* Build(deps-dev): Bump imports-loader in /app/assets/javascripts
Bumps [imports-loader](https://github.com/webpack-contrib/imports-loader ) from 4.0.1 to 5.0.0.
- [Release notes](https://github.com/webpack-contrib/imports-loader/releases )
- [Changelog](https://github.com/webpack-contrib/imports-loader/blob/master/CHANGELOG.md )
- [Commits](https://github.com/webpack-contrib/imports-loader/compare/v4.0.1...v5.0.0 )
---
updated-dependencies:
- dependency-name: imports-loader
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-16 23:44:00 +01:00
f5b29f9189
Build(deps-dev): Bump the types group in /app/assets/javascripts with 20 updates ( #25287 )
...
* Build(deps-dev): Bump the types group
Bumps the types group in /app/assets/javascripts with 20 updates:
| Package | From | To |
| --- | --- | --- |
| [@types/ember](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember ) | `4.0.10` | `4.0.11` |
| [@types/ember__application](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__application ) | `4.0.10` | `4.0.11` |
| [@types/ember__array](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__array ) | `4.0.9` | `4.0.10` |
| [@types/ember__component](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__component ) | `4.0.21` | `4.0.22` |
| [@types/ember__controller](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__controller ) | `4.0.11` | `4.0.12` |
| [@types/ember__debug](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__debug ) | `4.0.7` | `4.0.8` |
| [@types/ember__destroyable](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__destroyable ) | `4.0.4` | `4.0.5` |
| [@types/ember__engine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__engine ) | `4.0.10` | `4.0.11` |
| [@types/ember__error](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__error ) | `4.0.5` | `4.0.6` |
| [@types/ember__object](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__object ) | `4.0.11` | `4.0.12` |
| [@types/ember__polyfills](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__polyfills ) | `4.0.5` | `4.0.6` |
| [@types/ember__routing](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__routing ) | `4.0.19` | `4.0.20` |
| [@types/ember__runloop](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__runloop ) | `4.0.8` | `4.0.9` |
| [@types/ember__service](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__service ) | `4.0.8` | `4.0.9` |
| [@types/ember__string](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__string ) | `3.0.13` | `3.0.14` |
| [@types/ember__template](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__template ) | `4.0.5` | `4.0.6` |
| [@types/ember__test](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__test ) | `4.0.5` | `4.0.6` |
| [@types/ember__utils](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ember__utils ) | `4.0.6` | `4.0.7` |
| [@types/qunit](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/qunit ) | `2.19.9` | `2.19.10` |
| [@types/rsvp](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/rsvp ) | `4.0.8` | `4.0.9` |
Updates `@types/ember` from 4.0.10 to 4.0.11
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember )
Updates `@types/ember__application` from 4.0.10 to 4.0.11
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__application )
Updates `@types/ember__array` from 4.0.9 to 4.0.10
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__array )
Updates `@types/ember__component` from 4.0.21 to 4.0.22
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__component )
Updates `@types/ember__controller` from 4.0.11 to 4.0.12
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__controller )
Updates `@types/ember__debug` from 4.0.7 to 4.0.8
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__debug )
Updates `@types/ember__destroyable` from 4.0.4 to 4.0.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__destroyable )
Updates `@types/ember__engine` from 4.0.10 to 4.0.11
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__engine )
Updates `@types/ember__error` from 4.0.5 to 4.0.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__error )
Updates `@types/ember__object` from 4.0.11 to 4.0.12
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__object )
Updates `@types/ember__polyfills` from 4.0.5 to 4.0.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__polyfills )
Updates `@types/ember__routing` from 4.0.19 to 4.0.20
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Changelog](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ember__routing/history-location.d.ts )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__routing )
Updates `@types/ember__runloop` from 4.0.8 to 4.0.9
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__runloop )
Updates `@types/ember__service` from 4.0.8 to 4.0.9
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__service )
Updates `@types/ember__string` from 3.0.13 to 3.0.14
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__string )
Updates `@types/ember__template` from 4.0.5 to 4.0.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__template )
Updates `@types/ember__test` from 4.0.5 to 4.0.6
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__test )
Updates `@types/ember__utils` from 4.0.6 to 4.0.7
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ember__utils )
Updates `@types/qunit` from 2.19.9 to 2.19.10
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/qunit )
Updates `@types/rsvp` from 4.0.8 to 4.0.9
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/rsvp )
---
updated-dependencies:
- dependency-name: "@types/ember"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__application"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__array"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__component"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__controller"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__debug"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__destroyable"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__engine"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__error"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__object"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__polyfills"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__routing"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__runloop"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__service"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__string"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__template"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__test"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/ember__utils"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/qunit"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
- dependency-name: "@types/rsvp"
dependency-type: direct:development
update-type: version-update:semver-patch
dependency-group: types
...
Signed-off-by: dependabot[bot] <support@github.com>
* Update lockfiles for ember version flag
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
2024-01-16 23:43:19 +01:00
aabecabbd9
Build(deps): Bump image_size from 3.3.0 to 3.4.0 ( #25286 )
...
Bumps [image_size](https://github.com/toy/image_size ) from 3.3.0 to 3.4.0.
- [Changelog](https://github.com/toy/image_size/blob/main/CHANGELOG.markdown )
- [Commits](https://github.com/toy/image_size/compare/v3.3.0...v3.4.0 )
---
updated-dependencies:
- dependency-name: image_size
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-16 23:42:31 +01:00
ce04d800a5
Build(deps-dev): Bump bullet from 7.1.5 to 7.1.6 ( #25283 )
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.1.5 to 7.1.6.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.1.5...7.1.6 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-16 22:43:47 +01:00
949457266c
Build(deps): Bump logster from 2.13.1 to 2.14.0 ( #25285 )
...
Bumps [logster](https://github.com/discourse/logster ) from 2.13.1 to 2.14.0.
- [Changelog](https://github.com/discourse/logster/blob/main/CHANGELOG.md )
- [Commits](https://github.com/discourse/logster/compare/v2.13.1...v2.14.0 )
---
updated-dependencies:
- dependency-name: logster
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-16 22:43:25 +01:00
1fcd5fe90f
Build(deps): Bump concurrent-ruby from 1.2.2 to 1.2.3 ( #25284 )
...
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby ) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases )
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.2.2...v1.2.3 )
---
updated-dependencies:
- dependency-name: concurrent-ruby
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-16 22:42:55 +01:00
d7a341c965
DEV: Add site setting for Discourse Discover ( #25266 )
2024-01-16 13:39:25 -05:00
1f81e8d857
DEV: Add 'i18n' label to PRs which include changes related to i18n
2024-01-16 15:00:19 +01:00
49916b0a0c
DEV: Don't run 'labeler' GitHub Action for translator-bot
...
It's not needed and confusing when PRs created by discourse-translator-bot have the "chat" label.
2024-01-16 15:00:19 +01:00
50f8a51923
Update translations ( #25278 )
2024-01-16 14:54:32 +01:00
44ff62aa12
PERF: Skip validations when hotlinked images are replaced in posts
...
They are not necessary and slow down rebakes.
2024-01-16 14:35:24 +01:00
241bf48497
DEV: Allow rebakes to generate optimized images at the same time
...
Previously only Sidekiq was allowed to generate more than one optimized image at the same time per machine. This adds an easy mechanism to allow the same in rake tasks and other tools.
2024-01-16 14:33:16 +01:00
bcb8b3fab9
REFACTOR: Reuse `Discourse.store` instance
...
Calling `Discourse.store` creates a new instance of a store each time.
2024-01-16 14:33:16 +01:00
a8330222f9
FIX: correctly support safe-area-inset-bottom in footer ( #25276 )
2024-01-16 11:12:36 +01:00
4512e5652f
FEATURE: Mobile Chat Footer Redesign ( #25161 )
...
This update adds three tabs to the bottom of the chat overlay to make it easier for users to navigate chat on mobile.
As a result of this change:
- Direct Messages are now shown separately from public channels on mobile
- My Threads has now moved from the channel list to it's own tab on mobile
- My Threads can still be accessed on desktop via the sidebar and within the drawer channel list
- Chat back button has been updated to navigate to the correct tab (for both channels and threads)
Some special cases:
- If DMs are not used then the tab is not rendered
- If the user has no threads then the tab is not rendered
- If both the tabs for DMs and Threads aren't available then the whole footer will not be rendered
- Chat footer is only shown on the listing pages (DMs, Channels, My Threads)
---------
Co-authored-by: chapoi <101828855+chapoi@users.noreply.github.com>
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
2024-01-16 14:29:33 +08:00
1e57fed3b9
FIX: Use category hashtag instead of link in guidelines_topic.body ( #25253 )
...
* FIX: Use category hashtag instead of link in guidelines_topic.body
2024-01-16 15:22:29 +11:00
7b907ec50a
DEV: Fix flaky table builder system spec ( #25272 )
...
Why this change?
The `Table Builder when editing a table when cancelling table creation should close the modal if there are no changes made` system
test in `spec/system/table_builder_spec.rb` was flaky. It turns out that
when the modal is opened, we have to load some JS/CSS files. While that
is happening, the modal is actually not functional and clicking stuff
in the footer can actually result in an error. In this case, the
`interceptCloseModal` calls the private `_hasChanges` function which
then calls `this.spreadsheet.getHeaders()`. When stuff is still loading,
`this.spreadsheet` has not been set. As a result we get the following
error:
```
Cannot read properties of null (reading 'getHeaders')
```
What does this change do?
Why stuff is loading, we will now hide the footer in the modal.
2024-01-16 10:48:49 +08:00
c33a8d658b
DEV: Avoid duplicating constant between client and server ( #25179 )
...
Why this change?
While the constant does not change very often, we should still avoid
duplicating the value of a constant used on the server side in the
client side to avoid the values going out of sync.
2024-01-16 09:50:55 +08:00
22614ca85b
DEV: Compile theme migrations javascript files when running theme qunit ( #25219 )
...
Why this change?
Currently, is it hard to iteratively write a theme settings migrations
because our theme migrations system does not rollback. Therefore, we
want to allow theme developers to be able to write QUnit tests for their
theme migrations files enabling them to iteratively write their theme
migrations.
What does this change do?
1. Update `Theme#baked_js_tests_with_digest` to include all `ThemeField`
records of `ThemeField#target` equal to `migrations`. Note that we do
not include the `settings` and `themePrefix` variables for migration files.
2. Don't minify JavaScript test files becasue it makes debugging in
development hard.
2024-01-16 09:50:44 +08:00
fd7c6f1ca8
Build(deps): Bump stackprof from 0.2.25 to 0.2.26 ( #25269 )
...
Bumps [stackprof](https://github.com/tmm1/stackprof ) from 0.2.25 to 0.2.26.
- [Changelog](https://github.com/tmm1/stackprof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/tmm1/stackprof/compare/v0.2.25...v0.2.26 )
---
updated-dependencies:
- dependency-name: stackprof
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-15 23:01:27 +01:00
6d9029249a
Build(deps-dev): Bump rubocop from 1.59.0 to 1.60.0 ( #25267 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.59.0 to 1.60.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.59.0...v1.60.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-15 23:00:00 +01:00
086f3b1297
Build(deps-dev): Bump parser from 3.3.0.3 to 3.3.0.4 ( #25268 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 3.3.0.3 to 3.3.0.4.
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v3.3.0.3...v3.3.0.4 )
---
updated-dependencies:
- dependency-name: parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-15 22:58:01 +01:00
a562214f56
FIX: Update global rate limiter keys/messages to clarify user vs ip ( #25264 )
2024-01-15 19:54:50 +00:00
59c2407e18
FEATURE: add username header to global-rate-limited responses ( #25265 )
...
This will make it easier to analyze rate limiting in reverse-proxy logs. To make this possible without a database lookup, we add the username to the encrypted `_t` cookie data.
2024-01-15 19:50:37 +00:00
f631eb5799
FIX: Trigger search app event being triggered multiple times ( #25250 )
2024-01-15 09:47:40 -08:00
f2cf5434f3
Revert "DEV: Convert min_trust_level_to_tag_topics to groups ( #25258 )" ( #25262 )
...
This reverts commit c7e3d27624
2024-01-15 11:33:47 -05:00
d5f527ee37
UX: show the SSO options when creating an account on mobile ( #25260 )
2024-01-15 16:36:00 +01:00
c177c198c5
DEV: update .gitignore file ( #25261 )
2024-01-15 19:42:37 +05:30
c7e3d27624
DEV: Convert min_trust_level_to_tag_topics to groups ( #25258 )
...
We're changing the implementation of trust levels to use groups. Part of this is to have site settings that reference trust levels use groups instead. It converts the min_trust_level_to_tag_topics site setting to tag_topic_allowed_groups.
2024-01-15 20:59:08 +08:00
d0486a72ac
FIX: use getter and setter for computed properties ( #25259 )
2024-01-15 15:04:28 +05:30
60a4d09f1a
UX: Chat composer dropdown styling mobile ( #25244 )
2024-01-15 09:59:24 +01:00
David Battersby
Ted Johansson
Andrei Prigorshnev
dependabot[bot]
Renato Atilio
Gerhard Schlager
Bianca Nenciu
Penar Musaraj
David Taylor
Kelv
Sam
Alan Guo Xiang Tan
Discourse Translator Bot
Joffrey JAFFEUX
Tomas Vavrda
Keegan George
chapoi
Arpit Jalan