8fec1a412b
PERF: Eager load linkables when loading custom sidebar sections ( #20490 )
...
Not eager loading was resulting in the N+1 queries problem when
serializing with the `CurrentUserSerializer` as
`CurrentUserSerializer#sidebar_sections` serializes the sections with
`SidebarSectionSerializer` which fetches all the `SidebarUrl` records
for each `SidebarSection` record.
2023-03-01 07:39:35 +08:00
654959faa4
DEV: reduce amount of errors logged when notifying on flags ( #20472 )
...
Forcing distributed muted to raise when a notify reviewable job is running
leads to excessive errors in the logs under many conditions.
The new pattern
1. Optimises the counting of reviewables so it is a lot faster
2. Holds the distributed lock for 2 minutes (max)
The downside is the job queue can get blocked up when tons of notify
reviewables are running at the same time. However this should be very
rare in the real world, as we only notify when stuff is flagged which
is fairly infrequent.
This also give a fair bit more time for the notifications which may be
a little slow on large sites with tons of mods.
2023-03-01 08:58:32 +11:00
def4133d59
DEV: Move `form_template_ids` serializer location ( #20446 )
2023-02-28 09:09:20 -08:00
366f5e08d7
FIX: Copy & Fullscreen button edits in codeblocks ( #20483 )
2023-02-28 10:54:24 -06:00
0fbe26c15f
Add a plugin outlet `admin-users-list-show-before` ( #20477 )
2023-02-28 19:16:40 +05:30
ccb345bd88
FEATURE: Update topic/comment embedding parameters ( #20181 )
...
This commit implements many changes to topic and comments embedding. It
deprecates the class_name field from EmbeddableHost and suggests using
the className parameter. discourse_username parameter has been
deprecated and it will fetch it from embedded site from the author or
discourse-username meta.
See the updated code sample from Admin > Customize > Embedding page.
* FEATURE: Add className parameter for Discourse embed
* DEV: Hide class_name from EmbeddableHost
* DEV: Deprecate class_name field of EmbeddableHost
* FEATURE: Use either author or discourse-username meta tag
* DEV: Deprecate discourse_username parameter
* DEV: Improve embed code sample
2023-02-28 14:31:59 +02:00
42b451ef8a
FIX: autocomplete failing for :( ( #20461 )
...
Composer was not completing :( (sad face) correctly given guessing of term
was not allowing for special chars.
New algorithm allows everything but space.
see: https://meta.discourse.org/t/some-emojis-added-with-enter-immediately-following-a-quote-will-break-the-quote/256219
2023-02-28 11:35:19 +11:00
451ee71930
FEATURE: Add API scope for listing topics in a category ( #20471 )
...
Adding an api scope for `/c/{slug}/{id}.json`. Without this you had to
append `/l/latest` to the url in order for it to work with existing
scopes.
2023-02-27 16:21:39 -07:00
c81d4f60af
UX: Fix large onebox avatars in img chat messages ( #20469 )
...
When you included an image and a full-line (github) onebox in a single message the user avatar in the inbox would be incorrectly embiggened.
2023-02-27 23:03:02 +01:00
6a86288c5e
Build(deps): Bump minimist in /app/assets/javascripts ( #20468 )
...
Bumps [minimist](https://github.com/minimistjs/minimist ) from 0.2.1 to 0.2.4.
- [Release notes](https://github.com/minimistjs/minimist/releases )
- [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md )
- [Commits](https://github.com/minimistjs/minimist/compare/v0.2.1...v0.2.4 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-27 18:43:45 +01:00
116781c748
DEV: Update ember-cli-htmlbars to 6.2.0 ( #20467 )
...
* Build(deps): Bump ember-cli-htmlbars in /app/assets/javascripts
Bumps [ember-cli-htmlbars](https://github.com/ember-cli/ember-cli-htmlbars ) from 6.1.1 to 6.2.0.
- [Release notes](https://github.com/ember-cli/ember-cli-htmlbars/releases )
- [Changelog](https://github.com/ember-cli/ember-cli-htmlbars/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ember-cli/ember-cli-htmlbars/compare/v6.1.1...v6.2.0 )
---
updated-dependencies:
- dependency-name: ember-cli-htmlbars
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Load additional files
* Update code
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-27 18:43:28 +01:00
a509441148
DEV: Include unread topics in New topic lists and link to it in sidebar ( #20432 )
...
This commit introduces a few experimental changes to the New topics list and "Everything" link in the sidebar:
1. Make the New topics list include unread topics
2. Make the Everything section in the sidebar link to the New topics list (`/new`)
3. Remove "unread" or "new" text next to the count and keep the count
4. The count is a sum of new and unread topics counts
All of these of changes are behind an off-by-default feature flag. I've not written extensive tests for these changes because they're highly experimental.
Internal topic: t/77234.
2023-02-27 15:11:01 +03:00
badd40090f
DEV: Clean up `d-modal` ( #20443 )
2023-02-27 13:06:06 +01:00
e82b8c2b06
DEV: Resolve and unsilence ember string prototype deprecation ( #20448 )
2023-02-27 10:27:32 +00:00
486797bbfc
Build(deps): Bump ember-qunit in /app/assets/javascripts ( #20458 )
...
Bumps [ember-qunit](https://github.com/emberjs/ember-qunit ) from 6.1.1 to 6.2.0.
- [Release notes](https://github.com/emberjs/ember-qunit/releases )
- [Changelog](https://github.com/emberjs/ember-qunit/blob/master/CHANGELOG.md )
- [Commits](https://github.com/emberjs/ember-qunit/compare/v6.1.1...v6.2.0 )
---
updated-dependencies:
- dependency-name: ember-qunit
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-27 11:08:06 +01:00
d0237f63ce
Build(deps): Bump eslint in /app/assets/javascripts ( #20459 )
...
Bumps [eslint](https://github.com/eslint/eslint ) from 8.34.0 to 8.35.0.
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v8.34.0...v8.35.0 )
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-27 11:07:33 +01:00
d92fd30d23
FIX: do not escape slash for category text description ( #20460 )
...
Original solution to use `description` instead of `text_description` was wrong: https://github.com/discourse/discourse/pull/20436
Problem is that we have to escape HTML tags.
However, we would like to use escape method which is keep `/` intact. Expected behavior is given by ERB::Util.html_escape instead of Rack::Utils.escape_html
/t/92015
2023-02-27 12:48:48 +11:00
52d4de7b45
DEV: fix a linting issue ( #20453 )
2023-02-26 01:52:19 +04:00
9c669f3bdc
Fix typo ( #20452 )
...
Remove extraneous `>` from Views section
2023-02-25 11:50:39 +00:00
720cf7c424
DEV: Add classes to user profile's collapsed-info-panel ( #20451 )
...
Some of the dt and dd elements already included classes (e.g. invited-by and groups). This simply makes things consistent by adding classes to the other dt and dd elements and should allow for easier customization.
2023-02-24 15:37:38 -08:00
90ed30b3ff
UX: fix tag & category clicks on mobile topic list ( #20449 )
2023-02-24 15:29:57 -05:00
d3983d94a3
UX: only allow scroll grab if nav is scrollable ( #20447 )
2023-02-24 14:25:38 -05:00
5a384e60ac
DEV: Clean up `showModal()` calls ( #20442 )
2023-02-24 15:53:04 +01:00
d5cf128dbd
DEV: Fix an error in topic deletion ( #20440 )
...
Spotted as log entry in tests:
```
TypeError: Cannot read properties of undefined (reading 'force_destroy')
```
2023-02-24 13:48:08 +01:00
04659b0e41
DEV: Fix decorator deprecations ( #20438 )
...
…and correctly fix the decorateCookedElement id arg
2023-02-24 10:50:52 +01:00
1dca7b8b0a
FIX: Correct issues in admin-embeddable-host ( #20439 )
...
Classic Component arguments are not available in the constructor. Switch back to using `init()` for this component
Followup to a433b30650
2023-02-24 09:44:50 +00:00
4cadad9a53
FIX: Correct issues in admin-styles-editor ( #20435 ) ( #20437 )
...
The save action clashed with the save component argument
Followup to a433b30650
2023-02-24 09:34:56 +00:00
ba5e0924db
Build(deps): Bump terser in /app/assets/javascripts ( #20434 )
...
Bumps [terser](https://github.com/terser/terser ) from 5.16.4 to 5.16.5.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v5.16.4...v5.16.5 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-24 10:13:43 +01:00
f9150bc701
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #20433 )
...
Bumps [@babel/standalone](https://github.com/babel/babel/tree/HEAD/packages/babel-standalone ) from 7.21.1 to 7.21.2.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.2/packages/babel-standalone )
---
updated-dependencies:
- dependency-name: "@babel/standalone"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-24 10:13:29 +01:00
9fb5bfd93d
FIX: use category description for sidebar link title ( #20436 )
...
Value in `description_text` is escaped. We would like to display `/` properly in link title.
2023-02-24 16:11:45 +11:00
ad0fd9919b
FIX: Correct issues in admin-theme-editor ( #20435 )
...
Followup to a433b30650
2023-02-23 23:03:27 +00:00
c052df412a
DEV: Add support for aliases in HighlightJS languages ( #20380 )
...
We were only supporting the main name of each HighlightJS language. So, by default, you could not use `js` or `jsx` to highlight Javascript, given they are aliases for `javascript`.
This PR adds a list of aliases as a constant to core (built via a rake task), and then checks against the `highlighted_languages` site settings plus the list of aliases when processing a code block.
2023-02-23 15:06:06 -05:00
6108eee31d
DEV: Apply form template to categories ( #20337 )
2023-02-23 11:18:14 -08:00
a9f2c6db64
SECURITY: Show only visible tags in metadata
...
Currently, the topic metadata show both public and private
tags whereas only visible ones should be exposed.
2023-02-23 17:22:20 +01:00
5dbdcb3f23
FEATURE: Adding some more api scopes ( #20420 )
...
Adds api scopes for
- deleting a topic
- deleting a post
- listing tags
2023-02-23 08:33:29 -07:00
a433b30650
DEV: Convert admin component definitions to native class syntax ( #20311 )
...
This conversion was achieved using the ember-native-class-codemod, plus a handful of manual fixes/tweaks
2023-02-23 15:32:53 +00:00
a0ca10fa17
FIX: Make sure regular users can delete their PMs ( #20424 )
...
Regular users should be redirected to the homepage after the topic is
no longer accessible by them (only staff members can view deleted
topics). There was a problem with permission checking for category
moderators which stopped the redirect from happening.
2023-02-23 16:39:51 +02:00
925a7bd48b
DEV: Port sidebar mobile view acceptance tests to system tests ( #20421 )
...
The acceptance tests are flaky so I've decided to port them to system
test which makes them easier to work with and reason about.
2023-02-23 15:01:39 +08:00
da43b60510
Update period-title.js ( #20422 )
...
(A petty but important typography fix)
Use en dash (–) instead of hyphen (-) for ranges (including dates)
For example — 1–2, May–June, 1:00pm–2:00pm
A space in before and after the dash is usually not present in writing but for user interfaces can be stylistic choice. (The space is left unchanged here.)
References
- https://learn.microsoft.com/en-us/style-guide/punctuation/dashes-hyphens/enes
- https://www.thepunctuationguide.com/en-dash.html
2023-02-23 15:00:41 +08:00
0a619d8c88
FIX: Fast edit doesn’t work on content with certain characters ( #20410 )
...
Small js fix for fast edit to allow posts to save changes when the post contains apostrophes and quotation marks. Replaces unicode characters in text prior to saving the edit.
Includes system tests for fast edit and introduces a new system spec component for fast edit usage.
2023-02-23 11:30:16 +08:00
576745637e
DEV: Remove `redesigned_user_page_nav_enabled` property ( #20409 )
...
This commit removes all references to the
`redesigned_user_page_nav_enabled` which was used as a feature flag for
developing the new user profile navigation menu previously.
2023-02-23 10:35:02 +08:00
ab46a05d77
UX: User badges tweaks ( #20408 )
...
* UX: fix standalone badge padding
* UX: badge number formatting
* UX: copy
* DEV: Add LinkTo for the admin-badges/show count text
* UX: user badge awarded style update
---------
Co-authored-by: Martin Brennan <martin@discourse.org>
2023-02-23 03:21:26 +01:00
64d1192bff
Build(deps): Bump ember-auto-import in /app/assets/javascripts ( #20419 )
...
Bumps [ember-auto-import](https://github.com/ef4/ember-auto-import/tree/HEAD/packages/ember-auto-import ) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/ef4/ember-auto-import/releases )
- [Changelog](https://github.com/ef4/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md )
- [Commits](https://github.com/ef4/ember-auto-import/commits/v2.6.1/packages/ember-auto-import )
---
updated-dependencies:
- dependency-name: ember-auto-import
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-22 23:38:32 +01:00
f03186dc79
DEV: Rename glimmer-topic-timeline -> topic-timeline ( #20395 )
2023-02-22 15:55:23 -06:00
51a7cd899e
FEATURE: Add API scopes for group endpoints ( #20401 )
...
Added two new api scopes for managing and administering groups.
See https://meta.discourse.org/t/249710
2023-02-22 09:06:49 -07:00
8d2fa1c184
DEV: Add native class shims for `on`/`observes` decorators
2023-02-22 09:32:48 +00:00
89c6296638
DEV: Introduce ember-decorators addon
...
This provides Classic Component decorators for use with native class syntax (e.g. `@tagName`), and also provides native-class-compatible decorators for `@on` and `@observes`.
2023-02-22 09:32:48 +00:00
e9ef4900ca
DEV: Correct test waiter for requestAnimationFrame ( #20413 )
...
Followup to 207c0dd88c
2023-02-22 09:29:49 +00:00
cf0c73d1b7
DEV: Silence discourse.custom_html_template in its own test ( #20414 )
2023-02-22 09:29:36 +00:00
64cf7e444b
DEV: Remove use of deprecated prop from user notifications templates ( #20404 )
...
The redesigned_user_page_nav_enabled property has been deprecated and will be dropped from Discourse core soon.
2023-02-22 13:56:08 +08:00
Alan Guo Xiang Tan
Sam
Keegan George
Jordan Vidrine
Arpit Jalan
Bianca Nenciu
Blake Erickson
Jarek Radosz
dependabot[bot]
Osama Sayegh
David Taylor
Krzysztof Kotlarek
Andrei Prigorshnev
TheJammiestDodger
tshenry
Kris
Penar Musaraj
Loïc Guitaut
carsick
David Battersby
chapoi
Isaac Janzen