Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
52,110 Commits 260 Branches 502 Tags 935 MiB
Commit Graph

52110 Commits

Author SHA1 Message Date
Martin Brennan 9057272ee2
FIX: Use Guardian.basic_user instead of new (anon) (#24705) 
c.f. de983796e1

There will soon be additional login_required checks
for Guardian, and the intent of many checks by automated
systems is better fulfilled by using BasicUser, which
simulates a logged in TL0 forum user, rather than an
anon user.

In some cases the use of anon still makes sense (e.g.
anonymous_cache), and in that case the more explicit
`Guardian.anon_user` is used
 2023-12-06 11:56:21 +10:00
Alan Guo Xiang Tan d9dca6482d
DEV: Incorrect setup for test (#24736) 
Why this change?

The test in question is testing an anon user instead of a user that has
no permissions to a given topic.
 2023-12-06 09:26:45 +08:00
Martin Brennan a5d4bf6dd2
DEV: Remove unnecessary method_missing from GuardianUser (#24735) 
Followup to 77b6a038ba, this
was a mistake and should have been removed before merge.
 2023-12-06 11:24:19 +10:00
Martin Brennan 3141994e38
FIX: Add checkbox-label to notification bulk actions (#24734) 
Followup to c80b5b718c
 2023-12-06 11:22:48 +10:00
Martin Brennan 77b6a038ba
DEV: Improve Guardian devex (#24706) 
It's quite confusing for blank? to be overridden
on AnonymousUser and BasicUser to represent
whether the fake user is authenticated or not;
we can achieve the same thing more clearly with
a wrapper GuardianUser class around these
user classes. Also fixes an issue where
`def user` would be returning nil.
 2023-12-06 10:57:04 +10:00
Ella E 47629db3db
UX: Add a link from admin reports page to meta a topic (#24707) 
* UX: Add a link from admin reports page to meta a topic
* DEV: apply prettier
 2023-12-05 16:37:44 -07:00
Kris 4ad6c9ce34
FIX: shortcut typo (#24731) 2023-12-05 17:17:04 -05:00
Kris 3a98474983
A11Y: allow tab titles to use default translation (#24727) 2023-12-05 17:16:56 -05:00
dependabot[bot] c4cc738d0a
Build(deps): Bump json from 2.6.3 to 2.7.1 (#24729) 
Bumps [json](https://github.com/flori/json) from 2.6.3 to 2.7.1.
- [Release notes](https://github.com/flori/json/releases)
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md)
- [Commits](https://github.com/flori/json/compare/v2.6.3...v2.7.1)

---
updated-dependencies:
- dependency-name: json
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-05 22:59:08 +01:00
dependabot[bot] e305e7e218
Build(deps): Bump cgi from 0.4.0 to 0.4.1 (#24728) 
Bumps [cgi](https://github.com/ruby/cgi) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/ruby/cgi/releases)
- [Commits](https://github.com/ruby/cgi/compare/v0.4.0...v0.4.1)

---
updated-dependencies:
- dependency-name: cgi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-05 22:58:57 +01:00
Jordan Vidrine bdecb23fd4
UX: More adjustments (#24726) 2023-12-05 14:55:08 -06:00
Kris b65f281842
FIX: escape category description text (#24724) 2023-12-05 15:48:13 -05:00
Mark VanLandingham d4c02d738b
DEV: Add topicNotificationLevel fn to post model (#24723) 2023-12-05 12:08:29 -06:00
David Taylor a5fc8f3253
FIX: Account activation under ember-5 build (#24722) 
We were previously relying on Ember's 'vendor' bundle to make the jquery global available on the activate_account route. That no longer happens under our Ember 5 build.

This commit updates our activate-account script to remove the need for jquery, so that it works under both Ember 3 and Ember 5 builds.
 2023-12-05 17:49:40 +00:00
Isaac Janzen 6aeddad333
DEV: Add `search-menu-before-advanced-search` plugin outlet (#24720) 2023-12-05 10:08:27 -07:00
Bianca Nenciu 8fb5b1fe7c
DEV: Fix assertion in embedding test (#24694) 
The modified test used to be the same as the test above. The bad test
was introduced in commit 77d4c4d8dc,
during a refactoring.

This was not a serious problem because the same behavior was still
tested partially by the other tests below.
 2023-12-05 18:30:52 +02:00
David Taylor 863c0cdecc
FIX: Ensure slugless topic URLs are correctly redirected (#24719) 
Using `DiscourseURL.routeTo` with `replaceURL: true` wouldn't cause a true Ember redirect. That meant that the transition source would be be replaced in the browser's history stack, and the 'back' button wouldn't work as expected. Instead, we can use the router service to perform a proper redirect.
 2023-12-05 15:37:01 +00:00
Discourse Translator Bot cae2b83af8
Update translations (#24716) 2023-12-05 14:39:08 +01:00
chapoi ad77a6876c
UX: fix alignment (#24718) 2023-12-05 14:19:21 +01:00
chapoi 3d710fa0b8
UX:; scope details change (#24715) 2023-12-05 13:56:17 +01:00
Daniel Waterworth a6c79aa27a
DEV: Fix readonly admin login spec (#24714) 
"prevents login by admins" should test with an admin.
 2023-12-05 06:49:22 -06:00
Joffrey JAFFEUX c5aa6b5e16
FIX: correctly update replies_count on chat_threads (#24711) 
The previous query would look at the existing messages, count them, and update the associated thread.

But, if for some reason messages were **ALL** deleted without updating the `replies_count`, then the query wouldn't find any message, and wouldn't update any thread's `replies_count`.
 2023-12-05 13:46:58 +01:00
chapoi 707acbe696
UX: details tag background colour (#24710) 2023-12-05 12:52:00 +01:00
Joffrey JAFFEUX 094d597ec8
FIX: increments message version when processed (#24713) 
Incrementing version, ensures the message will re-play decorators.

Also removes a debugging line which had been forgotten.
 2023-12-05 12:34:19 +01:00
dependabot[bot] 9362949687
Build(deps): Bump regexp_parser from 2.8.2 to 2.8.3 (#24701) 
Bumps [regexp_parser](https://github.com/ammar/regexp_parser) from 2.8.2 to 2.8.3.
- [Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ammar/regexp_parser/compare/v2.8.2...v2.8.3)

---
updated-dependencies:
- dependency-name: regexp_parser
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-05 11:50:48 +01:00
dependabot[bot] 9a10f9d240
Build(deps): Bump terser from 5.24.0 to 5.25.0 in /app/assets/javascripts (#24703) 
* Build(deps): Bump terser in /app/assets/javascripts

Bumps [terser](https://github.com/terser/terser) from 5.24.0 to 5.25.0.
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/compare/v5.24.0...v5.25.0)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update lockfiles for ember version flag

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: discoursebuild <build@discourse.org>
 2023-12-05 11:50:29 +01:00
Joffrey JAFFEUX c6ee647b12
DEV: skip failing spec du to refactoring modal for now (#24712) 2023-12-05 11:47:39 +01:00
Ted Johansson c7667f791e
DEV: Fix chat notifier deprecation warnings from job arguments (#24708) 
We're seeing some deprecation warnings in production. This is because we're passing a raw Ruby timestamp, which gets stringified implicitly when written to Redis. As per #15842, this conversion needs to be done explicitly.
 2023-12-05 18:03:30 +08:00
Martin Brennan de983796e1
FIX: Introduce Guardian::BasicUser for oneboxing checks (#24681) 
Through internal discussion, it has become clear that
we need a conceptual Guardian user that bridges the
gap between anon users and a logged in forum user with
an absolute baseline level of access to public topics,
which can be used in cases where:

1. Automated systems are running which shouldn't see any
   private data
1. A baseline level of user access is needed

In this case we are fixing the latter; when oneboxing a local
topic, and we are linking to a topic in another category from
the current one, we need to operate off a baseline level of
access, since not all users have access to the same categories,
and we don't want e.g. editing a post with an internal link to
expose sensitive internal information.
 2023-12-05 09:25:23 +10:00
Keegan George 7756c210da
FIX: Flaky table builder spec (#24700) 2023-12-04 12:14:07 -08:00
Isaac Janzen b9110c5a71
FIX: Don't refresh on topic search result click (#24697) 
Fixes an issue where when selecting a topic search result we were refreshing the page rather than letting `DiscourseURL` redirect us to the given topic. This was because we were leaning on a `a` tag and it's href to handle the redirect
    
3aeff56faf/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs (L15-L16)

rather than `preventDefault`'ing the redirect
 2023-12-04 11:27:38 -07:00
David Taylor 87d850948f
PERF: Only apply terser to production assets (#24699) 
We funnel vendored javascript through ember-cli, but that's only used for the testem environment. Therefore, there's no need to minify it in production builds. In my tests, this reduces peak RSS of a production build from 3.53GB to 3.15GB.
 2023-12-04 18:05:55 +00:00
Kris c4381e0265
FIX: don't apply extraClassName to all popup menus (#24695) 2023-12-04 11:40:57 -06:00
Joffrey JAFFEUX c805bcc7ba
DEV: adds a chat-join-channel-button outlet (#24698) 
This outlet allows to redefine the button displayed when asking the user to join a channel.

The following outletArgs are sent to the outlet:

```
onJoinChannel
channel
icon
title
label
disabled
```
 2023-12-04 18:11:33 +01:00
David Taylor 3aeff56faf
DEV: Run assets:precompile ember build with `CI=1` (#24696) 
This will improve the output to print the current step (rather than the existing behavior which just says 'building...')
 2023-12-04 15:49:50 +00:00
David Taylor fa35ce9caa
DEV: remove duplicate spec (#24691) 2023-12-04 15:45:11 +00:00
Roman Rizzi 037622fc7f
DEV: reviewable_user spec should assert on delete_user_block instead of delete_user (#24692) 2023-12-04 12:44:32 -03:00
Jan Cernik 0af8bbd378
FIX: Multiple nested threads and duplicated messages in chat transcripts (#24685) 2023-12-04 12:43:04 -03:00
David Taylor cf8961e1c1
DEV: Correct forums_controller success spec (#24690) 
The implementation did not match the name of the spec
 2023-12-04 14:26:29 +00:00
David Taylor 9479b30ada
FIX: Ensure 'untagged' document title is set correctly (#24689) 
https://meta.discourse.org/t/286130/4
 2023-12-04 13:43:02 +00:00
Jarek Radosz 7196613e2e
DEV: Fix various spec linting issues (#24672) 
Duplicated specs, incorrect descriptions, incorrect assertions, incorrect filenames, old todo
 2023-12-04 13:45:19 +01:00
David Taylor c2887d3f8c
DEV: Remove unused Ember::Handlebars freedom patch (#24688) 
We no longer compile Ember templates in ruby, so this is unused
 2023-12-04 12:40:08 +00:00
David Taylor cdb904a1b0
DEV: Remove unused htmlbars-inline-precompile shim (#24687) 
Since 4425e99bf9, we no longer ship the template compiler to the client under any circumstances, so this shim doesn't work. Plus, even if it did work, it would trigger the ember-global deprecation and fail under Ember 4+.
 2023-12-04 12:34:45 +00:00
Jarek Radosz e0c876696a
DEV: Fix some qunit linting issues (#24686) 
`qunit/literal-compare-order`
`qunit/no-compare-relation-boolean`
`qunit/assert-args`
 2023-12-04 13:32:16 +01:00
Jarek Radosz 2029777b86
DEV: Replace AdminWrapper with body-class/html-class (#24683) 
AdminWrapper isn't used (directly) in all-the*

Co-authored-by: David Taylor <david@taylorhq.com>
 2023-12-04 12:53:07 +01:00
Joffrey JAFFEUX 3ed1528327
FIX: failing spec in sidebar tags (#24682) 
The modal is now larger and more tags will be shown by default, we need more tags to correctly test the scroll behavior.
 2023-12-04 12:46:53 +01:00
dependabot[bot] e9e6c4e5d6
Build(deps): Bump nio4r from 2.6.1 to 2.7.0 (#24678) 
Bumps [nio4r](https://github.com/socketry/nio4r) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/socketry/nio4r/releases)
- [Changelog](https://github.com/socketry/nio4r/blob/main/changes.md)
- [Commits](https://github.com/socketry/nio4r/compare/v2.6.1...v2.7.0)

---
updated-dependencies:
- dependency-name: nio4r
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-04 10:36:34 +01:00
dependabot[bot] ec4491cc3b
Build(deps-dev): Bump rubocop from 1.57.2 to 1.58.0 (#24675) 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.57.2 to 1.58.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.57.2...v1.58.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-04 10:13:20 +01:00
dependabot[bot] 364216cab3
Build(deps): Bump rbtrace from 0.4.14 to 0.5.0 (#24677) 
Bumps [rbtrace](https://github.com/tmm1/rbtrace) from 0.4.14 to 0.5.0.
- [Changelog](https://github.com/tmm1/rbtrace/blob/master/CHANGELOG)
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.14...v0.5.0)

---
updated-dependencies:
- dependency-name: rbtrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-04 10:11:55 +01:00
dependabot[bot] af30d3dc7c
Build(deps-dev): Bump shoulda-matchers from `7e069cf` to `3654e5c` (#24679) 
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from `7e069cf` to `3654e5c`.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Commits](7e069cf205...3654e5ca7f)

---
updated-dependencies:
- dependency-name: shoulda-matchers
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2023-12-04 10:11:15 +01:00