9ce9d72e71
DEV: makes hidepassed default when running qunit ( #7558 )
...
Mostly useful when not running headless, but I endup doing it a lot when debugging, one less thing to check.
2019-05-16 14:37:01 +02:00
0e677daaee
FIX: include posts with data-orig-src attribute in have_uploads scope query.
2019-05-16 16:39:38 +05:30
3172172b52
remove unused local variable
...
ec84c87ddb
2019-05-16 15:39:13 +05:30
ec84c87ddb
FIX: skip validation while recovering uploads from s3
...
TODO: add tests
2019-05-16 15:37:11 +05:30
56ada8374f
DEV: wrap find_missing_uploads method in distributed mutex
...
And skip posts with deleted topics.\ne8fafbc123170dd1f7d2a8adea4e7810585d3e76
2019-05-16 15:17:53 +05:30
a5a4f9dc1a
DEV: make prettier happy
...
(cc @jjaffeux)
2019-05-16 11:38:47 +02:00
d51a495dad
COPY: improve 'private_email' site setting description
2019-05-16 11:35:33 +02:00
5dd97d6d38
DEV: prevent already defined global warning
2019-05-16 11:32:10 +02:00
4a9756ff3f
DEV: sets rack server to test env when using rake qunit:test ( #7554 )
2019-05-16 10:44:29 +02:00
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 ( #7546 )
2019-05-16 10:34:19 +02:00
cabc203885
Followup to a8fbb19e
...
Correct edge condition where no available names are found
- increase search space
- search for 10 extra names
2019-05-16 18:15:56 +10:00
a8fbb19e7c
FEATURE: allow a huge number of users to share common prefix
...
Previously username suggester would give up after 100 attempts at getting
a username and fallback to random string.
This amends the logic so we do all the work of figuring out a good username
in SQL and avoids a large amount of queries in cases where a lot of usernames
were used up.
This corrects an issue on sites with large numbers of anon users
2019-05-16 17:15:16 +10:00
ea214b2b0c
DEV: logs tests exception when running qunit on headless chrome ( #7553 )
2019-05-16 08:48:08 +02:00
a36fe019bb
DEV: Fix race condition when enqueuing edit wiki-ed notification.
2019-05-16 13:48:46 +08:00
636b75fa16
REFACTOR: remove duplicate reject loop and implicit return
...
e8fafbc123
2019-05-16 10:04:04 +05:30
40328f055e
FIX: retrieve original filename from s3 object's content disposition header
2019-05-16 09:47:22 +05:30
227bedebf7
DEV: Fix modifying a frozen string.
2019-05-16 11:30:31 +08:00
dd49be27d3
DEV: Fix undefined variable.
...
Follow up to e8fafbc123
2019-05-16 11:28:48 +08:00
76173dea87
DEV: ensure we never fork v8 contexts from unicorn
...
v8 forking is not supported and can lead to memory leaks.
This commit handles the most common case which is the unicorn master forking
There are still some cases related to backup where we fork, however those
forks are usually short lived so the memory leak is not severe, burning
the contexts in the master process could break sidekiq or web process that
do the actual forking
2019-05-16 09:50:34 +10:00
7cd1067f3d
FIX: Select-kit too narrow in topic timer
2019-05-15 17:58:40 -04:00
2932b0e757
chore: bump ruby version in .ruby-version ( #7552 )
2019-05-15 23:47:51 +02:00
501bee56b7
Make prettier happy
2019-05-15 23:46:50 +02:00
7eea55d564
PERF: remove "new posts" stat from summary email
...
It performs horribly and isn't a personalized stat like the others.
2019-05-15 16:28:21 -04:00
db89722a98
UX: ignore leading/trailing whitespaces in site settings search
2019-05-15 22:22:20 +02:00
b9fcb2bcdf
DEV: Add before button hook in post-menu. ( #7550 )
2019-05-15 22:48:23 +03:00
0ef25f7a66
prettier
2019-05-15 13:35:58 -04:00
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles ( #7549 )
2019-05-15 13:26:25 -04:00
9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
fd5c5e326f
FIX: remove full quote on direct replies when "typographed"
...
Use the cooked version of the post and the quote to compare their content in
order to take into account the "typographer" option of the markdown pipeline.
2019-05-15 17:49:29 +02:00
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
64e81f0549
FIX: ensure `get_a_room` link starts with 'base_path translation
2019-05-15 12:41:38 +02:00
a0df676194
COPY: improve 'dominating_topic' and 'get_a_room' warnings
...
cf. https://meta.discourse.org/t/how-to-suppress-the-warning-that-a-user-is-contributing-too-much-to-a-topic/63249/9
2019-05-15 12:21:44 +02:00
be0555cc17
FIX: Add bucket folder path only if not exists
2019-05-15 15:37:40 +05:30
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
ab1684999c
DEV: Improve specs to use `upload_s3` fabricator.
2019-05-15 08:42:17 +08:00
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
33bd47164f
DEV: Re-enable uglifier for non-precompiled assets
...
Keep `harmony` disabled
2019-05-14 10:28:18 +01:00
f12709e24c
DEV: Temporarily disable uglifier for non-precompiled assets
...
This is causing performance issues which require further investigation
2019-05-14 09:34:38 +01:00
bbcc39e66c
FEATURE: update mini_racer to version including heap dump support
...
We recently noticed a leak, this introduces a new method on MiniRacer::Context
```
context.write_heap_snapshot(path)
```
To dump current memory in v8 context to a file, this can then be analyzed
in chrome and other similar tools
Can be triggered in production using rbtrace
2019-05-14 18:01:15 +10:00
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
dafc941a04
FEATURE: allow shadowing all s3 settings
...
Previously enable s3 uploads and s3 upload bucket were not shadowed.
This caused confusion when people were configuring stuff via env cause most
of s3 settings are shadowed.
2019-05-14 10:24:14 +10:00
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
13e54bca3d
DEV: Add specs for handling InvalidPluralizationData exception
...
follow-up to 6d44be51
2019-05-13 22:07:42 +02:00
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
5605dba85c
DEV: Automatically annotate plugin models alongside core models
2019-05-13 16:37:47 +01:00
Joffrey JAFFEUX
Vinoth Kannan
Régis Hanol
Sam Saffron
Guo Xiang Tan
Kris
Orlando Del Aguila
Neil Lalonde
Bianca Nenciu
Maja Komel
Penar Musaraj
David Taylor
Gerhard Schlager
Arpit Jalan