Commit Graph

16490 Commits

Author SHA1 Message Date
Guo Xiang Tan a389baeb07 FIX: Group pages should work when group name contains periods.
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
2018-04-12 17:11:36 +08:00
Joffrey JAFFEUX deab0486fa
FIX: apply fa-fw on class instead of icon name 2018-04-12 10:56:32 +02:00
Guo Xiang Tan 6e46f81123 Add a distributed mutex around user creation via SSO.
* When two SSO requests containing the same email in the payload are
  sent at the same time, it would sometimes result in two users
  being created but one without an email record. Investigations
  points to ActiveRecord not generating the right statements but
  we have no figured out the reproduction steps yet. We should review
  this after upgrading to Rails 5.2.
2018-04-12 16:18:49 +08:00
Kris 7ff78cc013 docked topic progress indicator too wide 2018-04-11 23:52:32 -04:00
Guo Xiang Tan c0595ebe99 FIX: Disable save button when new group form is empty.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
2018-04-12 10:29:36 +08:00
Régis Hanol 1a9271dd2f add a warning in robots.txt when using subfolder 2018-04-12 00:00:15 +02:00
Régis Hanol 062bf8bad3 add back missing 'group-edit' plugin outlet 2018-04-11 22:43:48 +02:00
Régis Hanol df7970a6f6 prefix the robots.txt rules with the directory when using subfolder 2018-04-11 22:05:02 +02:00
Neil Lalonde fcd20a70d7 FIX: allow lists in summary email post excerpts 2018-04-11 14:16:08 -04:00
Joffrey JAFFEUX d16c4b0677
FIX: adds incorrectly removed context checkbox 2018-04-11 16:57:34 +02:00
Kris be72d65355 Mobile upload modal alignment 2018-04-11 10:24:58 -04:00
Vinoth Kannan 19e8f9af13 Remove support for theme settings in raw handlebar templates 2018-04-11 18:21:04 +05:30
Sam b05ada3208 Avoid console error in tests 2018-04-11 16:11:53 +10:00
Sam 489c22d93c FEATURE: Disallow tags and categories rss feeds
This stops crawlers from hitting tags and category rss feeds to discover
new content, instead they should focus on latest/posts if they need to
consume something regular
2018-04-11 14:36:10 +10:00
Arpit Jalan c0a0b81335
Merge pull request #5730 from techAPJ/enforce-tagging
FEATURE: enforce tagging on categories
2018-04-11 09:44:33 +05:30
Guo Xiang Tan 3b9a656439 FIX: An option in `aliasLevelOptions` was accidentally removed. 2018-04-11 11:03:44 +08:00
Guo Xiang Tan 9176b2591d UX: Replace route when users try to access invalid group management page.
https://meta.discourse.org/t/unable-to-save-changes-to-a-group/84954
2018-04-11 10:55:45 +08:00
Sam f40f10240c FEATURE: remove topic rss from robots
Crawlers love hitting the rss feeds (confirmed that both Google and Bing do)

Experimenting with the impact of blocking these feeds and forcing Crawlers to hit
the content direct. It is better if they hit the actual page to start with as opposed to

1. Hit RSS feed
2. Find new content
3. Hit post link
4. Get canonical
5. Hit canonical

Lots of pointless work.

We do not know for sure what impact this will have on newsreader apps,
we will listen for feedback.
2018-04-11 11:57:52 +10:00
Arpit Jalan 48d43b33cc add client side validation for category minimum_required_tags 2018-04-11 07:17:52 +05:30
Arpit Jalan 9ca6ebe8fe FEATURE: enforce tagging on categories 2018-04-11 07:15:24 +05:30
Jeff Wong 4c6d2ed59a
Merge pull request #5749 from featheredtoast/service-worker-registration-fixes
Fix - service worker registrations
2018-04-10 16:37:06 -07:00
Neil Lalonde 6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Jeff Wong 32f919ea34 Fix - service worker registrations
* register service workers in a development env

* register service worker from ember initialize fn
2018-04-10 15:17:32 -07:00
Neil Lalonde d389d66f8d FIX: remove duplicates in available titles 2018-04-10 12:02:05 -04:00
Joffrey JAFFEUX 11c47f57f9
FIX: prevents keyboard from appearing on android when expanding 2018-04-10 16:25:05 +02:00
Vinoth Kannan 4822b77b49 Exclude available_groups from category web hooks 2018-04-10 16:46:22 +05:30
Vinoth Kannan 96867743c8 Exclude suggested topics from topic view web hook 2018-04-10 16:38:48 +05:30
Arpit Jalan 3a86a2588c FIX: bulk append/replace tags was not working 2018-04-10 13:01:03 +05:30
Guo Xiang Tan 867f327055 Remove horizontal padding for group navigation links. 2018-04-10 14:22:57 +08:00
Guo Xiang Tan 874003b7b1 FIX: Group can't be deleted if certain users are demoted. 2018-04-10 14:19:35 +08:00
Guo Xiang Tan 9df4f7bf8e UX: Move group delete button to details container. 2018-04-10 14:19:35 +08:00
Sam fe37ce165d correct issue where groups was never being blanked 2018-04-10 15:30:18 +10:00
Sam 5925a581db array is not supported here, use a simple comma delimited list 2018-04-10 14:37:10 +10:00
Sam afaeb20f27 FEATURE: Add option to have sso synchronize group membership
In some cases add_groups and remove_groups is too much work, some sites
may wish to simply synchronize group membership based on a list.

When sso_overrides_groups is on all not automatic group membership is
sourced from SSO. Note if you omit to specify groups, they will be cleared
out.
2018-04-10 13:17:23 +10:00
Guo Xiang Tan ffb7ec2543 Fix the build. 2018-04-10 09:50:00 +08:00
Guo Xiang Tan d9d86577ff FIX: Staff users are not affected by `enable_group_directory` site setting. 2018-04-10 09:22:01 +08:00
Neil Lalonde d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Kris affb935760 Cleaning up secondary stats on user profile 2018-04-09 14:02:43 -04:00
Régis Hanol d19bbfc7f8 UX: ensure the topic progress indicator is never overlapping with post controls 2018-04-09 19:44:35 +02:00
Joffrey JAFFEUX bd7100a062 FEATURE: revamp full-page-search UI (#5703)
This is the first iteration of this revamp, a following iteration will focus on improving the controls in the advanced search sidebar.
2018-04-09 11:51:09 -04:00
Régis Hanol 41150fc0cd FIX: J/K keyboard shortcut misbehaving 2018-04-09 17:28:43 +02:00
Gerhard Schlager 62aacce8f4 FEATURE: Notify flaggers when flagged post is edited by author 2018-04-09 16:45:33 +02:00
Kris 0e9ec237a2 Adding top margin to mobile user profile 2018-04-09 10:14:52 -04:00
Guo Xiang Tan c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan 4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Arpit Jalan 185d6ac747 FIX: use safe navigation operator when checking for totp_enabled 2018-04-09 12:33:41 +05:30
osamasayegh fe8301007c Add spec + make it work with .raw templates 2018-04-09 16:47:28 +10:00
osamasayegh ce1a6f2fd8 FEATURE: Theme settings in handlerbars templates 2018-04-09 16:47:28 +10:00
David Taylor ad7f2b7dc6 Allow import and keyGen URLs to be overridden in import modal 2018-04-09 16:42:47 +10:00
David Taylor a17cb11dc3 Allow adminCustomizeThemes.edit route name to be overridden in themes-show 2018-04-09 16:42:47 +10:00
David Taylor 37fe1c76b9 Allow FIELDS_IDS to be overridden 2018-04-09 16:42:47 +10:00
David Taylor 70e60f4afe Allow adminCustomizeThemes.edit route name to be overridden 2018-04-09 16:42:47 +10:00
David Taylor 7426e63c30 Allow theme asset upload url to be overridden 2018-04-09 16:42:47 +10:00
Arpit Jalan f5febe5843 FIX: date range was inconsistent for admin dashboard reports 2018-04-08 16:49:41 +05:30
Jeff Wong 641276af46 more consistent colors for dark themes on hover (#5743) 2018-04-06 22:44:51 -04:00
Neil Lalonde e33aef729f FIX: unable to save groups with mixed case names 2018-04-06 16:12:35 -04:00
Neil Lalonde f6cfff3cea UX: user preferences allows users to choose which title to use from their badges and groups 2018-04-06 14:34:36 -04:00
Guo Xiang Tan a2b9a55036 FIX: Binding style attributes need to be escaped.
See http://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes
2018-04-06 14:58:38 +08:00
Guo Xiang Tan 63ac34ed79 Move official plugin icon under own header. 2018-04-06 12:44:31 +08:00
Joshua Rosenfeld 8da296ce12
FIX: Broken PM title line wrapping 2018-04-06 00:03:54 -04:00
Guo Xiang Tan 0623785f69 FIX: Prevent group owners from editing admin only settings. 2018-04-06 11:44:58 +08:00
Guo Xiang Tan 2ddcdf8704 UX: Add an icon to indicate if a plugin is official.
https://meta.discourse.org/t/improving-admin-plugins/84585
2018-04-06 10:54:58 +08:00
Kris 50257ebfb1 adding margin to PM glyph on mobile 2018-04-05 22:33:58 -04:00
Guo Xiang Tan e4a9242ada FIX: Can't upload backup.
* Regression introduced in 142571bba0
2018-04-06 10:14:17 +08:00
Sam 3a7b696703 FEATURE: allow for setting crawl delay per user agent
Also moved to default crawl delay bing so no more than a req every 5 seconds is allowed

New site settings:

"slow_down_crawler_user_agents" - list of crawlers that will be slowed down
"slow_down_crawler_rate" - how many seconds to wait between requests

Not enforced server side yet
2018-04-06 10:15:23 +10:00
Joffrey JAFFEUX f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Gerhard Schlager cd6a99a027 FEATURE: Send a different PM when a post has been hidden more than once 2018-04-05 14:03:21 +02:00
Gerhard Schlager 35efdb39b3 FEATURE: Show the current reply count of the flagged post 2018-04-05 14:03:02 +02:00
Gerhard Schlager f2d00e5eff FEATURE: Use Message-ID for detecting email replies to group
Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group.

The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.
2018-04-05 11:00:38 +02:00
Guo Xiang Tan e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Régis Hanol d5412cff4e FIX: scrolling was off sometimes
Also changed "Jump To Post" to go to the post index in the stream rather than the post number
2018-04-05 10:08:48 +02:00
Guo Xiang Tan a26d3fc2de Missing save button when editing automatic groups. 2018-04-05 15:25:39 +08:00
Guo Xiang Tan d7943cc3db Make eslint happy. 2018-04-05 15:21:11 +08:00
Sam f8637ed616 FIX: if a message is *partially* archived consider it not archived 2018-04-05 17:17:47 +10:00
Guo Xiang Tan 85bcda120a Basic UX improvements to the group profile management page. 2018-04-05 14:59:04 +08:00
Guo Xiang Tan 8760c4d68c Fix `GroupsController#group_params` to allow more group attributes to be updated. 2018-04-05 13:53:00 +08:00
Robin Ward 17f12c0ce4 Add new plugin outlet below admin user names 2018-04-04 15:47:14 -04:00
Vinoth Kannan 434cbc649f FEATURE: Webhook for tag events 2018-04-04 17:49:20 +05:30
Arpit Jalan c36e201eb3 FIX: update categories topic_count when converting topic to a PM and vice versa 2018-04-04 12:01:56 +05:30
Guo Xiang Tan e6d07fa6d8 UX: Allow admins to manage automatic groups on group page. 2018-04-04 11:07:11 +08:00
Joffrey JAFFEUX b1cc368da8
FIX: regression where tag could not be deleted with click 2018-04-04 00:56:45 +02:00
Arpit Jalan 88e4c0ec3a FIX: new/unread tabs should re-appear dynamically 2018-04-04 00:08:31 +05:30
Neil Lalonde b7ecdb72d6 FIX: update Google Tag Manager javascript 2018-04-03 14:22:06 -04:00
Robin Ward 76d734ea6e A more extensible way to disable expanding/contracting of user profiles 2018-04-03 14:19:56 -04:00
Robin Ward 0188cbb650 UX: New dropdowns work well on mobile for category notifications 2018-04-03 12:09:00 -04:00
Robin Ward a383b368c6 FIX: The order of import globbing is not deterministic
Using a wildcard would load in a different order on some installs
resulting in unpredictable behavior (for example, `is-hidden` being
displayed due to a `display: flex` in a different file.)
2018-04-03 11:40:53 -04:00
Guo Xiang Tan 6f32de186a UX: Add a "add members" button on group page. 2018-04-03 17:35:18 +08:00
Joffrey JAFFEUX 61812b52e7
FIX: more conservative refactoring to avoid regressions in customisations 2018-04-03 10:35:22 +02:00
Arpit Jalan 54819d72c9 UX: show users who liked the post when expanding post actions 2018-04-03 08:24:09 +05:30
Joffrey JAFFEUX d54da517d9
FIX: more resilient focus filter or header 2018-04-02 22:50:20 +02:00
Joffrey JAFFEUX 017f5c1aee
FIX: regression preventing backspace to work on mini-tag-chooser 2018-04-02 22:42:20 +02:00
Robin Ward 58c81db279 Apply a 'no-group' class to quotes for styling 2018-04-02 14:02:16 -04:00
Robin Ward 90d3544db8 UX: Add a class we can use to target quotes without groups 2018-04-02 14:02:16 -04:00
Guo Xiang Tan 00d879ec63 Fix the build. 2018-04-03 00:44:12 +08:00
Guo Xiang Tan 2498403bc3 Revert "FIX: Username uniqueness check should not happen to current user_id"
This reverts commit f71a18facd.
2018-04-03 00:44:04 +08:00
Joffrey JAFFEUX 5685b45fa6
FIX: manually adds tag if existing but not in returned matches 2018-04-02 18:33:46 +02:00
Vinoth Kannan f71a18facd FIX: Username uniqueness check should not happen to current user_id 2018-04-02 21:59:11 +05:30
Kris 2eec572159 minor alignment fix on new like button 2018-04-02 12:17:50 -04:00
Joffrey JAFFEUX 8f2b305b9a
FIX: calling incorrect method 2018-04-02 18:02:45 +02:00
Arpit Jalan 5e4dd20795 Revert "Prevent robots from indexing uploads"
This reverts commit 0fd622e5d1.
2018-04-02 21:29:29 +05:30
Robin Ward 23e97a3c3a UX: Add classes for extensibility 2018-04-02 11:55:25 -04:00
Joffrey JAFFEUX a828da33aa
FIX: regression preventing addition of multiple tags in a group 2018-04-02 17:54:40 +02:00
Vinoth Kannan 16341219ab Log exception if remote theme importing failed 2018-04-02 20:10:18 +05:30
Guo Xiang Tan 221503cd10 FIX: Add server side uniqueness validations for `Group#name` and `User#username`.
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
2018-04-02 18:19:18 +08:00
Guo Xiang Tan d2a8f40fb0
Merge pull request #5711 from Supermathie/learn_cdn_url_hostname
FIX: CDN_URL hostname should be in GlobalSetting.hostnames
2018-04-02 16:39:24 +08:00
Guo Xiang Tan d4ebbd12a6
Merge pull request #5723 from featheredtoast/topic-list-item-unread-classnames
Feature: Add unseen-topic and new-posts classnames to topic list items
2018-04-02 16:35:19 +08:00
Guo Xiang Tan 142571bba0 Remove use of `rescue nil`.
* `rescue nil` is a really bad pattern to use in our code base.
  We should rescue errors that we expect the code to throw and
  not rescue everything because we're unsure of what errors the
  code would throw. This would reduce the amount of pain we face
  when debugging why something isn't working as expexted. I've
  been bitten countless of times by errors being swallowed as a
  result during debugging sessions.
2018-04-02 13:52:51 +08:00
Vinoth Kannan efb19dbdaf
Merge pull request #5705 from discourse/new_webhooks
FEATURE: Webhook for group and category events
2018-04-02 10:53:21 +05:30
Guo Xiang Tan 87e3779085
Merge pull request #5702 from kevinelliott/feature/20180323-fix-mass-assignment
20180323 Fix Mass Assignment Warning
2018-04-02 10:19:25 +08:00
Arpit Jalan 82b1dc6934 UX: consistent spacing for like button on mobile 2018-04-01 07:18:07 +05:30
Jeff Wong 03b2590036 Add unseen-topic and new-posts classnames to topic lists
Adds classname descriptions for new, unread posts, and closed statuses on topic-list-items.

Allows for new/unread/closed topic-list-items to be targeted with css directly.
2018-03-31 11:57:03 -07:00
Arpit Jalan cddaad7a55 UX: hide empty 'new' and 'unread' tabs for tl1 and above 2018-03-31 11:42:20 +05:30
Arpit Jalan 9df7fd4f30 FIX: discourse-solved plugin controls (buttons) should be in first place 2018-03-31 07:42:54 +05:30
Arpit Jalan 9815f301cc UX: alignment was off on likes for your own post 2018-03-31 07:21:18 +05:30
Blake Erickson 31ce955487 Add destroy rake task
Adds several rake tasks to delete users, topics, pm's and site stats so
that you can have a fresh site but maintain site settings and category
structure.
2018-03-30 18:32:21 -06:00
Kris 4fcbe9128e Minor color/alignment adjustment on like button 2018-03-30 16:46:37 -04:00
Arpit Jalan 4760f0e7a9 UX: better like button
Co-authored-by: jjaffeux <j.jaffeux@gmail.com>
2018-03-30 22:45:51 +05:30
Arpit Jalan 67efdaea40 FIX: properly hide nav items 2018-03-30 12:32:29 +05:30
Arpit Jalan 15945bcf15 UX: when there is nothing new or unread to show, remove those options from the top nav. 2018-03-30 11:38:44 +05:30
Arpit Jalan bf41010ac3 UX: make own post heart glyph grey 2018-03-30 10:35:54 +05:30
Arpit Jalan fe17ee6924 UX: own post likes glyph margin was off 2018-03-30 10:10:55 +05:30
Arpit Jalan a55b458e56 UX: show heart glyph on your own likes count 2018-03-30 09:06:57 +05:30
Jeff Atwood 131b19c26b move like count a tad closer to like glyph 2018-03-29 16:36:59 -07:00
Arpit Jalan 629ad48621 UX: better likes count margin 2018-03-30 03:02:56 +05:30
Arpit Jalan 9bf87f3665 UX: remove word "likes" from first post 2018-03-30 02:45:32 +05:30
Robin Ward 22b631510c FIX: Silenced user wasn't being linked properly 2018-03-29 17:07:09 -04:00
Robin Ward e4298a91b8 Pass `silenced_by` through to DiscourseEvent 2018-03-29 16:44:18 -04:00
Arpit Jalan ef07045aca fix the build 2018-03-30 02:09:48 +05:30
Arpit Jalan 6bef0428cc UX: remove the word 'likes' from the like counters on posts within topic 2018-03-30 01:46:00 +05:30
Arpit Jalan fda8b3d879 UX: updated 'new dot' styling 2018-03-30 01:25:39 +05:30
Neil Lalonde 73c1d3e7fe FIX: tag notification preferences were being cleared when other preferences were changed 2018-03-29 15:08:32 -04:00
Robin Ward ec6bbe2af0 FIX: Show error if dashboard can't load 2018-03-29 14:12:29 -04:00
Robin Ward e4a5b0c39a
Merge pull request #5715 from jjaffeux/remove-title-user-notifications
FIX: remove unneeded and uninformative title on user notifications list
2018-03-29 09:23:09 -04:00
Joffrey JAFFEUX 99cf091774
FIX: do not lighten color when no selection for cat and tag drops 2018-03-29 15:20:47 +02:00
Joffrey JAFFEUX 3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan 125434dcdf Minor style tweak on groups page. 2018-03-29 18:14:17 +08:00
Guo Xiang Tan 52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan 27f06505b1 Allow placeholder to be configured for `combo-box`. 2018-03-29 17:04:48 +08:00
Joffrey JAFFEUX a64cc9a990
FEATURE: allow users to collapse profile after expanding it 2018-03-29 10:53:57 +02:00
Joffrey JAFFEUX 9260969101
FIX: correctly shows education text for categories 2018-03-29 10:33:44 +02:00
Guo Xiang Tan 3b3e6ed23f Fix deprecation warnings in Ember.
See https://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib
2018-03-29 10:01:29 +08:00
Guo Xiang Tan 90f91bf017 Fix regression due to ee69d58a59. 2018-03-29 10:01:29 +08:00
Kris 6e569e5bfd X button for mobile edits in composer 2018-03-28 20:47:56 -04:00
Kris cf3c670cb7 Fixing table top-border alignment issue 2018-03-28 18:49:19 -04:00
Robin Ward eab64710ff FIX: Shared draft performance fix + missing avatars 2018-03-28 16:11:43 -04:00
Robin Ward 4b5977aa6a Revert "PERF: Don't join on shared drafts unless you have to"
This reverts commit efedd9745f.
2018-03-28 15:35:13 -04:00
Robin Ward efedd9745f PERF: Don't join on shared drafts unless you have to 2018-03-28 13:57:39 -04:00
Régis Hanol fa608f2bb4 FIX: ensure theme variables are unique when adding an upload 2018-03-28 18:57:11 +02:00
Robin Ward 31d0998506 FIX: Don't allow links with no href 2018-03-28 12:32:16 -04:00
Joffrey JAFFEUX 466f09bbc4 FIX: remove uneeded and uninformative title on user notifications list 2018-03-28 17:05:42 +02:00