93b40d5e59
Don't use `puts` here since it happens in tests
2018-04-30 12:26:43 -04:00
f7c4c71409
FIX: title selector needs to flag whether title comes from badge or not
2018-04-26 16:51:11 -04:00
00a0a9ac52
Merge pull request #5791 from yanokwa/patch-1
...
Correct spelling errors
2018-04-26 13:02:55 -07:00
e52d914c08
add discourse-user-card-badges to official plugins
2018-04-26 15:28:06 -04:00
02cd035164
Correct spelling errors
2018-04-26 09:46:32 -07:00
0732c69f73
updates moment.js 2.22.1 and vendor moment-timezone 0.5.14
2018-04-26 09:15:53 +02:00
88f5251415
FIX: disallow invalid top_menu and post_menu and share_links
...
In the past any text could be entered there causing big potential issues
2018-04-26 17:00:56 +10:00
c7a0ced656
FIX: remove facebook_request_extra_profile_details
...
Since this no longer works
2018-04-26 14:14:35 +10:00
98d142b1c1
also causes test failure, removing
2018-04-26 13:48:44 +10:00
0a82d739f9
unofficialize plugin
2018-04-26 13:23:14 +10:00
4ded5e18e6
add more official plugins
2018-04-26 12:33:07 +10:00
a5172a37e0
Allow staff members to enable safe mode, even if disabled
2018-04-25 11:49:57 -04:00
afe1a2793d
Mark discourse-signatures plugin as official
2018-04-25 11:58:39 +02:00
0e38481d6d
Add docker_manager to official plugin list.
2018-04-25 13:02:50 +08:00
aad7df2a1b
correct return value
2018-04-25 08:44:07 +10:00
18c27883e9
Version bump to v2.0.0.beta7
2018-04-24 11:13:52 -04:00
035312d501
FIX: specify path for dosp cookie
2018-04-24 11:07:58 -04:00
bf6e548692
Remove plugin that is internal to us.
2018-04-24 11:07:49 -04:00
42a848f88f
linting
2018-04-23 10:26:33 +02:00
69c32a2651
Refresh site settings after a remap
2018-04-23 09:57:13 +02:00
c148500d51
FIX: Deadlock when topic with auto close topic timers exceeds `auto_close_topics_post_count`.
2018-04-23 13:34:24 +08:00
6a0aeae91b
DEV: clean up JavaScript testing
...
- Unify runner for autospec and qunit:test
- Report on slowest 30 tests
- Use async await instead of promise tower
2018-04-23 14:43:04 +10:00
ded84a4b58
PERF: improve performance once logged in rate limiter hits
...
If "logged in" is being forced anonymous on certain routes, trigger
the protection for any requests that spend 50ms queueing
This means that ...
1. You need to trip it by having 3 requests take longer than 1 second in 10 second interval
2. Once tripped, if your route is still spending 50m queueuing it will continue to be protected
This means that site will continue to function with almost no delays while it is scaling up to handle the new load
2018-04-23 11:55:25 +10:00
80847d83a8
Mark `discourse-voting` and `discourse-staff-notes` as official.
2018-04-23 09:26:13 +08:00
86c1457c40
correct typo
2018-04-23 10:55:38 +10:00
70f2c5d3fd
FEATURE: move staff tags setting to tag group settings
2018-04-20 15:34:23 -04:00
cfcdc4b420
Output when a locale is invalid
2018-04-20 15:29:18 -04:00
45fe5dc793
`$redis.client` -> `$redis._client`.
...
See c239abb43c
2018-04-20 13:01:17 +08:00
91bf10bd12
FIX: create upload record for exported csv files
2018-04-20 00:27:49 +05:30
2b0e505121
Extract signatures from emails sent with Newton
2018-04-19 12:39:55 +02:00
5b93d69939
FIX: error when non-staff user edits their topic after a hidden tag is added to it
2018-04-18 12:51:25 -04:00
4810ce3607
correct regression
2018-04-18 21:04:08 +10:00
59cd7894d9
FEATURE: if site is under extreme load show anon view
...
If a particular path is being hit extremely hard by logged on users,
revert to anonymous cached view.
This will only come into effect if 3 requests queue for longer than 2 seconds
on a *single* path.
This can happen if a URL is shared with the entire forum base and everyone
is logged on
2018-04-18 16:58:57 +10:00
3566c6f02b
FIX: strip emoji string from slug
2018-04-18 11:32:32 +05:30
8fc1289172
move topic excerpt code to one method to DRY it up and for extensibility
2018-04-17 15:08:21 -04:00
b87fa6d749
FIX: blacklisted crawlers could get through by omitting the accept header
2018-04-17 12:39:30 -04:00
2585ada5ca
FIX: don't allow spaces in 'reply_by_email_address' site setting
2018-04-17 17:08:12 +02:00
ad4c25e004
PERF: Only save site setting if values have been changed.
2018-04-17 21:07:39 +08:00
9980f18d86
FEATURE: track request queueing as early as possible
2018-04-17 18:06:17 +10:00
1b9a38c5e2
FIX: Incorrect formatter used when logstash formatter is enabled.
2018-04-17 12:07:52 +08:00
001b0710c7
FIX: don't add diff classes more than once
2018-04-16 15:41:45 +02:00
c74c933996
SECURITY: escape HTML entities from topic title
2018-04-15 18:44:28 +05:30
0183656631
FIX: verify filtered tags when checking for category minimum required tags
2018-04-14 23:20:43 +05:30
fe32733a57
extract signatures from emails sent using Zimbra
2018-04-13 19:04:27 +02:00
e8d35653ae
Version bump to v2.0.0.beta6
2018-04-13 10:47:01 -04:00
a0a06492d8
FIX: make get_hostname more lenient to user input
2018-04-12 17:09:09 +02:00
3c8b43bb01
FIX: non-oneboxed links on separate lines should stay on separate lines
2018-04-11 21:33:45 +02:00
f0803e9611
sleep here is a better fit
2018-04-11 16:46:27 +10:00
be0366d587
add debugging for docker test
2018-04-11 16:39:39 +10:00
48d43b33cc
add client side validation for category minimum_required_tags
2018-04-11 07:17:52 +05:30
9ca6ebe8fe
FEATURE: enforce tagging on categories
2018-04-11 07:15:24 +05:30
64f2086cca
rake task should allow reordering posts of single topic
2018-04-10 13:52:08 +02:00
45f657336e
FEATURE: adds support for loading existing core asset in pretty text
2018-04-10 08:37:16 +02:00
874003b7b1
FIX: Group can't be deleted if certain users are demoted.
2018-04-10 14:19:35 +08:00
afaeb20f27
FEATURE: Add option to have sso synchronize group membership
...
In some cases add_groups and remove_groups is too much work, some sites
may wish to simply synchronize group membership based on a list.
When sso_overrides_groups is on all not automatic group membership is
sourced from SSO. Note if you omit to specify groups, they will be cleared
out.
2018-04-10 13:17:23 +10:00
adb93716ca
FIX: rake task should rebake posts in descending ID order
2018-04-10 00:18:49 +05:30
62aacce8f4
FEATURE: Notify flaggers when flagged post is edited by author
2018-04-09 16:45:33 +02:00
cd66dd1404
fix admin rake task
2018-04-07 16:57:17 +05:30
f6cfff3cea
UX: user preferences allows users to choose which title to use from their badges and groups
2018-04-06 14:34:36 -04:00
b87205831b
FEATURE: Staged user moderation ( #5721 )
2018-04-06 11:41:25 +02:00
fa7ddf7238
Add wizard_js to translations that can be overridden from a plugin
2018-04-06 11:34:25 +02:00
2ddcdf8704
UX: Add an icon to indicate if a plugin is official.
...
https://meta.discourse.org/t/improving-admin-plugins/84585
2018-04-06 10:54:58 +08:00
5da7c2a4ad
FIX: Restorer wasn't rolling back if restore fails.
...
* This only applies to backup file taken with
pg_dump 10.3+ and pg_dump 9.5.12+.
2018-04-06 09:43:32 +08:00
e27edfe597
FIX: Don't give two errors about not being able to post links
2018-04-05 12:54:48 -04:00
35efdb39b3
FEATURE: Show the current reply count of the flagged post
2018-04-05 14:03:02 +02:00
f2d00e5eff
FEATURE: Use Message-ID for detecting email replies to group
...
Ignores the site setting "find_related_post_with_key" and always tries to honor the `In-Reply-To` and `References` header for emails sent to a group.
The senders email address must be included in the `To` or `CC` header of a previous email sent to the group and the `Message-ID` of that email must be included in the current email's `In-Reply-To` or `References` header.
2018-04-05 11:00:38 +02:00
10759677db
FIX: when uploading image newuser restrictions should not apply to staff
2018-04-05 09:51:03 +05:30
0d6cfe45bf
tl1 should be enough for grant admin. tl4 is hard to revert
2018-04-05 10:53:11 +10:00
4f7f733ab0
Upgrade docker:test to use PG 10.
2018-04-04 10:28:23 +08:00
f1ef46d7b7
FIX: unable to import private themes due to key checking
2018-04-03 16:11:03 +10:00
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
31ce955487
Add destroy rake task
...
Adds several rake tasks to delete users, topics, pm's and site stats so
that you can have a fresh site but maintain site settings and category
structure.
2018-03-30 18:32:21 -06:00
a0386655a6
Add support to elide content from ProtonMail emails
2018-03-30 10:41:32 +02:00
cf9965fd54
Add rake task for reordering posts by creation_date
2018-03-29 14:42:41 +02:00
eab64710ff
FIX: Shared draft performance fix + missing avatars
2018-03-28 16:11:43 -04:00
4b5977aa6a
Revert "PERF: Don't join on shared drafts unless you have to"
...
This reverts commit efedd9745f
2018-03-28 15:35:13 -04:00
a8f211bd41
Extensibility for custom staff check
2018-03-28 14:48:14 -04:00
efedd9745f
PERF: Don't join on shared drafts unless you have to
2018-03-28 13:57:39 -04:00
9e7d5a3cdf
FIX: 'uploads:recover_from_tombstone' rake task wasn't restoring attachments
2018-03-28 15:51:47 +02:00
ee69d58a59
FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.
2018-03-28 14:49:05 +08:00
7311023a52
Merge pull request #5700 from discourse/crawl-block
...
FEATURE: control web crawlers access with white/blacklist
2018-03-27 15:06:03 -04:00
4d12ff2e8a
when writing cache, remove elements from the user agents list. also return a message and content type when blocking a crawler.
2018-03-27 13:44:14 -04:00
fcd352e089
FIX: Try fixing unparsable email addresses
...
The mail gem returns `UnstructuredField` when it fails to parse email addresses, but the `Receiver` always expects an `AddressList`.
2018-03-27 18:28:54 +02:00
b945a2dc39
Call `on_drop` only when tables/columns are dropped
2018-03-27 13:18:13 +11:00
4ad401bac5
Ignore delay when first migration was < 10min ago
2018-03-27 13:18:13 +11:00
19c5afc69d
Protect against accidental table renames
2018-03-27 13:18:13 +11:00
f2c060bdf2
FEATURE: option for tags in a tag group to be visible only to staff
2018-03-26 17:05:09 -04:00
f03b6bd8c9
FIX: Update `last_version_at` when publishing
2018-03-26 16:06:20 -04:00
d4296f33ff
FIX: Publishing should update the public_version too
2018-03-26 15:46:25 -04:00
09ea27ed89
Version bump to v2.0.0.beta5
2018-03-26 11:22:52 -04:00
2b161a2391
FIX: Don't include shared drafts in global latest
2018-03-26 10:43:55 -04:00
b75b6de982
FIX: respect nofollow settings for onebox links
2018-03-26 18:21:16 +05:30
c5c1d8e180
Add support for the '/p/:post_id' route on the client-side
2018-03-24 02:44:39 +01:00
9fdf139235
Add tests for Site Settings import/export
...
- extracted out site settings rake task to a class
- added tests for import and export of site settings
2018-03-23 14:55:17 -06:00
17584bca5e
UX: wrap full-size Twitter onebox images in aspect-ratio
2018-03-23 18:25:04 +05:30
9a184b355d
Merge pull request #5696 from techAPJ/instagram-aspect-image
...
UX: wrap instagram images with aspect ratio
2018-03-23 04:00:52 +05:30
a84bb81ab5
only applies to get html requests
2018-03-22 17:57:44 -04:00
c686ae8d8f
FIX: Ambiguous column name
2018-03-22 16:38:53 -04:00
41fc8e32e2
FIX: N+1 query for shared drafts
2018-03-22 16:24:30 -04:00
ced7e9a691
FEATURE: control which web crawlers can access using a whitelist or blacklist
2018-03-22 15:41:02 -04:00
33c1aeb2ac
UX: wrap instagram images with aspect ratio
2018-03-22 21:35:10 +05:30
e053697cfa
FEATURES: updates emojis and adds support for more women emojis!
2018-03-22 11:08:06 +01:00
f3b402ffd5
UX: Allow users to filter members on group page.
...
* Only admins are allowed to filter users by email.
2018-03-22 14:02:41 +08:00
d96c1058a2
FEATURE: add staff action log for 'restore topic'
2018-03-21 18:04:13 +05:30
eebe1d8c56
Allow delayed dropping and renaming of tables
2018-03-21 12:05:12 +01:00
6a3c8fe69c
FEATURE: protect against accidental column or table drops
...
Often we need to amend our schema, it is tempting to use
drop_table, rename_column and drop_column to amned schema
trouble though is that existing code that is running in production
can depend on the existance of previous schema leading to application
breaking until new code base is deployed.
The commit enforces new rules to ensure we can never drop tables or
columns in migrations and instead use Migration::ColumnDropper and
Migration::TableDropper to defer drop the db objects
2018-03-21 15:43:32 +11:00
b9abd7dc9e
FEATURE: Shared Drafts
...
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.
* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.
* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.
* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.
* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
63a1e9b60a
backup restorer: tidy pg_dump schema portability logic, add test
2018-03-20 10:32:39 +08:00
6ca71e1319
FIX: when creating a topic in a category that only allows tags from a tag group, don't allow creation of new tags
2018-03-19 11:42:10 -04:00
c5d26992d4
Prefer to use primary email for new user creation over other available emails
2018-03-19 17:10:35 +05:30
ec57ca54b5
FEATURE: Admins should be able to view PMs of any group.
2018-03-19 14:12:01 +08:00
52b9af10a1
PERF: PG queries for the `UserEmail#email` column was not using the index.
2018-03-19 11:31:14 +08:00
da8e15f954
FIX: Restorer was not extracting the patch version in dump file.
2018-03-16 11:09:56 +08:00
90291318eb
restorer: clarify logging
2018-03-15 12:14:08 -04:00
58bb3967e5
SECURITY: Oneboxer should escape the URL before processing
2018-03-15 19:57:55 +05:30
a35227918f
UX: Display group topics in a topic list.
2018-03-15 11:37:55 +08:00
20ba54d536
FIX: extracting mail content from exchange emails
2018-03-14 22:02:43 +01:00
135195363b
FIX: Not logging old post contents properly
2018-03-14 15:01:36 -04:00
58b8ea4f41
Upgrade mail gem to remove dependency on mime-types.
...
* Use a EmailValidator.email_regexp for `Email.is_valid?`
check as we're seeing an increase in allocation when
parsing email addresses wih `Mail::Address`.
2018-03-14 14:37:55 +08:00
6b13fbccc2
tag-choosers with everyTag should also be able to get more results
2018-03-13 17:17:16 -04:00
58508e553d
FIX: tag input should not include tags you've already chosen in the search results
2018-03-13 17:17:16 -04:00
c75fd34328
Allow Discourse installs to name the token cookie
2018-03-13 16:48:40 -04:00
31a0c4a9be
FEATURE: Add `quote-modified` class if a quote has been modified
2018-03-13 13:41:06 -04:00
7d375690c1
Merge pull request #5667 from techAPJ/pm-tags-page
...
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:08:21 +05:30
24338fbbe8
FEATURE: replace PM tags dropdown with a dedicated tags page
2018-03-13 13:06:58 +05:30
a9713ca20b
REFACTOR: Always prefer to raise an error if record fails to save.
2018-03-13 12:01:01 +08:00
2ad2ed2eb2
FIX: Couldn't move a topic into the uncategorized category.
2018-03-13 10:20:47 +08:00
65ac80b014
FEATURE: Log Staff edits in Staff Action Logs
...
Why? Some edits by staff are not tracked. For example, during the grace
period, or via the flags/silence dialog.
If a staff member is editing someone else's post, it now goes into the
Staff Action Logs so it can be audited by other staff members.
2018-03-12 13:51:40 -04:00
d243b82fb3
FIX: Calculation of text length for <details> in excerpt was wrong
2018-03-12 16:55:23 +01:00
5782a23a69
Allow `uploads:missing` to skip optimized image check.
2018-03-12 20:08:53 +08:00
ec3a2d2762
Stop retrying tests three times if qunit tests fail
...
Warming up the Rails server should be enough
2018-03-12 12:51:26 +01:00
345b453ee1
optimize query for fetching PM created in previous hour
2018-03-12 16:40:17 +05:30
758b9a7dda
FEATURE: prototype of local theme directory watcher
...
(note this will be documented a bit late)
2018-03-12 18:36:06 +11:00
3a35f459c7
optimize last pm log fetching
2018-03-11 09:34:08 +05:30
f862122978
FIX: do not log personal message view if there exists a similar log in previous hour
2018-03-11 09:23:32 +05:30
5ef75c9c61
Improve grep pattern in restorer.
2018-03-09 15:48:12 +08:00
766b41d9f4
Fix version check in restorer.
2018-03-09 15:01:10 +08:00
800760e353
also watch CSS in unicorn on dev
2018-03-09 17:47:57 +11:00
8fd47314d9
FIX: Restore process for dump taken with `pg_dump` 10.3+.
...
* Since we can no longer restore into a different schema,
we will move tables in the public schema into the backup schema
first before restoring the dump file which goes into the public
schema. The downside to this approach is that we will increase
the downtime experienced during the restore process. Downtime
would equal the duration of restoring the dump file.
2018-03-09 13:24:58 +08:00
39e679d3cb
FEATURE: allow themes to live in private git repos
...
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
a89f3160a5
Add new config to ensure backup/restore connects to PG directly.
...
* In `pg_dump` 10.3+ and 9.5.12+, in
it does a `SELECT pg_catalog.set_config('search_path', '', false)`
which changes the state of the current connection. This is known
to be problematic with Pgbouncer which reuses connections. As such,
we'll always try to connect directly to PG directly during
the backup/restore process.
2018-03-09 10:28:03 +08:00
5b6e49ae1d
FEATURE: split out max diff to 2 settings
...
We trust staff + tl2 and up to perform edits in grace period.
Allow them significantly more edit room in grace period prior to storing
a revision.
editing_grace_period_max_diff_high_trust applies to users with tl2 and up.
So
tl0 / 1 : we store an extra revision if more than 100 chars change
tl2 and up : we store an extra revision if more than 400 chars change
We may tweak these numbers as we go.
2018-03-09 11:58:50 +11:00
0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown
...
FEATURE: filter personal messages by tags
2018-03-08 16:30:38 +05:30
a8149f8969
FIX: user should not be able to invite to PM if trust level requirment not met
...
FIX: when personal messages are disabled let user invite to a public topic
2018-03-08 14:59:04 +05:30
c29660c8f1
FEATURE: filter personal messages by tags
2018-03-08 14:42:07 +05:30
152f64a18b
Trigger is dropped along with the table.
2018-03-08 15:28:00 +08:00
9dc72537e5
FIX: `TableMigrationHelper` didn't clean up after itself.
2018-03-08 15:10:05 +08:00
a8f825d6a9
Version bump to v2.0.0.beta4
2018-03-07 15:18:26 -05:00
e162cd16b6
FEATURE: editing_grace_period_max_diff to force revisions in grace period
...
If a user performs a substantive edit of 20 chars or more during grace period
we will store a revision to track the change
This allows for better auditing of changes that happen during the grace period
2018-03-07 18:34:34 +11:00
76e2b6c825
Add "discourse-assign" to the list of official plugins.
2018-03-06 21:45:37 +08:00
7068b90c01
Merge pull request #5651 from tgxworld/live_update_group_messages
...
Live update group messages
2018-03-06 18:55:13 +08:00
832f0a9c4d
FIX: Typo prevented extraction of email signatures
2018-03-06 11:34:47 +01:00
1365bab0d7
FEATURE: Live updates for user's messages page.
...
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
2018-03-06 18:15:21 +08:00
0134e41286
FEATURE: detect when client thinks user is logged on but is not
...
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
f0d5f83424
FEATURE: limit assets less that non asset paths
...
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
2018-03-06 15:20:39 +11:00
17a615165c
FIX: Don't lock wiki posts when they're edited
2018-03-05 14:50:06 -05:00
003b03d939
allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age
2018-03-05 23:31:29 +05:30
ce1994beea
FIX: do not treat :: as a valid emoji
2018-03-05 15:35:24 +01:00
2f65393706
REFACTOR: Use `Topic#private_message?` to reduce duplication.
2018-03-05 15:39:22 +08:00
282f53f0cd
FEATURE: Theme settings (2) ( #5611 )
...
Allows theme authors to specify custom theme settings for the theme.
Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
cd6c5fc5fb
FIX: Disable "Make Personal Message" if they are disabled
2018-03-02 20:28:39 -05:00
6a78669ca3
FIX: 'reply by email addresses' site settings should allow email addresses without a 'reply_key' when 'find related post with key' is disabled
2018-03-02 17:53:18 +01:00
b3883f5c32
FIX: Don't lock a post on edit unless the raw changes
2018-03-01 20:40:19 -05:00
75172024ca
SECURITY: ensure users have permission when moving categories
2018-03-02 12:13:27 +11:00
482c615ef8
FEATURE: extract signatures from most popular email services/software
2018-03-02 01:51:15 +01:00
a41446a502
single quote password in restore command
...
> Followup to #3283 . Quotes passwords passed to shell for backup restore.
2018-03-01 12:08:35 -08:00
7a2183e8ab
FEATURE: rake task for merging users
2018-03-01 12:28:12 +01:00
fb75f188ba
FEATURE: Disallow login via omniauth when user has 2FA enabled.
2018-03-01 15:47:07 +08:00
81ca3677f7
Add guard for `nil` in our `RateLimiter`.
2018-03-01 13:20:42 +08:00
5d9f9c2614
FIX: `RateLimiter` max of zero or less should raise rate limit exceeded.
2018-03-01 13:14:46 +08:00
baf1c385eb
UX: when a post is blocked due to a watched word, message includes the word being blocked
2018-02-28 11:22:18 -05:00
e7a7356986
Remove ancient votes code that is no longer used.
2018-02-28 14:37:22 +08:00
902c5d11cf
FIX: Don't allow other flag actions after `notify_moderator` has happened.
...
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
f295a18e94
FIX: stop double counting net calls in logs
2018-02-28 10:45:11 +11:00
2a7b7add59
oops
2018-02-28 09:35:46 +11:00
182aaffbd5
Keep second semantics for method
2018-02-28 09:21:38 +11:00
33340071e7
FIX: Use 60 minutes, not 60 seconds for column dropper
2018-02-27 16:45:20 -05:00
3c430a3949
FEATURE: begone gmail signatures!
2018-02-27 15:19:34 +01:00
73ee62f55f
FEATURE: automatically elide forwarded emails and signature from outlook
2018-02-27 15:00:50 +01:00
4a54c09e46
FIX: Retry with GET request when HEAD fails with error 400
2018-02-27 12:07:16 +01:00
cb0c443343
Merge pull request #5615 from jjaffeux/puke
...
Adds :puke: as alias to :face_vomiting:
2018-02-27 10:20:54 +08:00
fd33090646
FEATURE: automatically elides gmail quotes
2018-02-26 23:54:02 +01:00
26d5ae61dd
FIX: handle <pre> inside <blockquote> in html_to_markdown
2018-02-26 23:28:02 +01:00
3313072957
Remove censored_pattern site setting, which is replaced by watched words
2018-02-26 16:29:27 -05:00
3be0294465
FIX: local post onebox was always pointing to 1st post
2018-02-26 16:05:35 +01:00
7d7f6faf40
FIX: properly render emojis in local oneboxes
2018-02-26 11:16:53 +01:00
b301c9f6c1
more prep work for jRuby
2018-02-26 10:25:58 +11:00
b9a669ba32
FIX: do not log personal message view if user can't see the message
2018-02-25 22:39:25 +05:30
aa990604c5
Adds :puke: as alias to :face_vomiting:
2018-02-24 17:11:04 +01:00
0559a4736a
FIX: don't double request when downloading a file
2018-02-24 12:35:57 +01:00
a1ea477604
rescue error when cleaning avatars
2018-02-23 18:15:55 +05:30
69af881f7f
New site setting `trusted_users_can_edit_others`
...
The default is true to keep with previous discourse behavior. If
disabled, high trust level users cannot edit the topics or posts of
other users.
2018-02-22 20:39:24 -05:00
24d0a7a4c7
Take 2 on f74d6bb605.
...
New options are left out by default when not configured so that an
incorrect default configuration doesn't blow up google oauth for
everyone.
2018-02-23 07:53:01 +08:00
dd26bbe868
Merge pull request #5610 from discourse/pm-tags
...
FEATURE: Allow staffs to tag PMs
2018-02-23 07:07:41 +08:00
1c790ae6bc
Revert "Add prompt and HD settings to the Google OAuth2 plugin."
...
This reverts commit f74d6bb605
2018-02-22 19:17:02 +01:00
ca1fd774a1
Revert "WIP"
...
This reverts commit 2cf5479678
2018-02-22 18:15:42 +01:00
2cf5479678
WIP
2018-02-22 17:56:56 +01:00
7cbda949f1
REFACTOR: New spec tests and code improvement
2018-02-22 20:27:02 +05:30
c302c28a7d
Switch ids in References-Header field of mails. ( #5567 )
...
This change allows email-clients to show threaded views of mails as
expected. Apparently most algorithms expect the message ids of mails
in the Reference-header-field to be sorted such that they build a
traversal through the thread, so the oldest (original) message being
first, then its child, grandchild and so on until it arrives at the
message id that the "new" mail (that is to be sent) is the reply to.
MSGA [1]
+- Re: MSGA [1-1]
| +- Re: Re: MSGA [1-2-1]
| +- Re: Re: MSGA [1-2-2]
+- Re: MSGA [1-1]
If the stuff in brackets would be the message ID, the References-Header
field of a message that is a reply to [1-2-1] should look like:
References: 1, 1-1, 1-2-1
Discussion took place in:
https://meta.discourse.org/t/e-mail-threading-in-ml-mode-does-not-work-in-thunderbird
Main information taken from:
https://www.jwz.org/doc/threading.html
2018-02-22 10:48:23 +01:00
f74d6bb605
Add prompt and HD settings to the Google OAuth2 plugin.
2018-02-22 12:29:19 +08:00
84867c1c07
Rename site setting to allow_staff_to_tag_pms from allow_staff_to_tag_in_pm
2018-02-22 06:48:34 +05:30
1b04d881c5
UX: Display lock icon in admin user lists when user has 2FA enabled.
2018-02-22 09:00:09 +08:00
720e1965e3
FEATURE: add category suppress from latest
...
In the past we used suppress_from_homepage, it had mixed semantics
it would remove from category list if category list was on home and
unconditionally remove from latest.
New setting explicitly only removes from latest list but leaves the
category list alond
2018-02-22 09:56:35 +11:00
2b509eaa91
Merge branch 'master' into pm-tags
2018-02-21 23:55:59 +05:30
776ab73a8d
FIX: can_tag method called without guardian variable
2018-02-21 21:22:56 +05:30
84ce1acfef
FEATURE: Allow staffs to tag PMs
2018-02-21 20:11:46 +05:30
8964e75ad6
Merge pull request #5612 from discourse/featheredtoast-two-factor-login
...
Featheredtoast two factor login
2018-02-21 15:00:10 +08:00
26450f7587
allow for no lograge
...
(fixes tests)
2018-02-21 15:40:37 +11:00
ca1a3f37e3
FEATURE: add instrumentation for all external net calls
2018-02-21 15:20:29 +11:00
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
3ea272f4f1
New setting: minimum trust level to embed images in a post
2018-02-20 20:00:06 -05:00
0799831dbe
FIX: use the avatar of the post rather than the topic in local oneboxes
2018-02-20 19:49:39 +01:00
a4bc54a686
FIX: strip zero width spaces from topic title
2018-02-21 00:12:39 +05:30
de5418a905
correct search in topic list
2018-02-20 20:47:44 +11:00
86d12bd44b
FEATURE: search within title using in:title
...
Also
- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
e5cec28eae
FIX: `Stylesheet::Manager.stylesheet_link_tag` cache should account for `Discourse.current_hostname`.
2018-02-20 09:53:15 +08:00
60ec483caa
FIX: include title in local onebox when linking to a different topic
2018-02-19 22:40:14 +01:00
c419c26f56
FEATURE: new site setting 'max_emojis_in_title'
2018-02-19 18:15:26 +05:30
b6277e208b
FIX: Cookies header didn't have the right format
2018-02-19 12:46:57 +01:00
f3815cd785
FEATURE: New site setting for additional allowed filetypes for staff ( #5364 )
...
* FEATURE: New site setting for additional allowed filetypes for staff
* Problematic variable name
* feedback
* small issues
* fix indentation
* failing tests
* Remove message bus and fix minor issues
* Missed this message bus
2018-02-19 10:44:24 +01:00
5d9d0fcb4f
FEATURE: add setting which adds group name to PM email subject ( #5475 )
2018-02-19 10:20:17 +01:00
a3c7ee09b6
FIX: ruby bench not working properly
...
- Remove thin which is no longer supported
- Bypass admin api rate limiting in profile environment
- Admin password was too short
- Run by default in concurrency 1 mode
- A skip bundle assets flag to speed up local testing
2018-02-19 11:37:16 +11:00
61930e092a
FIX: support incoming emails with just an attachment
2018-02-16 18:14:56 +01:00
93b1829f04
tiny refactor
2018-02-16 11:21:11 +01:00
49ad983050
fix extra blank line
2018-02-15 16:54:22 -07:00
925d1a7869
FEATURE: add rake task for import/export of site settings
2018-02-15 16:23:42 -07:00
322aa9ed85
Version bump to v2.0.0.beta3
2018-02-15 17:48:34 -05:00
cda3f72ab8
SECURITY: don't onebox whispers
2018-02-16 08:57:20 +11:00
57e140dc07
FIX: oneboxing to private messages
2018-02-16 08:00:22 +11:00
8e0da35857
FIX: allow local oneboxes to public topics/posts in PM
2018-02-15 18:14:41 +01:00
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
b4aa0b096e
FIX: Couldn't like staff when `allow_flagging_staff` was set
2018-02-14 15:46:04 -05:00
f028ffaf29
SECURITY: correct local onebox category checks
...
Also removes ugly "source_topic_id" from cooked posts
Patch was authored by @zogstrip
Signed-off-by: Sam <sam.saffron@gmail.com>
2018-02-14 10:40:46 +11:00
03b3e57a44
FEATURE: login by a link from email
...
Co-authored-by: tgxworld <tgx@discourse.org>
2018-02-13 16:14:39 +08:00
3e835047da
Remove "already initialized" constant warning.
2018-02-13 08:55:15 +08:00
4dfe659189
Rename `allow staff flags` to `allow flagging staff`
2018-02-12 15:27:26 -05:00
6287631745
FEATURE: New site setting, `allow staff flags`, false by default
...
For some large communities, it makes sense to disable flagging of
staff posts.
2018-02-12 14:56:21 -05:00
932a1a1187
Remove use of deprecated site setting.
2018-02-12 14:26:22 +08:00
569e57f0a9
FIX: Delete the invalid auth cookie even if you hit the rate limit
2018-02-09 19:09:54 -05:00
5466389f4e
FIX: Consider oneboxes links wrt to `min_trust_level_to_post_links`
2018-02-08 18:27:40 -05:00
dedeb2deb8
FIX: Don't show the link button in the composer if linking is disabled
2018-02-08 12:56:10 -05:00
6a5dad0b86
FIX: Too much Javascript :)
2018-02-07 11:46:05 -05:00
8c04893a04
FIX: Don't throttle local lookups
2018-02-07 00:31:05 -05:00
016b9cd0e9
FIX: Count the links in the post
2018-02-06 20:16:48 -05:00
1bab15c757
FEATURE: A site setting for a minimum TL to post links
2018-02-06 18:07:58 -05:00
b2b6dc68a6
FEATURE: a setting to customize the minimum TL to flag a post
2018-02-06 17:12:27 -05:00
df8e43abdd
use lazy & instead of try
...
unregister ip skipper in test
raise if called when a skipper is in play
2018-02-06 10:38:15 +11:00
eefd226611
Add extensibility point to `request_tracker` to skip IP addresses
...
This is useful if you want to run a per IP rate limiter but want to be
able to skip some IPs with custom logic.
2018-02-05 17:49:40 -05:00
2f19588311
FIX: If personal messages are disabled, don't show messages for groups
2018-02-02 16:35:54 -05:00
0edd386b48
FEATURE: Vanilla bulk importer
2018-02-02 16:28:51 -05:00
Robin Ward
Neil Lalonde
Jeff Atwood
Yaw Anokwa
Joffrey JAFFEUX
Sam
Gerhard Schlager
Guo Xiang Tan
Régis Hanol
Arpit Jalan
jose-hms
Angus McLeod
Blake Erickson
Michael Brown
Vinoth Kannan
Guo Xiang Tan
OsamaSayegh
Will Jordan
Felix Wolfsteller
Geoffrey Challen
Jeff Wong
Leo McArdle
Erick Guan