Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
32,080 Commits 179 Branches 500 Tags 935 MiB
Commit Graph

32080 Commits

Author SHA1 Message Date
David Taylor a9d5ffbe3d FIX: Prevent critical emails bypassing disable, and improve email test logic 
- The test_email job is removed, because it was always being run synchronously (not in sidekiq)
- 34b29f62 added a bypass for critical emails, to match the spec. This removes the bypass, and removes the spec.
- This adapts the specs for 72ffabf6, so that they check for emails being sent
- This reimplements c2797921, allowing test emails to be sent even when emails are disabled
 2019-03-22 17:28:43 +08:00
tshenry 48d0465f72 FEATURE: Improve avatar education link (#7240) 
* Make profile_path more direct to setting

* Add id to profile picture setting for easy linking
 2019-03-22 02:20:48 -07:00
Guo Xiang Tan 839a54b97b FIX: Destroy `OptimizedImage` record even if `Upload` record is invalid. 2019-03-22 16:47:06 +08:00
Guo Xiang Tan 19c3c25db1 FIX: Handle BBCode in `migrate_to_s3` task as well. 2019-03-22 16:47:06 +08:00
Joffrey JAFFEUX eec7822d7c
DEV: warns instead of raise exception, test should fail if legit error anyways (#7239) 2019-03-22 09:23:20 +01:00
Sam Saffron 68fe6b8d53 FIX: suppress autocomplete on group filter 2019-03-22 17:02:04 +11:00
Guo Xiang Tan 7aab7e9062 Revert "UX: Don't reload page after saving settings when editing category." 
This reverts commit dd142eec03.

We need a fully reload when reordering.
 2019-03-22 13:10:30 +08:00
Guo Xiang Tan 2d34be24be FIX: Rebake lightbox and use short upload urls in `migrate_to_s3`. 2019-03-22 13:09:59 +08:00
Sam Saffron 5284f235ef DEV: update version of ruby in docs 
Honestly I am not sure we should be carrying this document in the repo,
just a link to meta.
 2019-03-22 15:00:04 +11:00
Sam Saffron b418857830 DEV: document max_logster_logs in discourse_defaults.conf 
This cleans up logster configuration a bit cause we no longer have to
check if we respond_to anything and keeps the logster limit properly
documented

Followup on da578e92
 2019-03-22 14:11:40 +11:00
David Taylor 59491f3047 FIX: Add `sassc-rails` for plugins using sprockets to compile scss 
This did not affect core because we have a custom stylesheet pipeline
 2019-03-21 23:23:29 +00:00
Sam Saffron 2f8f801970 DEV: use Qunit.skip to skip a test 
commented out code tends to get forgotten, at least with skip we can alert
on it.
 2019-03-22 10:09:11 +11:00
Osama Sayegh 67b96ad2ff FIX: discourse client should know about Logster (simpler approach) (#7237) 
* Revert "FIX: discourse client should know about Logster (#7232)"

This reverts commit bfcbc4d2d6.

* FIX: discourse client should know about Logster (simpler approach)
 2019-03-22 08:48:57 +11:00
David Taylor 3f9e7eb326 FIX: Respect the disable_emails=non-staff site setting correctly 
This reverts commit c279792130.

This commit inadvertently removed all of the non-staff email logic, rather than just for the 'test email' button. 

https://meta.discourse.org/t/112231/5
 2019-03-21 21:44:14 +00:00
Régis Hanol e1e46f0dff FIX: topic with no tags 2019-03-21 19:40:10 +01:00
Neil Lalonde 1812a38f0a FIX: upload watched words should use UTF-8 2019-03-21 13:46:16 -04:00
Maja Komel 1f1d3909e5 UX: add more tag classes to topic view (#7228) 
adds tag classes where there is already category-* class
 2019-03-21 17:49:50 +01:00
Kris 252e17ea1b UX: add padding to hidden content link 2019-03-21 11:50:41 -04:00
Vinoth Kannan 1e3cb7575d DEV: Update webhook event attributes even when an error raised 2019-03-21 20:45:21 +05:30
Maja Komel 34730a0b16 UX: show if webhook is disabled (#7217) 
+ show in staff logs when webhook is created/updated/destroyed
 2019-03-21 16:13:09 +01:00
Osama Sayegh bfcbc4d2d6
FIX: discourse client should know about Logster (#7232) 2019-03-21 16:54:55 +03:00
Tarek Khalil 605530a77f FEATURE: Include muted users count within the ignored users report (#7230) 2019-03-21 14:31:45 +01:00
Joffrey JAFFEUX c18a6069c2
DEV: upgrades bootstrap-modal (#7235) 2019-03-21 14:18:12 +01:00
Osama Sayegh da578e92f2
DEV: configure logster max logs via ENV (#7225) 2019-03-21 16:10:17 +03:00
Vinoth Kannan 4c6bfb9b39 DEV: Don't destroy webhook in case of error 2019-03-21 18:34:54 +05:30
Joffrey JAFFEUX 5b465ce053
fix tests (#7234) 2019-03-21 13:16:55 +01:00
Tarek Khalil a31a35b334 FEATURE: Ignored user notification behaviour should be as a muted user (#7227) 2019-03-21 12:15:34 +01:00
sau226 50b3d8c3bd Fix spelling error (#7231) 2019-03-21 12:14:54 +01:00
Guo Xiang Tan 6cd42629e1 Fix failing qunit test. 2019-03-21 18:04:19 +08:00
Guo Xiang Tan 100ad15e18 Make prettier happy. 2019-03-21 17:25:05 +08:00
Tim Lange d16a0db4e1 UX: Enabled sorting for more columns in admin user list (#7208) 2019-03-21 17:16:58 +08:00
Guo Xiang Tan 4e594f2b2b FIX: Destroy optimized images in `upload:migrate_to_s3` rake task. 
`OptimizedImage` are currently not renegerated when the image changes
store.
 2019-03-21 16:50:15 +08:00
Bianca Nenciu fdd2e7f2e7 FIX: Do not update last seen notification ID when forced to enable 2FA." (#7222) 2019-03-21 09:27:22 +01:00
Tim Lange f7b156ffbd UX: Better emoji escaping for topic title (#7218) 
* FIX: Fixed failing discourse-prometheus-alert-receiver plugin specs
 2019-03-21 09:11:33 +01:00
Guo Xiang Tan 6450969c7b PERF: Add index to speed up scopes for `UserSecondFactor`. 2019-03-21 15:23:36 +08:00
Gerhard Schlager 41c7423985 UX: Use a less technical term ("replace") for reseeding (#7223) 2019-03-21 16:22:07 +11:00
Guo Xiang Tan 8e5e5d7d35 DEV: Make setting up of multisite DB in test env clearer. 2019-03-21 09:58:07 +08:00
Sam Saffron 600313373b DEV: skip creating multisite db when running JS tests only 2019-03-21 12:19:12 +11:00
Kris 896204bef7 FIX: Don't override .is-hidden on mobile 2019-03-20 20:40:43 -04:00
Gerhard Schlager 64bf4d4483 DEV: Add spec for reusing category permalink 
Follow-up to f3c76ad482
 2019-03-20 23:38:59 +01:00
Penar Musaraj 0db2846a5b Add user bios to NodeBB importer 2019-03-20 16:40:26 -04:00
Kris c7c409549b margin fix 2019-03-20 16:04:47 -04:00
Tarek Khalil 1dd0fa0c4e
REFACTOR: Move redundant ignored user check into guardian (#7219) 
* REFACTOR: Move redundant ignored user check into guardian
 2019-03-20 19:55:46 +00:00
Penar Musaraj 3c7eb74f51 DEV: no delaying topic scroll in tests 2019-03-20 15:24:06 -04:00
Joffrey JAFFEUX 45ef2ec8cd
DEV: do not wait for closed composer event on test (#7221) 2019-03-20 20:13:15 +01:00
Kris 88a3b89990 UX: Improve user profile header layout on mobile 2019-03-20 14:56:34 -04:00
David Taylor 56b4ee43d3 DEV: Update sassc gem 2019-03-20 16:04:26 +00:00
Tarek Khalil ed73cc60a9 FIX: Staff should be allowed to ignore users (#7216) 2019-03-20 15:47:13 +01:00
Tarek Khalil 5852e86226 FEATURE: Only allow TL2 Users to ignore other users (#7212) 2019-03-20 15:02:33 +01:00
Rishabh ad6ad3f679 DEV: Remove SiteSetting.s3_force_path_style (#7210) 
- s3_force_path_style was added as a Minio specific url scheme but it has never been well supported in our code base.
- Our new migrate_to_s3 rake task does not work reliably with path style urls too
- Minio has also added support for virtual style requests i.e the same scheme as AWS S3/DO Spaces so we can rely on that instead of using path style requests.
- Add migration to drop s3_force_path_style from the site_settings table
 2019-03-20 14:58:20 +01:00