Blake Erickson
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
Joffrey JAFFEUX
1f40258d5c
fix spec ( #7500 )
2019-05-07 19:20:56 +02:00
Joffrey JAFFEUX
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
Joffrey JAFFEUX
2570311718
FIX: simpler w function check ( #7496 )
2019-05-07 17:57:35 +02:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
Daniel Waterworth
c7a0baebc5
DEV: Prefabricate more things in topic_spec.rb ( #7490 )
...
* Moved let to more appropriate scopes
* Refactored tests
It's confusing when let blocks in a parent context depend on other let
blocks from a child context.
* Moved fabrication to top level
* Removed unnecessary user fabrications
* Added a trust level 2 user at the top level
* Factored out category
* Made test use generic user
* Prefabricate topic
* Cut down redundant users
* Prefabricated more things
2019-05-07 17:05:52 +02:00
Saurabh Patel
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
Gerhard Schlager
73da9c171a
DEV: Upgrade unicorn
...
The gem has minor bug fixes. One of those stopped the RubyMine debugger from working.
2019-05-07 17:03:27 +02:00
Gerhard Schlager
1ddd4a44d5
FIX: Wrong color palette after backup restore
2019-05-07 17:02:57 +02:00
Gerhard Schlager
2487e01c73
FIX: Optimized site icons were missing after backup restore
2019-05-07 17:02:57 +02:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
Natalia
1b7be1500f
Time variable used to be created with users timezone, it has to be UTC in order to pass the test
2019-05-07 08:43:38 -04:00
Daniel Waterworth
32e0c4997c
Prefabricated posts
2019-05-07 08:39:45 -04:00
Daniel Waterworth
d3a59a43a1
Prefabricated anonymous
2019-05-07 08:39:45 -04:00
Daniel Waterworth
033d584275
Prefabricated topic
2019-05-07 08:39:45 -04:00
Daniel Waterworth
3e2f7d800a
Replaced create_topic with Fabricate(:topic)
2019-05-07 08:39:45 -04:00
Daniel Waterworth
e79421abb7
Prefabricated users
2019-05-07 08:39:45 -04:00
Daniel Waterworth
c9dedd7d72
Removed unnecessary fab!
2019-05-07 08:38:55 -04:00
Daniel Waterworth
da31661b80
Prefabricate category
2019-05-07 08:38:55 -04:00
Daniel Waterworth
cdf17986aa
Removed unnecessary let
2019-05-07 08:38:55 -04:00
Daniel Waterworth
b95a5330b7
Moved automatic_group fabrication to top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
5af63def61
Prefabricate group at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
df63080bca
Prefabricate staff_post at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
db64bee0c4
Use prefabricated user
2019-05-07 08:38:55 -04:00
Daniel Waterworth
30676e8a56
Brought prefabrication of another_user to the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2c7ed7b848
Use prefabricated admin instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2f706be43a
Reuse prefabricated moderator instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
16c7b86c86
Use prefabricated user and moderator
2019-05-07 08:38:55 -04:00
Daniel Waterworth
7472f15368
Prefabricate evil_trout
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d3769fff95
Prefabricate admin
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d0c7e3469d
Prefabricated more things
2019-05-07 08:36:29 -04:00
Robin Ward
c403569895
Remove unused translation keys
...
cc @gschlager
2019-05-07 08:27:30 -04:00
Arpit Jalan
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
Vinoth Kannan
f5a217be92
Fix typo in condition value.
2019-05-07 17:09:08 +05:30
Bianca Nenciu
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
Joffrey JAFFEUX
c487dff776
early preview of new emojis ( #7486 )
2019-05-07 10:49:15 +02:00
Bianca Nenciu
4696be4c19
DEV: Fix failling test.
2019-05-07 11:19:13 +03:00
Guo Xiang Tan
2adbec1b3c
PERF: Speed up migrate_to_s3 rake task by deleting optimized image record.
...
No point moving all optimized image files to tombstone when the store is
changing. Also, `destroy_all` can easily blow memory since we are no
loading in batches.
2019-05-07 16:10:32 +08:00
Sam Saffron
e4abc51866
DEV: avoid using send when we can simply call the method
2019-05-07 16:50:45 +10:00
Bianca Nenciu
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
Roman Rizzi
9adfd66a8b
Revert "FIX: When mutating a string to build a diff. Duplicate it first ( #7482 )" ( #7484 )
...
This reverts commit 20d4093a67
.
2019-05-07 16:36:23 +10:00
Joe
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
Guo Xiang Tan
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
Daniel Waterworth
e219588142
DEV: Prefabrication (test optimization) ( #7414 )
...
* Introduced fab!, a helper that creates database state for a group
It's almost identical to let_it_be, except:
1. It creates a new object for each test by default,
2. You can disable it using PREFABRICATION=0
2019-05-07 13:12:20 +10:00
Guo Xiang Tan
329969ea20
FIX: Discobot mention tutorial should be case insensitive.
2019-05-07 10:54:22 +08:00