Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,030 Commits 207 Branches 500 Tags 853 MiB
Commit Graph

33030 Commits

Author SHA1 Message Date
Guo Xiang Tan ab1684999c DEV: Improve specs to use `upload_s3` fabricator. 2019-05-15 08:42:17 +08:00
Vinoth Kannan 42b10a646d FIX: return 404 only if upload url also not internal. 2019-05-15 02:06:54 +05:30
Maja Komel e0fe01925e FIX: make frozen string mutable in incoming_domain 2019-05-14 17:44:53 +02:00
David Taylor 33bd47164f DEV: Re-enable uglifier for non-precompiled assets 
Keep `harmony` disabled
 2019-05-14 10:28:18 +01:00
David Taylor f12709e24c DEV: Temporarily disable uglifier for non-precompiled assets 
This is causing performance issues which require further investigation
 2019-05-14 09:34:38 +01:00
Sam Saffron bbcc39e66c FEATURE: update mini_racer to version including heap dump support 
We recently noticed a leak, this introduces a new method on MiniRacer::Context

```
context.write_heap_snapshot(path)
```

To dump current memory in v8 context to a file, this can then be analyzed
in chrome and other similar tools

Can be triggered in production using rbtrace
 2019-05-14 18:01:15 +10:00
Joffrey JAFFEUX d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Sam Saffron 624184560e PERF: improve performance of publish_notifications_state 
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.

On some heavy notification related sites this can be a major CPU user on PG

This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
 2019-05-14 16:02:55 +10:00
Sam Saffron dafc941a04 FEATURE: allow shadowing all s3 settings 
Previously enable s3 uploads and s3 upload bucket were not shadowed.

This caused confusion when people were configuring stuff via env cause most
of s3 settings are shadowed.
 2019-05-14 10:24:14 +10:00
Neil Lalonde 6f747c6b71 FIX: don't allow username to be changed to same as password 
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
 2019-05-13 16:43:40 -04:00
Gerhard Schlager 13e54bca3d DEV: Add specs for handling InvalidPluralizationData exception 
follow-up to 6d44be51
 2019-05-13 22:07:42 +02:00
Gerhard Schlager bbab60fa9b FIX: Don’t try to delete inactive moderators 
follow-up to 6d77156a
 2019-05-13 21:44:03 +02:00
Régis Hanol 7707d5db2d Revert "REFACTOR: user-selector (#7529)" 
This reverts commit 9a56df89f0.
 2019-05-13 19:39:30 +02:00
Arpit Jalan a2b1789c3e FIX: do not log username change if the save process was unsuccessful 2019-05-13 22:20:27 +05:30
David Taylor 5605dba85c DEV: Automatically annotate plugin models alongside core models 2019-05-13 16:37:47 +01:00
Robin Ward fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts 
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
 2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX 7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX 717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
David Taylor 750c125707 DEV: Include foreign keys in model annotations 2019-05-13 15:53:42 +01:00
Penar Musaraj 607c671003 Fix string literal when switching theme in dev env 2019-05-13 10:25:51 -04:00
Penar Musaraj f1b0782624 UI: Adjust footer nav bar size in iOS app 2019-05-13 10:25:51 -04:00
David Taylor 1bff81419e DEV: Update annotations 2019-05-13 15:24:24 +01:00
Joffrey JAFFEUX 3912d6f806
DEV: pikaday 1.8.0 (#7536) 2019-05-13 15:09:04 +02:00
Gerhard Schlager 53d2232731 FIX: Remove trailing slash from topic URL 
this lead to duplicate slashes in concatenated URLs
 2019-05-13 14:51:45 +02:00
Joffrey JAFFEUX df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX 9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
David Taylor 2b28abdc21 FIX: Allow underscores in s3_upload_bucket setting 
Underscores are not allowed in s3 bucket names, but they should be allowed in the subfolder name
 2019-05-13 11:18:24 +01:00
Arpit Jalan 25b39b86ae FIX: reload the user record instead of fetching via email 2019-05-13 15:16:53 +05:30
Joffrey JAFFEUX e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00
Guo Xiang Tan 64c117519e Fix modifying frozen strings errors take 3. 2019-05-13 16:45:23 +08:00
Guo Xiang Tan 74989783da Fix modifying frozen strings error in `OneboxController`. 2019-05-13 16:25:52 +08:00
Guo Xiang Tan b584e30902 Fix modifying frozen strings error take 2. 2019-05-13 16:23:45 +08:00
Joffrey JAFFEUX 9b75320d63
FIX: track mutations on topic edit category-chooser only on select (#7528) 2019-05-13 10:22:28 +02:00
Guo Xiang Tan 999fdb95db DEV: Mark `discourse-login-with-amazon` as official plugin. 2019-05-13 16:13:20 +08:00
Sam Saffron d643294c9d FIX: delete duplicate invites earlier in the process 
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.

Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
 2019-05-13 17:42:39 +10:00
Gerhard Schlager 427cf295d9 DEV: Always require %{count} in French pluralized strings 2019-05-13 09:36:05 +02:00
Gerhard Schlager 81c329fbb8 FIX: Customizing missing pluralized translations didn't work 2019-05-13 09:36:05 +02:00
Gerhard Schlager 6d44be5142 FIX: Catch InvalidPluralizationData exception in fallback locales 
It shouldn't raise an exception when a pluralized string in a fallback locale is only partially translated.
 2019-05-13 09:36:05 +02:00
Gerhard Schlager a3e4f43a4d DEV: Remove patch for I18n.exists? 
It was merged upstream a long time ago
 2019-05-13 09:36:05 +02:00
Gerhard Schlager 73015521e2 FIX: Correctly calculate fallback locale list 
* English shouldn't fallback to any other locale
* Calculate fallback for default locale if it isn't English (useful for en_US)
* Reuse the fallback locale list when outputting translations to JavaScript
 2019-05-13 09:36:05 +02:00
Sam Saffron 3fbab595d9 FEATURE: use the exact name provided by auth provider 
Previously we would attempt to titleize it causing names like McDonald's
not to work as expected
 2019-05-13 16:45:24 +10:00
Guo Xiang Tan d369b84ced Fix modifying frozen strings error. 2019-05-13 14:31:20 +08:00
Guo Xiang Tan ba913a24db Add steam login to official plugin list. 2019-05-13 12:39:35 +08:00
Guo Xiang Tan c00dab89e4 Fix the build take 2. 2019-05-13 11:22:48 +08:00
Guo Xiang Tan 8c4caac2e4 Fix frozen string error in `plugin:install_all_official`. 2019-05-13 10:19:02 +08:00
Guo Xiang Tan 9059a8ca90 Fix the build. 2019-05-13 10:16:26 +08:00
Guo Xiang Tan 8165ceb320 Make rubocop happy. 2019-05-13 09:55:44 +08:00
Régis Hanol 888e68a163 FIX: When mutating a string to build a diff. Duplicate it first 
Co-authored-by: Roman Rizzi <rizziromanalejandro@gmail.com>
 2019-05-13 09:31:32 +08:00
Sam Saffron 982c4496ee Correct some missing spots for frozen_string_literal 2019-05-13 09:31:32 +08:00