David Taylor
5284d41a8e
FEATURE: Optionally skip the create account popup for external auth
2020-07-06 10:18:57 +01:00
David Taylor
041d28295f
UX: Hide login button during externally authenticated account creation
...
Also switch to use the new d-button loading property for the create account button
2020-07-06 10:18:49 +01:00
David Taylor
977766e7a8
FEATURE: sso_overrides_(email|username|name) for all auth methods
...
These settings previously applied only to discourse-sso. Now they work for all external authentication methods.
2020-07-06 10:18:45 +01:00
David Taylor
ec448a1516
DEV: Refactor Auth::Result for readability, recreate during signup flow
2020-07-06 10:18:41 +01:00
Joffrey JAFFEUX
789a15a897
DEV: allows autocomplete to be debounced ( #10166 )
...
Usage:
```
$(".foo").autocomplete({debounced: true});
```
2020-07-06 09:28:57 +02:00
Joffrey JAFFEUX
b2a2e4f1e5
FIX: ensures seconds are displayed when used with dates ( #10170 )
2020-07-06 09:26:31 +02:00
Vinoth Kannan
6d17765924
PERF: use post number to create canoncial path in mega topics.
...
We don't need page number accuracy in mega topics since it can be expensive.
06d426bd87
2020-07-06 10:31:19 +05:30
Guo Xiang Tan
227ddb214e
DEV: Add commit to ignore for git blame.
2020-07-06 08:58:53 +08:00
Sam Saffron
38a30a6e96
DEV: correct regression and correct tests
...
etag change in 31976ecf
was incorrect, revert it
Also correct regression in test suite.
2020-07-06 10:56:19 +10:00
Sam Saffron
199a53e936
UX: suppress "in reply to" section in emails by default
...
Previously we would include this section, unfortunately
1. It is usually elided in gmail
2. It can make the emails longer and more confusing
3. Omission is a feature, it means people need to visit site to get context
2020-07-06 10:40:04 +10:00
Sam Saffron
31976ecfeb
PERF: only update etag when it changes
...
Previously when synchronizing upload etags we would update every single one
regardless of change.
2020-07-06 10:40:04 +10:00
Krzysztof Kotlarek
1fd3a30a59
FIX: update normalize css from 3.0.1 to 8.0.1 ( #10141 )
...
It is a second attempt to this update. First one was reverted here https://github.com/discourse/discourse/pull/8618
We noticed a problem that `like` counter had incorrect colour on mobile.
I added a missing rule to the bottom of the file (that rule existed in normalize-3 and was removed in normalize-8)
```
button,
input,
optgroup,
select,
textarea {
color: inherit;
}
```
2020-07-06 09:09:30 +10:00
Vinoth Kannan
06d426bd87
FIX: skip hidden posts while generating canonical url.
...
Previously, while generating the topic page's canoncial url we used the current post number. It will create invalid canonical path if the topic has whsiper posts. Now we only taking the visible posts for current page index calculation.
2020-07-05 14:04:31 +05:30
romanrizzi
6b4cebed3e
DEV: Instance#replace_flags block should be optional
2020-07-03 16:21:06 -03:00
Régis Hanol
48b4ed41f5
FIX: uploading an existing image as a site setting
...
The previous fix (f43c0a5d85
) wasn't working for images that were already uploaded.
The "metadata" (eg. 'for_*' and 'secure' attributes) were not added to existing uploads.
Also used 'Upload.get_from_url' is the admin/site_setting controller to properly retrieve
an upload from its URL.
Fixed the Upload::URL_REGEX to use the \h (hexadecimal) for the SHA
Follow-up-to: f43c0a5d85
2020-07-03 19:16:54 +02:00
David Taylor
4c1e690e32
DEV: after_extract_linked_users hook for plugins to modify user list
...
This allows plugins to change the list of users which will be sent 'linked' notifications
2020-07-03 14:52:49 +01:00
dependabot-preview[bot]
b0d17a508b
Build(deps): Bump rubocop-rspec from 1.40.0 to 1.41.0 ( #10164 )
...
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec ) from 1.40.0 to 1.41.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.40.0...v1.41.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-03 09:46:35 -04:00
Régis Hanol
f43c0a5d85
FIX: uploading an image as a site setting
...
When uploading an image as a site setting, we need to return the "raw" URL, otherwise
when saving the site setting, the upload won't be looked up properly.
Follow-up-to: f11363d446
2020-07-03 13:23:10 +02:00
Sam Saffron
a9c703c230
FIX: emoji autocomplete not triggering correctly
...
08044b4f
regressed emoji auto complete logic since we (I) forgot to add the
space into the not capturing group at the beginning.
This meant that
`hello 👍 t` would not trigger an autocomplete to pick skin tone.
2020-07-03 16:56:11 +10:00
Martin Brennan
8ef782bdbd
FIX: Increase time of DOWNLOAD_URL_EXPIRES_AFTER_SECONDS to 5 minutes ( #10160 )
...
* Change S3Helper::DOWNLOAD_URL_EXPIRES_AFTER_SECONDS to 5 minutes, which controls presigned URL expiry and secure-media route cache time.
* This is done because of the composer preview refreshing while typing causes a lot of requests sent to our server because of the short URL expiry. If this ends up being not enough we can always increase the time or explore other avenues (e.g. GitHub has a 7 day validity for secure URLs)
2020-07-03 13:42:36 +10:00
Vinoth Kannan
9426d12c1d
FEATURE: trigger `user_updated` event if username is changed.
2020-07-03 00:14:19 +05:30
Osama Sayegh
de243426c4
FIX: Negative limit values shouldn't cause error 500 ( #10162 )
2020-07-02 19:52:37 +03:00
Roman Rizzi
2df388ffd7
DEV: Plugins can extend ReviewableScore types. ( #10156 )
2020-07-02 11:47:43 -03:00
dependabot-preview[bot]
6e3756c2e6
Build(deps): Bump diff-lcs from 1.4.3 to 1.4.4 ( #10155 )
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.4.3 to 1.4.4.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.4.3...v1.4.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-07-02 10:03:10 -04:00
Ahmed Gagan
04d7693355
FIX: Filter read/unread notifications on the server side ( #10152 )
...
https://meta.discourse.org/t/notifications-unread-only-filter/37621/32
2020-07-02 11:06:00 +01:00
David Taylor
95153356ea
PERF: Refactor lightbox decorator to use querySelectorAll ( #10158 )
...
Previously we were using `$elem.find(...).not($elem.find(...))`. This took approximately 2ms on my machine with a test post.
This commit switches to using a native querySelectorAll method, which takes less than 0.5ms on the same test post.
2020-07-02 11:04:19 +01:00
Guo Xiang Tan
6bab2acc9f
Fix typo.
...
Follow up to af52df2d
2020-07-02 14:23:10 +08:00
Guo Xiang Tan
af52df2d96
DEV: Add hidden site setting for PG search ranking normalization.
2020-07-02 14:11:18 +08:00
Guo Xiang Tan
ecc799ab56
FIX: Delete related search data when record has been deleted.
2020-07-02 12:24:59 +08:00
Kris
490939a1c9
UX: Truncate long badge names in the mobile usercard
2020-07-01 21:39:40 -04:00
Vinoth Kannan
f11363d446
FIX: return cdn url for uploads if available.
...
Currently it is displaying non-cdn urls in the composer preview.
2020-07-02 06:36:14 +05:30
Robin Ward
8bc61e84a7
FIX: Support root paths that omit the trailing slash and have QPs
2020-07-01 14:55:20 -04:00
David Taylor
76d5e54aab
PERF: Check for modal visibility in a more efficient way
...
This code runs on every keyup event in the application, so it needs to be efficient. Previously we were iterating over the whole document using the JQuery :visible selector. Per the JQuery docs at https://api.jquery.com/visible-selector/
> Using this selector heavily can have performance implications, as it may force the browser to re-render the page before it can determine visibility. Tracking the visibility of elements via other methods, using a class for example, can provide better performance.
We already had a `hidden` class on the modal element which we can check, so we can check that instead.
2020-07-01 17:49:23 +01:00
Dan Ungureanu
fc4d74870c
UX: Add Login button on 403 error page if user is not logged in ( #10154 )
2020-07-01 18:27:42 +03:00
Robin Ward
e0d2174e75
FIX: Search was not multisite aware
2020-07-01 09:58:17 -04:00
Guo Xiang Tan
01a722885d
PERF: Exclude `image_url` and `thumbnails` from `SearchTopicListItemSerializer`.
...
The attributes are not used and was resulting in N+1 queries.
2020-07-01 14:28:31 +08:00
Guo Xiang Tan
093ee1d80c
DEV: Ignore commit where we added rubocop.
2020-07-01 13:30:27 +08:00
Guo Xiang Tan
82964265cc
DEV: Remove logster current context config.
...
Multisite middleware sits at the top of the middleware stack.
2020-07-01 11:44:22 +08:00
Sam Saffron
ac968f5363
PERF: cache all metadata for 60 seconds
...
Clients tend to request webmanifests and such very often.
Keep the data cached for 60 seconds so it is not requested aggresively.
2020-07-01 12:58:02 +10:00
dependabot-preview[bot]
d8c2fc3ee0
Build(deps): Bump mini_sql from 0.2.5 to 0.3 ( #10122 )
...
Bumps [mini_sql](https://github.com/discourse/mini_sql ) from 0.2.5 to 0.3.
- [Release notes](https://github.com/discourse/mini_sql/releases )
- [Changelog](https://github.com/discourse/mini_sql/blob/master/CHANGELOG )
- [Commits](https://github.com/discourse/mini_sql/compare/v0.2.5...v0.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-30 13:12:54 -04:00
Mark VanLandingham
57a8b3b964
DEV: Add group name as class to group-box ( #10150 )
2020-06-30 10:49:31 -05:00
David Taylor
4db9f7bb73
FIX: Hide publish_read_state option from non-admin users ( #10148 )
2020-06-30 16:49:04 +01:00
Gerhard Schlager
fc8e842773
FIX: Sometimes not all output of psql was logged during restores
...
There was a race condition which could prevent Discourse from logging the last couple of lines of output from psql.
2020-06-30 16:52:50 +02:00
dependabot-preview[bot]
c0b37aa9ef
Build(deps): Bump diff-lcs from 1.4.1 to 1.4.3 ( #10145 )
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.4.1 to 1.4.3.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.4.1...v1.4.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-30 10:11:55 -04:00
dependabot-preview[bot]
cd70960c49
Build(deps): Bump json from 2.3.0 to 2.3.1 ( #10147 )
...
Bumps [json](https://github.com/flori/json ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/flori/json/releases )
- [Changelog](https://github.com/flori/json/blob/master/CHANGES.md )
- [Commits](https://github.com/flori/json/compare/v2.3.0...v2.3.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-30 10:11:09 -04:00
dependabot-preview[bot]
68ebfa3ef1
Build(deps): Bump zeitwerk from 2.3.0 to 2.3.1 ( #10146 )
...
Bumps [zeitwerk](https://github.com/fxn/zeitwerk ) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/fxn/zeitwerk/releases )
- [Changelog](https://github.com/fxn/zeitwerk/blob/master/CHANGELOG.md )
- [Commits](https://github.com/fxn/zeitwerk/compare/v2.3.0...v2.3.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-30 10:06:51 -04:00
Sam Saffron
67a310db02
FIX: emoji_autocomplete_min_chars failing when not 0
...
autocomplete resolving to [] was causing it to stop working.
Instead we have a special const (SKIP) which ensures it will
continue to be evaluated and only this instance is skipped.
2020-06-30 17:39:52 +10:00
Mark VanLandingham
d00e83eab1
FIX: update theme fields when updating from ThemesInstallTask ( #10143 )
2020-06-29 13:49:02 -05:00
Roman Rizzi
7ddd83dfcf
FIX: Uploads cannot be mapped due to the cook-text's element attr being null ( #10136 )
2020-06-29 15:37:40 -03:00
Mark VanLandingham
cd5cfc1496
FEATURE: Site setting to always show category definitions ( #10124 )
2020-06-29 13:22:02 -05:00